From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F256C25B10 for ; Thu, 9 May 2024 03:22:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 932316B008C; Wed, 8 May 2024 23:22:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E0B86B0096; Wed, 8 May 2024 23:22:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75A796B0098; Wed, 8 May 2024 23:22:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 560E66B008C for ; Wed, 8 May 2024 23:22:46 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02170A11FA for ; Thu, 9 May 2024 03:22:45 +0000 (UTC) X-FDA: 82097410332.27.85B7881 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2062.outbound.protection.outlook.com [40.107.255.62]) by imf25.hostedemail.com (Postfix) with ESMTP id A5834A0005 for ; Thu, 9 May 2024 03:22:42 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=FQfDhjbN; dmarc=pass (policy=quarantine) header.from=oppo.com; spf=pass (imf25.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.255.62 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715224963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aDy3DBx4GNoLB/Vj8n3bqvRKYtIvbm70I84kBSSdlQM=; b=CAgdQeQTXJwpycANgitm7k7Z/UxYRrg8D6CXzvDNZ/BU8rI/08rHBIhSx+ZoCDIYKY6S8N DNjLIVHt1dhQrbKVBLDbYxySTwJKSWMjLmr87V0kIwcFmuLt8qhG7I4jA+oQpz/OeKukoG KKYw/+8G6ikwBEh/a5XNkla0GRd7bUg= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=FQfDhjbN; dmarc=pass (policy=quarantine) header.from=oppo.com; spf=pass (imf25.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.255.62 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1715224963; a=rsa-sha256; cv=pass; b=OMI3dYxjCO6E9QPKxP6IJPUA0i1qWfaxOPYP9o3hfbLTHPLeKpayTKOOYaSwDpjLzSQCmj mZURlE+Vq1jrqkLX1yF8JPbkx8yfqmWnX93ySZTGkP+B2mJUY4Msxu0kPHrndMfeID8og0 dCOL7pL9bfF98nnMcVd7PWgKmLLBJt8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N+92uK2a3KCd0FU6I2YI9A8dJyl1bk1zKHolSkg7Kw1dCZtlEqBzZtELQ3oAtv99gPuyqvDy/lJREbTxj4YQE593jtykS9dL/5CR08Hk96D7Id+WHeOuJbTFudp2SGhq53Kqv4FGHWWrm4sMmWVYGFtl/L9cL1veLhh5ggDhnsynwNTJhbPh0xfM2QcDzZo21suyY1l/psMum96Fb+L7vDxJC5jbMjcK0m2jdCK6Sr0tqQXvkR0+Z8EQdaPnhwv9gCJ1FrNhUS5mPyEybRScS6HjaE2E9s6/9IE6hKFcodGdC5veIPNESEtY13H9o6lI0AiPf4ajqKUB5nIx1+LT5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aDy3DBx4GNoLB/Vj8n3bqvRKYtIvbm70I84kBSSdlQM=; b=LMOGuJUe47+ZCTDVfi6bduPJWkAv+1guiYzCx3CDNqXyWWwDuNYtivW4bhGrcGMSWrmn+ofdV3sSFaxmYfzvJAikSBioobXN1SuuugdPG3dcaUlxt++LM+cGbgw2n5hEvqMPQv7dFXM952uH4zqKT1PCnHqwR9riNyzK7GvkRhdZSWrRbF5irCs9DNg4FWss92Vdfh5SKOJOdvksUIIrB4cbolFjWFIjWljSX4Ui2gHXGsR1o6XSaA2Ik2+mmvexpR2WXwHkr4Pls30UpY+MA4dnSF8e4rFMw2sIVVhe8VA7xKJOCP1RRAACi4YEwgmnSEWIak9gJZWfo7eKSLl9FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=linux.alibaba.com smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aDy3DBx4GNoLB/Vj8n3bqvRKYtIvbm70I84kBSSdlQM=; b=FQfDhjbNtSHg6QeQo9A6u5Oqc6jyy4AkTL9WqwUsn6N+ademTdkAf5YMeYuMlu8K6tlJeIKmUgPOjbtNE8WhbLo4GhkERyOQ71W+UzZpUMlIW6UIvwGYXuEKAkAqKr+JdX1TDlwSS7DIVlx8Cl68fTSHcDNH/hO2+mN3a1gQsC8= Received: from SG2PR01CA0127.apcprd01.prod.exchangelabs.com (2603:1096:4:40::31) by KL1PR02MB7521.apcprd02.prod.outlook.com (2603:1096:820:118::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.46; Thu, 9 May 2024 03:22:38 +0000 Received: from HK3PEPF0000021B.apcprd03.prod.outlook.com (2603:1096:4:40:cafe::e1) by SG2PR01CA0127.outlook.office365.com (2603:1096:4:40::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.46 via Frontend Transport; Thu, 9 May 2024 03:22:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by HK3PEPF0000021B.mail.protection.outlook.com (10.167.8.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7544.18 via Frontend Transport; Thu, 9 May 2024 03:22:36 +0000 Received: from oppo.com (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 9 May 2024 11:22:35 +0800 Date: Thu, 9 May 2024 11:22:30 +0800 From: Hailong Liu To: Gao Xiang CC: Barry Song <21cnbao@gmail.com>, , , , , , , , , Oven Subject: Re: [RFC PATCH] mm/vmalloc: fix vmalloc which may return null if called with __GFP_NOFAIL Message-ID: <20240509032230.72vtl2cjtg72ydds@oppo.com> References: <20240508125808.28882-1-hailong.liu@oppo.com> <20d782ad-c059-4029-9c75-0ef278c98d81@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20d782ad-c059-4029-9c75-0ef278c98d81@linux.alibaba.com> X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw31.adc.com (172.16.56.198) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HK3PEPF0000021B:EE_|KL1PR02MB7521:EE_ X-MS-Office365-Filtering-Correlation-Id: e7106abe-e28e-408d-00ac-08dc6fd7462a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|36860700004|7416005|1800799015|376005|82310400017; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UFZldlhIY1cxSXN3N3RUOG55U3R4RXpSTndWNkJHZmVPSERMOFlrbnE2UnBr?= =?utf-8?B?Tldjb2JuazBadEVWK3VhMWoyS0Q2K29rU1FKc3pXY2xlWGYrdFdNcGozem5I?= =?utf-8?B?eVBvTlB1d204djhBU1BzR2x2Z01lVFp4NXhzcU02OTN5RE5LT2Q0SkJLTE1l?= =?utf-8?B?Ry9GM25xOGpaQkZBSUowNFVvY05hV2w1WHRXa2d6VHUrUUZRTmlxOU5paVlq?= =?utf-8?B?dnFNSk9PM1ZEWjhIM01qNGtneFZ6OWtyNHVFdUhQcXE2MUUxUmVaNDJTdWxH?= =?utf-8?B?bVFpbnhQQmcxK2svc1p5UTZwM3lmY2I1TmRodlRwcGsxYWZiVDVwQ29vSG13?= =?utf-8?B?T0dGUVA5cnoyWXMwWnY2d2ZKV3VPZ2lYWGhMaHltNzJhSWx1WFRLaDlmVG5Y?= =?utf-8?B?cVFRODBQNjhlSGcwOE9oYXJtbE1ZOFlXVWE3cjBUWEZiM0RubjY3aCtqampw?= =?utf-8?B?WXJxY0ZMcHBTY2RSaW1NcjljQTg1Mkh0aG0wU3gzQ2IwU2hweGxyMXJuaHcx?= =?utf-8?B?T3ZXU28rYmJBeU90cDJ1Rnh1QWwxbTRzSDlVdnFHWHYyTks4Y1E5eUhMV0h4?= =?utf-8?B?NUJkWDBTUFFZYWZxL0Z2ZUtwajZYSGVwd2c2aUZEUEc0N3ozM2pIVFBTVnhz?= =?utf-8?B?Sjg4WVo2MU5JbSswbE9oZFViaXIwTldFaENZYkdrRG4zWWdSMzhPYXF1UlNa?= =?utf-8?B?SXo0eFZsSTRySTREWU5XWjA2S3VVeEs1ZDY5RE9hZlZkWHZPVFNzaDF5Rm1r?= =?utf-8?B?UEZYeE1wQ0llRVFjV0hIY0FZTDFCalpReUJvSzR6RkxkZjMyNkM5T3lDMUti?= =?utf-8?B?TTgwNkhWRE5TZHVVUC9wT0w3YWRVNXNWOVBWVllzSUlEU2xOSk93Z0xCaFdh?= =?utf-8?B?WEtzYWpiVzlxYzlwT3YrQ1A2anVDaEtpLzluWDZoWTRDVEFtWkFqZFJyUDkv?= =?utf-8?B?L3RCemVWZkpValNkWEh4N1k0d2Rka0N5R2lyek4zWlQ3eFJid2N3NThzeEhk?= =?utf-8?B?TjYwMGZSQlk2OCtldU1QNXIrZlhabGFEZlBVVlZLNjQ0KzB0bDQ0R0xDVUpy?= =?utf-8?B?ZndSaGdaTHBJRUtzZ3BkMXNVT29oenBWZmpsM3YzQ1hkZ0JnV1JSYm4rbWF2?= =?utf-8?B?NWlZREI3bm5SV3laNTVhWWhqN3VsdWlscEFEakFhamRwTUpqTDdzc3B0RzFW?= =?utf-8?B?ZmlwZm5yNFZoRlpsb1AzZVlBR0lhaE82ZXNBM0xoTDNoKzhiTVJONVROVWIv?= =?utf-8?B?VUVKcWdqcDRCRklUZVk4TnhBOER6QnpKSGxLSTFYZzFpRU5ucjBxNTFzQWV1?= =?utf-8?B?VGxnUE14Skt3bHpmYlR2QWF4ZGZBVlh1dlFNa3RNbmd5eVByN3hudnMyRTF2?= =?utf-8?B?VGVCd1dIVG5ZdFdhYTFjekxYbWdqNFJkR2k0ZUw1Y3Nwbk9LcHhZL201ZVAx?= =?utf-8?B?V09yWnJmOXMzZ3VHbTZ6MktHcXRERUVpbUJMdU5DVExmUnladkVYaXJTTnp5?= =?utf-8?B?UVNReC9TMTNkalZIRXNSbWZYOTBMcm1rMDV1S2pBWTRFcTJQdkNJejE4M2J6?= =?utf-8?B?SGNnMkNvZUFCMjFPWGw5OTV6MzR6enJYdmJ4T2cySkIzY1grK0Y4YzB5eDNW?= =?utf-8?B?bzdzUUNWV0s4SUY2NTBsc2p1eHRqRU9wbDRVdnlyeXpXQnZWZEg4OHp4M2hv?= =?utf-8?B?QW1NN1lMR3BaZmgweUJPcVM0clNkNzAyNUg4MW1KbkcvUngrNHFqZmJKZlBh?= =?utf-8?Q?VCRXgiJgyweu6HW9GSeTa7Np41EVmfr6S4eW1oW?= X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(36860700004)(7416005)(1800799015)(376005)(82310400017);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 03:22:36.4014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7106abe-e28e-408d-00ac-08dc6fd7462a X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: HK3PEPF0000021B.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR02MB7521 X-Rspamd-Server: rspam01 X-Stat-Signature: 9hubf964ydbmmk8f1oxuupezkmnf1czf X-Rspam-User: X-Rspamd-Queue-Id: A5834A0005 X-HE-Tag: 1715224962-550598 X-HE-Meta: U2FsdGVkX18UbN03UoMvozSwBZNJRRLtUhfMLJ/iMzodL2oGLEH7jBGgRlYqxIkD0X0oO4I0whVg3qSJSOgGN8t0esE7rasHWKgzmfKUnXvHRJKwXTXhoJv3uDDSnxTIuURMID7gV/wiPxMnsZ/PnHSFsOGQ7Gb5tgDq/buZ0GZSylJzuliaoYw/+smHTpKxfAmLD/ejwgtqrpzbM7sm6ZwfsqSVkb2Ce1nCUmWMR0UhntQQwp4L5lCWqzkSd61r/Fc0CKZvWPk5IPm0X+CZd4Tp8fq+kLS+CzuVzTVO8J4TuSluRKFjKawA2H4SHH284MjqHoYf1mjIc7v8j1YT34IGgV7H0Cg95eE3uNPjpBXu96JVtAWqUyOKkZC5yWVxAXEsUInGNZrHrl1zH76utRDK5P60rg9lIhuvpSDjnhvAs9PQRyqqYZz9t2u0tae9ZiF/h3uTUGnDM4cKCaPReRZxgUCxAH1RDuCRq0M2PRcTd8QfBOGxAwsgNYg64Ik01r3XousQJ6iutAqlOFfINOU9jv0XehEN97dhLyT5MEI5jKP7dn2sCu5w6GTWa+YwrHej6473HocNZhQB46yokTfYoZES1t750RC6QxqNaJuP4gaZQR+uRqiB8JHN+7tw3o7ibocrw3hpg7bILuC9L1IcDW5aIn3uVuCd/PiAjEITxeul6RY7wjjX9hwnbJUFHnfa4Hbthj2rnbpG1TGecnDJD5crjVgbFbzblzAW3uqp2SCjoOl2K2O/whpcxHa3EB118mNd2UB57qtCGr0OmjU6jmRZczXxsXcDIFagKjfzpMDv7a9fuXRt1ONPsfzT2BQWrKovfLR4geTPqSt0lHR3yTyij6ytL+mu3KYIkYGTKXyFJqH4du1nlCalwW8ViEqyO1q378Ls/uU9Ufyagc2cJjrA923wT9+/bgEoN2r6DIMoUYhSEfHBDkt4IQYnF5BjyDpwesi+nv2nPD5 7miX72xT ha66bkmJNf+LX0mERQKHdt0/4owo1T9eF2L0l/TdYtXK8h5TosWniPQCQr/lBaPlhZJOY/MVJKx1WvTktmDsURJ+r93ZEr9VkpXv8cwsVlpqAMM5dAPWwkTgCMar0UwZ+XZuJb0W6Va+//TIIja/q5zAgdvGQDDHNyBGw0ngzw8cKMoE5LkYDQRyJI94PZZYioBSF58wWiCcx2XbeFuPVwrL7oCj/qi4q8RPnpNOJQOftu8kRRy0sETZaZCaLm/2/e+mG8ePmIxa7Q6GXhAtEpZkOcZAtBF2CZrXiaRCAoPQQUT2nWd4sqGwBILwaao+WgVHDTzDnfYkKOx+t5Qf3xNDjgSzSFJDA//DG0U6V+lzlqYeWJqkYxySjz7IEHUdlVbrGOekC0rXaiJhSccMkvBuWI8GxFwSMmy5+DG6x7P8uvoUlv+ITwaSAWiIxVHbjjOvBTjg5z8MdhbskY7tnCY+BYGO7V+lyjMc8u/R6IQ+sJ9mnSH3HlmhD7lexue+5gOJP3nHOZoi9szo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 09. May 10:39, Gao Xiang wrote: > Hi, > > On 2024/5/9 10:20, Barry Song wrote: > > On Thu, May 9, 2024 at 12:58 AM wrote: > > > > > > From: "Hailong.Liu" > > > > > > Commit a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc") > > > includes support for __GFP_NOFAIL, but it presents a conflict with > > > commit dd544141b9eb ("vmalloc: back off when the current task is > > > OOM-killed"). A possible scenario is as belows: > > > > > > process-a > > > kvcalloc(n, m, GFP_KERNEL | __GFP_NOFAIL) > > > __vmalloc_node_range() > > > __vmalloc_area_node() > > > vm_area_alloc_pages() > > > --> oom-killer send SIGKILL to process-a > > > if (fatal_signal_pending(current)) break; > > > --> return NULL; > > > > > > to fix this, do not check fatal_signal_pending() in vm_area_alloc_pages() > > > if __GFP_NOFAIL set. > > > > > > Reported-by: Oven > > > Signed-off-by: Hailong.Liu > > > --- > > > mm/vmalloc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > index 6641be0ca80b..2f359d08bf8d 100644 > > > --- a/mm/vmalloc.c > > > +++ b/mm/vmalloc.c > > > @@ -3560,7 +3560,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > > > > > /* High-order pages or fallback path if "bulk" fails. */ > > > while (nr_allocated < nr_pages) { > > > - if (fatal_signal_pending(current)) > > > + if (!(gfp & __GFP_NOFAIL) && fatal_signal_pending(current)) > > > break; > > > > why not !nofail ? > > > > This seems a correct fix, but it undermines the assumption made in > > commit dd544141b9eb > > ("vmalloc: back off when the current task is OOM-killed") > > > > " > > This may trigger some hidden problems, when caller does not handle > > vmalloc failures, or when rollaback after failed vmalloc calls own > > vmallocs inside. However all of these scenarios are incorrect: vmalloc > > does not guarantee successful allocation, it has never been called with > > __GFP_NOFAIL and threfore either should not be used for any rollbacks or > > should handle such errors correctly and not lead to critical failures. > > " j> > > > If a significant kvmalloc operation is performed with the NOFAIL flag, it risks > > reverting the fix intended to address the OOM-killer issue in commit > > dd544141b9eb. > > Should we indeed permit the NOFAIL flag for large kvmalloc allocations? > > Just from my perspective, I don't really care about kmalloc, vmalloc > or kvmalloc (__GFP_NOFAIL). I even don't care if it returns three > order-0 pages or a high-order page. I just would like to need a > virtual consecutive buffer (even it works slowly.) with __GFP_NOFAIL. > > Because in some cases, writing fallback code may be tough and hard to > test if such fallback path is correct since it only triggers in extreme > workloads, and even such buffers are just used in a very short lifetime. > Also see other FS discussion of __GFP_NOFAIL, e.g. > https://lore.kernel.org/all/ZcUQfzfQ9R8X0s47@tiehlicka/ > > In the worst cases, it usually just needs < 5 order-0 pages (for many > cases it only needs one page), but with kmalloc it will trigger WARN > if it occurs to > order-1 allocation. as I mentioned before. > > With my limited understanding I don't see why it could any problem with > kvmalloc(__GFP_NOFAIL) since it has no difference of kmalloc(GFP_NOFAIL) > with order-0 allocation. > I totally agree with you. so I fixed this in vmalloc or not in erofs. However, there are still some extreme scenarios that cause vmalloc to return NULL, such as vmap failure. Let's see what the mm experts think. > > Thanks, > Gao XIang > -- Best Regards, Hailong.