From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4BC0C25B74 for ; Thu, 9 May 2024 06:16:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45E066B008A; Thu, 9 May 2024 02:16:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40E786B008C; Thu, 9 May 2024 02:16:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7256B0092; Thu, 9 May 2024 02:16:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0F9256B008A for ; Thu, 9 May 2024 02:16:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 968DB80EC9 for ; Thu, 9 May 2024 06:16:36 +0000 (UTC) X-FDA: 82097848392.28.4CD1A67 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf11.hostedemail.com (Postfix) with ESMTP id AA97740002 for ; Thu, 9 May 2024 06:16:34 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fi0ofE1x; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715235394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8s5ogdUt9IfEZlAdYuj7aMmz3fDPUoN3crsNCifKctI=; b=YrpZyiVNVkGz+j6TA2W0iYmK7GkB4Tn6QK5js1zoo+fgyteaWn2MBukT5iifBvdI1cBE/t /tKeN13xzXFZLT4OqKYuqN3C6XY5G1KPhvy4q9YPvN34T2v2pt2nQIHpeT36PuounOJhh8 Wg/W59VZXlmGlng/WFVO3pNaFpA7ssg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fi0ofE1x; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715235394; a=rsa-sha256; cv=none; b=i/aKuFN3fXk05Hvw0iwINQdAUMZSBMpPNXE6DKxWQSf3huya74NF2S0ZW282Mn2XjrljgR tEddi5L7fo/X2GL/qHiDQCN9xfL/qxYakP7amfIWc0KYjD3B9vGAyiH7SwUKLupfi9xj7V YxIJAcCJ8tXGacF2+JrmBgoaj+MJQJg= Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2b6208c88dcso444596a91.3 for ; Wed, 08 May 2024 23:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715235393; x=1715840193; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8s5ogdUt9IfEZlAdYuj7aMmz3fDPUoN3crsNCifKctI=; b=fi0ofE1xSmFp5lFyZeqSlH0c0D6P6MWmT597PqorNxMAxeKNf2zydkIEN+kOAsX0qp /VeQyrIqDrJvqwIPQSecypLtQqZhOGmCJbKa1mYjlOGg19oX+XWYlQtg/QRmve3CVa1b UNaBMh6UCLa5OSDZbysAqWqiEi0mW4v8stcy8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715235393; x=1715840193; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8s5ogdUt9IfEZlAdYuj7aMmz3fDPUoN3crsNCifKctI=; b=n9x7qN08nvmGiuHyYEcGClki0+59rUyK0qhtRvJqAGSkHmn2GmqpPzWhtZFGLZr7Kc DX1wqD7uO4KF6/oUBc2B2GvMerOzsdAz2W+AnkNyJYV9RqQgo+2UEnhnBBgiKIN67iFs jEVuz3SnD+NiPQ+s+/TPeFM2bTIK6pxJsUGxy3XEFvHR8sXjrLfJAXWM9PtJJ2iY0aii /j+n9S1nBc5a5y2UIH0vY+LGGHDiYEKKxNS5lYrzbqIRrhn9UQncjAVrzuj7qm7dmdo3 Ns4+KWd04/DDyQIhX/4u4Pyhezw/z37piCNeDODkCkNy3/Ru3TuIlnqQGRZ3n4Vll8IA aJeg== X-Forwarded-Encrypted: i=1; AJvYcCXfI5Jas79JgtGPrhcU0hrxGVqirWRkUvUhjC3itnxbx/KqClm+Zjeub9yDYz9jO4gBi7zIFSCvtCE/Vtalz0MGtqk= X-Gm-Message-State: AOJu0YyKZwVhdmKmz+N6GT+PQNHG9WW89t3rv3ZuuDfeDlKJxEItweGu 6O9mOqMNyCSjk1VM5iiqwvJrta2RJO1GVyEtXNMGS8npU+MsDbIKVXtc5Un4WQ== X-Google-Smtp-Source: AGHT+IFqzikMESBMZG+WVvk+WptHcSgh5kqTqoDaOrL0B6tQBKEyulj/ZA+fDWbKAGEbWorXR4unvw== X-Received: by 2002:a17:90a:ac03:b0:2b5:6d47:9e12 with SMTP id 98e67ed59e1d1-2b61639c8a6mr4341255a91.2.1715235393466; Wed, 08 May 2024 23:16:33 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2b628ea6a83sm2490804a91.56.2024.05.08.23.16.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 23:16:32 -0700 (PDT) Date: Wed, 8 May 2024 23:16:32 -0700 From: Kees Cook To: John Hubbard Cc: "H . J . Lu" , Chris Kennelly , Eric Biederman , Shuah Khan , Muhammad Usama Anjum , Fangrui Song , Andrew Morton , Yang Yingliang , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Mike Rapoport , Rui Salvaterra , Victor Stinner , Jan Palus , Al Viro , Christian Brauner , Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 1/3] selftests/exec: Build both static and non-static load_address tests Message-ID: <202405082312.D922795@keescook> References: <20240508172848.work.131-kees@kernel.org> <20240508173149.677910-1-keescook@chromium.org> <1f6a2905-395d-4f81-9ee0-57c541fb2486@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f6a2905-395d-4f81-9ee0-57c541fb2486@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AA97740002 X-Stat-Signature: 8sd47sjr1nnap398fkr7bfrbfwphi5mb X-HE-Tag: 1715235394-898477 X-HE-Meta: U2FsdGVkX1/AgZGPBEoPHAcG+kZo4WM0ng9MQtiOVL7FOB/jIRmKbMzrc1tOUJypzHLn2n7D4L97AC37ojYy6+0ZlEG2Alffu6g3uIPU4JiZ02L9uBdg/IzccSNUE/rtnjIpsfSMNeg1ws6wMqS37/zFH+6vxleFhmgqpCn1sQtBj37keBSHD/euugED7vA/REMNyAbT7qBgGMOkrQ10lIEQBpypdJDNTjLKZjmBumnQdL5sL02J7zbqTIk0ZAp2kjnQH0w0FSFUx2d5wlowaDDXoqzu7SCLi5lEEwO0Dd9nbaK21dTOYLG1vl6P/UPm1OZwnDImymayo77oRviDv40PJKAyUDLRNce6UD/I264qf4TCVUyp6tW0XhNwys3ej50ArFczLHW1ts9td2maJbmO0U+BLPfVUIGwAbjwvvw1ChqjmOkjISzR9UDXJHgazoZMKOlMzidNLLyOA0eD0UzoAxrHZ33xfr6saY1LkD/89nrYsCRcXXocR1YjX9QMKLHigx4aAnKlneTInp5D8tvIfUEX6JzjRRCUnm6ZIkndVDz6g2Wm6yKBSrPY5U1M4eJy7Y/QkKaMIF6f5lViZgPDeHl8sI0Ylpg0yt6zKP/y25JNRitkvULdFR8LvMoBrzdPpQXTw0xRaN04KQ3BRBj6xyuOr8GByrB8zKICNQ2DLnbv4/3v3PnyuI7oxlCVFbzfI6a8a9OWnDCxBVtzCKDuTpS2bxTUEIY+QE4l91vjh/rZm5LKoOyJAGnGgy2LU7JiUHDzUTpx3UyhqCGGoW/LNZ1gS8x6WGzU3El+cJnDCXyqipT/6eoc/i9rpsSR5FYips07SWpWpa921pbG2BBIhTJHpzloqFtSlObTmvm+h73skJwOgWUBbsmECBw4N3A/RDIw1OZKz/JQ2WlX+fwA5qzqpJxf1QgtgSd5G26JPKxQ+GjmOXz+pmJnjafaFFXhUIDBto7MWyFUABD TK0KLFYy q0a+eCOLVIcnLQ7SF05xuEul8VslA9Iy0Bx/O0IoHXwTXjCA5nTPRSMxfhU1MeAFkw3C08MSDrL0fvy86ab6qxB+u7ltjTTv5y8LJXRQDRfvmKS4b6IjczkvksgjpfRUTkEkH4YFHJg954EGWenKgwZI1EHozWGrWTTK6uKfXERpWj3hNgmlGEoigHAMJnqR9e0AssoPvC7iaD+EsxJ5ITQ1Ov4HBIXnHnt4a+y1Jg9tltVyFwrqdA8JM/7pIzA18AfZOmo2PRdMZMt/lW55dxRc1+7vrRnv+0rwHJj1oCTH6BBHHf4iIgOMK1DPp7dAv4R2wauiOVbBvq5kpsjn/M2grJfsg9XdtvMXasm9A+C69rmwMlPGASqX94CUM/87KNF9DyOggWnUH8LPW+Ma7D4Kya+8/c4cMSbnpH1W2y6ZtpdJeA/rSDTF2IzvfUa3zqkFKWp64P7sFnHppwYzowpMUea1VHXKrggQ8v9Tabthi1JP5gzFiLNyP5aj/V5c8gVkAFjTGaQCjvLg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 08, 2024 at 07:54:13PM -0700, John Hubbard wrote: > Didn't we learn recently, though, that -static-pie is gcc 8.1+, while the > kernel's minimum gcc version is 5? Yes, that's true. If we encounter anyone trying to build the selftests with <8.1 I think we'll have to add a compiler version test in the Makefile to exclude the static pie tests. There's also the potential issue with arm64 builds that caused the original attempt at -static. We'll likely need an exclusion there too. -- Kees Cook