From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269BBC04FFE for ; Thu, 9 May 2024 01:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89F406B008A; Wed, 8 May 2024 21:00:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 850066B008C; Wed, 8 May 2024 21:00:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 716E46B0092; Wed, 8 May 2024 21:00:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 527266B008A for ; Wed, 8 May 2024 21:00:10 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EF47C140BEB for ; Thu, 9 May 2024 01:00:09 +0000 (UTC) X-FDA: 82097050938.24.B0D879D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 4BAED14001F for ; Thu, 9 May 2024 01:00:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=D0za5rf8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715216407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eJT5p42ehQRKbXHHjr+ukFSiGmwqQ2J/P9FvCH4x0VI=; b=c48fxVyCLtvC5tI2rmUC/MRsT1FJ9WWzG0Eg+4okAF0GRNAPkD6p8HGcrC3Tp6nJ2vX36u KIDZAuHakPDK1c5kwmPbVikd6vcENuJ6aGsYn1Ua1mFlsjqnkdfkakEuwFqTQCRkxO0weU qn4xQJlqrzdiO75nzt2w1e6Ql52z2OQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=D0za5rf8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715216407; a=rsa-sha256; cv=none; b=g9UW0wXSAkUa254sEHnhHD/ZasclObH66N6/gQe5DAdESSV5wWc/r5Z2IbGHhSb7fSNKkU EwPkDyn2O6UAlMwEEuyGOL4Pou5h8Dgs7qxfGS4BieS1P5aAv0fpy+GJZzAOj4fmEoeLV+ awCmaHeEiDn2LJv69VrNNB+5s0YS1Yw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4637561A3C; Thu, 9 May 2024 01:00:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5827C113CC; Thu, 9 May 2024 01:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715216405; bh=9n6emzJJV1YX0cAHx4F9eAW5P1FzVQRtiGBpOCeJFX0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=D0za5rf8sBZLeTFfBwvH/5N1DEtRx4ddPaEKSxntYldtCZFiYr+kZfL/DPfTpd57y FkhTonAdznnnMsG/Jp8zcJ/5PM+gP0HSB24OIa5SvzI6O66EgZUZWygQB8n3m664Vk iw2gLzWak8zQqGD7NWJHmLYv7ayRF7VNeJDvoJQbuuL4ka1sD6Vgqp+3H5xH816G20 IgUv7nVLhAegE3iIM6ZwFEP1kfHbzk6yoOEt4uVmR2mApKLXHKB1BZi2CcWGV8jx04 kONXdu6CLktRjchT/w65rRI6tXLJZuu9lzLKHyav3WPKnjku1XOKMFyOYjqa3XcRWl nEfGC6fd23pIg== Date: Wed, 8 May 2024 18:00:03 -0700 From: Jakub Kicinski To: Kees Cook Cc: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Luis Chamberlain , Joel Granados , Eric Dumazet , Dave Chinner , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: <20240508180003.548af21b@kernel.org> In-Reply-To: <202405080959.104A73A914@keescook> References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> <20240424201234.3cc2b509@kernel.org> <202405080959.104A73A914@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: dcnrnxqwyntbmcyw37fdpzgwh5ia37ub X-Rspam-User: X-Rspamd-Queue-Id: 4BAED14001F X-HE-Tag: 1715216407-624827 X-HE-Meta: U2FsdGVkX19ENKDOASAuoS5no+dmtnSqwhQq/q6oWhBxM12KP7660M3pPRGiZDCDmKincv7+BPgww9toRjuh64hBEZX1I4qgg1w3JHKgDMEyoYUoIfm+qNW70HeYl/kXrW7QM3GGtQKHhYRlDiztVZxUttiJqdBTOSagjZhrHlxzh+Xv2Lmgd5RXYZWt32BUwaf6zM6csp8a1HWHZA4vvpxYurjHi0Cqf7x3rFrVcJfZnOP5ARL8mprQtulGlUFWbsB//Lfj01lKoE1TiKdJ5UFvjYYABz4TPcl+vC0Jg9WbghD3/NlX9/5p9HMb3ch582c5bDgEB4nmV9YL+GUJtO02ZVkdqFSge5sTEZX8xS2Gv0zwyZonThBXxnNFnl7fU/ZJfuXQQw36PfazJxEKKjjRJlHoCiyZjbbTTUVsWGyvYMOupkNkfjiNWZSQdPYz9aqlXQDGCJfs2EwW7CrwsREJYUacy8hB+9UDi20HAGXKJgowJU8iKvH8afPJvp78Zx0CDgI9s+CSHKREHkADW8mlh0fJIdPsnkjZ2417/rDkDtVJfdIW7pIxSaDx0tsE9yPP1DNTzLVKnhfjxe7gjbADvc9Oeja+Yq+q2tJwTdwayaUUig4EEScrvQkclQl8bAUyPi1w0U09dahJRgNhyhekZHdfcQYv97mezYFiEr3oqW/U2QjV12v0alnOHmdlveCEXEFY/vx2f47C3RLTO4ERE3PKQiZ7RjQVasLy6ar7YyE/LgCLWqsLN9haonWaPHlQCvr2iiRx0Mt5NmJLqsPcyewvfCOaHtZePWQuOmsMCBa6pFkPzhpK/9ZPjEx7HlZ3EVDYfmnVO1Csm5Bx8WfZpQsfgI+lv39FlvWBSrYpfyD39RQ3rhGfVP9HhXU/FEaPzFwFJ8vtkFvAUL77H9aXT5YWdd7HAQ9WnFbCx51SQkHknb3LQZ42VTrhnaA1GkYkAfOMAEOxxFDVxB+ iDfNdkR8 w3tM9eR5nSVcoN4ac0H5bxaXTASGC3L31RcIYCahAz1NQLUTylMDejadCbPrKfnp/KwIyGc6voP8Fe2K0u2OQGNkHl0gN+6GBqsJWSvCQiVR2/QRzHyJn6sm5qdW6cOPzp/1BfpZ+dfFviKh4JlZ2qc2hvtT1fMCt9bLYGcrqNiKjN63smmRNEY90R2nDI0umc/n2pPMtqjelFv1tfXzQPAAZ+/1Iv/P0yXfH0SjOMNrZZbw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 8 May 2024 10:11:35 -0700 Kees Cook wrote: > > Split this per subsystem, please. > > I've done a few painful API transitions before, and I don't think the > complexity of these changes needs a per-subsystem constification pass. I > think this series is the right approach, but that patch 11 will need > coordination with Linus. We regularly do system-wide prototype changes > like this right at the end of the merge window before -rc1 comes out. Right. I didn't read the code closely enough before responding. Chalk my response up to being annoyed by the constant stream of cross-tree changes in procfs without proper cover letter explaining how they will be merged :|