From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCEAC04FFE for ; Wed, 8 May 2024 17:12:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 958366B009B; Wed, 8 May 2024 13:12:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 908C26B009C; Wed, 8 May 2024 13:12:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CFEE6B009D; Wed, 8 May 2024 13:12:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5D7D86B009B for ; Wed, 8 May 2024 13:12:23 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0F65E14113E for ; Wed, 8 May 2024 17:12:23 +0000 (UTC) X-FDA: 82095872166.24.9BA73C6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id A19F820008 for ; Wed, 8 May 2024 17:12:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CGWxFZfO; spf=pass (imf03.hostedemail.com: domain of will@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715188341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ngVZaZBBrMf1n5WRISqT3bpA454Yrz7VYtipxN3J/M=; b=1eNkSsZ0Nmn1VsS42X9MkVKYQri5I0Qk5f1S2tL1noHHv0VDHZAeJS29m+GkxceXZXKzhN xVvTBWbo+pUMpUHQX757pq3mV+3Gn0BTDU2i0pGkhGD6e0ryZ7WpMTmR5KJzImoE7pNbe1 RObC868LmdUcPETpXFsYOu3EZboGGhg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CGWxFZfO; spf=pass (imf03.hostedemail.com: domain of will@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715188341; a=rsa-sha256; cv=none; b=192r9+yn3KThKosHDEtomUgU55tUChlbnGC3dPD2pro8O2zinYpYIeJKQSJ7wvIAKluSAS o9rolxwUI2ZHwcSOUlZ6pTiYwG/zVyIgSwGyY9KDF6GiTiWzHyyHMt7iCaz+TbsbQ5mLpX 959n5rYI+h2zr2tfHlQqyJS2d/JAdhM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 30D50CE195B; Wed, 8 May 2024 17:12:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28FA3C113CC; Wed, 8 May 2024 17:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715188336; bh=yo1ooz5CIKyHvFNuqxWwyAce3pzv8kH0zcjKhsWI99I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CGWxFZfO5gw1j5G+HVYhcqeTiaISoIhlwfuUhtonJdvlM/r3yI0/d40iPngr2IoSS 2vL2OvYiieio9Qr++bqLt2hxOLk0DW4Zd1DNQNJar0DYykdGHUTWMvO9NlAQv/ANtW 4eAdfxc14vgn+oOl9YqUDvpsIpOF7roPHYIS0qYCuGFjaCsrHdhESIPsRVyQW1Rdau X5NWhGPJKcG03lXcLnmBLvwI6ylVB7J/I1AvOryxnrLpnATCTOGyZwRGIkeYOCakYc zPHQrURDG7GqiA10aDhKwXsNBBeLEhouRRGdJuiBN6b00HpIJobpV6ixmuTAvlCP9X 2/hBU5vQ86pFQ== Date: Wed, 8 May 2024 18:12:11 +0100 From: Will Deacon To: Ryan Roberts Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Catalin Marinas Subject: Re: [linux-next:master 10159/12060] arch/arm64/include/asm/pgtable.h:1102:16: error: implicit declaration of function 'pud_valid'; did you mean 'pmd_valid'? Message-ID: <20240508171211.GB23294@willie-the-truck> References: <202405082221.43rfWxz5-lkp@intel.com> <10cd4b97-d780-4524-a0ee-89f26a7897fc@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10cd4b97-d780-4524-a0ee-89f26a7897fc@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Queue-Id: A19F820008 X-Rspamd-Server: rspam06 X-Stat-Signature: spptdfdii17fwgtdjcoktgzhtonywend X-HE-Tag: 1715188340-833540 X-HE-Meta: U2FsdGVkX19G49w2i7b8lLYwL+3j8Z/Dp5W6bjwDpMDdhErX5jE4CvAKxUcNJnwsA/hmA4no+6U8LNZYTIIIMnoLaoda4g1L/H1ispoha0BI/kh+8YrtSSYDMKfqpEiYalBNJYL+/Sp9b+v55v9bz+enPEYGZRQkLUYHQhD625/8Cdt5PGCKI4wLiGxgUjJ8rQfNldyKWZKbujzuEXsG6zRyYfnUa2kbVhduFaLn8TG8oxiR/UquvrF08QkFmbKxQvi19SU09lhhZ7J2yduj8bN1rh8N4YjJVUVjSclk6HMxGgAUhY0R43yfMvxpQdAlWpsN01h/IS06v0zbjkr0+5CtcVy9Ows4GSWKn3+N5RLZHj1q3L6Y702MzDvkI4q6iqGQ/LoKwPiE+YjPzBuUpjVbJ9AcvhaJRwxvBFLGaZ9JKF3z9XX43zLpN/Ka5/DbjfzLBXpMPbvvoYNFRaApwpFM1ig/re6EcwBS+A0j6ZYOS9Eq8ovpjHqn/CNMf4d46VFR47UP2di0aUhbgrIjcjZlJFab5orChXMquFI2iPUE9ZSankVVM9BdCkOaCjqfla/vuonqo+jOfu/OQ4Yx/tECRtjMIpOBNkYSgFTObd48WEeIVvDTRoKGuE0kFIZIkkXlW3VkHTz6BvIjJzEdJ4LASXZRc6O4uySQGUzf6BVmBcbfyXh4Zcs5GrVxtLe2P+iKY2FYjBfuBBjpKmewQpQk8eeNTCiFYnOW6AlRCZNZFmcayttCjj6l+roFOe/3DidCHxPn4enjbOHamcxgPSCoiRhDxeJiRD8QQwCTFVA4ZKnpCw1WimVejavh9cZ4FZIEnYoegpIfWIAW9oS3La7BNAbQaiWVFph3VxV8RNe5ztYMFkoOImLhUiXsIzcXk2VvfFL5tOO7IYLZhsZSslrDkE67Su2nyVzzomF+25Ur+4Oyk34+KZFHmY2vPYs6gytgV3gi5aSHNDQ0j+l wI7AhT8o CQhYeLJ1RHeHXwhlsH1vkBYXEwS4BewLepZ2tD/3j1NVgsruFuqDGJQ6Gb4YH/lSq/LdRuS6ME0Tyz3Ih5MT9SppllnAgkuKUTYcAt60CF1CiyTeqKbYge5C66cPjeCYB7c7KA24AnzLEvfvWPot4os3clNeSQWrWHvyTE4F66r1eX1gmpK5A6mclcgO97utwQtq9nDmHkUw9WLSWAd3PZNELTZu5wLJFH1VjnyNJLe8n5lob6W2Ja1mfBWJqiG6TY8zMbGt/nhqmfm41xAVvvMjcEANnNS+KpDHPqaRAn0QzWWoCmGtzwdIWVgOgiHN67DlSxVnducxEqgorK4hr2RfzslZo4WZJOHdX0tgyoS02jGAxEUcDSI65zoMk9hmIyg7ii1HZJ1Ar60q7cFqa12Syti5FFlMeN3MF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Ryan, On Wed, May 08, 2024 at 04:38:01PM +0100, Ryan Roberts wrote: > On 08/05/2024 15:24, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: e7b4ef8fffaca247809337bb78daceb406659f2d > > commit: f0f5863a0fb0fb48a5881c3f6acca1958899dd76 [10159/12060] arm64/mm: Remove PTE_PROT_NONE bit > > config: arm64-randconfig-r013-20230528 (https://download.01.org/0day-ci/archive/20240508/202405082221.43rfWxz5-lkp@intel.com/config) > > compiler: aarch64-linux-gcc (GCC) 13.2.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405082221.43rfWxz5-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202405082221.43rfWxz5-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > In file included from include/linux/pgtable.h:6, > > from arch/arm64/include/asm/io.h:12, > > from include/linux/io.h:13, > > from include/linux/irq.h:20, > > from include/asm-generic/hardirq.h:17, > > from arch/arm64/include/asm/hardirq.h:17, > > from include/linux/hardirq.h:11, > > from include/linux/interrupt.h:11, > > from include/linux/trace_recursion.h:5, > > from include/linux/ftrace.h:10, > > from arch/arm64/kernel/asm-offsets.c:12: > > arch/arm64/include/asm/pgtable.h: In function 'pud_user_accessible_page': > >>> arch/arm64/include/asm/pgtable.h:1102:16: error: implicit declaration of function 'pud_valid'; did you mean 'pmd_valid'? [-Werror=implicit-function-declaration] > > 1102 | return pud_valid(pud) && !pud_table(pud) && (pud_user(pud) || pud_user_exec(pud)); > > | ^~~~~~~~~ > > | pmd_valid > > Hi Will, > > Looks like this is due to pud_valid() not being defined for > CONFIG_PGTABLE_LEVELS <= 2. Seems to me that this is the cleanest solution. But > pgtable folding breaks my brain so perhaps there is a better way? I think your approach is the right idea. pgtable-nopmd.h defines pud_present() as 'return 1', but I think pud_valid() can be false given that it's only used directly by the arch code. > What's the process here? Can you just merge this into the broken patch, or do I > need to re-post the series, or post a fix patch formally? for-next/mm is stable, so please just submit proper patches on top of that (and you can add a Fixes: tag as well). Cheers, Will