From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7227CC04FFE for ; Wed, 8 May 2024 15:53:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06AFE6B0092; Wed, 8 May 2024 11:53:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 019E66B0098; Wed, 8 May 2024 11:53:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAE5E6B0099; Wed, 8 May 2024 11:53:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BB58C6B0092 for ; Wed, 8 May 2024 11:53:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6C7E6C0E2C for ; Wed, 8 May 2024 15:53:01 +0000 (UTC) X-FDA: 82095672162.10.84D88CB Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2051.outbound.protection.outlook.com [40.107.236.51]) by imf15.hostedemail.com (Postfix) with ESMTP id 9129CA001A for ; Wed, 8 May 2024 15:52:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=bJ4UJIW+; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf15.hostedemail.com: domain of jgg@nvidia.com designates 40.107.236.51 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715183578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z9pcefZewD7EhQ4E0DRAyrFINVA87z9scIOk6YVMslo=; b=t5t8ZKv1VQI6UWoJSZjl1MspGUpkMQVdrLnn+/gVLV4fodgfpwp9OJdT4IBvlpqGhUmIeJ ZvnCzrSUCgfFjE7ElMNH5Uq+FMBMfqIkDEORX6cezZecWnIC9kdGEp/dHBETF0J80cLGXc kbzV4oeWsgPrEZGYq9SNOSP0hyo3LeA= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=bJ4UJIW+; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf15.hostedemail.com: domain of jgg@nvidia.com designates 40.107.236.51 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1715183578; a=rsa-sha256; cv=pass; b=k147ENd4lMcQkBsjOSaGTf+L4Ra0ZB2NGKzz2u1fpmALfY56pORN5lojRnYkrs4MCTGTvz dsyBZGb++fiAWo7xODxv0IZ9WIOTEMPD0XXG6QJQDQaz6W6QxG0jSJC1Ybkvu7a1ZxO7uK 1lkrTnpUyx5Bn0ld87iJvfEBiY5gsV4= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j2ULwvCWhJDbNJ/LFhqsv20WwOvZjge3luU+xNYuPTLN0tRe6IVdlZ8a48hzAM//ae7SlKH6V7fuXvClVq/vz9BTa0gzbbnZrrYnUnbHrdqnMIxKbJEjovBKrEczelGHi3THScUIn7b5oSVTyWnrweeA1KU6yZ2pvAB1/2j12FEZFB5CjE6YbInhNycn/gDlInjktjU76xf+32J71g+H/RVn8aUC3kbgQzC1laF2lWS/CDbDFFlW7es9dyVtW2hVVSBj/r4IEOe1oHsfTDCEM6aiISOtRDeWP/ohc2CGTL6/a2PgkWE4W3mJRg/ziBHSrT5NHrLJvrYy/q40NxUoTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z9pcefZewD7EhQ4E0DRAyrFINVA87z9scIOk6YVMslo=; b=V5YpJ5zHpsAHCxvrqnB3MeFnXwKe3eqLCKhUQxJkD3b2uRiZd1vRRxlv8JWXPwkLlY3rAh4TBTErT/kg+GAbviwijtUeOi286a89pr3qQn+ixJLHVAOljN5noBUMfB/ia+VlkPQs5lL6SRNpBwYqmdpbBm4XaChleQZpSMGjxvZpeR+YSne3ccGAWzWA9NEAuGHz4b8uEXqZAXxj3GMcwMzwVf4dnn6Kq/hlVHQ1uwIf6s6KM59/WOhWLp3u6328FEOuOd4w6YVe4LFQRqtIKg6ndpf2qExFN0Bkjn5WlW7WOKANn26sV7LJhAMqMqgK9Ypg4dbxbyiQO5VKsASEzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z9pcefZewD7EhQ4E0DRAyrFINVA87z9scIOk6YVMslo=; b=bJ4UJIW+CAC1glPT/b2pCCRDPahIzEU8cX836Ipoh9Y0Qha1ZDIxusNJy73EFS+le26CAJ3LtXArHOHzkEAMKld5ktbOw9J3ZyxI88OJ8RafNJgb4nPqB+ZMpuJns2lOLdkkeVAQOyGNAr7S7nnKdfmXeT8qdUoV4JB17mtC5gaRLw6X5JTWwkUofeVaX3guwlmK6f3EX3qd/qxAAnal1Lrc868ClrHPpXAy8kCqv83QQizcyNgFMqoks5oB9eaLqhl2Kjg37J1/AMGlQ6689W996lEp3U7C0+BQdBcqLCqgy2SDtkCiPMia1s9mu09UoT0pTlFOVARjY8brkrVU+g== Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by MN2PR12MB4454.namprd12.prod.outlook.com (2603:10b6:208:26c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.45; Wed, 8 May 2024 15:52:55 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c296:774b:a5fc:965e]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c296:774b:a5fc:965e%3]) with mapi id 15.20.7544.045; Wed, 8 May 2024 15:52:54 +0000 Date: Wed, 8 May 2024 12:52:53 -0300 From: Jason Gunthorpe To: Zi Yan Cc: Lance Yang , Alistair Popple , akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, maskray@google.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang Subject: Re: [PATCH v4 2/3] mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop Message-ID: <20240508155253.GK4650@nvidia.com> References: <20240501042700.83974-1-ioworker0@gmail.com> <20240501042700.83974-3-ioworker0@gmail.com> <0077A412-0AF1-4022-8F49-EE77AE601ECB@nvidia.com> <10BA9EED-A2BB-44C2-B80A-26527CDFFA50@nvidia.com> <1B2017A4-A252-4C1F-9608-D43ECEAD53B1@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1B2017A4-A252-4C1F-9608-D43ECEAD53B1@nvidia.com> X-ClientProxiedBy: BL0PR0102CA0063.prod.exchangelabs.com (2603:10b6:208:25::40) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|MN2PR12MB4454:EE_ X-MS-Office365-Filtering-Correlation-Id: d6042949-d100-4f35-1445-08dc6f76ec90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|7416005|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?n+LE5upWk9qmZhM3KcLA6HnKKn2wZs2byLbNkHZkuPSm4ZsMvUATGhuIeM85?= =?us-ascii?Q?4dyv0qttPAY+ejtQCvosytQDO+GB5egbVTy2BAdW2btNf8Yszc4u0H8pL22t?= =?us-ascii?Q?B3viNJ1ZjmsuaQTpPYIx8tZ+dfWLnNyhqdiTiYXm3UNA+upZww0b6rwTovqr?= =?us-ascii?Q?klacHRi5UmlTCX2/AuFGrM7XhERrnnUm911Bfz6G9liaIqAGpkFOtl500I3b?= =?us-ascii?Q?A42mWUSp2dXZYSkmh8K2fXLDI3QXy6amFLterApOj+bHIWBKMbyLGD6VXGvk?= =?us-ascii?Q?NRQsDc13VWoaSPjPO1Dfvf9ohYqZGn/sORfY9d52YRiLeXRjRaeU5jivSr2g?= =?us-ascii?Q?6hZisSuuLtKXgVfCsIcsv2i8CmcnuY2pJaPTu/BlAxYislw7uo/5VcNZYtpo?= =?us-ascii?Q?WvwB2Wum3VyyKf/g2t/He2nCItyuTPri67aNSae0ngl9A8vDrmPUpNvT07wz?= =?us-ascii?Q?GfZrr+SwaD+Spt2kLoi4GXjxd0DvBtVE4QCh/N/0TUdTdC6aI16LzsOFLMz2?= =?us-ascii?Q?BvCsSWJ7/5sSk53uD+zfugtao22//mrnVsMPjYfNY0bjqf8grn0cSnfTQOaH?= =?us-ascii?Q?FWloJC88E6z90vO60yAo+8B0D+5T6txyEo61RINZ1il6+njmxCsrsGsDyZ63?= =?us-ascii?Q?Gv02kYHZ+wB1eswST9ZydLyGwIV4Uniso0kOs6QxORbrScDULWXNjwD4kHmH?= =?us-ascii?Q?DMpiBLP2bQdn9LTQrcEd/06e+Eb8KzdG9DPKC3CFGgaQaWPt10VNAZcxGvom?= =?us-ascii?Q?4xTW9d1aG5CCLQklxWyJgdaaSwmKc/tM04shloUbttabAC4ZWDeKhYcQSKul?= =?us-ascii?Q?NBxfEkzonVNfyeWYCZHDFn6mz9g4vDmeRqxkqeUUlyIadBcx3HAUy+P2Rkh0?= =?us-ascii?Q?MvtILxePKb0h22kp3Y7XChSN7z0WILSH73f2XYr7+A2ip30TZYQTf79AoN3W?= =?us-ascii?Q?aP1LGiGus+ZZdadXMKhXF49vDi+8VGIcRzFmn1RVxoKQrIu93ALQ2px97NTB?= =?us-ascii?Q?mW+MaDEuMHcuL998AsHH6xnim6nhGDoHOAshjdDr/LGhiNHq7/sYxdDpUJkc?= =?us-ascii?Q?HQlpWSG+1oRoSs+xS1sdtP0MJ8KD7957wQr06v/GZLYtDd/1uyAiSAuBAmiE?= =?us-ascii?Q?2KkekxlOwIhJAL5MBUcNm66dwhFfmQRbFaygWfra1qlmiaEc88lsP3QvhYv4?= =?us-ascii?Q?ITpTGwtqgjQNFBhv9HhhhsA4OCJ1WhMu4uY7s5idqVSslLrtuAuA/wRekNX1?= =?us-ascii?Q?t/Z0JqNJq61rZptwB10baM7y3Dc8K7dL3be34ZQvYg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(7416005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?McSRMOERYX620VpaSAO0FQRqScO1EPpy4K+fK+Q5ceY5v7Lw2zM+6/47FVRz?= =?us-ascii?Q?JWgL7V/axtZZ2P6RfnFmgYnJB9qQXzAWNJ0qR+whLd3mVgtTL6LivL/iNtk7?= =?us-ascii?Q?ukPltOeOacVrGfNuF5/FivFU2FKjwY9QAc/lYV7R8kGfpETfImfwFKITnSg/?= =?us-ascii?Q?tP0YIjzCYYM1s+w4wVWPvz4j8LFn3KoYFzjEAKSrFyCFAU8QqI+nyJz+KrBJ?= =?us-ascii?Q?prTQVBajhC7h0L02RGxP6OsJAdik+vd+rfSuZPImsCfz6ibhq/foXKNKhiTK?= =?us-ascii?Q?dWP1fwTWU6gV1+HnY3VHSQ12aLEq5wn4R3lPO1Qa+Et6kxeUhB/df0qhJ6VZ?= =?us-ascii?Q?wIJRhIZvHbPA7TXUWrHfXadbCS8LV0SNVeMPkuxa2hcoZ7NBpQ47RFkCeBA3?= =?us-ascii?Q?gL1KgfJx2BZMKPXJxrJUr9oCI41lX/uYc/LyH8nNVetQCdryR43hEz9v+o7j?= =?us-ascii?Q?PCxWB+PnU6UUsFDr3J93QbdQ42HQ042SJrdiGyHwEPe776bgii5ofxmXyNbz?= =?us-ascii?Q?j5iZX0PmgGwk0VJ6IVvjSG+njMRmIUPsBxZyqYKrfZAH0tRGsekInGFsjIgU?= =?us-ascii?Q?syqvc6S+PuhO+WxciMjzNZtwLobSeNd/+2vbLQfA5oTZdulyst1AnCFq6GFC?= =?us-ascii?Q?wXdsznPEZbdHR+hcvtmGnnuYKMF7jk30/7XQjGZK+WA5sa5I+IvcENGTnUa4?= =?us-ascii?Q?9ae+4ioBeB0cybNgdrssQvkT0TiFn7Xel0rdVGUDIer4hvmT3+iqTR9WHZ8k?= =?us-ascii?Q?HTyjfZXcsQw8RaegIi6uKcEnMgQ5caVRyM8aJrx0fRYz2llzX7FKU3CfVfKT?= =?us-ascii?Q?TMO/jgejDL+IFQrfr3l9iJ4Z7kDfJML5t3C5yMziXTnpeabnOObPBAgpMxIf?= =?us-ascii?Q?knMtYYEJZ4BOdPaqVKVLbSjt6nJ+p0Ir9nQwG4ggF7kw7QjxneWDV49MyDCT?= =?us-ascii?Q?wDeuxLfeKPhZclTLJcHHx5IbSTah0fcvwFwsZxmkUXrb2jY66hgwoJVfZBzp?= =?us-ascii?Q?x0rsMEtKUn1wOG4S7r6CMvDF0aFJM/vQHhlhqb8duguiEsjqBC8YS9QyjzJ8?= =?us-ascii?Q?/hnPef2XyXteU3AWMD/2Tk3ngzsAn305vpCuVw7lcIWbf9QGzMvjLcDq+tBO?= =?us-ascii?Q?jxr74dJTCsZzrt8tGhtTvne6wqXoMlmhF4rrbuPmQSr9rCt1jnNbB4b+lVA4?= =?us-ascii?Q?hl76KcAO1mzsZSZLhtYxusurNQWdfTyh4wq3Yb2Jf+dBC+NdEJwZaXjpXrGz?= =?us-ascii?Q?aqEOCWx1dsjNklxzmIsE6/ROBX3g+muf04QfBcB630LrvuJ9lVcbSH0K7pTP?= =?us-ascii?Q?VUmBKVzf22Zx6HLyXzsQHpQFxf67HCOSub2uwfBM1DtlSu27B/rtEPBPFEs5?= =?us-ascii?Q?ehnd0hnXSFWyk4ZIfo1hP7sTrXinCkmcDx9wv5EL8aikPfz0a05faRJTS8Qo?= =?us-ascii?Q?f/GZLs2y7p7n0US1Lk3n04vBiGSO0O+gfOdiI278ZEzzoQy0k5zv7YQtjkgD?= =?us-ascii?Q?8MeHp+XsjficCIfQqgPyqMdo+cPH1cV84ORSHFEIDuB89cDpq7YYoj8+xS1e?= =?us-ascii?Q?j23udPkUmzTDugWGI012hw/O7oouIBCVyXN7oku5?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6042949-d100-4f35-1445-08dc6f76ec90 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 15:52:54.6625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RHxTf2Ge+bu9iyloUD+VywfaxG0zK0yUlSHAFUdbgS+yH+T6d3lEcJ0c/vYCUmo/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4454 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9129CA001A X-Stat-Signature: 8boa6bj9xkwyqimshtces4bxgd4ezprb X-HE-Tag: 1715183578-814202 X-HE-Meta: U2FsdGVkX1++t4I0RImf4/TdRSvllY96HkgZoXUM/Csi+MO6Uo2JUy8DANR4lvCgxLDHykvJgIrfcuvwVtORc2pneVSVS1WWUKwd+u5EvuMnmmPP70iJLfABhgZxC170dQKJNLv86rMx+4+7MEQph0dcUO1zwGbTJwY0aq5ieYqbwHO7M3dhnxiYcDWW88q80V63VoLOE7xBZu0NJs7unPE6YnQfZQIAhLjwisgcaQ5zoi9VQd8rarbZiytqEC/04L3nR5ceOGrsxzeJbJMtRw/l1A7hDqWhNpRMPA4jfSVEsQP67Sghf3HosQqj6RHsTk0z+gk0Jc7kRVtwH8LsQ3YNgeT17DGr6JCw9zlMh23qFlba95TSgunw9JJruprZC7bp4QH2xWjFopzQf3f1QK+K1rGrDciIbrB7AwGPSJnzSCek7fjWTq3HiT3KanOPGVVJmOHleGL2eLtwD7l/AOo+z1XwS5aIPbjuLQtdPXJ2RAGGrHrsDAn/T5A7g5CHkeo5b9brnjr95aSEAF8XFc5hmBZHyIdO9vSRFXpHuoInMLdoAAlSDVCmUrrQM//G/uXwlzHTBsIXJFZL14ufYzN2eLQMYugQBbnRLlRZVQjxG9tSUY81dKRNdKQzM3cHhs6y+UlYfATGVDLKrosIvi73mXkIRaOFXHQ7Q2zlHBUwvhl8rmLI1FtlOfh7YYZb3htTByD7IYN03mJBbCN+SXu5iBoQupCsvkIQelsT/IWiACeYfYuQpE9vDsZoa9V4HCs4fIymeNiievbsghd3cCOPSvBt1vqI5fzancCCBvjNIVSfNFSzznIj6scEHkho6zms2SJ3PzJL0yhaWa1wrT2xZNDU5+6J6fTQaKSvseY6uRe8N5LxMamFvm+XN8T1v7FnbX4UWDufseEQwctZS118FmqbIW1Q+6GVoUAnTfMgwXWQPEIusZyjHDC0VUPpsJdO8PPThL/wfCKNoY/ 4iED4WjW kfk8/KzG5shm0dHaX8lDFBaIVunJWMjExgwkv5nheM7B0L4oexmEoz30ke2HbGItC2aJM8QjbNDKV4fQ7Zt5tM2uOVXakGcbY/DSWD4nRA2PKMIceXbgl9oPhydPsyBEySNu+l3mSMVcxaYQQcUQUmXpMnKXSm/vgunYaEZBgN45eV5dI3q+joI7KB2FPengYxHptvx8ve0ZpLYHcrT7agUY4Ug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 08, 2024 at 10:56:34AM -0400, Zi Yan wrote: > Lance is improving try_to_unmap_one() to support unmapping PMD THP as a whole, > so he moves split_huge_pmd_address() inside while (page_vma_mapped_walk(&pvmw)) > and after mmu_notifier_invalidate_range_start() as split_huge_pmd_locked() > and does not include the mmu notifier ops inside split_huge_pmd_address(). > I wonder if that could cause issues, since the mmu_notifier_invalidate_range_start() > before the while loop only has range of the original address and > split huge pmd can affect the entire PMD address range and these two ranges > might not be the same. That does not sound entirely good.. I suppose it depends on what split does, if the MM page table has the same translation before and after split then perhaps no invalidation is even necessary. Jason