From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03DCC04FFE for ; Wed, 8 May 2024 12:58:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42BB66B0088; Wed, 8 May 2024 08:58:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DB386B008A; Wed, 8 May 2024 08:58:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27BD66B008C; Wed, 8 May 2024 08:58:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 071A36B0088 for ; Wed, 8 May 2024 08:58:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7B0601403FE for ; Wed, 8 May 2024 12:58:38 +0000 (UTC) X-FDA: 82095232716.05.3F494F3 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2042.outbound.protection.outlook.com [40.107.255.42]) by imf09.hostedemail.com (Postfix) with ESMTP id 39B00140023 for ; Wed, 8 May 2024 12:58:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=YaAhApHd; spf=pass (imf09.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.255.42 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=oppo.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715173115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=NAKGxuau+zdh5ldhQgYIuJGzScIPltlXMA8cN6yOibg=; b=3+44GCuW1yxszBgS5afZ+fRrEwNKDuCGQ40b7BAQw0T9Ody+1l5jnV6Hvmo3jyS1LGKwrO EandpQ6sRvL7GsIooq0dbpJ/PIF0dFuVjK+Rd1vdAD8rAHlPC4DFehQMs0hsiV1oSDcqp6 9cj6eiS9u+21cCDZWsxzmOVGs7sHOag= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=YaAhApHd; spf=pass (imf09.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.255.42 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=oppo.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1715173115; a=rsa-sha256; cv=pass; b=cCGtxxbk6vWpBm0966POUOO20dq2gguEmRzs3mffoukzDLdjdKaJaZKbSDaic13DgG40GG CnRgCidGTgX6P/qg+mTjGhi5ISPiuiz7DK3qnwqmQjJQ0Jl+8Ztc8uOJ+SjUDctvR+OdEz XJG6YLeBZYyk7f1lPSCvI+GqZF/b5R8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hszAub+7MeC6fedBCKE4PEO/JJMiaknRsr8YlZHzsSkf5ru4AaH6du3g59aK/V3bS/Uwyi+r6ibu8qny1XbP9Uq8EYX0nmoN8dDLbS6C+BWXktyzyzxCOC+wXsPFoY5gVmI+L17Ke2fe6mhGAmWmRs44Tek23IKP3rUULG3glnFO9Da3HZip1FdWN2yVkcg7FUtowzeoEY2X2aTbNoMbHmzSxXn/MvsBfsV0yJHCGmP7UGPDiPS/tzeVxxGGSQSxlMw+b1C/AS49fZAPbQUVXW65+OTUsACZjafGSgxuJ9Ls/dmZpT9BCNUGpSudPBTuU9LhIhNijeX76VQKH16X7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NAKGxuau+zdh5ldhQgYIuJGzScIPltlXMA8cN6yOibg=; b=bbpDgpBP5QDBlU+iqPyLhoaRQDk08LwNpSLc9TQd8+IR2M0tVNgA4zga4fhYN3maTCe2GBjbdAwHtdIqhNXGtKbKDTmssNvBKZApkTh67OVhnzpSjgdgl0A/FrfJvh7nIbOuWD7HQIpHQ+0kBUzejg5nt0KlM5x8jrOW54K3Id8RjySl+hX0D7oilHrllRGUH1jLpp2UvjqycaqjV10m3DkbMKj2uGKaSggDh3JHnuYASUeoClcz6Ci34Yk4rIvvuwCErHakz+O4gZ5JIJg3bm8njZKH0OuzjrzDXn4EGdsoEDTOkcNvDmdcbLdtJbZOE2YrXJjkFityDOwqzxddtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NAKGxuau+zdh5ldhQgYIuJGzScIPltlXMA8cN6yOibg=; b=YaAhApHdt1ran+48+u3+JTNkQXrwVB2pn+FJLG/An0E13FayS483TlfPn930fvBJQhWVr6qyMXUqx/HjuVfE2kz4jkrmV/k+3dCjlti//ZuvI0hjpBx5+b33mordat9ayHHyEIl1pGD4QN/oetUxOwrvNkTmajwY7sFQ5m0idcY= Received: from PU1PR06CA0019.apcprd06.prod.outlook.com (2603:1096:803:2a::31) by JH0PR02MB6438.apcprd02.prod.outlook.com (2603:1096:990:1a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Wed, 8 May 2024 12:58:29 +0000 Received: from HK3PEPF0000021A.apcprd03.prod.outlook.com (2603:1096:803:2a:cafe::e5) by PU1PR06CA0019.outlook.office365.com (2603:1096:803:2a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.45 via Frontend Transport; Wed, 8 May 2024 12:58:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by HK3PEPF0000021A.mail.protection.outlook.com (10.167.8.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7544.18 via Frontend Transport; Wed, 8 May 2024 12:58:29 +0000 Received: from PH80250894.adc.com (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 8 May 2024 20:58:28 +0800 From: To: CC: , , , <21cnbao@gmail.com>, , , , , Hailong.Liu , Oven Subject: [RFC PATCH] mm/vmalloc: fix vmalloc which may return null if called with __GFP_NOFAIL Date: Wed, 8 May 2024 20:58:08 +0800 Message-ID: <20240508125808.28882-1-hailong.liu@oppo.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw31.adc.com (172.16.56.198) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HK3PEPF0000021A:EE_|JH0PR02MB6438:EE_ X-MS-Office365-Filtering-Correlation-Id: 68d36560-5d0c-430e-b0e1-08dc6f5e8ec5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|82310400017|1800799015|36860700004; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LDy49rz/NenaJ57q5e4u/v/1xBSds0zJVxvVrbuFR79qM6ZV2sOru+KlNoP1?= =?us-ascii?Q?OWsPlpjr+HX9XbpbAh9KjI0TSxPpBgIm3e027Dc1MK96YsyQ+l04TvJ6jGz1?= =?us-ascii?Q?cgVROOLig+Yg6+DXl+RKc08cAiBwbcVAo+aDSEqflhE2wIEkXTS6uBJSoGre?= =?us-ascii?Q?LvyBhnD4hvazrS6SPU1JoTfZJ9zVV0z97CQX07JU6MoWEBsJoMBra/7Ds1QO?= =?us-ascii?Q?uVwZveZBBoShUPMlSOTyHhUb+rNBWH57k8uIeGH2VKZZVGGmooV5Y88HNJo2?= =?us-ascii?Q?tCTDIL7cnrKIVXgYa1bhvfLwQ4+Hk9kIffm+17Xnv42N+OsffrCgHzxFkG+L?= =?us-ascii?Q?lAWYritC3py3vR5ty2q5hO6+y6JwhJR2pR1sxxHFwXYwvcg07k1RVcZgIt4s?= =?us-ascii?Q?Ch5NRZFihxTaFTHtRCAbSCWX7PrjcQFAiKjxhAaUvlifDSfPUk2zrvAQr8iy?= =?us-ascii?Q?hWgJGe9kz6A6X4dcClVKwKDnzn1fdHcmT1dVtl5pW0qeebB6V5X1234vj1SO?= =?us-ascii?Q?aa/OpFQVh8qE06w70I5mbliMrw8xRfVxLgPMPTtpUAC2nLNP/kVgUYcUsehq?= =?us-ascii?Q?dFOXqxsrvAXxaN7EyvGjKadQlE2nrS9H1atHTPfldjiLpNdP2n3sqJX/0a50?= =?us-ascii?Q?Nygmb7MmZc8Pvzn1uzQYjmGoVtanLX9LMEBI+Ve2DRH5ORZdIULVn3Udv8JG?= =?us-ascii?Q?XwXH0oVirN7svFGEyjDIwxzd6JZWA+nHm6b62tdY9dlvVL8xpumAAYwGf4Pz?= =?us-ascii?Q?YKLWeqFkp5yQWnfTOtpCLgP9kp+vBWyIYkmqTvI6Ysed5jnsW3X1xBK5r3Td?= =?us-ascii?Q?vS2GIr0ZNCSiAOGm4+2Y4EculaNQede6A3GJndXlgYBXUlFhoj0JYPYUL91O?= =?us-ascii?Q?VGplPpqmPaK3NEZ+kHd4Bap+4LVQQhQbFrIR9qcXUTXcO85WhHv5YpVUCFAj?= =?us-ascii?Q?N0CwtQjKiW8Gq8v8864p/Cgy5pOONAfYnQrX0jMbE5ywhQ5Has8f9YAZysuv?= =?us-ascii?Q?5mSLqtnZMm97zUOWtPY8JT4fRNupqz89nlmdLtxO7jj9ferySoQMIg0K2Uhn?= =?us-ascii?Q?B+Dqwfylhjpua47g6ZeeyhC/QGNDNp2AjDWJ5nIa9XoWM0x3cyW15IoRFYPQ?= =?us-ascii?Q?4noqKT5YCf58HFdUG3/02OWsY/wInMSIOjCXweDu8vSd2oE05U85eLPb8OAf?= =?us-ascii?Q?aL4syvzd50oGlvf5uU0HU/kzCUJPhr+lAE3Vbm03pS2btmVELKJUtaGV3fHc?= =?us-ascii?Q?0bpKKoV0fzkkzRD4ZLXJksA+ut8LgiJY3tvC20MtITWDkmkli/onABOd46dY?= =?us-ascii?Q?H0fZh5rLOkaAqXPRdq/bNKsxe4sURUnhFyUFEHOcTMOywmt93tlrRBWAIvej?= =?us-ascii?Q?GbT6l1IclATfxXA5GfJyJpNZi1jc?= X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(376005)(82310400017)(1800799015)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 12:58:29.1134 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68d36560-5d0c-430e-b0e1-08dc6f5e8ec5 X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: HK3PEPF0000021A.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR02MB6438 X-Rspamd-Queue-Id: 39B00140023 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: u64ge3xyf5ae3sewenoxrj7y5doe3r3o X-HE-Tag: 1715173114-691272 X-HE-Meta: U2FsdGVkX19Y0EoL93eXBKJpWr8PP8I76AfkYg1qHqCaiqvjqk290q9Sia2OJKx1AeuG6n6g1HhrskhgbJZrp1PNeqCz8w3fHwDkh5CfIu7vW8bc8uSl8qZMkI78Z8qBp8VMz5Jbqwjv7AX3IpkOyMD7GEMt0xZLziJGr+pH87L8tRBbHGVDRhbkUtQPB9PuG6L4WDXDuL1JJJmVrKxBkboL2PUe3vRGgZC0qIp1oXo0WZhKoDgb1hodkcFALji7L3eqBVdxrlJ8y93MgNtYUZjBMpheiKmV9avVat6lAodWdS9Cbiqo1hhCHtU1P1jIzP4jbdvd5fVxcDmLoek1ezg61c99gksHwY1k1hoWEtJleciG99u7rBVWVGenmCihJx0BkpbhLetiolRczeZPd9SqMQZUZVe+a47k8UarQ+7XGr37BWz0gYN84If3BEecAuSD/IYByzD3omeCVzuwgMg9ywHjpWThJhzEVFMSA5iZnIssmOBp6jcp14BDeZQU6P8BprlQG+w3ZFURdCLvdgOHvwmcWzLAD36+r7CyThzV6XjyvdAWW9/Bpl6E8lBv8O9EbBenVoHfkjP5KqwoKMSY29kNhxUlCfe7sYLLkD/nQdHrnXNqex++mzjmYr8m8Zo7cCtTLJMqHTzYeHwEnzPV6XCzhrngExB4L4vWICt2rCRJQGWzNpUdhgbzh/S+Iwt426na816O+2rQJMEGIiFjxbd7S/YTvyuJEPXVljdBH+egFrb5o+Mqy8obKj58MSFEnuqsvZ0adBqTYb1DaTKGSVlUSOrnIfIe+LfSDxv/OVT4Sr1u8tiEHxMj2+4Vkip6ynI/6J1bGYUMsz7gZud5L0UWtuUJ1hOOmgVd7rjGmK79OsWs/Udh2xueHHz578mFZbBo3O252emrmJXL0JuGGLn9UrqttXOogl0TXMPYLk8FbZGwxDNaYOvTEGlLWjH1u7NZ35u2N1dMbv4 /+t3Wcwb Iako0opwZ4rJuJt4lzDiZfSKTxIgAPC60OUqqY06RY9CM5MP2gF8hszEjRPL6JDIb+9MnjglCThWfSgBAFi9PLx7RmBbstzLbVP0O/FyyytqDpzo0AbjMGgbz+bgFrarLPzqvVlMzdC/zs3ECRGVofE8S1jPHpcL7dgLdwDstusfVKjWL/5910gcuExLx5kL/syKu42kuZ9wL+DKjzpgBFdfht+q5Z/lP7/pLW10cP0tA5c71vRXd4qgktAC48y92wUBVTCSYeKfTOA3UZ5IDxucCVc/F07pXVI/iY6Nis4V4n+QInPejrlo7bZRr0ub8IHOMPNF9FCZppbF0E8/TfxVE5wnZ3i6ohJTmgNYOZ0jjOOxoKD2Pky1yBeF7eJSmTRRzbU+n2GW/+j35HRUTBNZi0NMad5jC2og7S3aEUuMj6ds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Hailong.Liu" Commit a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc") includes support for __GFP_NOFAIL, but it presents a conflict with commit dd544141b9eb ("vmalloc: back off when the current task is OOM-killed"). A possible scenario is as belows: process-a kvcalloc(n, m, GFP_KERNEL | __GFP_NOFAIL) __vmalloc_node_range() __vmalloc_area_node() vm_area_alloc_pages() --> oom-killer send SIGKILL to process-a if (fatal_signal_pending(current)) break; --> return NULL; to fix this, do not check fatal_signal_pending() in vm_area_alloc_pages() if __GFP_NOFAIL set. Reported-by: Oven Signed-off-by: Hailong.Liu --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 6641be0ca80b..2f359d08bf8d 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3560,7 +3560,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, /* High-order pages or fallback path if "bulk" fails. */ while (nr_allocated < nr_pages) { - if (fatal_signal_pending(current)) + if (!(gfp & __GFP_NOFAIL) && fatal_signal_pending(current)) break; if (nid == NUMA_NO_NODE) --- This issue occurred during OPLUS KASAN test. Below is part of the log -> send signal [65731.222840] [ T1308] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=/,mems_allowed=0,global_oom,task_memcg=/apps/uid_10198,task=gs.intelligence,pid=32454,uid=10198 [65731.259685] [T32454] Call trace: [65731.259698] [T32454] dump_backtrace+0xf4/0x118 [65731.259734] [T32454] show_stack+0x18/0x24 [65731.259756] [T32454] dump_stack_lvl+0x60/0x7c [65731.259781] [T32454] dump_stack+0x18/0x38 [65731.259800] [T32454] mrdump_common_die+0x250/0x39c [mrdump] [65731.259936] [T32454] ipanic_die+0x20/0x34 [mrdump] [65731.260019] [T32454] atomic_notifier_call_chain+0xb4/0xfc [65731.260047] [T32454] notify_die+0x114/0x198 [65731.260073] [T32454] die+0xf4/0x5b4 [65731.260098] [T32454] die_kernel_fault+0x80/0x98 [65731.260124] [T32454] __do_kernel_fault+0x160/0x2a8 [65731.260146] [T32454] do_bad_area+0x68/0x148 [65731.260174] [T32454] do_mem_abort+0x151c/0x1b34 [65731.260204] [T32454] el1_abort+0x3c/0x5c [65731.260227] [T32454] el1h_64_sync_handler+0x54/0x90 [65731.260248] [T32454] el1h_64_sync+0x68/0x6c [65731.260269] [T32454] z_erofs_decompress_queue+0x7f0/0x2258 --> be->decompressed_pages = kvcalloc(be->nr_pages, sizeof(struct page *), GFP_KERNEL | __GFP_NOFAIL); kernel panic by NULL pointer dereference. erofs assume kvmalloc with __GFP_NOFAIL never return NULL. [65731.260293] [T32454] z_erofs_runqueue+0xf30/0x104c [65731.260314] [T32454] z_erofs_readahead+0x4f0/0x968 [65731.260339] [T32454] read_pages+0x170/0xadc [65731.260364] [T32454] page_cache_ra_unbounded+0x874/0xf30 [65731.260388] [T32454] page_cache_ra_order+0x24c/0x714 [65731.260411] [T32454] filemap_fault+0xbf0/0x1a74 [65731.260437] [T32454] __do_fault+0xd0/0x33c [65731.260462] [T32454] handle_mm_fault+0xf74/0x3fe0 [65731.260486] [T32454] do_mem_abort+0x54c/0x1b34 [65731.260509] [T32454] el0_da+0x44/0x94 [65731.260531] [T32454] el0t_64_sync_handler+0x98/0xb4 [65731.260553] [T32454] el0t_64_sync+0x198/0x19c -- 2.34.1