From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB73C04FFE for ; Wed, 8 May 2024 11:22:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBB416B0133; Wed, 8 May 2024 07:22:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E438A6B0139; Wed, 8 May 2024 07:22:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE3D06B013B; Wed, 8 May 2024 07:22:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A23CA6B0133 for ; Wed, 8 May 2024 07:22:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 528A2A102D for ; Wed, 8 May 2024 11:22:34 +0000 (UTC) X-FDA: 82094990628.21.D832619 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf09.hostedemail.com (Postfix) with ESMTP id 951FD14000A for ; Wed, 8 May 2024 11:22:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=GxZJdzRU; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf09.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715167352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EdIGErpvvibBR4nNdikj9JRxEGZBf8SHMI98catsm7M=; b=LaQDvCJiUVOo0EOiFUD9nNOWEmZHMqlL3QRQ+6+6dACsjEsbh+XQGCkTFL7llUPajEHoV1 Q+HGNBazacNjTKfdmC66WgeZvwO98OJxPxZaLVxxpbKRT53svZ5OFJlDMQD2PL9GiwXKpl eQomMilFrO6G6a/eWb5zrGJlvvCTiBo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=GxZJdzRU; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf09.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715167352; a=rsa-sha256; cv=none; b=FWDcWmvTY5lKIgr0Yv54bjjRoy/EMTBqyOywUSP7OYh0hwBWBxUU/D/fQOxA0R8USPRqUF LlVKIO/pZnoa9+ee2XlwgaEecDvh16QQLFJy2+3EYD4JktU5edJKoC3zmiDb5Ad+b0953t yVPVxRPa6jFz2AIbi5IK4L9lwo/JE2s= Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4VZCRR5Ql0z9sTc; Wed, 8 May 2024 13:22:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1715167347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EdIGErpvvibBR4nNdikj9JRxEGZBf8SHMI98catsm7M=; b=GxZJdzRUKxcdids+Hn+s+DVoctkTJd6lAo6DvQX9ebtPb6YGea5AxBM+bCDmYWpn0md+sN guORSaJyn/EWB0ATpr5QzyVtxDzLgHlN7jYSrTq+aMpafQLBn6pn2Y4zZgBkm5sQjF/XBL vPABhmU91Gxvp9ukidzve7I9UR99uKibjr2smIigb5OzFXTMRsjofaZm/SZ9ahQxqTVdnm N9jvv5i9BtjebkUGmYouSbYgBh4nkySM1AxusoTPwRy0Xj0waw+kFcRYxrKfpKo1OcRtAS urVc6SM7+kQV7YcEnTtllW22AYAiWT94LkEncmfD6Vvv2c5UYHEfT7fXRWWBKQ== Date: Wed, 8 May 2024 11:22:24 +0000 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: Christoph Hellwig , Luis Chamberlain , akpm@linux-foundation.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v5 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240508112224.gnvdhr4j4fphzj6n@quentin> References: <20240503095353.3798063-1-mcgrof@kernel.org> <20240503095353.3798063-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 951FD14000A X-Stat-Signature: zkrkmc5bkjtidrzdukuzwegao4493xjn X-HE-Tag: 1715167352-296398 X-HE-Meta: U2FsdGVkX1+xUERzvvQXFkTMd7Aef5NIls9tS2oYK+DKI72Ll5W+s1nTVHHOirsfWXA4B3OGzn2v4rhBvJR5KSaKT+7hYTzrc6vsHaYoRo5m+mUj3F1AEdSOOsV/+uUn/RundvooxVkJCm2jfMR+wNRRitZrqAkeFxtTeKUow0iaqVPfyrHdhw8MF3xxn9oPrki95Tw1d+a7UI1JlDZ4jKhIIiGD4/DCHKDM7g0pMtjl5v9SBuJN8/krRPqnrA2oQiA0sG0l1vbZsYk9cbgjEqMtGJ+X+fM0tug9B6PBOJ7xySkH9/4b9psrSUz7PedirLtonpz6eCCgngwNt5cpn5fov1pVdkpANniG5K5l1Nqm7+sgFbh6YzSBnKsDkjPr2Xx3eYtciO+LWB/DRCrq9PIQd94H0bKQ24UWcfSzmXNV/e0JGUzv7CfTYo4IJlg8rlNGLpMoJDxYxTrmP1Qox+pXZvDrIqQqfhPsZsZQpvnPHXievluvnEB18au79XH0+WjNjI1L9/wUG8f3XplMWPR0dGkU5wS9R6TxLP8HhsOlBPzF7vHhXIIzIGgh4aubvI6EEmAeeoyXuee/xFy3N3TmrO6D793l8S02fYKr+JUYacPIB2jpZsunA06m9toBqLuLOuCFlQPbSILcFigshSLhWni9gWhpE3Sufb/lAACtljX79YOcHZ8J4M4lUtO6P3pXzM9uYA+gF6kfvdC7SbD9NMztMlsVrjo3HrNpYZwBMCBTuh2/3O2ulOJxc6RkYOvz4moSslpA9uswbMIQ4ojvP1Mss5yBZgjpzXhlrEn931+MtR9Rr+sy6xSU96Sj390AtOseK3oZ0wjbZG88QKRNpMfP0UC/Tg9JzIFKUt+uh3nTvGZxlkzoDAAlTL4/8omM1UtY92vVg5BdmQlOgovKCPUEuAjlj6/ZELZfh6SLg8jKdsJmfhEu50m35JD+azRcQkqPv6gUGvJrGtd g5C5HKbK hx6dgpIJk7sih7Gbic+inA3cemvEDrZxQooZ61b+ntTfmAY8camftS+pSvErD2EC5tRX3XBuM80KubpxKvVEeOh6dWCnTLDk2/Pj1FuhRXiPsqNw6Uf1VDSRCwNRZKWEMiSTIxluWx5cENSzSuVkrysXRUPNowLqoJ2DrhFYbE3U1pWqpFNlGTXcze7HNeu+cOiXQuR754DRWTMferE9wASCu1w4Arrv+Tx8RHG5OVfTRCO2fsiiQwBXKADoBark7WfDX/qWt4XeZq4JO6Qlu7YqEaWM6j+YWM9cA/69gt1jjBlE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 08, 2024 at 05:24:53AM +0100, Matthew Wilcox wrote: > On Tue, May 07, 2024 at 09:13:17AM -0700, Christoph Hellwig wrote: > > On Tue, May 07, 2024 at 05:11:58PM +0100, Matthew Wilcox wrote: > > > > __bio_add_page(bio, page, len, 0); > > > > > > no? len can be > PAGE_SIZE. > > > > Yes. So what? > > the zero_page is only PAGE_SIZE bytes long. so you'd be writing > from the page that's after the zero page, whatever contents that has. This is the exact reason this patch was added. We were writing the garbage value past the PAGE_SIZE for LBS that led to FS corruption. Not an issue where FS block size <= page size. -- Pankaj Raghav