From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 280DCC04FFE for ; Wed, 8 May 2024 17:11:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B531B6B0096; Wed, 8 May 2024 13:11:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B02E26B0099; Wed, 8 May 2024 13:11:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CADC6B009B; Wed, 8 May 2024 13:11:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7BD866B0096 for ; Wed, 8 May 2024 13:11:40 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1F0C114119D for ; Wed, 8 May 2024 17:11:40 +0000 (UTC) X-FDA: 82095870360.30.E5AD7DA Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf12.hostedemail.com (Postfix) with ESMTP id 3406840018 for ; Wed, 8 May 2024 17:11:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=V3bc8aND; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.177 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715188298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tSmrj41Qt+Se2fdGi7WeozvVj6AfH//AS3pb2zkquGg=; b=pP+lDW0f+o6/wgVZlKtsORZp1QIFj+/tT5jjhx2cR9Rfv14EM+S+IpFvl/SW0Lhyk2o3W2 3MVPE67CggBlFuWV5Ka8Jl7QPwU9+wqFnjksqaFCc23HpYVir/Kp/OaC6VxS318O+Bzmvr hcXOpbZ3/UMmulqjtLIiCsjwT0ZvmHA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=V3bc8aND; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.177 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715188298; a=rsa-sha256; cv=none; b=qJZ1BEPE5EAoava2IHJKzv0BzgDUn7obgAuQ7qC4BF6FhnVQXMzzES8wjNImUXOouDBMcs h1vadgs0wDzVZGZwpYl+MFiqbGqUU204IH9LbAg5nx26LzeTJdJnFrylxyNyId8yJVlhDG mJvPfHk15LvyhaUM7lk1qgG5iqRK1PI= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6f44b296e02so8765b3a.2 for ; Wed, 08 May 2024 10:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715188297; x=1715793097; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=tSmrj41Qt+Se2fdGi7WeozvVj6AfH//AS3pb2zkquGg=; b=V3bc8aND3BDosTKhRE3l1okWhFjUf4Avj/KmZsyZq/+IhfwIQaDcwVxLSPbEig1Nza 4UByJjjPVUyuMmLRsmwk7YCiJphRDw9E8xL84dFpjF9Hxa9CnbPG1XvjNQUeAd/l0eTr zD26lz4Ln9Hk6wbYU/0ggj6/rKtrinfL3zlJU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715188297; x=1715793097; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tSmrj41Qt+Se2fdGi7WeozvVj6AfH//AS3pb2zkquGg=; b=hMzUt2Gi5a1uikXHD7ID9/SpypkEfKMWHX4c9l5EzWlGzCFmwh8k+uX+7OAoIt02en rHpMWxNuMI0Agpeql0Cz9JdpLbQ4cDpJnNKlZNBHvZuHYnnRn3IPouJVUW8amA2jxa4G v0GYT8SoG3N/M0dASHKCH3h+M6XQ9D9toyL0mVNFe1RI0gtH/e0NH+Uz0ACrbMyqwz/x pkDbMIoQMgCWH1txGFYVUZ0V17cMgw68deinHygoyxTX8sX7cyYpuz3Y9TCHB9nCLi37 GCKzSpnSb1+O0ER+hjEh0xbZm5kIoXTiFLR7vY89u0yaa9KNYn8461jTSFi4b6htyM+L ldMA== X-Forwarded-Encrypted: i=1; AJvYcCXCUfqKlqQei27mYhP3wA5uhMh8ZIzst1Nthq54tiv0xXaOg9ECvwQtOy4OGznsAW7nVatfp8rCGZ8r+6Io9eoGeN4= X-Gm-Message-State: AOJu0YwivHcsi7oYQMmu8WnzXznil2JBm3SPMJT3E5FsVPZW9lTvxe1W aIfyb6KT+Zv58cnTWT+4wvXB+Qmgfe/kvPAc76Mr7WvJwPV3BLC3POoAZ6qBIg== X-Google-Smtp-Source: AGHT+IHN8eeXE9OsgItxEKHR70nrrazwBAjav29jEzJB0wGGmdP+iVlP1VjtMYRBUjqpRzzzPBgYhQ== X-Received: by 2002:a05:6a20:c88b:b0:1a5:6a85:8ce9 with SMTP id adf61e73a8af0-1afc8d1b02amr3543639637.12.1715188296881; Wed, 08 May 2024 10:11:36 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id lp9-20020a056a003d4900b006f44ed124dfsm9245352pfb.160.2024.05.08.10.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 10:11:36 -0700 (PDT) Date: Wed, 8 May 2024 10:11:35 -0700 From: Kees Cook To: Jakub Kicinski Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Luis Chamberlain , Joel Granados , Eric Dumazet , Dave Chinner , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: <202405080959.104A73A914@keescook> References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> <20240424201234.3cc2b509@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240424201234.3cc2b509@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3406840018 X-Stat-Signature: 1zwmj6nh66yta7p65onrieaz18qinkxd X-HE-Tag: 1715188298-103003 X-HE-Meta: U2FsdGVkX1/cnX7shIYJapJ2NVWRGxDI1TZHGnqJILCkX3c1+TILJLDOgq+2QJxGZLEfLaqZFvfM5fTPO6EuzRBlNFe8Y4PPOH4E1itPAJ8C07MMxJ2RudnLCtR/HDGwX3gyNZtn6fPcspuBI+O1LGaQ6PmbbcWM1PskeqIrETASF6QdpvBN9L+DWq2lQXAw8MAr2Q5OQNKm+ndiBfjO/7BTPOHMweD+y0tybUyW1yAm29m7fnQ/uzFJIjomeSt3/ArWBo8Jnn5HIeF29axTqRsyJbb7fn8PmRyZjtkRvL9Y350rwyU0FFt6QnAI2+QcpK+JX+DVejeXbDSIv6V6CQg+CBcoz0e3tivnI4H9vajsgsnA+GoZOYnwVzqPl5pP3Plg0nMP2nQYou5FftFh5wslV0KMFuX/Mrk/y9eXzQEQHOEsUOjCgRRTSH9oCRwAAr/UKGzYx9MoB8mU9DNC95jmkiluStFOSxez3P8m4FNt/4p3YwfoqruooDjrxFQh+Hk7hDM2VTWPUttL0DLGhgM+oSoBNooGfbi/uj0Jq4cBnmvzQtevSMjoFaWEjizYBqenjLibmZoQ7WT4hBd2USgqATDA67mGxDmSQ+ge1zcwoYC23+fgibjg/eioF8tgZyXf+4w2imZXT2q3MLxgG60w3ZcG+3hsH7yhOPicA3wGGHSztfL9RpHpx/KHNM77uA2wusUzcPb4u8NcLOkNzTVXrU8yiBn4TXPyfIotElK8NmS5XcwyW9qIFKvivNkfnfErxnnhgKo4OBX0M12sHJYMStQ/kNxQZKBgRKSowVxa807Niew/rf3XNx6ZN2bwEcQd+5IOiR+76BBdhqZar/OZBW6XWpkRYZoDOrjHYg8yn5PHNOUwsF45NKEBmOms/PmKTC0ZENActwKWpm5ANiuR9qlmD04SqiHXwdZ7oHkhYmUbRi0vku1PJVeHBKYZcv4vXbB4cNBJugfYjZ/ cYy3YXid 15EdM5VRUKl+ZpqzkqVXpuH8n7ySXqsJP7LCNYHWo/MV2DrFiX8MBBzxYCZI0aU4pzu/ojjkkJTOv9Wk234c0SPjJ+6GsseQEewgTrFzLxirr0nS4p6pMpyIkftSQibOq4kjXEjCX4KzLYYCQbARcXEcviO2CCqRnnz8sTaY0tX3bp0dMDjy5EgGICTTBZl1H0xvUlBPhG9a806uSNnPmnjdF68oqbwY5I/9omJRG6FKa2uR9ItipOr+LdkCTk3U6I6o4jl4Rxtig0Y8Gh2jqYJGOBY2d8wJp4/R+aijDrrD+S9HQHa6WxUzGHsiqqvkPK1T87n6Hgnys7BbwoY5eb8c9s1DXbJiyXiydR2VQqzLAio6flUb9WOZesKdBkPIUtOEZ8ybE+drS4Po+t8dRUfD3f4nNAGs4KLaKJ6O/YhgItf0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 24, 2024 at 08:12:34PM -0700, Jakub Kicinski wrote: > On Tue, 23 Apr 2024 09:54:35 +0200 Thomas Weißschuh wrote: > > The series was split from my larger series sysctl-const series [0]. > > It only focusses on the proc_handlers but is an important step to be > > able to move all static definitions of ctl_table into .rodata. > > Split this per subsystem, please. I've done a few painful API transitions before, and I don't think the complexity of these changes needs a per-subsystem constification pass. I think this series is the right approach, but that patch 11 will need coordination with Linus. We regularly do system-wide prototype changes like this right at the end of the merge window before -rc1 comes out. The requirements are pretty simple: it needs to be a obvious changes (this certainly is) and as close to 100% mechanical as possible. I think patch 11 easily qualifies. Linus should be able to run the same Coccinelle script and get nearly the same results, etc. And all the other changes need to have landed. This change also has no "silent failure" conditions: anything mismatched will immediately stand out. So, have patches 1-10 go via their respective subsystems, and once all of those are in Linus's tree, send patch 11 as a stand-alone PR. (From patch 11, it looks like the seccomp read/write function changes could be split out? I'll do that now...) -Kees -- Kees Cook