From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F041FC04FFE for ; Wed, 8 May 2024 09:56:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 815076B0113; Wed, 8 May 2024 05:56:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C6916B0115; Wed, 8 May 2024 05:56:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 666FE6B0116; Wed, 8 May 2024 05:56:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4452F6B0113 for ; Wed, 8 May 2024 05:56:42 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0C4E7141411 for ; Wed, 8 May 2024 09:56:42 +0000 (UTC) X-FDA: 82094774244.09.15924F7 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) by imf07.hostedemail.com (Postfix) with ESMTP id 37E3740011 for ; Wed, 8 May 2024 09:56:39 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kjcNAsj1; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715162200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FsicJzPzSYjb9EaWqN7pAslrOCGTYHDq5WxD1KJCe/4=; b=gjgkE7vQBRY3wF5yUjH7tA9gNQkdt4BGpejEnNfjnyZA8iXpnNSRSpYX9DOq6iUCeWQQiN fH+lUwhzYLLDJPOtilzfpieGDs/ArBeP0wK3c2wQe4yersS1oqGiwHtorOQ1Q/IHQnt/M+ RZAe940Kauo8WqRL65sMhviw0OTGhJE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kjcNAsj1; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715162200; a=rsa-sha256; cv=none; b=CEGA/yKuWQYfnLoIB2wSYBqXfw+1LAT7nbZwjoyLi7zeixs+OffbbIQ7SgBvDrgL7ccR/d eNkig129ajXf7pqBT+ttzrbC4BB8WHbRlTp0XL3kFSqvFLFUn6h2YcTfsGMStMGfrVv5Vz GQvpci8kGL/j+JnNJ/vHOryKROsbBKg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715162198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FsicJzPzSYjb9EaWqN7pAslrOCGTYHDq5WxD1KJCe/4=; b=kjcNAsj1cuN9Enofn4z93wcbSAjYLywjhJjN77ua1sIREN682XM4/TUP7KT8khp+C1Lxo9 /sUFpeSD3NLJqtnOZwJbyj9x/lzghKhbvs6VQjYNuH7/a4A3y3fzWLWWbcQd8hcfO2GpIG /os+5isiO/1zThfvmUzmeT4jB804zKw= From: Chengming Zhou Date: Wed, 08 May 2024 17:55:41 +0800 Subject: [PATCH 4/4] mm/ksm: calculate general_profit more accurately MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240508-b4-ksm-counters-v1-4-e2a9b13f70c5@linux.dev> References: <20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev> In-Reply-To: <20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev> To: Andrew Morton , David Hildenbrand , Stefan Roesch , xu xin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com, Chengming Zhou X-Developer-Signature: v=1; a=ed25519-sha256; t=1715162174; l=2381; i=chengming.zhou@linux.dev; s=20240508; h=from:subject:message-id; bh=ss7DfeQ3iIOHVfPafgYrAJPDTsUQSQx+kzwMyH5OwKo=; b=X6wGm8B+bjpFtCP8g73w6XczYKdiMwJ0vj812mxv/NkXQMbGzsqKeRNtJg3TU4ZL32DX+qm6z RzE/1RA0jgRBfO4CzfzJYEvfQ2HcOnx7ltDIHCHSXi8xkvh4KwjavFh X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=kx40VUetZeR6MuiqrM7kPCcGakk1md0Az5qHwb6gBdU= X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam01 X-Stat-Signature: ehmpsmkb3zoypt1bid4asj64rcqgnbw9 X-Rspam-User: X-Rspamd-Queue-Id: 37E3740011 X-HE-Tag: 1715162199-657663 X-HE-Meta: U2FsdGVkX1/0twvQ3kXryaqyHXMqmYmG9pJU+on0FfmrrrUhI/MUKx9VWYr8B7rU0Zx+rasbUTgmEbyo6rf5GS4NPbEucYkWJ52o4aapiHuachTJG2f36yIdQErpdtjn7Vmpk2CG7N8GDT5iW+maYXfpRuSVKWiI9zQICX9UPD3DpgH1XqXnrtfk0CvWTmDMb1dt9Bu/drKQZaTiRqkGE16Mgwq2QKHk1oDwWmdGaTHcGBEfRSs3j4q/XOsZEAyQfIXYB6dt2g/suSCLaTMWJgPAmXB/SIvd8TPpUlvS0ctumJzhh5croBsJUwqv/3LmF4xZfekyS4WejLm8fJ7MlRSzz2fbtq8klS0S5RzZRAvvbszKsdw2WGhdt+J0iBAKsAYGrupVrWuW44VptmI0TnhwVRbzx1krmU6byk4onhqTG5qeoKfh5Fx1BIAY96wZHT17F00/5j1GMbeSnKwXYzgKjlgL89xfuvfYSmKKU/DIULuBcEDbtzwtyuaCRKU3OYtJ54PmYvlsLGQUzSb5XI2B2BAjM3pPIuyibkkDQe4TSZfZggtxwNeqL/eN2Kb20SojKjO8uvGSduiqyHlUa4KcTwtV2cna2TpBrfOej9WoYjqPyLIhQp1W98xlFVOEG0wOz1JwO1FkGNL/QTKPWxDBsyy12DXhT2hHQZI4B9YBUlKoBojcjgMYnekIy1IESw5nKE7NHtZPHzQUJtD2NgRAswR8fz15GTn0uI2DDVo3J5bmnnMo6t5Rd5Uu0oxGen8Mk3uWToLs+KkoGlIDwM9hKiVCnYvpVszrSQaiOxuwGuzyH4aRy9f334p62pUb9kHVE9F71DIX40mKtkyb0sIbZW2mHZCEu+/o0RGLMtI+xVTOa7n5wOhJ+79C43uv5toT51ZdoHohfgeEk0jIMXfadztOgMnwJb1bK3+Z4iR/kCeCMmx5ILa/d9L3b2DoWpDkwBxDBTCALllGSce hTBrn5L+ NZf0z7at4BMMZqjbqmH7ApVnKZS4BONAqXehhU+117M8gyOpqHoW13qaBS/M1SDl1k0nPNVQI/kC1Bsc7/xIdhlYHxez/s4yuvBG5nZgOHh7Enl7wkTd0wR4h7JmvgMpOGU4O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The memory resource of KSM is mainly ksm_rmap_item, which has to allocate for each anon page that mm has mapped on. Another memory resource is the ksm_stable_node, which is much less than the ksm_rmap_item. We can account it easily to make general_profit calculation more accurate. This is important when max_page_sharing is limited and so we have more chained nodes. Signed-off-by: Chengming Zhou --- mm/ksm.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index 87ffd228944c..a9ce17e6814d 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -267,6 +267,9 @@ static unsigned long ksm_pages_unshared; /* The number of rmap_items in use: to calculate pages_volatile */ static unsigned long ksm_rmap_items; +/* The number of stable_node */ +static unsigned long ksm_stable_nodes; + /* The number of stable_node chains */ static unsigned long ksm_stable_node_chains; @@ -584,12 +587,17 @@ static inline void free_rmap_item(struct ksm_rmap_item *rmap_item) static inline struct ksm_stable_node *alloc_stable_node(void) { + struct ksm_stable_node *node; + /* * The allocation can take too long with GFP_KERNEL when memory is under * pressure, which may lead to hung task warnings. Adding __GFP_HIGH * grants access to memory reserves, helping to avoid this problem. */ - return kmem_cache_alloc(stable_node_cache, GFP_KERNEL | __GFP_HIGH); + node = kmem_cache_alloc(stable_node_cache, GFP_KERNEL | __GFP_HIGH); + if (likely(node)) + ksm_stable_nodes++; + return node; } static inline void free_stable_node(struct ksm_stable_node *stable_node) @@ -597,6 +605,7 @@ static inline void free_stable_node(struct ksm_stable_node *stable_node) VM_BUG_ON(stable_node->rmap_hlist_len && !is_stable_node_chain(stable_node)); kmem_cache_free(stable_node_cache, stable_node); + ksm_stable_nodes--; } /* @@ -3671,7 +3680,8 @@ static ssize_t general_profit_show(struct kobject *kobj, long general_profit; general_profit = (ksm_pages_sharing + get_ksm_zero_pages()) * PAGE_SIZE - - ksm_rmap_items * sizeof(struct ksm_rmap_item); + ksm_rmap_items * sizeof(struct ksm_rmap_item) - + ksm_stable_nodes * sizeof(struct ksm_stable_node); return sysfs_emit(buf, "%ld\n", general_profit); } -- 2.45.0