From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4F5C19F4F for ; Wed, 8 May 2024 09:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D2FB6B0111; Wed, 8 May 2024 05:56:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 182D56B0113; Wed, 8 May 2024 05:56:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 024BF6B0114; Wed, 8 May 2024 05:56:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D6DE36B0111 for ; Wed, 8 May 2024 05:56:38 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 841C91A0FBA for ; Wed, 8 May 2024 09:56:38 +0000 (UTC) X-FDA: 82094774076.06.EB7E03C Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf03.hostedemail.com (Postfix) with ESMTP id A7B2B20013 for ; Wed, 8 May 2024 09:56:36 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TxoxqQr6; spf=pass (imf03.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715162196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7esPxFrHeeBhwH9TcjMg5ONohBvtI4PjIYPbV7umvFg=; b=OyjcMBKp2GjGbO89IKQgIUuAIPbyYbEB87EpukNGsy5NmJRIRWqHZuSiPVtx0p5AE92gQ+ wCJJrlHf/dlw4iPNQkGzvMACKvM7MG8TmNsbBVWjKTxmzmHZcHI08FbI9Hx6F+L/ZzE31N 4kAtfbWG97aL16oYslq3i5D76ppYpCk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715162196; a=rsa-sha256; cv=none; b=z1hjw3eFsRXv3WFH6pp9a/WNUsuo9YontsFqnPZ0An2xTyqnA/UDS8c6RTz4Vj5naEAwbn 1SHaUti8XtQFII00ys4cyWS5jrINB9JG9tULMYhfLezLNLI0L0jQ/prjs7nc/XE1F/iWTg dFALJnTG3pwxjL+pJpmxmpd39OA/400= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TxoxqQr6; spf=pass (imf03.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715162195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7esPxFrHeeBhwH9TcjMg5ONohBvtI4PjIYPbV7umvFg=; b=TxoxqQr6IkPtfChwoT38ktZdFciaSGa3+CEFn0j3iaJM2QQ9PI0C6oA8r+CCO5OyIuLQKk 5iZps/f6cdsTPnSvWzVrdidclmBnSAFZwtFbVxwMIp3x7I4ElQut3qTe6idS+3e3QHKs8Y ZZi2Ih6oQEmzqFu75yMvT9mYIfnqKDI= From: Chengming Zhou Date: Wed, 08 May 2024 17:55:40 +0800 Subject: [PATCH 3/4] mm/ksm: union hlist_node with list_head in struct ksm_stable_node MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240508-b4-ksm-counters-v1-3-e2a9b13f70c5@linux.dev> References: <20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev> In-Reply-To: <20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev> To: Andrew Morton , David Hildenbrand , Stefan Roesch , xu xin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com, Chengming Zhou X-Developer-Signature: v=1; a=ed25519-sha256; t=1715162174; l=892; i=chengming.zhou@linux.dev; s=20240508; h=from:subject:message-id; bh=9T02FTklfVUMR7drM2v/kaRCwGZRX7z9/r7McdEQClU=; b=YuJNdQkZ4hOohg/ChgI1eEPAZsFyNzgMZ72nhyyjbRyA7QWsyafXvdi4d09ef4lYNSfT+KoKj QrNHFhfTfVcBUsmVogPymqqloYcrkQfyOf2Imn1RNmK07HWkiZyl0Ux X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=kx40VUetZeR6MuiqrM7kPCcGakk1md0Az5qHwb6gBdU= X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: z75zx8sc8yqai98z4fnjp3pptyq6if4d X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A7B2B20013 X-HE-Tag: 1715162196-47745 X-HE-Meta: U2FsdGVkX19qU0v5wLibJZAoEtmKlAJInzuMgfUjlAhJIAOBEMa+Rd/Ow9zT+QAFcwJoTDNc6r8hkq++O9s0P/W630/wDG1srreEcMXOfJ5ztvyEv6T46lhHkYHrj4LYuhVj1WRWWzqOAP4reW/z5prhDKck1Jx/+HgrCEuh88ETHRB4bh4/evfiB9wujl3/qQURRo5vPxXZpMY+ffDcAJkyw742K5+Bh5rXynxTOXUhGPRJhUWxvo4/O+KLuvwXYzdM4dZ+zCWNc1e9KUQzK9ClB8OzptI3qaF+cf7D8lPk+sELsEbhEXyWgFRaQ8Z6nSSfsG5W9dmP4vTXH1DjPFtWIi/Y3hAqBjUZfAnjiA0RHXo1I5JMlUWYpRoj0wxxLRMYqzVen0jUeNQDsl1JmEetKICu4YMPN7PtV7oFMRUCZwas9Gn7G17auMb+CXIWJKmOPcMLiLJkCl0jfcDiCdi4T4x9SCXeNq82tQ3EO9PSwV6N7XE6d1rOhi3liVvsyanLYe2qP31ssHzkk2pb4pVpzeeQdYhLf3ngRFBCISWIEsS/ftpxK1JZr3kkOtxWXQgoTBv2PSpdkvU74mI7fUoU8t3V/UcOiIvSRNTw5gGTybKU/iRGt9DQevf1BMHUoqV1k9TOoGfOev2lt/jsFv4eR/CuoWB04GkULIeix03J+QyCi1RpYXRgm+pjbtZHQU/u/yBoVYeK5mFom/w45hNGVP/Uve1MV7fVEGzmjwUofUHeGfB8dJO9ToLIsxyYYmGpg2adnTURzXdyrf+nn5nM/kz0SxvB6zJXxKB/rfr8yPX696ArQgzl1yFbgLnmGp0TiSkHZw/NnRRbwi+70+sT8BV1l3Pd0oP+2nxR2fnxPev1o8tlLCL+zHCCJFFtsijVD9L9RofwDpAt8rLN3Fw86f7yqcifJMxfbRhMBmXAns2HB2tw2tkoIE61FD8tTC1DK+qycw9f+8SSO6X eF22pjp6 BVwHslrxKUnYIHG7hsdUyjQCNY37V32I6GPwBxPD2JlR2+favmuybhPdg+s6ERERpB9lIOZtIIkBO6GXFomiItHsHxfv62lYgRVJQsmaH8h/GG64RomCzhE28q3quJquIHc/u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The ksm_stable_node->hlist_node is used for linking on chain node hlist, and ksm_stable_node->list_head is used for linking on migration list. We always stable_node_dup_del() first before adding it on migration list or list_del() first from migration list before adding it on stable tree. So we can union hlist_node with list_head to save some memory. Signed-off-by: Chengming Zhou --- mm/ksm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/ksm.c b/mm/ksm.c index 6e0dca3cecf3..87ffd228944c 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -162,7 +162,7 @@ struct ksm_stable_node { struct rb_node node; /* when node of stable tree */ struct { /* when listed for migration */ struct list_head *head; - struct { + union { struct hlist_node hlist_dup; struct list_head list; }; -- 2.45.0