From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33691C19F4F for ; Wed, 8 May 2024 09:56:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B48B36B010C; Wed, 8 May 2024 05:56:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF8806B010D; Wed, 8 May 2024 05:56:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E8C66B010E; Wed, 8 May 2024 05:56:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7F12F6B010C for ; Wed, 8 May 2024 05:56:22 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2807E81066 for ; Wed, 8 May 2024 09:56:22 +0000 (UTC) X-FDA: 82094773404.08.F235B2E Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) by imf09.hostedemail.com (Postfix) with ESMTP id 3CCC6140006 for ; Wed, 8 May 2024 09:56:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FWaZtJ6E; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715162180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=3rfrWz+6jXK312Dthrz355nwHvsfvj5vadJvhiAehC4=; b=jCQmo4Ei777Kl7LxIhIBzqrDtYboMIwL/sB1QLxEwjvOUf1RW0/JWBNmPUYNYFagQr36BI cqyNyvSQer6r5NAwrZBFWK75LmZBl8vx/XYBqU7QxwvrAvaO9toCe2Krn5PSBLYDtEXFbw 2LZtByLIegwlrveH1d5ZlJ/IoQvCkeo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FWaZtJ6E; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715162180; a=rsa-sha256; cv=none; b=cQFscO1BCp+Oqhit7NJTNdo4GqaYuLE19/uR4zKCCVBoS3bca3j29JeUQIw6dGVT2JfsA6 oFvqxBmIDspvWaoPGPTMp3cmFY1uKRzAT1q1ZcIH7V6jyPiE6y02RYMuBYrcGLPg+Q3LIU rDXEYONe7DMovSa3galeplC8JX0tFbY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715162177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3rfrWz+6jXK312Dthrz355nwHvsfvj5vadJvhiAehC4=; b=FWaZtJ6EmE5ajyj+bblbTGBTtgONcus1MnonF9Pkh+aQFyhRFoq+NBumkk3xIwkzheiMu0 jV5mhd1pVi+7dDBiMnBLL42njPH+qsK9nB5gvcfXc1Fbgsv0r5pkaA8zJ/uGXjBvF4IB1m kB4JdnlkEgEzOR7tsvbJZzvnZ1c4mDk= From: Chengming Zhou Subject: [PATCH 0/4] mm/ksm: fix some accounting problems Date: Wed, 08 May 2024 17:55:37 +0800 Message-Id: <20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIABlMO2YC/x3M3QpAQBBA4VfRXJsarMiryIWfwSRLO0ht++42l 9/FOR6UnbBCk3hw/IjKYSOyNIFx7e3CKFM05JQbKqnGweCmO47HbS92imTqrBoMTQUzxOp0PMv 7H9suhA/i9v2yYQAAAA== To: Andrew Morton , David Hildenbrand , Stefan Roesch , xu xin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com, Chengming Zhou X-Developer-Signature: v=1; a=ed25519-sha256; t=1715162174; l=1119; i=chengming.zhou@linux.dev; s=20240508; h=from:subject:message-id; bh=Xxa7Ak0JI97EX+j9mxn9LmkgnjWch4hCajYnLCWYtp0=; b=+IXTS3FedlIkxYy/lsaCO6YZfszKIIILCFsM7u+20GeXZ1GpnMkUzX6VWlPxYgNbKOMKgUeqM dYSbvZXHXR4CZVw7OpPEQ8SHtqq1Dhrw1oJjEuh/tC/1/VsThtKXtAH X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=kx40VUetZeR6MuiqrM7kPCcGakk1md0Az5qHwb6gBdU= X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam01 X-Stat-Signature: h8j4b89o3nhge9mm8bbn4qtjwyqjk9h4 X-Rspam-User: X-Rspamd-Queue-Id: 3CCC6140006 X-HE-Tag: 1715162179-823547 X-HE-Meta: U2FsdGVkX18TuSGefWr8wnvABrv78F4EpthFLONDnJY/YnisyUZFzAhEy5Zt2e/m807TsEDisu/8yBuUGNeTXpZ/wDWsFzrP+hpHDm7K4YWO2ZZQdO3R/CX9u4wUt4AWEGPjQSI+WeNN7XUpWwK6mHrFd1YOQwaI0WnxNnOTFOcDRf5CQlF+dn0fjMJqQhCWYR7fmm5smRzqfI3+py6k3qZpsWQiaSrXPh1tZIdVQqpamLqs6zUP4dE7ZEMoJUFOmw029kCyUJWH2nIZ9I1ywRanY8UX/3w/Mb1VpSksAiOKo4xfkwIWiCb9hbNMlWoPCmOiaFHErjn4+cqdSznCS2WNEvsqFHdo96Fkr1vw+qZIESg8QvSk5JsOqk5vMVRgQmZP/SeBOfEx6qHjGhIAyDZ8mJMLx8blJ4I1oogekGkKKgkC8DRA7N8GfBgWNol0kN3uPJ3mJrDq9tk4TQQd3NrLnxjvLjKcJ6HLJlXZxwKHN6prCYhApKNxYSkeoqiH9oNsERd5jFuY6kzSS/F+p6SJ+Ni8Zm7JMCp9TzB8LLx0x7HmTy+5ZLy8lhru/ZBYp3sxXEh+3JhBTDTSShpnI51kwG0jwWNSQEjAImFJ/0TP68t9VHpQf9byq9H4e+4Qd1nibU2Rj6ASEIYfja/TDdC4i63B2o6LxE5M63mZucGWL5Aj9gVnucZh/WB1W1fobyZKVf2aou7mADnfx4QomGyZIiLVYGg6pSu1zE3jCZ4o3Mc/4Y31c9F/MzyGH9J83mLIIQM3KX858LboK5gBkWOUyvTio4yR8tcrjzgT/qFNAgFFs5FzXmicM7C1cUEa+WwHU3QXQAAmNHv12FKz6hidpS++vAJ+WPqmEqAvUPoT3SiJOphdo8vdtuuvKa8J6j6nAtW4ZusFlE8SUlq28DasT7sBqfydEflwG+4JsA5svX976WoA3BCQO4ZnAKjokT7Uaw25JziAQgjZKT/ pwULga2w g7vfRpdElmRygA3QFeiDoQoCXDYHPVTzuqfN42kM9PJXUH+dpwpdOJR7PdfDvmRf5VKKRVaZrJtpOsDEpXm++skA7BA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We encounter some abnormal ksm_pages_scanned and ksm_zero_pages during some random tests. 1. ksm_pages_scanned unchanged even ksmd scanning has progress. 2. ksm_zero_pages maybe -1 in some rare cases. The first two patches fix these problems and the last two patches are minor optimizations about ksm_stable_node and general_profit calculation. Thanks for review and comments! Signed-off-by: Chengming Zhou --- Chengming Zhou (4): mm/ksm: fix ksm_pages_scanned accounting mm/ksm: fix ksm_zero_pages accounting mm/ksm: union hlist_node with list_head in struct ksm_stable_node mm/ksm: calculate general_profit more accurately fs/proc/base.c | 2 +- include/linux/ksm.h | 22 +++++++++++++++++++--- include/linux/mm_types.h | 2 +- mm/ksm.c | 33 ++++++++++++++++++++------------- 4 files changed, 41 insertions(+), 18 deletions(-) --- base-commit: fb0f40125feec3de7ef4524600ac83946207117e change-id: 20240508-b4-ksm-counters-04817b40d3ee Best regards, -- Chengming Zhou