From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F1FC10F1A for ; Tue, 7 May 2024 15:12:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E6D16B0092; Tue, 7 May 2024 11:12:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 198296B0093; Tue, 7 May 2024 11:12:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05EDE6B0095; Tue, 7 May 2024 11:12:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DB47C6B0092 for ; Tue, 7 May 2024 11:12:38 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5394140B43 for ; Tue, 7 May 2024 15:12:38 +0000 (UTC) X-FDA: 82091941596.15.B3A8136 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf20.hostedemail.com (Postfix) with ESMTP id 953421C0013 for ; Tue, 7 May 2024 15:12:35 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cbtvZcyp; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715094756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RfRSCg5KpHGWw8RsZ8I5UnrarkE9F9OFEY67ZOlRbAA=; b=EeLknCG/3DGYO0QwT9I0Dllec7dW3a0reeX3Dqv+bphOrdqb2mJq40djFBHDI6itkSD+Ek N9Of+s0kjF3GCMKIAPoDqXF5Db3cNvdqn0n94LIVgMBdEyzcRUbbI2IJyDWaiz4wDPpGDR Z+ew4MoZl/WZ8hc8WYOWNPg8TG9YR7I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715094756; a=rsa-sha256; cv=none; b=opzJFliRA8GRM6mdu9Nbzy3xPjiOacOhTlZkL6l/2+AeEal0X+l5nT+g0Ai/aPXW57Q30A 2okyREzrM0RxBYyukyiGo0YrP7afAqXoxPLX3g+Ei35tEpaN742midiPc0PpnGKwqD+r0j uq8Ye7QngRevqLiElh655yvSwimGrWA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cbtvZcyp; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715094755; x=1746630755; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sDXlhsNL5aaev9Nug91UWPEjiW+dKOlplEJl0WJcwro=; b=cbtvZcypOR1EoR2tlweJaMtsm/Fgx3Plro0XA+DVNjn1xYqEUbEZ0tZK /OcbFCkHgLNiz/KZAEgZzPpTV4BSpuggaTsJlRfGR5p4hZPfpXkjeyoug rJjP3MF6/kR6L/0Tv6b+QzpIOiJvkeh0LKcjsOhDoE/rI5eBq5U9SGAVR dE4kCZZq9Myk0gdRk1NBdYphz9kMne9V4PjPoEqRCSEraKKgAZk75Cfub 40SDWiKdwNK961++jsusyyNDt9TmNChXpTacmobaBzHKlQV6lppsejn5X QfWcz9GnTHADXqjJ4OcBziqXVACan9aTivbqqZ8pv1LVZzOFaj6HQwVoe w==; X-CSE-ConnectionGUID: Rx3vwqh5QeycM+NPdx+opA== X-CSE-MsgGUID: Xz4G0VhtSBu8KiKXev2mcg== X-IronPort-AV: E=McAfee;i="6600,9927,11066"; a="14684887" X-IronPort-AV: E=Sophos;i="6.08,142,1712646000"; d="scan'208";a="14684887" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2024 08:12:34 -0700 X-CSE-ConnectionGUID: QnsjyMUSRxuQuZTqlOlNMg== X-CSE-MsgGUID: gHdADgIIRwWIs7FK4UGgQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,142,1712646000"; d="scan'208";a="29077414" Received: from lkp-server01.sh.intel.com (HELO f8b243fe6e68) ([10.239.97.150]) by orviesa007.jf.intel.com with ESMTP; 07 May 2024 08:12:31 -0700 Received: from kbuild by f8b243fe6e68 with local (Exim 4.96) (envelope-from ) id 1s4MUW-0002Et-2V; Tue, 07 May 2024 15:12:28 +0000 Date: Tue, 7 May 2024 23:11:33 +0800 From: kernel test robot To: Allen Pais , linux-fsdevel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, ebiederm@xmission.com, keescook@chromium.org, mcgrof@kernel.org, j.granados@samsung.com, allen.lkml@gmail.com Subject: Re: [PATCH v4] fs/coredump: Enable dynamic configuration of max file note size Message-ID: <202405072249.fLkavX40-lkp@intel.com> References: <20240506193700.7884-1-apais@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240506193700.7884-1-apais@linux.microsoft.com> X-Rspam-User: X-Stat-Signature: 4537zok9qpy6grksk8y3rzxhgjphzfk8 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 953421C0013 X-HE-Tag: 1715094755-906551 X-HE-Meta: U2FsdGVkX192YJjNF48Etb+SuwSakK7ZBJeWHGP3BOxlLFdE3Xei7Fd8pLzW6AqyyrcUj1jqjA2FrCLCh+MYZTqP4gTmVsVS15ujb8O3DGmojSAHDsvTZUZQ0oaAITy2HRO2Jnf6AVZypr1GyuAqz1byjTPY264V+qurrXiIvDrG1EY97RAsUWeIS37hXntZq2cpkxHPL5rQowak7S6KiOiFa7G4iB8MxGv6pUJ1X6sgRuQHhzqKa0GC64/iwMhD6P8PeRfEBwYsOMIOHhPaVJtz/8lIk7vIZ50+4ZgEhx9iJHRpaRjxIwB3AYnTRMbvSqpqIfPMLikasW9kGFENbBnUHnyf6mjsPSnAFlPT6AQ1rJLNAOw2fTe+Ogbxsagm3bJnC77QVrWTxziTqznDyTrGvxFF888loun9IuP+hkw88Tnmo0ITeXo9P8da+KUSE8Oc0VMbDFYlqCxKet/+t4R5EeXwWMZvSsHt/Zchi5mKnRX7/Sli1ki/uE6q+htUfZ0umZlup+GYa9FQp9apFulOVDXBewp3tzKuoq/DvNhZrWhO+EEzoGYfectsMe3bTGn4MAFqfhoN615zFmnW6MJ5shSL8+t2OCkdOJRlSp5qNGKDB9vyv7W5vOf6hP6vnD1kT46trtPYHi/lQmWRmlE2aZke5MUO8rX0t66Fu9QY0sWBNE84U8MCfg8R90Kmd50oEvCdvMFkcaudGcKhwsQc9+TaBzSIBH26a30vISu3sNmQcRAcqVGYDzr/42Qptftavi0QSxWKjMqY1jNggGq2x8IvZiOcTGQzQKeldyx/EcC5Z+bCxulRvWmHs9q5ielLDYyYraRhlj0zDDc/8fsaMK6ssMdm43E7GOijwC1ANta3mwpgyPiFEN9jGwiDTSmepvUZZYxkLarjvl3GTKsfbKSeVLjH+dJZBBsstPM0Z8OKS+ukd1AUmJ44hV6CcJC+UCpnYwczYgv8P3m 4unRKExj WbaM46l4+PFrRv3+t7E6nw6LC0DybwD3nLlkwIn9rRLAVSlQXFubEQ2hpD6ccJH8MzPjx/K6RD6MsDmeM3jbMTR+ztJTSBeOElm5JyvuVk9IEsmipH9z5NBedEitxaxeIJkMdK+L1xUI9KRI5l8D6V6tWC0u1CGWXIbwrA9iTjLN/in4bW9Xbs4xQ+OO43miwDRkWzfVADaXXILz3DZlJHa58okmcHY9WgGOcbtkjL+lcbFKB/7cFJtgPkgjoYOOc1dfll/WTtO8iFWQYuRxbn4mJMuVX+xb2TZLuHN4krLaPt31hQEmS+RfajKbdEHCQsMshIXB/cASKJdgNlgq2w78SmpkQucEvzZ6mFMZrFDhzOvWe9oi300ZLGRPGA19J+9ur0sjXdbOdnJecDpc+Ep/GsXDM/8cm0jU7Vx5SggIoiZ72djQK3lG0sjoQJQLDxGUxF1p6ujFPzUA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Allen, kernel test robot noticed the following build errors: [auto build test ERROR on kees/for-next/execve] [also build test ERROR on brauner-vfs/vfs.all linus/master v6.9-rc7 next-20240507] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Allen-Pais/fs-coredump-Enable-dynamic-configuration-of-max-file-note-size/20240507-033907 base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve patch link: https://lore.kernel.org/r/20240506193700.7884-1-apais%40linux.microsoft.com patch subject: [PATCH v4] fs/coredump: Enable dynamic configuration of max file note size config: loongarch-randconfig-001-20240507 (https://download.01.org/0day-ci/archive/20240507/202405072249.fLkavX40-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240507/202405072249.fLkavX40-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202405072249.fLkavX40-lkp@intel.com/ All errors (new ones prefixed by >>): fs/binfmt_elf.c: In function 'fill_files_note': >> fs/binfmt_elf.c:1598:21: error: 'core_file_note_size_min' undeclared (first use in this function) 1598 | if (size >= core_file_note_size_min) { | ^~~~~~~~~~~~~~~~~~~~~~~ fs/binfmt_elf.c:1598:21: note: each undeclared identifier is reported only once for each function it appears in vim +/core_file_note_size_min +1598 fs/binfmt_elf.c 1569 1570 /* 1571 * Format of NT_FILE note: 1572 * 1573 * long count -- how many files are mapped 1574 * long page_size -- units for file_ofs 1575 * array of [COUNT] elements of 1576 * long start 1577 * long end 1578 * long file_ofs 1579 * followed by COUNT filenames in ASCII: "FILE1" NUL "FILE2" NUL... 1580 */ 1581 static int fill_files_note(struct memelfnote *note, struct coredump_params *cprm) 1582 { 1583 unsigned count, size, names_ofs, remaining, n; 1584 user_long_t *data; 1585 user_long_t *start_end_ofs; 1586 char *name_base, *name_curpos; 1587 int i; 1588 1589 /* *Estimated* file count and total data size needed */ 1590 count = cprm->vma_count; 1591 if (count > UINT_MAX / 64) 1592 return -EINVAL; 1593 size = count * 64; 1594 1595 names_ofs = (2 + 3 * count) * sizeof(data[0]); 1596 alloc: 1597 /* paranoia check */ > 1598 if (size >= core_file_note_size_min) { 1599 pr_warn_once("coredump Note size too large: %u (does kernel.core_file_note_size_min sysctl need adjustment?\n", 1600 size); 1601 return -EINVAL; 1602 } 1603 size = round_up(size, PAGE_SIZE); 1604 /* 1605 * "size" can be 0 here legitimately. 1606 * Let it ENOMEM and omit NT_FILE section which will be empty anyway. 1607 */ 1608 data = kvmalloc(size, GFP_KERNEL); 1609 if (ZERO_OR_NULL_PTR(data)) 1610 return -ENOMEM; 1611 1612 start_end_ofs = data + 2; 1613 name_base = name_curpos = ((char *)data) + names_ofs; 1614 remaining = size - names_ofs; 1615 count = 0; 1616 for (i = 0; i < cprm->vma_count; i++) { 1617 struct core_vma_metadata *m = &cprm->vma_meta[i]; 1618 struct file *file; 1619 const char *filename; 1620 1621 file = m->file; 1622 if (!file) 1623 continue; 1624 filename = file_path(file, name_curpos, remaining); 1625 if (IS_ERR(filename)) { 1626 if (PTR_ERR(filename) == -ENAMETOOLONG) { 1627 kvfree(data); 1628 size = size * 5 / 4; 1629 goto alloc; 1630 } 1631 continue; 1632 } 1633 1634 /* file_path() fills at the end, move name down */ 1635 /* n = strlen(filename) + 1: */ 1636 n = (name_curpos + remaining) - filename; 1637 remaining = filename - name_curpos; 1638 memmove(name_curpos, filename, n); 1639 name_curpos += n; 1640 1641 *start_end_ofs++ = m->start; 1642 *start_end_ofs++ = m->end; 1643 *start_end_ofs++ = m->pgoff; 1644 count++; 1645 } 1646 1647 /* Now we know exact count of files, can store it */ 1648 data[0] = count; 1649 data[1] = PAGE_SIZE; 1650 /* 1651 * Count usually is less than mm->map_count, 1652 * we need to move filenames down. 1653 */ 1654 n = cprm->vma_count - count; 1655 if (n != 0) { 1656 unsigned shift_bytes = n * 3 * sizeof(data[0]); 1657 memmove(name_base - shift_bytes, name_base, 1658 name_curpos - name_base); 1659 name_curpos -= shift_bytes; 1660 } 1661 1662 size = name_curpos - (char *)data; 1663 fill_note(note, "CORE", NT_FILE, size, data); 1664 return 0; 1665 } 1666 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki