linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	kernel test robot <oliver.sang@intel.com>,
	oe-lkp@lists.linux.dev, lkp@intel.com,
	Linux Memory Management List <linux-mm@kvack.org>,
	Bill Wendling <morbo@google.com>,
	Eric Biederman <ebiederm@xmission.com>,
	Justin Stitt <justinstitt@google.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Shuah Khan <shuah@kernel.org>,
	Yang Yingliang <yangyingliang@huawei.com>
Subject: Re: [linux-next:master] [selftests]  35c9dcde4e: kernel-selftests.exec.load_address_16777216.fail
Date: Tue, 7 May 2024 21:01:52 -0700	[thread overview]
Message-ID: <202405072057.1DD78A3EBB@keescook> (raw)
In-Reply-To: <202405081002.fc4eafcb-oliver.sang@intel.com>

Hi Andrew,

Can you please drop commit 35c9dcde4ecb ("selftests: exec: make
binaries position independent")? It looks like it's broken under certain
conditions, and what's more, it seems it's been subtly half-broken since
commit 4d1cd3b2c5c1 ("tools/testing/selftests/exec: fix link error")
too. (Using -static changed the nature of the test since now it doesn't
have an INTERP program header.)

I'll be working to fix it up.

Thanks!

-Kees

On Wed, May 08, 2024 at 11:22:02AM +0800, kernel test robot wrote:
> 
> 
> Hello,
> 
> kernel test robot noticed "kernel-selftests.exec.load_address_16777216.fail" on:
> 
> commit: 35c9dcde4ecb82ba4a46219a345c36054fd15454 ("selftests: exec: make binaries position independent")
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
> 
> [test failed on linux-next/master 9221b2819b8a4196eecf5476d66201be60fbcf29]
> 
> in testcase: kernel-selftests
> version: kernel-selftests-x86_64-c7864053-1_20240419
> with following parameters:
> 
> 	group: group-01
> 
> 
> 
> compiler: gcc-13
> test machine: 36 threads 1 sockets Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz (Cascade Lake) with 32G memory
> 
> (please refer to attached dmesg/kmsg for entire log/backtrace)
> 
> 
> we also found kernel-selftests.exec.load_address_2097152.fail
> which always pass on parent.
> 
> 200a289b342bae6c 35c9dcde4ecb82ba4a46219a345
> ---------------- ---------------------------
>        fail:runs  %reproduction    fail:runs
>            |             |             |
>            :6          100%           6:6     kernel-selftests.exec.load_address_16777216.fail
>            :6          100%           6:6     kernel-selftests.exec.load_address_2097152.fail
> 
> 
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Closes: https://lore.kernel.org/oe-lkp/202405081002.fc4eafcb-oliver.sang@intel.com
> 
> 
> 
> The kernel config and materials to reproduce are available at:
> https://download.01.org/0day-ci/archive/20240508/202405081002.fc4eafcb-oliver.sang@intel.com
> 
> 
> # timeout set to 300
> # selftests: exec: load_address_2097152
> # TAP version 13
> # 1..1
> # Bail out! FAILED: alignment = 2097152, load_address = 140281068855296
> # # Planned tests != run tests (1 != 0)
> # # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
> not ok 3 selftests: exec: load_address_2097152 # exit=1
> # timeout set to 300
> # selftests: exec: load_address_16777216
> # TAP version 13
> # 1..1
> # Bail out! FAILED: alignment = 16777216, load_address = 139671213199360
> # # Planned tests != run tests (1 != 0)
> # # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
> not ok 4 selftests: exec: load_address_16777216 # exit=1
> 
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
> 



-- 
Kees Cook


  reply	other threads:[~2024-05-08  4:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08  3:22 kernel test robot
2024-05-08  4:01 ` Kees Cook [this message]
2024-05-08 15:41   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202405072057.1DD78A3EBB@keescook \
    --to=keescook@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=justinstitt@google.com \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=shuah@kernel.org \
    --cc=usama.anjum@collabora.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox