From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3294C10F1A for ; Tue, 7 May 2024 19:27:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2622D6B0085; Tue, 7 May 2024 15:27:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20FAB6B0089; Tue, 7 May 2024 15:27:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D8326B008A; Tue, 7 May 2024 15:27:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D69B76B0085 for ; Tue, 7 May 2024 15:27:13 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7701514080F for ; Tue, 7 May 2024 19:27:13 +0000 (UTC) X-FDA: 82092583146.25.A2EF894 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf25.hostedemail.com (Postfix) with ESMTP id 40C82A0007 for ; Tue, 7 May 2024 19:27:11 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Lxncq+5j; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715110031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gvTYQvtdmFkBWYBMVhiFfbISKmN7J/FVgrifaFJdSG8=; b=FMoQIIZyLhhywz3tjdU33VRfoboHYXEsUHdX7b5Bvwtxp56Sdffyy/e8EgwxiZF/ckdDFC mBM0K+dPB+f0GslgKW3MtvR/rP1HvXvPYfMUhjTK/is9U+Ig95WrEzXyiUb9lbTSxR8GcT GZI+9lZoIPMHg9rDbKD73Bn+BB5GwH4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Lxncq+5j; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715110031; a=rsa-sha256; cv=none; b=khIFB8LqBaXkzrUthD1oNtgK5uQqZS3+T7G+aKXIBN32UZoVrKLbEulGYrVpZhOqSOgi3B F8W/NXY93ZCEnTcYU9bDkkD4JB/4ayaBCcSFwxGDupNSjyiiwwFYSze/HycOKhP2/v4MVW +hoLBeEaWSVvi1RXS1UPK241EzAsy8o= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 8F04D40E01A1; Tue, 7 May 2024 19:27:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pKGFQKbUhIz6; Tue, 7 May 2024 19:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1715110025; bh=gvTYQvtdmFkBWYBMVhiFfbISKmN7J/FVgrifaFJdSG8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lxncq+5jJ2HsvOIS6PnAxN0lAK5rQCznC4CA+Aj7HrvQcnU0HfOqdeHSXaSL7986C UoYqnj5rD0m6kUyCeE07WuaTWLkbysPSncjw7KmwY+NJQSwIg3ZBSnImCQvluG9XWZ KUqWkHrx6tiA6jMkrff8jREXK/X7QJsURqn3OZDnKh6t7677hSxmwNUi/v+KsnP8Og DrBMkpZL0bsWHpEkmN8lNHCuD9lReB7d/p6dljc8JVWW/THA1Kms6EQ/EO40iqLIXh xLsHy3X/1/lReoeoZMymztUngnKAXzn6Ycf+eYpOWVE9m0dZlCR+9yv4khOhlf+yJd AvPeUOlYsQAu82diAE6WuBuwa9KDUwiCfa2gA5skkvl+VF6rcZexFw+r46dUfVLhpn t4F8+rzv7wI7PZZYcqxRQ+YtqTmFkyuIKv8L+P/R/iLkv0+IQAwHvwRXE3jp/FBh5t X73mAzy4kgjTJZAu0dt5/cHDe32JvSmtr1ur7R+q2JUbmpfXzqJtCnEnQV+J8AdWR7 maQjZgRyJFIOGuW/F/zP89nKrygCyceqZxO7/XsbF2car6dyj1zT2ic/9cCS/uwY4m DKq3x3BUmCC/SiNoCRxrM62BBonsrxov5VN9MtIYvElXVt2ndt5gap2mMZPsNpBKMJ kC4mLRfWpNEwotMvaZz3W9ww= Received: from zn.tnic (pd953020b.dip0.t-ipconnect.de [217.83.2.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4A6DB40E01A3; Tue, 7 May 2024 19:26:55 +0000 (UTC) Date: Tue, 7 May 2024 21:26:50 +0200 From: Borislav Petkov To: John Hubbard Cc: Andy Lutomirski , Dave Hansen , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H . Peter Anvin" , LKML , linux-mm@kvack.org Subject: Re: [PATCH] x86/fault: speed up uffd-unit-test by 10x: rate-limit "MCE: Killing" logs Message-ID: <20240507192650.GJZjqAeipgUw2AoCK9@fat_crate.local> References: <20240507022939.236896-1-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240507022939.236896-1-jhubbard@nvidia.com> X-Stat-Signature: ynawi36xxe6eq9so168ss7htykogmcra X-Rspamd-Queue-Id: 40C82A0007 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1715110031-852999 X-HE-Meta: U2FsdGVkX1/oe94ZtygTEF80elyKzoLLWXzqAxcGhx0dYazvTJFRqbn4LG3g9B11WLFpsarjc9iXoMcFIG44g3PuH3okv5qLoXbDB8fPOk9f6ZpKig2CTCfQINrg8tq7BurjeF4afhQ/qrHUA5ybvv2ncNG3mhKtK6sHfXh5909afGNFpxkPvTs4JpB41vspKrd/MXvv3knpaTkGr1N3ZVPrReVWGAm9kkaC8MIbtoOTfumYe9TUEnUWevQIEO6Lq+xglWWB6r0YlLlSlEIK9Q+SLHyZk9smsYGj44etiyMm0JMJyebHdmhlrj2Cb02HpzdmrkPrGJYAsS4/8FlmULG3FlpQjZGPUFXOPJ6YpG2u9fZgdo/5jmSbsWy2tSp3NSZQW7PdZxnz6NK2dv37/bcJEvDWD+BUhYVx4w1C7vGsgE1gh82wIM8PFedmXymwcKFEAyoWWzyhjQEUhoCnlC9kAx4o9p3PxJBOJvuHW+7FHOeAcEHSORwaedIjXL0wUgG9PM/u2Htl/b3B2c5AFVHbrfJ1mdaEuAjwaKvgz5ps9Mcgfcpn2trCqDzwrOuE9nEqPbCAKeN3UlS/CNqCx6y2yB4wOF0wZOe5CdhbvdKiZXFw8wrTCN1Fe2PvD4bhK0QpF6a/9Ew66ixdV9JKid1N7fRdqE2w8cLtafTuh+Jpdm0uhuJWQNNKJLUfKA/0TWimX4y2OjfMIE2Ps8MLpoohyhJunhw80iyqwzjlU2dm9mSZ6gDk8AnEj1XkyoFUe8cqk+GF1DFR975n7ljqPmMhYKNx8aT1pwGF9xdz5aevsm1IFxqGKoeQJ807pNkq0BGoyp1a2lfUzfXSMz1Wn4UE1UC1TY5BwCDDKn+hbeZAK6MSuX+GvwNrXvKwi3Lt3TumzIUymZOv3uqS94w3C71ED78w9tk0DHtS9iycavCDs/RGRKaeWUJyKTFefBm2726S3RLP9WgBHR4Mdoz CxO0B+lG rZwFIvkwvRTAuHuMMpoDTDkXPen/nyTXEfAOTpWnnLHLk5ukgNHYQzqQ1eq8qiNv4OB2xvpKZUsFkI3f3k5EdF2C3o3KrctzqbOyNWYMnSdKu++P4BEQ14uKsAwBXfR1Nrmp8f18JM+chL6amJXTkf9k9vUviPiRWOH6Neayn0xPTA9zFqmUvkjMRxZjYMv8nMhSyZppgZWS1nQ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 06, 2024 at 07:29:39PM -0700, John Hubbard wrote: > Generating lots of memory poisoning events seems like a valid use case, > by which I mean that this is not just a testing artifact. And that's why > the fix applies to the code that directly generates the output, rather > than the selftest that triggers it. Sorry, not taking a "fix" for something hypothetical. If this is a real issue on a real system and the printing is the *actual* problem at hand in a hw error storm sure, but no, not because a selftest runs slower. I'm pretty sure in a hw error storm scenario, printk being slow is the least of your problems. And in such a scenario the *last* thing you wanna do is ratelimit prints so that you can't even get all the logs which is *the* thing you need to debug the hw. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette