From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5C6C10F1A for ; Tue, 7 May 2024 23:28:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3F496B0085; Tue, 7 May 2024 19:28:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEF036B0089; Tue, 7 May 2024 19:28:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8FD76B008A; Tue, 7 May 2024 19:28:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 85E356B0085 for ; Tue, 7 May 2024 19:28:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 40FF41A09CB for ; Tue, 7 May 2024 23:28:57 +0000 (UTC) X-FDA: 82093192314.09.45F013B Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf09.hostedemail.com (Postfix) with ESMTP id 5F4E214001B for ; Tue, 7 May 2024 23:28:55 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=e4O31ARC; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715124535; a=rsa-sha256; cv=none; b=HN3foQixzglDil9QuvftNQ8BS8VXte3y5jz32HxORDBVNMM5MDkoaWRQ5H6AwBir1LGvOJ vYWb8PcgKynIMZIM1sUnPg8L9xRls+GZYr+4K1xcnvmH8ood33eNxEiJnshabJqZkDLrHs vzXZ8USfcjD0AnRAaievrPRyjmOF/JI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=e4O31ARC; spf=pass (imf09.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715124535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tt8XgRQm+eA+VmBxGqEcvvy66oE9R2AfbLeL3WkCPuU=; b=Cpairbb0L0w1o1PXlyjQ+6BdD1zEgHve8tgIZFILezmwcQXGnQ2VuheRdGXG6IAvqZazdw mgi5UZGunWVkq9fAZ0I2ctltWtxhkGqpW4VjlpRFKecch09/KHehXDXApUEGaSqwwX/q0P WwcrnTDNCIqoQ15WEPsUMPt7THNf10E= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6f44b390d5fso3624703b3a.3 for ; Tue, 07 May 2024 16:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715124534; x=1715729334; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Tt8XgRQm+eA+VmBxGqEcvvy66oE9R2AfbLeL3WkCPuU=; b=e4O31ARCsoQWieBNYMX596gWFckNBamCITxyV6SoZYkVKqYzkAGiHD2kJ5XM/INZNL 3ZX7/SUettO3zCI7NnRxqf4/t7lXBYLtD70HWJ8A4er6O+QInejS2vgNJ3WZeYKrx0VI FQpVN0X3rn5BczokHk4AslAEn7boE542jKOyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715124534; x=1715729334; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tt8XgRQm+eA+VmBxGqEcvvy66oE9R2AfbLeL3WkCPuU=; b=pUtyCMJ08l7oe69+ThMQHVri8MJPJRGHR2QFzL6+F+0gBnY6zoV1zufxbUk0Nd6rzh iJvwnTHoT2JQ+XRvpJ5+7pH3NXA8q3sq5SFnee8Od29GB4Z7K/T2hV6EbjC4xV3HghNh VAsg1vORtQ7/QsNX/x/nzck8oABzLmx7RyZIiIZyW9x02gEBkhEQGv5UN1sHY7/Wo7zb N54sNX7Ij9cZWd1ELy1Gj6+xffZrAjX7oX7joKKhSMXltpD4fnm++PBcF3tHQ5kPsmmO UqM19d5bx79OWktL0zUmC8cgXpArV8K43pQWJUpOmym1c410j+scxYIkLffmc9UwOecZ HOtg== X-Forwarded-Encrypted: i=1; AJvYcCUGnVhhyeWvms/Q8/me6VK9Tpo0UoJAvbXbm/YwKkoH8tN/Mf8xSBZOh71N81LkiZOoWAu0oJCCPluO118V37cGrCk= X-Gm-Message-State: AOJu0YySOetchiGsarJNTem1EhZhlCHouKaPd2oBtLKe9NrWwaB5tIHp InHmLFko+/9gyF9or4fYkfU96jmPVgrx5v9YXugZPL5JJTMxvPKXCYouLXndew== X-Google-Smtp-Source: AGHT+IFbPbF1juPMua/7QCwr3XNtJKU67fTmoJPJThYwOlI8JdQwapcBSCTsyl1gnc0fJudVKZxUrw== X-Received: by 2002:a05:6a21:6d91:b0:1af:8468:5f79 with SMTP id adf61e73a8af0-1afc8d26e67mr1461660637.16.1715124534122; Tue, 07 May 2024 16:28:54 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2b628ea6aadsm61520a91.50.2024.05.07.16.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 16:28:53 -0700 (PDT) Date: Tue, 7 May 2024 16:28:53 -0700 From: Kees Cook To: Edward Liaw Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?iso-8859-1?Q?Andr=E9?= Almeida , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using Message-ID: <202405071628.7F8C3EC@keescook> References: <20240507214254.2787305-1-edliaw@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507214254.2787305-1-edliaw@google.com> X-Stat-Signature: 5e64ei9n3u91cr8hf89o4e9oxjt5yzkt X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5F4E214001B X-HE-Tag: 1715124535-897754 X-HE-Meta: U2FsdGVkX1/lyPAjvXmDnZDuQzbREWRAHFO1i2k0LAwsSCSMQcIVVdX8ykh3YkVTVR0Bsm5vjECHEw0wd3zyfvRmlEF4cv1LFilnA9+W6yLiEOYQFpTpa6HtORtUbsRHA68V8DxUKdB+Pg/z+9RYAJE8nkIS8/GQkXfuP/vZ1lWQzKtAiQW/oeKwL+rmdPrOZ2Uoyo8TJzO/B7mLEw/HIrO2A/Q7HMtjF/8MgVB3lFANaIcvUZXqi+h1znxobapnDOibeEtZwr7NfxBIl4W3nQBXZBFGLXjWpGQ+COxCHds8RUJNCD3afRZIyt93WNKtazF8HLA8+QpdgMAMNWZz4gN2cvKcjM4TUx+b6FRhANHhi6e/zxX9ea2iYcjoq8aAf5XS4E6EeoV48PaujXAU0B4H2OcMGnzUtn2WSbnz9v2yl/WPsK5rsMHVi4C8jLdnxlHT8EAExKRJHezFegsP9rRQmHBIbPwZQSWFOXNfjU+LX7/VUVjL16yrg38LBtffpbH8eRMSTJsGBSwyU8IS5A1ipQB6kRPLcVKWyMS7ift6AfE9Y+6xk8WxnEsiGapglx0UmR++0EKtJWAvfkGaKvKxv4dRjG40oYl6pw4F5zki5D+khID/PHi77rG7Nr20dcbppFO3EXx3ua8J//8ttT24KZCtqVg7IyN0L1bntkvanGPbcqFkfvJyVgDDcurPD2avJiZGjyjEm5icdX9d+/OF5YWXNfOhC4FAazzF7Qzv6x5ApskJaTacWLxK0qHVlMdSneFQwwFCO67KY0JI299UEmbeMbekBZsZSxG+xeK/DMpefQKSruTVb3Boo1k4AAP6ueL3jb7nFTFSqQ51/GLxNMdj81B+8hAc34kMZEK3WX2Eh4vjo08733gJgpsQqOZMNfD1650FIffKz4XGkR9qCkEEIRsXeY+3bgO06o5xD9OdseLsyS1Z2VmaBQRvs6f+8Gmkn4wH9Wnh1Fw DvTRs6WE NWaC9ELM2ppMWaFKWMm0WHozq7bDUu2X4mYoELWR/kzkAA1bd4V4r49qkPMIQY4g+iQUOLIfS2Z0QlL3lKlOg+kR3MmVqluZrGL4FHNJryWpU64I2azAyfvfEMGsqMBHyz8uLZVkFCHq11dw+ufZ3ROavsqb2p9LheAShd0mpzGiwKTRBgzJop8gn0BDQrrYgmmuN22yNe48Oi2n0zcrlJQ+f6w9DikoTrXwlPkVhODV8jr5/lYK9vzUMz5/cjjrFBAHmlCvpiZy8SwSI8UjVzHqfxm1rhVVgRHjVLkgMykjmC6uHliVACyN6u2Hs3HBcCLUeBE7nk/4muWUBopci4ODALwuJRjifmQSJfLq2LX539Py0V8lK/wp/FdYoAjBZLn9tEoQOdpH6pd3IA1qE6kCzkXapWr6yBpDX+22JOcaVEZjZP5zzjvxDnNnF4NTD2r+cRDX/iGvlMkb15BNtS50jmnY/rFchinYF+Mog4/1ZMe17XXd6JJ5KBkZ3gVinNbT7z0wQ54mbwQn9KQInf/OEnUwJZnLJ7zqyDW+YDVJONbHAekYwrSkS1+2b8YdyRAmrgdyVrc8iabE5RkW1iakegQ+4xIQmw3X4xuX93csy7WU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 07, 2024 at 09:38:25PM +0000, Edward Liaw wrote: > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > asprintf into kselftest_harness.h, which is a GNU extension and needs > _GNU_SOURCE to either be defined prior to including headers or with the > -D_GNU_SOURCE flag passed to the compiler. > > v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ > v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > location. Remove #define _GNU_SOURCE from source code to resolve > redefinition warnings. > > Edward Liaw (5): > selftests: Compile kselftest headers with -D_GNU_SOURCE > selftests/sgx: Include KHDR_INCLUDES in Makefile > selftests: Include KHDR_INCLUDES in Makefile > selftests: Drop define _GNU_SOURCE > selftests: Drop duplicate -D_GNU_SOURCE It's a lot of churn, but I don't see a way to do it differently. :) Reviewed-by: Kees Cook -- Kees Cook