From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F030C25B4F for ; Tue, 7 May 2024 14:59:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11C056B0085; Tue, 7 May 2024 10:59:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CD696B0088; Tue, 7 May 2024 10:59:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFD146B008A; Tue, 7 May 2024 10:58:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D33716B0085 for ; Tue, 7 May 2024 10:58:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 766801213EA for ; Tue, 7 May 2024 14:58:59 +0000 (UTC) X-FDA: 82091907198.11.CC05E9B Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by imf20.hostedemail.com (Postfix) with ESMTP id BE4B01C000D for ; Tue, 7 May 2024 14:58:56 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=iIOQShVl; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf20.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715093937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l4BxBuTRaRH2Icv5CxaP0p6s54rUUSgkZ15W6zrfzYQ=; b=AwqerRYJEJN7YFCcRnvyuUCVLwKYsO8iP87tmsiKf4dtiWAK0l03nvxPalk8NhRAuwhbge Xw5oCKvE2qdlRHgp2WdSSPx8fs9xq8rsca43LCTTqoXvCFMmEF67O2BAkrAq1OnqiRQrOz t6uh1rVHv3Sk70ZlTwOXtou9Moi2xbI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=iIOQShVl; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf20.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715093937; a=rsa-sha256; cv=none; b=KQslvkt3dcVlF6NLeShKo8spIdkjAuTEbbqg7uZn87FR7ZxYDWgcRDkGX5885uhLA+taFk UbXi/wbUTzvKAjK2u9pnimplg47pjjhTM4asSwr/R8O13SV03iqe0iwSxk69lWXpU5jpX6 cDmLNRxzoXxZ3zxM4gNGiaNnduhe8lU= Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4VYhHT4qmNz9sd6; Tue, 7 May 2024 16:58:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1715093925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l4BxBuTRaRH2Icv5CxaP0p6s54rUUSgkZ15W6zrfzYQ=; b=iIOQShVl6oyIultqxr0Zh0jmWet+S/bPIQv8kiORbz4m3wvOnGDEc6ZSEdiPiIwJBxkdax gue+lspS1QNXVxkBcVmCx5y83WhPe5Ios/fLrQSv2aBKeLuObTyg5V5YSP7ovzWBRvUJf8 rDNu7yl9cmBDhy/rBfbclICwyIMTVdeVnMBQTLZt3DNQwMMA4mnIfj/zZQXoBsTubvdHB9 mplnIDFmivgPZH81/IBYfaFYKll+02u6H6Sphe55j0wHE2JaCQ1wAH5ovWWis3FltlvEMr RAZp+Ic8jQpeZiMHaRpkqe/dmrlsrf1kB+6ztKqL5N3Vs1nV18K5F1SUs/5KJA== From: "Pankaj Raghav (Samsung)" To: hch@lst.de, willy@infradead.org Cc: mcgrof@kernel.org, akpm@linux-foundation.org, brauner@kernel.org, chandan.babu@oracle.com, david@fromorbit.com, djwong@kernel.org, gost.dev@samsung.com, hare@suse.de, john.g.garry@oracle.com, kernel@pankajraghav.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, p.raghav@samsung.com, ritesh.list@gmail.com, ziy@nvidia.com Subject: [RFC] iomap: use huge zero folio in iomap_dio_zero Date: Tue, 7 May 2024 16:58:12 +0200 Message-Id: <20240507145811.52987-1-kernel@pankajraghav.com> In-Reply-To: <20240503095353.3798063-8-mcgrof@kernel.org> References: <20240503095353.3798063-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BE4B01C000D X-Stat-Signature: u85qicocthnsc9wxqs6ao1rcnj6eojg6 X-Rspam-User: X-HE-Tag: 1715093936-72879 X-HE-Meta: U2FsdGVkX19leGTKOlBeC4hn0PFK8RFDzppE9hKGYK3EsLUqmbvTsnfliTZtVnquniK4xaQptxpepH+YIq1jRHWM7vBboD3mg7Hmf6bg5esxGwnSW2RgbSA7KpAXXrwd39jz11iby7O8wzNqaLKRqVBWsGGRedFXRDzm5UJ2L/xl5yDg3vS3rmkMfAafFWh2r1g3i8GKdCM7hbxbERtSCWUIjK5pqf+ZO7Q1G6e9bqsx4JPHnyLQ2S3+nboLp43la3pD94v2tEutJL37C8q6a1oow82nMQ27gQDQrZuy4UpBodKN6nqr1MJCPj8oJ83BnoFITS95uZjT+pgnxYlXGWn+lN7C3my5lzc1KS3Ry1UVceb60DUst5rTirs3TlDM7x/Q/IcR4jQ5KStNad04wbQRdqRR1BrGF5X74mcgBNfqKxrwLz21c48KjZhJR1EF50Sb5MpADByCEtPJM2W7tUAkAgpdRweBMZ6AQzsnA9tXMCTIjDyCOQX0fZ0evRmpoTSd0rf3HEvM8RYckF1b9Lo3L0bn3pzP77YrE1VJsLw/xZ63Bb3h7jM+JMuN7jI03b6/5fv+BnjxvXIWULDniNm9uWw5eL8HGiGqCoLkGpaHrY9LsBOhc0wp3XDN+tjooVU793uo55w7V8oh6XK4VOAN5QksluT222qe8GHWz5Ct4TBbKJMMmADqLNkecG2btrVhetQygDMndi/i1F3rTi5nby6YymSbcT7hQ1cGKwAVev/QXYapg/2PafcH4UzkZJxAK00V0F/iTeIr3bDfbX+0AJcIJky3c7M+IieghIpY63J1loSNWuDTP7OhoOsKAk18+WPZHd/S852FlVN8watYbwyDKNQey/AKU8aZJ/xgk0wNCkfDa/SGHXtKbtfvHhhP+Uo8XW8hBtj4HZ0AHJ/akQpyHTz1fZktNHtDJePQCCwSCfCI4eGzgFewMIOspOGt8sURR7GedJeuRCM TKE43gS7 Oqmob8W5kAh+FwdcpUPk1hlJEXQz3FMX4cyKtGRaYk2K/dxTHtc5Un4f50aASBblnAnppPjOQYl442hfz8EkiK6qFErhzZDA/LN1mKvHX3udupIaavE+YakK05Y64aN0J4tzPENdHnbB7wcETStKPmPR8sed+zxXgnk9hUtjMHEvfnGsnv4IavmQugW8F4w1BoWepItnGBH5g/gxT0WHBYHh5zrQl5xzeXeeWafQBscZu8ReLLMJy40cRpcwMhC/QR1qW7dwPIxihh+XeoU+XPswLkqznybWflUuQOm9o6g6V+9QQxMbFyuIkYNYC8/N7Upq+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Pankaj Raghav Instead of looping with ZERO_PAGE, use a huge zero folio to zero pad the block. Fallback to ZERO_PAGE if mm_get_huge_zero_folio() fails. Suggested-by: Christoph Hellwig Signed-off-by: Pankaj Raghav --- I rebased on top of mm-unstable to get mm_get_huge_zero_folio(). @Christoph is this inline with what you had in mind? fs/iomap/direct-io.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 5f481068de5b..7f584f9ff2c5 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -236,11 +236,18 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, loff_t pos, unsigned len) { struct inode *inode = file_inode(dio->iocb->ki_filp); - struct page *page = ZERO_PAGE(0); + struct folio *zero_page_folio = page_folio(ZERO_PAGE(0)); + struct folio *folio = zero_page_folio; struct bio *bio; WARN_ON_ONCE(len > (BIO_MAX_VECS * PAGE_SIZE)); + if (len > PAGE_SIZE) { + folio = mm_get_huge_zero_folio(current->mm); + if (!folio) + folio = zero_page_folio; + } + bio = iomap_dio_alloc_bio(iter, dio, BIO_MAX_VECS, REQ_OP_WRITE | REQ_SYNC | REQ_IDLE); fscrypt_set_bio_crypt_ctx(bio, inode, pos >> inode->i_blkbits, @@ -251,10 +258,10 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_end_io = iomap_dio_bio_end_io; while (len) { - unsigned int io_len = min_t(unsigned int, len, PAGE_SIZE); + unsigned int size = min(len, folio_size(folio)); - __bio_add_page(bio, page, io_len, 0); - len -= io_len; + bio_add_folio_nofail(bio, folio, size, 0); + len -= size; } iomap_dio_submit_bio(iter, dio, bio, pos); } -- 2.34.1