From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D3DC25B4F for ; Tue, 7 May 2024 13:30:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95C5D6B0088; Tue, 7 May 2024 09:30:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E5506B0089; Tue, 7 May 2024 09:30:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 786A16B008A; Tue, 7 May 2024 09:30:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 586616B0088 for ; Tue, 7 May 2024 09:30:25 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D6B1A1C1B57 for ; Tue, 7 May 2024 13:30:24 +0000 (UTC) X-FDA: 82091683968.10.00D9D2F Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf27.hostedemail.com (Postfix) with ESMTP id D20DF4000A for ; Tue, 7 May 2024 13:30:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715088623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=CFmP3XJ9ED2Np3imw2ozf490ANWpl4on7+nrjpMTWsc=; b=CUE0TEV7B1fIBt4kVSJ7bqdg9mZFkyxEeXAGQZYPIpdIxPERStv9AbUCFvgy5nOmgQIZag fgjF1b9R71ratNrgnelg89AWCaQAk+Hn88S6O54blMXZ1MtgnyzS/ikv+NakhEcSoWbAdJ mqVycGwSGYQjyS1Qt5duFC6rUOQ/qDE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715088623; a=rsa-sha256; cv=none; b=LfEKeHUqi2D/QK+qr3ZDy30JuzbaLJGVl32GySMBJpnrOfAVQjEa0wd5QPhlpr+R547xhH v5zD4VyjFYrJ+dcbTbSsVpV3yCNZgS5ulpw6HQb2fVKjcbbZdumzVginJavLxAcjHATCKz /AUBSj4QEd9JPA5Kbb9TM9hR2B+datM= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VYfJ25KfdzCrNm; Tue, 7 May 2024 21:29:06 +0800 (CST) Received: from dggpeml500023.china.huawei.com (unknown [7.185.36.114]) by mail.maildlp.com (Postfix) with ESMTPS id 6E844180065; Tue, 7 May 2024 21:30:17 +0800 (CST) Received: from hulk-vt.huawei.com (10.67.174.26) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 7 May 2024 21:30:17 +0800 From: Xiu Jianfeng To: , , , , , CC: , , Subject: [PATCH v3 -next] mm: memcg: make alloc_mem_cgroup_per_node_info() return bool Date: Tue, 7 May 2024 13:23:24 +0000 Message-ID: <20240507132324.1158510-1-xiujianfeng@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.174.26] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500023.china.huawei.com (7.185.36.114) X-Rspamd-Queue-Id: D20DF4000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9416cyyiqmyzebu4ud9gc4fihydg35qc X-HE-Tag: 1715088621-668426 X-HE-Meta: U2FsdGVkX187pnea3i01Seyz7H4wrFgiCQeDGyp/9LLGJRw0d5VY5FYX/NBdmh203apc2Cbh+LlHP8NuL4rBex+7hazYybwrriCtMGqWsAnHIFcCdxY+ySfIeHlBzWT5FyrKTY9r35IuTGvmeBFf6BzDPJ2O1rqJSrlzgiLgDSWkb7FcrmhOTOEu66KYsPUKPTcubEXqcW20WQXO3fvBTJ2MOzydI6Pwl9AoypDmXYJiDKIr5/8qqwftX5ilYjtNDiAh+aacKSjtPp/URVCOR6TPPpgJCQhfqomQJtZwo8png0vc+x9tBvuGytyBdZw56fNlqZN7lSSzLR+4tMMT5Mv/LriIJCLqPTuL4Ilcm2+c7XyN/VwkJDCKmZfIZcVY0JQgUVS5TW9cthaqaQqYtP2+WanATQkgrTuYbAKytRGADRtb1ub1BPYOmOF7aAW2ik7U8CEBPFd6xPeZ/cnrLnin0wtPBe+JDo07yPzWsZfFohcemr3WecbdIXY8NCv7VoSZ2OoRZkxh71/80FNMxFppyRMUS+Cl2KPVl+yH+PIjTq6cd2oDJaxb/Htdxd90605pKFJ2kUUPZt2SfOR0c5FTR0WQxo6GtUv1WQu+2Diu+olSexEFJRWTxYSbNO/Yadb27xvpkDdORDDGZC9GPy7DW1W3LluP+j+hCjq8THwhWwaK3gcl1tn+zR9NWKPhCibjsRaFR54RbIhAW2mue17PQJ2a7LAB+DcjvO1OVkabGnakAsI2MVbfFc4Ztua7u3QstI5PRbn5eit3t3hC8ZM4UH6JCZ5vJA8lzzGBI7LG7LKONE0ksv8cgZ8jkpQA72/KJBtqvjyeX02/1cd7tceZTF6rpAI3UZoOEqCc5OwRDMtFmsC6mK/ZJEy753uodw+GEitEQG38XOFi7MpyRbfioWvWy618S5ZOLHl8uZ0hIlZvQ2DNRTzfxvblvRxclbZ4UDkp7b6GwRDZiVV shUn7zvd fBj9WlHEQaIjp7CkHNZiZo47jMnh4Ra+O5lvfNkOi90XUNKVYyoVWVKJhGo/9WsP9ZCha/JX4nigTZokdoYpObM08tw3bjSJuYSoJ0oL+Dss6BocYqnY1dgC3eK4LyaNuZHiUXKPsvVVVJpVJpeQLZGQ4Ce46Nt3Nh2C/2z3a0/S5RG/VpELeH4WsnGExDgwLbKBzpDaJoshKVWTNZrl3bGeY3Tr8M1yxOiTuD16n99dsQ/QrpT9UoN916g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: alloc_mem_cgroup_per_node_info() returns int that doesn't map to any errno error code. The only existing caller doesn't really need an error code so change the the function to return bool (true on success) because this is slightly less confusing and more consistent with the other code. Signed-off-by: Xiu Jianfeng Acked-by: Michal Hocko --- mm/memcontrol.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index feb6651ee1e8..5d4da23264fa 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5642,13 +5642,13 @@ struct mem_cgroup *mem_cgroup_get_from_ino(unsigned long ino) } #endif -static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) +static bool alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) { struct mem_cgroup_per_node *pn; pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, node); if (!pn) - return 1; + return false; pn->lruvec_stats = kzalloc_node(sizeof(struct lruvec_stats), GFP_KERNEL_ACCOUNT, node); @@ -5664,11 +5664,11 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) pn->memcg = memcg; memcg->nodeinfo[node] = pn; - return 0; + return true; fail: kfree(pn->lruvec_stats); kfree(pn); - return 1; + return false; } static void free_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) @@ -5741,7 +5741,7 @@ static struct mem_cgroup *mem_cgroup_alloc(struct mem_cgroup *parent) } for_each_node(node) - if (alloc_mem_cgroup_per_node_info(memcg, node)) + if (!alloc_mem_cgroup_per_node_info(memcg, node)) goto fail; if (memcg_wb_domain_init(memcg, GFP_KERNEL)) -- 2.34.1