From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E697BC10F1A for ; Tue, 7 May 2024 08:16:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B6B76B0099; Tue, 7 May 2024 04:16:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73F416B009A; Tue, 7 May 2024 04:16:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E0EA6B009B; Tue, 7 May 2024 04:16:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3E4FB6B0099 for ; Tue, 7 May 2024 04:16:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DA07680C73 for ; Tue, 7 May 2024 08:16:52 +0000 (UTC) X-FDA: 82090893864.20.F9BA902 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf07.hostedemail.com (Postfix) with ESMTP id DB6024000D for ; Tue, 7 May 2024 08:16:50 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Rp/1VYEK"; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715069811; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=maPe74un1UQbFXNUNtNwtmyr5vBb7tDiWAcBESvmSQ4=; b=cV3dvegvA8dYjQ/ENOPSWJp9BfJKJOWIsxQfft8ZRKyuYajfbI8lkcMyCM55vG3eOORbtF QnAWan0gPJTrkgSF86fr6FRnpEWdZ1TjvmPTCUdIN4wzHR+fg1anBtClQi46+S+2+9HAzb mSY/TpbK2RxYn7d5QQ/+vzl7EkOpAQI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Rp/1VYEK"; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715069811; a=rsa-sha256; cv=none; b=Bv0IUdmBM3LRQkEffbd4WawC8XT16CF/YPQjyOsC1qqrVJW3xP8aCxEkciBGw3TvDGQ/fW 41Ck4ZDTXootUc3M6bIN/vgACq0cbgNAJGjePhQjUUzVccL57K1m8tBitwK85AAgn4ZYXw tt8JEqkvwajNNvRefHm8WfXwEdShT+c= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-573137ba8d7so720860a12.0 for ; Tue, 07 May 2024 01:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715069809; x=1715674609; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=maPe74un1UQbFXNUNtNwtmyr5vBb7tDiWAcBESvmSQ4=; b=Rp/1VYEK6pjUqnXEyUEpHdcYhlC9LhcmWZ+cDWbBVu/2bygO8njrxCqfSrueaLXtMt 8Q8HIJZEQed1C77XQMk921vLTcQ49VbbyddiUxf6aYQaPuQN+eb+VFWZqly9b7I6oJBX yYpuWNhypkFSqyg+CEo3Nu3aKigbgi/Xqgr4RI7ltevqmXvohoEDBfS8Eab/fJ/8pu8U TMfZlfztkNRestyNnlw3b1+oqEYqfgXLkI3ifZRfU4FD1zucExRgsrWJqiZGGxWkHh8+ Y995DfWi1ElLlfI1ssTvSLBkrDIi/80YVtJOA4jhVqPb0sGV3oy6Ou496fi2AtTkYdRr VdYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715069809; x=1715674609; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=maPe74un1UQbFXNUNtNwtmyr5vBb7tDiWAcBESvmSQ4=; b=cZgDb4T+rqieWJtNklZgmZoJoxniiyRznCgRueG6LHImMj+g9bb7JiM5OsGmqa19/9 JaE8lqnaoWg1HZl/QjI/cN/PR91i4Us6BQLw98t4SmD0gwN87SATDj8B67X4zKWj6+Xf MPDJ7wliDtoSXVkcd+yWEdmJ9QWBesYoiFpPXOL9IyqY6Br+WBPbs6ekCO5vAcbW9rf4 8a1H9BKjwbQAZpngKZk0pacmzsZlBzKGsVdSshw+lKdGKGYA4w8avbuzKPW4PI8JlPLy 8myEyZQqIF5ueGtb3hPINmFgnKCNmZN/+K+c6NkYV52sHJNn8ovJTyFO+rb+u8JDojuy rEuQ== X-Forwarded-Encrypted: i=1; AJvYcCU7IrOqHkonsWaiPcXJW97ziatpUiDWAjNfv/VV/lGaUnQaGbPhNYuJLSfm2l0AxjH7mu/+60eJr+N28kaH48D8WMw= X-Gm-Message-State: AOJu0Yz2IdCu7rYeu+BncXej+qYyAWeKagIWFtxM4yXWRXz3/8sR39tr ugntlRKfWOkXt3bLwPDA5PeYisw4CayP3RGDNAMLSIwyPV/0bgXg X-Google-Smtp-Source: AGHT+IGguKbFCboPibTCI7Xs36D/0JStkhieejoqZsvCp1T4ZXAkr3vT0GKhxI2ErSNLSH3s+TcQWw== X-Received: by 2002:a17:906:2c49:b0:a55:b67c:bd04 with SMTP id a640c23a62f3a-a59e4cbc8femr160702266b.4.1715069809147; Tue, 07 May 2024 01:16:49 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id dx3-20020a170906a84300b00a58e8d08b40sm6062079ejb.21.2024.05.07.01.16.48 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2024 01:16:48 -0700 (PDT) Date: Tue, 7 May 2024 08:16:47 +0000 From: Wei Yang To: Anshuman Khandual Cc: Wei Yang , arnd@arndb.de, rppt@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/memblock: discard .text/.data if CONFIG_ARCH_KEEP_MEMBLOCK not set Message-ID: <20240507081647.2x2l7fwjnyiud6ee@master> Reply-To: Wei Yang References: <20240506012104.10864-1-richard.weiyang@gmail.com> <5f9e5d19-8a38-4e98-8cbb-e5501c76f740@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f9e5d19-8a38-4e98-8cbb-e5501c76f740@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: j6y9oubxkdp5ts44p11aew7ujmoj6dw9 X-Rspamd-Queue-Id: DB6024000D X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1715069810-251849 X-HE-Meta: U2FsdGVkX18q5b6IYZts76+1gG+kTFzD2gY0DWMHBVk7+yB9+jlRsnSPi5UkYCJX3bqtkTY+P9slShbAxbrL254AIYYUdIED1l6jOjKwRF3p7a7tq/jtm/1qSW5AXxsxFCEDkkT+RwGJI3kLA++bZ73hvlZTKxzrxtCJRKahwaevqMcgccdjvanRq6ueG3vZwyuNo4VGVD+gpEGepQcqlBGOQ5cgBLQ+fhoyID7o0JfAh25JOzRgIdmiMG+YY67SOlj6TJLnj24ZQZU4nXNBtKIXdF8/8AGXtKr2QP02p3WcbnnIoTvnJtPtwbNye0f3NS5xzoEZJp+nzu2DfWUrtmJxR/H8+JD4FoxGtZcttJ7Aw4QmHO0h7IBQZhvIW8oMrO6YLX0niAie9bdLyM/u++Cw9FYjckF1Vpv6epoPpuUJur4VRPWgH9XeD+RE8p38+QOK1vT4hx4TVSi4sEV6OzJa+iuv7CIO+x+YVjHyKyz4PIUxrOIfn+EAOtkG4uTKUS36k5YPeTFg06ZJfD2uIPENacDfzhN31JOnESyCECfFyOYvqqhjuC8a+SH8rnynLIqrJaw41Q86cHErG4BcE3xKbehhE73kv5IzHj7uTsm7/yRXxx2B/LzYDRCMYWgaLR7rO1+o+/1WmoOtpREo3mvtq+4Y/C6HMdbzI/tRXibmOkLR03TzzCQKb+f48lhHAbiorxDzahdtROF/kDXSSKhBcHNtw7OXRnm3lq6Warnss/C8aWvKkfiqt/AODKwCgfAXtCQFOg5drVICC85IfXcRm9vqP8hxPcYkPJbXWedeQR11VX/K17ZJK0E84GAmJM8ZTvQq9dR065o0+KtqPizY7tahwxjqWjLr4Rq8LP8KDd+/hEmHlAcCrMCO7D+A5tJAv9/o3y5qR9g/F49GOX4rh/wC6ePy0Q20SfbhBDY+/lX0B7tBqDqhV5c/laHFvM+d0bS3qXdmiEoKIRk L77koTg2 HMThTQGxTHfHDXb34V4ZcUsNZFoksFuMO5qFY/8wQt9GhopnjLV0iciLu/owL3aCOUfiLa9c7GRkoz6w9tA15SslKcds8IenekQFcjxRTwXnNBnwJ235QNIZzCGDKKEJ9i+ycCrYNykehzB0ZArAvvkJBva6Cf6nVFaIXj+4HyqTW8U6Ac2+TcXF1ZLBYUu6RlHvGfCUe8G0Qu6H+0Cv4/r6C50jeR06vxnbvZOi6ThUv6ugpBZ9dSDciv/6qoBNO6lahGNu/iUb/eMndtVsZiwjckH80SW7nZ0ZDSz2cSHGjHeu05wCkfuTehI7hzR4/WNQcB828OKf5P82yQe4paQIt7/ZTQdt46cbtKnYVyW+nzopVBO6r4OzLg1lZQfI5dCE7WfDHbuiQxa9BDT7i6RxI5BLi08P2w+28zURig84AByLCHHGp+Mh7s8uynMfNMH4cnGjJxNJsYkuFdi/CnqZb1xvlfS47i22S/TyCf48RqcPGl6fH85qpIk2pU7KCYFKfCNqVMJlYG2tG+rEXowtEiasr8wMgf9UP6c9lLSlGjLKF6JjkQOtVych6kAVgE1mDg2fBhGT4oLpwIBB8VZBVvm3JpiparWd8i7OzpDkioag0fyp3Ptnauwg7oFTHdQQMWuTzEE8mTrh8AqyoJEWUmuyKtM3ZwwMYAE2h4CmVy+oNzqbu1DVg6wHL20jdTTDs0FzqYjgmrPOhJUgQgStneAL1Fn941cptY8JiIGAIP0aeuT8YvYk+nLBDOqOrDQCm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 06, 2024 at 03:30:54PM +0530, Anshuman Khandual wrote: > >On 5/6/24 06:51, Wei Yang wrote: >> When CONFIG_ARCH_KEEP_MEMBLOCK not set, we expect to discard related >> code and data. But it doesn't until CONFIG_MEMORY_HOTPLUG not set >> neither. > >When CONFIG_ARCH_KEEP_MEMBLOCK is not set memblock information both for >normal and reserved memory get freed up but should the memblock related >code and data also be freed up as well ? Then I would also believe such If not freed, those functions would access unpredictable area. >memory saving will be very minimal given CONFIG_ARCH_KEEP_MEMBLOCK code >is too limited scoped in the tree. Not very much, it shows 12K more in it. > >Also could you please explain how it is related to CONFIG_MEMORY_HOTPLUG >config being set or not. > This is in file include/asm-generic/vmlinux.lds.h. MEM_KEEP/MEM_DISCARD is conditionally defined by CONFIG_MEMORY_HOTPLUG. So even __init_memblock is defined as __meminit when CONFIG_ARCH_KEEP_MEMBLOCK not set, it is not discarded. >> >> This patch puts memblock's .text/.data into its own section, so that it >> only depends on CONFIG_ARCH_KEEP_MEMBLOCK to discard related code and >> data. After this, init size increase from 2420K to 2432K. > >Is not this memory size saving some what insignificant to warrant a code >change ? Also is this problem applicable only to CONFIG_ARCH_KEEP_MEMBLOCK Yes, this is not significant. >config. Could you also provide details on how did you measure these numbers ? > Kernel print related info in mem_init_print_info(). One of is it init size, which includes init_data and init_text. >> >> Signed-off-by: Wei Yang >> --- >> include/asm-generic/vmlinux.lds.h | 14 +++++++++++++- >> include/linux/memblock.h | 8 ++++---- >> 2 files changed, 17 insertions(+), 5 deletions(-) >> >> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h >> index f7749d0f2562..775c5eedb9e6 100644 >> --- a/include/asm-generic/vmlinux.lds.h >> +++ b/include/asm-generic/vmlinux.lds.h >> @@ -147,6 +147,14 @@ >> #define MEM_DISCARD(sec) *(.mem##sec) >> #endif >> >> +#if defined(CONFIG_ARCH_KEEP_MEMBLOCK) >> +#define MEMBLOCK_KEEP(sec) *(.mb##sec) >> +#define MEMBLOCK_DISCARD(sec) >> +#else >> +#define MEMBLOCK_KEEP(sec) >> +#define MEMBLOCK_DISCARD(sec) *(.mb##sec) >> +#endif >> + >> #ifndef CONFIG_HAVE_DYNAMIC_FTRACE_NO_PATCHABLE >> #define KEEP_PATCHABLE KEEP(*(__patchable_function_entries)) >> #define PATCHABLE_DISCARDS >> @@ -356,6 +364,7 @@ >> *(.ref.data) \ >> *(.data..shared_aligned) /* percpu related */ \ >> MEM_KEEP(init.data*) \ >> + MEMBLOCK_KEEP(init.data*) \ >> *(.data.unlikely) \ >> __start_once = .; \ >> *(.data.once) \ >> @@ -573,6 +582,7 @@ >> *(.ref.text) \ >> *(.text.asan.* .text.tsan.*) \ >> MEM_KEEP(init.text*) \ >> + MEMBLOCK_KEEP(init.text*) \ >> >> >> /* sched.text is aling to function alignment to secure we have same >> @@ -680,6 +690,7 @@ >> KEEP(*(SORT(___kentry+*))) \ >> *(.init.data .init.data.*) \ >> MEM_DISCARD(init.data*) \ >> + MEMBLOCK_DISCARD(init.data*) \ >> KERNEL_CTORS() \ >> MCOUNT_REC() \ >> *(.init.rodata .init.rodata.*) \ >> @@ -706,7 +717,8 @@ >> #define INIT_TEXT \ >> *(.init.text .init.text.*) \ >> *(.text.startup) \ >> - MEM_DISCARD(init.text*) >> + MEM_DISCARD(init.text*) \ >> + MEMBLOCK_DISCARD(init.text*) >> >> #define EXIT_DATA \ >> *(.exit.data .exit.data.*) \ >> diff --git a/include/linux/memblock.h b/include/linux/memblock.h >> index e2082240586d..3e1f1d42dde7 100644 >> --- a/include/linux/memblock.h >> +++ b/include/linux/memblock.h >> @@ -100,13 +100,13 @@ struct memblock { >> >> extern struct memblock memblock; >> >> +#define __init_memblock __section(".mbinit.text") __cold notrace \ >> + __latent_entropy >> +#define __initdata_memblock __section(".mbinit.data") >> + >> #ifndef CONFIG_ARCH_KEEP_MEMBLOCK >> -#define __init_memblock __meminit >> -#define __initdata_memblock __meminitdata >> void memblock_discard(void); >> #else >> -#define __init_memblock >> -#define __initdata_memblock >> static inline void memblock_discard(void) {} >> #endif >> -- Wei Yang Help you, Help me