From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB13C10F16 for ; Mon, 6 May 2024 10:56:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B9A66B0085; Mon, 6 May 2024 06:56:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06A786B0087; Mon, 6 May 2024 06:56:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E73546B0088; Mon, 6 May 2024 06:56:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CA1266B0085 for ; Mon, 6 May 2024 06:56:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7AE2BA092D for ; Mon, 6 May 2024 10:56:03 +0000 (UTC) X-FDA: 82087666206.07.28097E0 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf26.hostedemail.com (Postfix) with ESMTP id 9AEFE14000A for ; Mon, 6 May 2024 10:56:01 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="YAlrSW/+"; spf=pass (imf26.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714992961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tbdkD91gK+weY24QVpNlpFJ35CtXEhcF4iFO2J9YLew=; b=Dw8pbYvnfqAblVrKMPOpu7GDwsLy5lYmUaDU7FMjLEigqj6XcBQmvnOsXlUvIGtnZaYTRM jL/N+R9JP0RkqilR6MoFV4gZMr/YTyH32Ah9Sj39+ek11dBxxPIBJrGeNqEfCld1JAryLx BiO2af8/ajqIOcIGOV4gl6fMM3eBJ7o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714992961; a=rsa-sha256; cv=none; b=W7j3axwhZutv0pnzmONk9zOb2EN75Pggait8+WXkoZ3wT4vuXReulDnenS1uPGOhb06Jgs Oeas8IykBtjta4ThBHE7om/Sc3HC9ExklwVieeBDb9xeTzRRvFw2rlhx2KokSyL8Z8Etu4 JUZzVRM+kSNC6cdXuvsIUCcStsm2Aks= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="YAlrSW/+"; spf=pass (imf26.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-23fb9c871c8so218449fac.1 for ; Mon, 06 May 2024 03:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714992960; x=1715597760; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tbdkD91gK+weY24QVpNlpFJ35CtXEhcF4iFO2J9YLew=; b=YAlrSW/+3C0Vs4mXMUGT9WJt2WRBJ52AMaYA8ju97vxVW/AbdPaBlPDsLxUVeeAYeZ Lz3CXiMlxEsv8i9QSxrQyjwAR7c5iCWzPQTxhhOkXve47patR19NyntRvLPMGTTQJLnl wyZIZHfWy6r1xFXLQAxlba9J2crcYN1OTCd5AmK0tEN6HrB5JALcGHvkj4ptbM8Bn36s ceRqnkatGWZX2QBm1ii6iGCScdqrHFxExMru2rCKRyLCAxybEnHgFdOyuuLdkAYpsKzg nwn6opl5yHnCpPTR6DeijkWAffyXwVIGt2Ncb95OLP2EM3qtwKKUmss+rbfp40LUv/u3 gSYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714992960; x=1715597760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tbdkD91gK+weY24QVpNlpFJ35CtXEhcF4iFO2J9YLew=; b=jaIiUjj8Rzuc/V6on4ehBAw7Ry496Qt0aMX2hi615qdMQByVT5DqJ5bvrG9/kk4hZT Or5+DceWdp6H7jmcPKUGiE2dri/vqXuTapJN8xN6eQH5SsGxVoTXXIvtQb/b2CWEJjT0 rALlKob8Q5oPkPBaU2I4aqXqkllkklP0jCX+lcEBAzlKPyScvGNS/bFkt/Zb2mSEZtMt Mg1mzTiEqSerDjvoGut8cLPE+sHDGPyf06upiTCDQmCRRaSaSLPJsX86NXehXtzsCiNG CA8tM+zUsm35osOBUZZqTpgNwCE5QQ3Gg3UYJvVxojOp+P2pj7dSEB48iMe7OuVLAyv6 uUlA== X-Forwarded-Encrypted: i=1; AJvYcCUmOXCAou21/EvbhouKLat8kkzjUTuex/PX+6tut6itXlfK913zVB+QzrjeqQSV1RyZ6zrYvs6bwez23aJ5a+Wfcho= X-Gm-Message-State: AOJu0Yxk82icvPA5to+RZCKuFAcEyKZcWM2APO3A+f7uwAG8tIus7yf2 0faTXN9ykyDXJzX4Wx7elafoFeo8fMJ/wA4CrW/UoCli3wpU+5FD X-Google-Smtp-Source: AGHT+IEAu9yQJXE0rK0WU9nlJugQ/eAbbALbUAv4nS2sFTIVfnfrEXaYEzIA5cWSngvleqfiSt3NwA== X-Received: by 2002:a05:6870:a10c:b0:239:4a86:bbcd with SMTP id m12-20020a056870a10c00b002394a86bbcdmr12396045oae.3.1714992960430; Mon, 06 May 2024 03:56:00 -0700 (PDT) Received: from LancedeMBP.lan ([112.10.225.242]) by smtp.gmail.com with ESMTPSA id ge1-20020a056a00838100b006f46eb9d7ffsm2666490pfb.97.2024.05.06.03.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 03:55:59 -0700 (PDT) From: Lance Yang To: baolin.wang@linux.alibaba.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com, hughd@google.com, ioworker0@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, shy828301@gmail.com, wangkefeng.wang@huawei.com, willy@infradead.org, ying.huang@intel.com, ziy@nvidia.com Subject: Re: [PATCH 0/8] add mTHP support for anonymous shmem Date: Mon, 6 May 2024 18:54:47 +0800 Message-Id: <20240506105447.1171-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 5kbgfpg5bnf4zik7838gtjznek1rag7r X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9AEFE14000A X-HE-Tag: 1714992961-450415 X-HE-Meta: U2FsdGVkX18FGSWVpbzfM4wyvT91B4CSzJYHt4yuXu4O2Z4EUz+CdG4jUby2Xpyn5OV9erqPDNJpEI9isoFYS18zn5NWOmAqXSrKr8/DALsdV4iIEHJpDbbIOPRCAG1Em6kosA31vM/Fe7NNoy++/DPwvk38oyng4dxrzoOUkszVytmYJmD4we+NJfMjzw/CqoI3igjstYF67e2o6iWkd7SNoJMoKsgrKFyIWldUpaWRIgGmQwlztKNJSc+1uEXf0YYX6I5QvXM0ZY7brBXXldvw+eQPZ1oMa6zFqfuxoMFx92KHyy4lLIBKJQgd2fKRxHqsLBwQKU9JBuGIaUJQeXOAW5i90qDgq8tI6XMty/RlFfXajeq98RySJ13Z0Tm7weAifPnULuslt2/wBvXFOSmmX3jBrl3YJ5KGNh5Ni24zCbV01yWVTnDqBsNNkEzEAsitbnbSSZLFiteKAhIWCEEq4Trgh/3AtsUsVB/lik/BzEtq2AAAEBADwdHCCfh8oGn2PjybbY8JgXhRjSjz90lIqj6SPmjCrpyViMPfnyi/usJXYdAP04aHg0oYaTajcgqU8nnlzEc64tzJqjUnE1Mc1mgGoY4A6OptLdilYDkVyOdx0oIKzjVIoeAzNIwBgjtEjynbtFLUQMMuMvvnYZAFbYA6LIgtAiVQcH7KDRRJGZb7T+BD9SbKHOUz7IgWo/AjTkAkAars+BAuFhKen/z88TMZXPfEW/YU/cYAysNAdnViOknc0E3J8kxkjyDRELFgkEoMgFLdsJfFIjRim1tOzJCfAdEcoXJrk34APTGCIbIfwlYMzwXmYpMQhdD5RCRrQPzoX0+ip5WpJGlDCOzgJmLXVE7x+20CSnQY+xWpInREmaOuka+M7S9sQlL7G5f3ZeDBtrFJ0OgQDlxbDo50dAnI94Mqm5YeYwMt1/bFGJS04X4+2dTB6eNt17wDWysMxWOMufzx1WE2qXc PvOPogn4 utLVjRubAtRG1SrHkA2ZsFbxW0E2KkMmMhuf9iNnauG1VVDvYYBTcDM55X8GW8SqA26SD2wad4B0arJPCMtAFvgNviP9cYT3Yds51J1OYkY2WH0hVo1oRrBt/xew1mGqZTzs17oOn6fXeiTb7I+dxTPgZSgvDjQcxwT972yCUigyqP44EjYmGFxAKzS0P258/W8MNyfBOqY5p5CiXFvXxWl/0mt4pvZhlmCyrdA+nlyOrmkvW9UtUHih5hFp5KUFGQkR3FpaDTaWNBnUVZveCY7P3VsQ8VTojb2KuruPGMy75/mFK7n1W56rSD6qwOFcjlUoEXEJmL4IfW7rMACDIMU+WvURtF96Tpn+689DisaxoBjnkubselrTTsBqUHO6+pYgEOpRRqEz7uXz9D0fQqzN025TtajmPLrBdV6tgEW9X+1Ey4je6IA2+Q4RXl3c3L8QmP4h/++qxKlQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.090961, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Baolin, I found a compilation issue that failed one[1] of my configurations after applying this series. The error message is as follows: mm/shmem.c: In function ‘shmem_get_unmapped_area’: ././include/linux/compiler_types.h:460:45: error: call to ‘__compiletime_assert_481’ declared with attribute error: BUILD_BUG failed _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ ././include/linux/compiler_types.h:441:25: note: in definition of macro ‘__compiletime_assert’ prefix ## suffix(); \ ^~~~~~ ././include/linux/compiler_types.h:460:9: note: in expansion of macro ‘_compiletime_assert’ _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^~~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:59:21: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") ^~~~~~~~~~~~~~~~ ./include/linux/huge_mm.h:97:28: note: in expansion of macro ‘BUILD_BUG’ #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) ^~~~~~~~~ ./include/linux/huge_mm.h:104:35: note: in expansion of macro ‘HPAGE_PMD_SHIFT’ #define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT) ^~~~~~~~~~~~~~~ mm/shmem.c:2419:36: note: in expansion of macro ‘HPAGE_PMD_SIZE’ unsigned long hpage_size = HPAGE_PMD_SIZE; ^~~~~~~~~~~~~~~ It seems like we need to handle the case where CONFIG_PGTABLE_HAS_HUGE_LEAVES is undefined. [1] export ARCH=arm64 && make allnoconfig && make olddefconfig && make -j$(nproc) Thanks, Lance