From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A058C10F16 for ; Mon, 6 May 2024 10:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAACA6B0082; Mon, 6 May 2024 06:31:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5ACC6B0083; Mon, 6 May 2024 06:31:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C22366B0085; Mon, 6 May 2024 06:31:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A428A6B0082 for ; Mon, 6 May 2024 06:31:09 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4E8E7A0929 for ; Mon, 6 May 2024 10:31:09 +0000 (UTC) X-FDA: 82087603458.06.3DCBA12 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf03.hostedemail.com (Postfix) with ESMTP id 144E820007 for ; Mon, 6 May 2024 10:31:05 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=lKsTAn5S; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf03.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714991466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=snaM6UDtGtGvqvIKA47vd3NtbUZwsnUs8N0zwMuvcFA=; b=etRzVO3d7ILb8wrxDPNYVYR+0AcOIrsXNU2E0T9RCHM8MuPyJpDeiDlkysYCnWX68eTkV7 oUNpvUi24ojwQdVLaY1+gPAvIKFRHebUGVwn8k1RI8xjL2bLzMqrArwWCpaUcco11W4hJK Y1u6ryXZ6S8j7btitEA2O3f+P0DAfw0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=lKsTAn5S; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf03.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714991466; a=rsa-sha256; cv=none; b=0Flu8WNBiLaXED7SIAIMVe4ST2yNAKO4k1zRe04YJguurJNWkgULc6om8pmPh5sFnyfPP7 FZduLasCdcU6AzTDJhlxh2ahfKRcnJ5PREBPK4SzKNEUR39CEmFoYaNZZIpYny47Syb0o0 I3yNShFN9EFvTjCut9O6xDXpGv6O1ys= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 0982D40E0249; Mon, 6 May 2024 10:31:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id h5q6KkWXILDw; Mon, 6 May 2024 10:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1714991458; bh=snaM6UDtGtGvqvIKA47vd3NtbUZwsnUs8N0zwMuvcFA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lKsTAn5SKefD7WI+yRaq08YbIV+1ksjAPMz31FhFS97vvzMBXS/MUSbHPDQGOYxLI LJ+2OMimc4sy7QTSfhIKBn0lNu9SFSNJ0f2bSIyn8ScGMYCWGKusTnKexdk2MMJTIt Td7g2RmjqRAzSg/14n7zvDh/7WPw+Pgl6mMkHrCN/7p3nPXfN362Zj+h/bVsDdAlcz ezOsWx2t9UtC9h7lgES4p4LocFcTBtdUbSxOYmI5lfA6EwRTnMGcFES98RUed0wyxu Otf0mlBhKW65Xpf/mwJIS1Xl5zvq0WRGi/RAp7K/1YNp9BgwL+L5+mMle/M9rhV+uL j7xDXYq40aZP7/6OQ5zvn/4MgUKsGANoDTbNGXykt44NIkBmHm1Ek5fYwAG/NU6gpx LMGnd4GJhR0A2GnGOpsbNv41F7rPhN0NxKPM26Gmi5SA4e8eUqG4RA7hk+l7OiL3lc Ri6RS9Qylcb+gjR2m2RCV0wQqAmzLI4x1gSQQnL8SkhEYw1/K84kQWIaOouSMlptjy D5u+2PUKgvBSw7AxIDd5/wJVPsOEO4VZfWJtr0n1qSQh+6NoGe/lOOlkmfaEfEZCIF KfH5qVWUPM9aBMqf1Iv0fsKrvWJVp6tdASX5j2j31OB0nQ+89XRIyz77YkEtqAKej+ /lR1VU/27KvCKxnUssgLwkDA= Received: from zn.tnic (pd953020b.dip0.t-ipconnect.de [217.83.2.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8B77840E0187; Mon, 6 May 2024 10:30:15 +0000 (UTC) Date: Mon, 6 May 2024 12:30:14 +0200 From: Borislav Petkov To: Shiju Jose Cc: "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , Jonathan Cameron , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "tony.luck@intel.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "mike.malvestuto@intel.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: Re: [RFC PATCH v8 01/10] ras: scrub: Add scrub subsystem Message-ID: <20240506103014.GHZjixNhhFkgkMhDg_@fat_crate.local> References: <20240419164720.1765-1-shiju.jose@huawei.com> <20240419164720.1765-2-shiju.jose@huawei.com> <20240425101542.GAZiotThrq7bOE9Ieb@fat_crate.local> <63fdbe26b51f4b7c859bfb30287c8673@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <63fdbe26b51f4b7c859bfb30287c8673@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 144E820007 X-Stat-Signature: wwn1rrkghezfgqukkp3du5b9ih8dkb7d X-HE-Tag: 1714991465-542035 X-HE-Meta: U2FsdGVkX1/X5PE0GQQEOSkIx96jKV8wcXWnEtQuvOqWUz/sODYFTtjB9a2gX+q75PK0X2OqdwN6qV/ydusTZM827zzRHyCGHoNS7BfKaxazg47FNTHXzM+Ws4s4RP3WJHwAuKrA4GeqWtags+0+yD1GgGpb0/a7b/q/4mL9V66jsGkvJbe8VHfTLPzpCnel5ED3RNUz6ih1+B2NZ3RBh8+XirtgEtPO0s18s43jL3nHuPkbUGOrbCN6C5yalvKCYMOuIeO3VneyIZ+0WkAVWSrRVKEM6grImkzB4Dx3z5Rvcm3k2tuBfixY/ghXhaRrNZmW73rlDvt7ITyzRQpS4PHOBQJpO29dj51S/34kLHm+8QbufLkmtJzfOCFqopAykRI0lgDeIY6mQ1Nwcfq21Bg9U7LkCkg7Wfi3Rp2DZhEs182RkevUrCsDDiTNxpMggZ2JSv4O9pH3jy3guWObHd66Ul3mVstmeKeSWjaZKeSiYe+ngo/QWYHBjdCcBpIuymkCWX26zZe3jkHZJcn0YRjMbwDztYJXpZ3Ix5JE1XCjxYtskFqh6iuPOFtjjSMIoMjanRtWgxrZyTMCODXHhD/qkQ+I23VWLu9V2oDcB6fXS6WZHORwOErK/IBLR6fimzKbR3y6x5OuwQJa1n2ItE5yVMMh8Q6y7LDvtjcVE4QiWtnnfjte+4R8Kc57uT04jhEN43fRhAWKMimTSD/i6HiqBynEpm9iYWisJet1GQ0nNM75hDJEHY1VDxO1Jd5/eRRlfYh0B8eIKQ29avVr9ovNJn9qyOjDwwwAQJHO3T8w8j/lHLkd1eLScOh1DflA3rEkDk7Pj/ajEVYpxAu0kG9ls+Wj6EnULJLOc6VhKuuap/Xr0h+jAg7uP4nq8ainVZeiSuHKDsQTFyCw3eFsmceUJppbMgRajb3Sf/x+VMU/J/bfdt/6sI1nP8aVjcOinlSNMF3qbFZlaWZrHVn CbBsO09D GZeiyg5D1w/Dezj7fZeA9yMJs1FWCNDzfcy/oQ9L7QQ1JvaP7Ps+VjV+UmwG3G/VGfe8mB4943cPOpbUr5cslg4Zo3s8h/MPdZSHrIugJk6QjR61VczL+Au5Hs6gevmnI7DYv5crgBszpHDUPDLgl0xuozC10/al3ExVr6UaArEoaqsCA/NHxheXpPp5IcFeWizkLhGzZTnElDSV2mvSVJJcG+aaqfTTkwVJ9KkwSIqUIyLuaLfyiDLoQDaIlzaYja9e2KAwDXRcGUbNJxBk7lmmf5zl6PajOVAfh6uZvZ2zQwcQUcmz5Q0uUDbQiu9lZC7goGjFrcqlOXMTPSzD1DMBjzKL4fHaJiew5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 06:11:13PM +0000, Shiju Jose wrote: > It is expected to have multiple RAS-specific functionalities other > than scrubbing in long run. Most of the classes in the kernel found > as /sys/class//X/ > > If not, however /sys/class/ras/X/ is more > suitable because there are multiple device instances such as cxl > devices with scrub control feature. For example, > /sys/class/ras/cxlX/scrub Make it as user-friendly as possible. cxlX is not as user-friendly as /sys/class/ras/cxl/ / and so on. Yes, you can introduce a special category .../ras/cxl/ if there are multiple cxl devices which have RAS functionality on them. > Presently underlying hw driver does the check. I think this will > become more complex if does in the common rate_store() if we have to > check against either a list of possible rates or min and max rates. Ok. > >> +DEVICE_ATTR_RW(enable_background); > >> +DEVICE_ATTR_RO(name); > >> +DEVICE_ATTR_RW(rate); > >> +DEVICE_ATTR_RO(rate_available); > > > >static Forgot one. > This is the ras instance id (X) used for scrub control feature, /sys/class/ras/rasX/scrub/ Yeah, as discussed above. > >> +static int __init memory_scrub_control_init(void) { > >> + return class_register(&scrub_class); } > >> +subsys_initcall(memory_scrub_control_init); > > > >You can't just blindly register this thing without checking whether there are even > >any hw scrubber devices on the system. > > I think it happens only when a dependent module as autoloaded based > on a scrub device existing with exception of memory scrub control > built in and who would build this in? You think or you know? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette