From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59934C25B4F for ; Mon, 6 May 2024 17:09:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD7CE6B0092; Mon, 6 May 2024 13:09:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C10116B0093; Mon, 6 May 2024 13:09:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A89856B0096; Mon, 6 May 2024 13:09:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 829596B0092 for ; Mon, 6 May 2024 13:09:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 24FFFA0B02 for ; Mon, 6 May 2024 17:09:54 +0000 (UTC) X-FDA: 82088608308.09.1A77112 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf28.hostedemail.com (Postfix) with ESMTP id 0F597C0013 for ; Mon, 6 May 2024 17:09:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=T6XMn8Kp; spf=pass (imf28.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715015392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mdReYnfYpXbw8UTYqzLrE/VJPRPi8vsKw/zSYHi1u0E=; b=5msmYA1Y6nwB4rrIt1WDeifNiTX5ZPrOcYk8A9+olIDQMahkiUWy8p6Gdilv+n6uL8MOKJ H9UUmMX1q/MGDOdAxuRjBJ0lY+U9nXH5IvzDTVry8VxLv09JxKyxUPwlD6t+QkK7OCQQQR M+VPvViiiAsA+OxuLjNUfEQaLGl5yv0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715015392; a=rsa-sha256; cv=none; b=L6i0H+kFhy4xHMOGOjO4mxpzt3XB6XdrFO8vpL/7nNeZZLDnSAnsT6uXmmHazMz+kNOOfe EX75OHj0SpTSKQyXECvprUoe+Q0Xb/UFMtkaneW8bUWd4e1IeYQff8Uv+R5tkiXWko5y2D vCpBr0AMMejHnKzM+wIpKOzQDxiOCdE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=T6XMn8Kp; spf=pass (imf28.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5d3907ff128so1748407a12.3 for ; Mon, 06 May 2024 10:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715015391; x=1715620191; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mdReYnfYpXbw8UTYqzLrE/VJPRPi8vsKw/zSYHi1u0E=; b=T6XMn8KpdHpUP6+z6mTUmgT5IHSJ+lpqfJCRW9IYUBETW34M2A+m66hOkvvkVic9lp y8C/rP6oFBNOa1EFU+B1Oc/cK+Tv87LjEKaXD6MtKJxitcnz90bBXmEb6/ybui45FqiR LPvj4ogqqFjbYu8C4pDFLJVfB825+0WnPR1fA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715015391; x=1715620191; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mdReYnfYpXbw8UTYqzLrE/VJPRPi8vsKw/zSYHi1u0E=; b=Izgd2EZtFC6R8soKK3brDOEOGUvqSDfpkYJzIPPtnfflZO3ij/JBSD6+KOrlxOasmu lvhojhVwjHCS6ulijNbwJ4jSYLeNZ0MMgC6dm2hc5rVmhDFGpKfKbdlJAX+WofLyfsLV 9uXUZzEKBs0pYB5G2dhvp7l/vnw353THqrinYvQWLyOkwOI2cMlkN755EHelMOcHYFot XoAn/Y9NO7qPTBKX1V5Bfhg7mKrdLYk3VKFiaHT9OgOX7e9sUrQpiyjk3tQlG+ktx6mu IN4lXd0b+qzhUy7M/qSNJfDltqyjTUlQHT350qMX7UR7I5ifiUTtcreXDGR5m3LWQiRN eOFw== X-Forwarded-Encrypted: i=1; AJvYcCWTKAdGTEOhPxbLRtIjs4OZp440Q9B/eeTGu/uswXUtVT/n91xNYRciSKlFYlRNG1kfSF8TQnM4aKGpVrVjjpxt7lw= X-Gm-Message-State: AOJu0YwMi6h5bumvQmFbXhVyeYZMwQhTeTqjG+tI36cc+ebZeHq3/6rK ZeBILBZxR5QGBX4qVUNgMwvpBLCkG97AWpZzuFlkonLSqF0l4GQzuS4mLvp1cA== X-Google-Smtp-Source: AGHT+IGxUieIOzFQ0Mko83hxGUk+gEzoGxA/1Ap+Bl/r+WCemjUK5IeIzFbSjiBsICA7ksrrUH4MtQ== X-Received: by 2002:a17:90a:d496:b0:2b4:3679:183e with SMTP id s22-20020a17090ad49600b002b43679183emr10938107pju.21.1715015390728; Mon, 06 May 2024 10:09:50 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id l9-20020a17090add8900b002b269962606sm8407951pjv.30.2024.05.06.10.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 10:09:50 -0700 (PDT) Date: Mon, 6 May 2024 10:09:49 -0700 From: Kees Cook To: John Hubbard Cc: Shuah Khan , Eric Biederman , Muhammad Usama Anjum , Mark Brown , linux-mm@kvack.org, Valentin Obst , linux-kselftest@vger.kernel.org, LKML , llvm@lists.linux.dev Subject: Re: [PATCH] selftests/exec: build with -fPIE instead of -pie, to make clang happy Message-ID: <202405061007.F1A46E89@keescook> References: <20240504022301.35250-1-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240504022301.35250-1-jhubbard@nvidia.com> X-Rspam-User: X-Stat-Signature: 35hkmq9s6ibqny8fb345e6dqecrnsz7b X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0F597C0013 X-HE-Tag: 1715015391-215201 X-HE-Meta: U2FsdGVkX1/0fpoJfRgwqHkaRujz7BYq0OcDsEW1uzcjjqG4+ifgLlxUrO2ItyPYDHvesAqJ1HQtA5+jWR11lYDAvJBdLN8MlDXp6Plyn1caVBo58eg+dO50J/MnzBM6Y23Z/4waecozvqtYE7aHYRVF5UeoDghXlVHRF67ccYkjGYPJPRTIFr1KMyicwwCAVKzcqc6ENJ3sqUC8/fVzsjBD4DjfOLCdYIUjAfPW7n3iZxOBF11chX8a5lCCp+SQmb+yyLsnO6sW6CZalov7NtrBZ3tIPUa8ffXn73fld32X4piO7VC/vx9xOnq4YkMcHGP2bH3sL5gINmarjpZnMlwZVOofgWQ5P80oE0PsSniXDqzHlA5TecqzM8Uw7uUbIrCfJWRrL7HbTEbu+oHaN5z1zEz0Y2VgNPz7P8qzTOV5jo5Geu8vQvjm0P53MGPOQncVbRVSPjuWEqv7ni4S4YEsxUlXX4ztR7lxaV9BB+Rf/FLdMd3DOW8P55Zh/bSYZ2F5YySaSHYBorCuHcb/ghtp1Jiup1cDpSx8GaXWSfE7dwWmtM8SHUik7TssIAkqMot4xi7CspRhDPXuyhGr74kUvP9Lx2eNg8xDNmh10yNlyx118nADvIrx+A32oBEf/1A31DIP8r+hghOcHReSW1xBR4R96/sBPuMeFxBqNzOuIjJw9y6JwShYKXV+5t84rVeBixKXcvzLwnGdjtOYKGvI0n3yh9AXTKwZApQiDX9X1M5psmbTJv+HF0UUe3ipVKkcEPghaduAImvJILYKp05dsrPFhdeWjG7qvGeDn5cxQCVV+sl2mjnRxf4B1f+5N7H3XOZYtMDvKF8TVW5lDsy5d5djWKBebWcf9GOOxDOe+2WLQg60N/PaFh1HyCbQNUM8l4xiryW1b5lDu9OEadl7CrFpcSpl5ClvqqjSQmYKGSikCfwULndattompJpjUXofCtODGNMhDhL8meC VLVIOuRA Ng896OEgNpY5+HchMRVtxLZCzB871xpI4EvgPw9KEM7gYvYAAmln5m2SjNnEKbjVLblPlx8vO+Tg+BeE7m80jxSCDIeSfhogC0OhaDnt125FElra0UYor1YyuQ932lSGfE4xx9eyIlIJPJCK6ZsQ0xEkXFsYIDJBZ8SwUGLNsNzG7nE4P7C9Klb0UdjtrrSS8mnAr4dtInKasmBIIlgyVCUyDLvAuUJdAXgqTz1gU9N8WCgMiG++cCJub/hSOQmLZ5X2RJUal1YcaiIFruWif/xCk+os3xOi+OCsUT4o9H3PrrbGdqNGgw0J6eO81g9JVS0R+h2vpyrwmuX7Ap86GnVE+U79fzZphGNNdCxqkririOlUYv0QaAC+rdf8nNplEnlW7hDz9yyFFrP7foEtsEQzU59Jh3T5uDx2P39ehd2DV9EMSBm1zQGb9RSoS+PPISGQw353Z6JGDkCL6MfGteTGNHxBgZzmU3qLQU1UheLWq1P/nlQwNP98PRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003647, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 03, 2024 at 07:23:01PM -0700, John Hubbard wrote: > clang doesn't deal well with "-pie -static": it warns that -pie is an > unused option here. Changing to "-fPIE -static" solves this problem for > clang, while keeping the gcc results identical. > > The problem is visible when building via: > > make LLVM=1 -C tools/testing/selftests > > Again: gcc 13 produces identical binaries for all of these programs, > both before and after this commit (using "-pie"), and after (using > "-fPIE"). > > Also, the runtime results are the same for both clang and gcc builds. Thanks for this! It got solved differently here: https://lkml.kernel.org/r/20240416152831.3199999-1-usama.anjum@collabora.com Does that work for you as well? -Kees -- Kees Cook