From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C53F4C4345F for ; Mon, 6 May 2024 03:22:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5F5E6B007B; Sun, 5 May 2024 23:22:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0F196B0082; Sun, 5 May 2024 23:22:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD6AB6B0083; Sun, 5 May 2024 23:22:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B12D76B007B for ; Sun, 5 May 2024 23:22:16 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 034DC1407A1 for ; Mon, 6 May 2024 03:22:15 +0000 (UTC) X-FDA: 82086522672.19.7B71D6C Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 0736D180003 for ; Mon, 6 May 2024 03:22:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BtIMHJiT; spf=pass (imf06.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714965734; a=rsa-sha256; cv=none; b=n+urK//Cst/1Emr+IsnvcxjbcwhlwLS9+czgfWc7xT/sUGMoh7qrVlvaCoya7WwV6z/xZc zaoCbR0f2SZ1tGm/q22DJbhsgUa26l1ulWYy5W3AHK1NQh0K4hId4zucg4TcFMAXd7+pQW Z6re/mrindLz3ZGHAsp9skLsyhtTwvE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BtIMHJiT; spf=pass (imf06.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714965734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NLj2W08/AlPxLeXkCP61XrllXdJOfYp00hdT7d+0hkI=; b=W2lVXNTIo8fbLs//hhw87ETQDSkUhFDOeHI0Gmx1sbgRtDrwgbTfzEbPapheDCRxmraQQo XOZj6PKZJgGYYYME2Dg2LkXfw4JP891DdAD35hZQhiq/dXaCR36S5SgFs+e5ihyXNTuRDa pjlO0lPz2wphHzq1aWp0X740WdxEtuI= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1ecddf96313so12118455ad.2 for ; Sun, 05 May 2024 20:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714965733; x=1715570533; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NLj2W08/AlPxLeXkCP61XrllXdJOfYp00hdT7d+0hkI=; b=BtIMHJiTWA0jRwkRkIkfUnOuYWuFS1ilBxM3CeoL09Q7F/1NGxVdlpdjQjmazOrLst Uk9REt4AK8XlPKxDnriSV07VtMycbKndBoPp6b5lsbyK+iZ8btV2XF10JP8TrPt8euxM m2TRRfxnQHptFVHS66GkO+27Mv9usUAT63s/g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714965733; x=1715570533; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NLj2W08/AlPxLeXkCP61XrllXdJOfYp00hdT7d+0hkI=; b=hCprZ/ulFEFaUW1YQ5xl2bV/Bmz78o19hUwiJtzXxZnthMJeQSyYysn6dOblnUV/Ve 1SHQc/Q/fnuM64TCr2w7MH/px880BreNXKIZyUIFNZjeIDaPN763WDws12aRn1o/sZup ncLG1JoaK/kAEoGW3//AextHG3yjq4nyGzKkjHmeCSXY1+bwzSxtSJ5TYJHrBvICTEhC 6mfhuf9ys4K4O79XwX34/E6jmKjEX1dZsm3XuuAXHh48ZbDXLXZmaf5ZkaJU9aHUBh+s ax/6v8Lexr/dxbo2YZGiHMsn+41m7DnYL8A1va4a8w+Pnv5ysPOzztYzKcL5dlb6A2uN b7/g== X-Forwarded-Encrypted: i=1; AJvYcCXMVfenjAg1C1D3yRMpG1HDlEhNeg0NrEMMJWw1+dKDm6H+oQgpXYwk8XjJ8PHghaJFoEL9+lKFlEEj/KK86zqGu4c= X-Gm-Message-State: AOJu0Yyy9eawqydZ8eX5/4WnkKYKs5uLVO6QNpdYrOhXVwbsDvWe5ytS oT1xqgRyG1g9lCIt+KgRJmOE+u2+FKIWSXXQenPJszNS5ZTirIf90/FmfIKXmQ== X-Google-Smtp-Source: AGHT+IHdGPyGQrnvWR5Admmi4idMQxhyP5nB96L+iNkf96/MgdQqtZ5qsVJTxOQ1cKRQu2U3zrqpXw== X-Received: by 2002:a17:903:8d0:b0:1eb:7ba:a4c3 with SMTP id lk16-20020a17090308d000b001eb07baa4c3mr16253443plb.48.1714965732789; Sun, 05 May 2024 20:22:12 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:8263:3b89:bcee:2ed4]) by smtp.gmail.com with ESMTPSA id o7-20020a170902d4c700b001e249903b0fsm7134459plg.256.2024.05.05.20.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 20:22:12 -0700 (PDT) Date: Mon, 6 May 2024 12:22:07 +0900 From: Sergey Senozhatsky To: Andrew Morton , linux-kbuild@vger.kernel.org Cc: kernel test robot , Minchan Kim , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 08/14] zram: check that backends array has at least one backend Message-ID: <20240506032207.GD8623@google.com> References: <20240503091823.3616962-9-senozhatsky@chromium.org> <202405041440.UTBQZAaf-lkp@intel.com> <20240504071416.GH14947@google.com> <20240504161004.f5a0aab5e5aa1033d4696c20@linux-foundation.org> <20240505043957.GA8623@google.com> <20240505051305.GB8623@google.com> <20240505064832.GC8623@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240505064832.GC8623@google.com> X-Stat-Signature: pp6u57kck9ey48s6biyg4r16mipregtu X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0736D180003 X-HE-Tag: 1714965733-321232 X-HE-Meta: U2FsdGVkX18Zo8wN/IEa2vyoDQjRK/iIcxfPTSqzbxt9d8r0FBNG6dtLVzMq6zBNfJXH8rqtU2+U5FT6jX8xyyKNQ6IVRCOEXN5N6sGVmRZ/LtmQrV8ScHSNWtu3rYJju4jAKzAz6jqKVwPo/UdNu48YGijtkO9lDUDQ4iC/r8PbFlx7BVBY+7Uub5hYIH2xipGOXmuM2octb4m7MwSkrzBxFfd0hoQeh7DJpG/Az3xlmSvQP5rkUi9ZArOiMEwxIHLC8l7PVekPaHV6V+7dJeIXIYKEZYjbcU8VWeIJBAoCdIYTKkcdKym+v5lwhuuBiNWKCFXNKQwj+mUeGvV7O4AlE4BZIYajF2Bu9q48KXGLHQ78hpxO2/ovwOEXWJbT0G5ZLCJ/2Ka1MQ8COFov/QyZj9Z881PaCe8xeD/7VayhxQ+QYM63Byv//FcxqFc2LIgRm6NZenOzpLAJTvg7liq8LcPZlzAyQHHF6wAgUOFNaF5Cw3YPlGi3tfXi0MsgjRXWO0yCaQV6fLt8UOHUXTM4c9+PiWPiPZfThDeO1C+gBzaHghSBHBfPCj4jfrWKWFRUb51DYeBZ65oASv3UkGK+CcvzA78C3rTewMMRCwnqMIXkg7eClgLnEgGnMOE+Om/PHRbKe8sdfPX4y/0Mks62f8O8zEUL7QXgDrbD4dlKcak1Hz11sIH3n93nWNf6Plon2NQE2KhAwtEd02+Fn2mUrliHwUUccRYkXm4ulHYkq6j0OxsuPVA58JAdXZNgCmeNQLkAUYMyOM/HG2aL+20bmBsDnmxnoTJtX4rU7JKrfoWonugtCylt7hwlnHBL5CYjXWJHsAVFpCY5IlwWkSKAoNbuqzmZwVHqzkwtffjmabj6DelRkelMkBsBoPyVBcTVchiZZi8nsOX1Md79GeBOza98rxJC5z7+isvmKptgJQ1c39tiJO/V1sXSsWzGvEFKC67PS1IlnrSi5Nd TCVX0VoD PqyXJYMNgDf+VWqANiRU40LYJ3R2x+ZQY2cJivXCjLhuDfAqYaFaV8QrRBAV0UFts4gqqPlcSA3x3QRD+M8vIS7zn/TcaAzBIOXXL/lPQHd0az3gep10Q8m0bxZXI+5hxSHEED4eBj0jMZ3psoCuhEqY3pK21II4fCu8LWma4n5/vUEqqnr2JPSgcrc68t3Gd1Oq4Mr6fwvRv/Vp98/3JPb7Qj8I83lxtpngZdSTbOtQSyEosbB3r/Ad17Z+OdTPLN+DBahaAP5urZhxwryOdtxe8buIt7gpD4ypRLb4jRZ/DUiOjctEfNbjg/+Qd5mt1Q1UwwwZVlYoD/7UAsgIreRiYaz5KAT1QUDLexXlWO7/h3olh6bJZJi/aaJMu9LYtIpxcYaTPDnZvHqc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.046825, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/05/05 15:48), Sergey Senozhatsky wrote: > On (24/05/05 14:13), Sergey Senozhatsky wrote: > > On (24/05/05 13:39), Sergey Senozhatsky wrote: > > [..] > > > > I guess just pick one if none were selected. > > > > How do I pick one if none were selected? Does Kconfig support > > something like that? > > This triggers Kconfig error: > > config ZRAM_EMPTY_BACKENDS_FIXUP > bool > depends on ZRAM && !ZRAM_BACKEND_LZO && !ZRAM_BACKEND_LZ4 && \ > !ZRAM_BACKEND_LZ4HC && !ZRAM_BACKEND_ZSTD && \ > !ZRAM_BACKEND_DEFLATE > select ZRAM_BACKEND_LZO > > > drivers/block/zram/Kconfig:17:error: recursive dependency detected! > drivers/block/zram/Kconfig:17: symbol ZRAM_BACKEND_LZO is selected by ZRAM_EMPTY_BACKENDS_FIXUP > drivers/block/zram/Kconfig:52: symbol ZRAM_EMPTY_BACKENDS_FIXUP depends on ZRAM_BACKEND_LZO > > > I'm a little surprised by this - EMPTY_BACKENDS_FIXUP does not depend > on ZRAM_BACKEND_LZO, it depends on NOT ZRAM_BACKEND_LZO. > > Let me Cc linux-kbuild. Kbuild folks, how do I workaround this? Is this how one does it? config ZRAM_BACKEND_LZO bool "lzo and lzo-rle compression support" depends on ZRAM default y if !ZRAM_BACKEND_LZ4 && !ZRAM_BACKEND_LZ4HC && \ !ZRAM_BACKEND_ZSTD && !ZRAM_BACKEND_DEFLATE default n select LZO_COMPRESS select LZO_DECOMPRESS User still can select N and then we'll have empty backends, but at least default is Y if none of the algorithms were selected. Is it good enough?