From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDDE5C4345F for ; Sun, 5 May 2024 04:40:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE4596B007B; Sun, 5 May 2024 00:40:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B94696B0082; Sun, 5 May 2024 00:40:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5BB96B0085; Sun, 5 May 2024 00:40:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 847B16B007B for ; Sun, 5 May 2024 00:40:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E3D48140249 for ; Sun, 5 May 2024 04:40:05 +0000 (UTC) X-FDA: 82083089970.28.24FD663 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf16.hostedemail.com (Postfix) with ESMTP id F2E6B18000E for ; Sun, 5 May 2024 04:40:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Lv7rXJzH; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714884004; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TzpM7FU8Imvm8zuTPXcEgxBeaAl1FWkYeSH3YqD2Xns=; b=0wWXFpNZVCe917n7PQydkA3Sa0ro+1dMpEtHesaBpSwNF309q6U11dY/kT3xMo+2VmbUOJ bpeAb58crg92Hiqud3XvCft9f6RWlnTAmDK8DbdMexqJNg4/liw2Eu5WEpToEMuE6Y72E9 xI1VlPdU4469Lgj2Cq0L/QTzokIGs/4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Lv7rXJzH; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714884004; a=rsa-sha256; cv=none; b=MILjBtxgcaX8KXHMoKdhMsb8EIChKYlzD9n5z00Cb6YP+UKTr1Cb3S2BAotxytspAKdzlo 5ycn5XHUXp9lUSrpT+Mxb+aydVgtOTMs8Sj2OyeUTzXulxlGfLfVx2l+KmtPbKTzTKGAX2 51rNuuEBbGw6PPAVqJHvRHlFqDiLNaw= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1ecd9dab183so24600405ad.1 for ; Sat, 04 May 2024 21:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714884003; x=1715488803; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TzpM7FU8Imvm8zuTPXcEgxBeaAl1FWkYeSH3YqD2Xns=; b=Lv7rXJzHEPsqkUJbZQKOsRxsv7nT4CjKdbw17icy+yIDdEcPkZ4JApkr11l60bvJPu 7rX299ULSNa1F33/xNwoj4nfKHG3LPxXVIyCkxXgEmV/pBV33VkA7ZoKukbUVF3MweuV IIRRSEO9rKSn2j1heUMTYORZqial/gE/RoTOA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714884003; x=1715488803; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TzpM7FU8Imvm8zuTPXcEgxBeaAl1FWkYeSH3YqD2Xns=; b=CCxaAKe10Ts9nz/vqtvlPmXmGla5vDk9GYa5bfH6saGJATIJuyySMtSgG5DAH9JVGe Opy0vZz77P5Z1UB6kA8H0fRdRmfmgTfMhhHhNs8zjTp2/khwaBBY5y9xtwtqfkTbnNBE eJwWOSoYqzOt1iVe/zfStqnUfcCA2nkO+7kzMGc4lGTyJL80oec5qQn0wrVsQTbyKTsw M3gCaf2vnz/MMwBPSUBjtIc5aSJXLQw9+D5xf54ohlpHkcZWKSIIfuwkNHyvSmNDxl2p QcNOGE/xF1AN/EDC17SQ7g5uIWd/ewVeDMkqrgUybRZt1TMu4HGayA8OKTauCf6BRGAq 5+nA== X-Forwarded-Encrypted: i=1; AJvYcCVExA0hixX/LLjfK5ZzNRt1g4uwhUDwHb4Reg9p3XyzV1UG1W6UenxV422KOaaLrbygVrTqiIL6A66QR3XUVUhmHqk= X-Gm-Message-State: AOJu0YzgVh7EQCqE/7tH1jzQy990dLqHdtvQ6geAzTUf2seNy3dLr+4F bziosTRO27EfUEkWNL1ERzlHHDqjchkCLzAXAjzEnyEAOzsN3RgDYvHDq+JO3w== X-Google-Smtp-Source: AGHT+IEeiKOrRPU5vIIqBtlS4HJNxQ0aabIvlspSUVAEeWBnpj7xpaPpcUt2xQ7IpYeR2DLXXzG+rw== X-Received: by 2002:a17:902:ecc4:b0:1e4:59a2:d7c1 with SMTP id a4-20020a170902ecc400b001e459a2d7c1mr15472258plh.33.1714884002658; Sat, 04 May 2024 21:40:02 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:8263:3b89:bcee:2ed4]) by smtp.gmail.com with ESMTPSA id r12-20020a170902c60c00b001ec7a1a8702sm5789626plr.271.2024.05.04.21.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 21:40:02 -0700 (PDT) Date: Sun, 5 May 2024 13:39:57 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Sergey Senozhatsky , kernel test robot , Minchan Kim , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 08/14] zram: check that backends array has at least one backend Message-ID: <20240505043957.GA8623@google.com> References: <20240503091823.3616962-9-senozhatsky@chromium.org> <202405041440.UTBQZAaf-lkp@intel.com> <20240504071416.GH14947@google.com> <20240504161004.f5a0aab5e5aa1033d4696c20@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240504161004.f5a0aab5e5aa1033d4696c20@linux-foundation.org> X-Rspamd-Queue-Id: F2E6B18000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: usbeetfnu7x48xp1ngjzapxy7g15dp5h X-HE-Tag: 1714884003-484690 X-HE-Meta: U2FsdGVkX19x8FQNkJEk9oGBFzXXMKKzrQhFxNqjHlkF1smA0G1W995u7Aa61XCIWYeTMAsGPiwRzBclNYeGQf8hkFV8y1yBNrOllEi5ZK7B3tCa5Xj2MEVQqPDxo3AxCr4szLkKccESLNZ2dnMx+de0gGD5hVi0vZH/nsgj27Uo0rLRYDt55lXSaBe7U4OYI0l7sDUraF/7txpzcuXhxWp/0+Fs3DCMM2tvFV+VWUFax4A5ZM8ylp8+gi2gLaLJIy5+J/EvnSV0D+BsGhAoRgOYfdvMF09NkOyIUBTg9cOj9ohAfpt+RHv80d/GM7L2TyM2A82f4Y9HuLrQ6MolDfZJEPWARz9FBbef0X+NgBXnfjSZWFYwIfq+/WrrlhtkZuDJCIfSNWg+amR6DqIYkJNE0DcT3429VxzkE3EHXNzK5+LZT+eahH4P1duhGa+XSFXBZXlFZEqkt8ENZLhzX5S8Wnn/fLVYwTkW6ZRsru30YHnRgQvXaWd644GqtFJYRxlunZD1XJK7jEe5tn1UHCi5Q+EjLCGuIE4m3W1tWBRlBsq/O01WHxzQXNKdak5jn9bdNFqEmJZoIH1uK/ulQ2ZJHNIABN5v5BNKdR8Mg7rPpMCbM7DCeOu4fUrkatD1lar2uLmaLmgQzjudX2tVA08HTsTGRMXbZXDKTa8DRh41HMFUMMSoi1EETxApaFhaIXULJNuYYzFLvOeRmyWT6RqpzyOX7X8KleQ0JaHRfhl0GCkFhaECVKpwch18GaUbvl8uVSaVinzS9Yprkn5fv9DTNgeElJ5vEr4xfODOKPBIl7IxqvrO0RDwakWAogn8VaZl1pBIpcvxDqC8qyKagaxSJKHh0VmC8P1nvCUt7l0lARAgtlfW4OZjJz33nenxOi0RPD7+YNvhaqi3WcWw4W96YrVBhO3DkY0Y4gCvVoSYCQlXKzdavmSRthpa1ZQIuueRfR49r9apEKJMIyI hFz1q5oR s0bnrCAd0Mkek1IOoz2tMvdJrZpPTUwRVf90T4p+CVpv8Fn7QE8xq0XoX2YKWfHh+/PTl4+JKt/DXjNOMhdS197/4a3xrTuNaOnxnz3xNXZrEYD2/5nxs7K/wXvDRdDAR3FjrAWks8cKDsDul6S2ZMdEYuB91FVyAMNv5nXknjbk2IkUesOd3ZdwfFOabPly6oTT4/rmU2TyY54wOIwh00U1oCrdAt2IOLR10+TRsqrE8TtY2IIy6V64xQWIDrLHBqQ/99JYWSnu7Z2IUx26panKN3d+K4fvqle59IBg7+eKFRAN5iHOHFUTShaY09JrGGMmSyf232YClUI/0uZKg8mF3Eabfj6xjTYtc3oKHX8ldbOxIOL9CiLAZB0RlctPJnfIM3K0vyqAGXEE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.016048, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/05/04 16:10), Andrew Morton wrote: > > On (24/05/04 14:54), kernel test robot wrote: > > > | ~~~~~~~~~~~~~~~~~~~~~~ > > > >> drivers/block/zram/zcomp.c:214:2: error: call to '__compiletime_assert_285' declared with 'error' attribute: BUILD_BUG_ON failed: ARRAY_SIZE(backends) <= 1 > > > 214 | BUILD_BUG_ON(ARRAY_SIZE(backends) <= 1); > > > | ^ > > > > So this is what that BUILD_BUG_ON() is supposed to catch. You don't > > have any backends selected in your .config: > > > > # CONFIG_ZRAM_BACKEND_LZO is not set > > # CONFIG_ZRAM_BACKEND_LZ4 is not set > > # CONFIG_ZRAM_BACKEND_LZ4HC is not set > > # CONFIG_ZRAM_BACKEND_ZSTD is not set > > # CONFIG_ZRAM_BACKEND_DEFLATE is not set > > CONFIG_ZRAM_DEF_COMP="unset-value" > > > > Which is invalid configuration because it means that zram has no > > compression enabled. > > We don't want s390 defconfig to be doing this! > > I guess just pick one if none were selected. I'm looking into it. We used to have "zram depends on crypto compression algorithm" : config ZRAM : tristate "Compressed RAM block device support" : depends on BLOCK && SYSFS && MMU : depends on CRYPTO_LZO || CRYPTO_ZSTD || CRYPTO_LZ4 || CRYPTO_LZ4HC || CRYPTO_842 I sort of wanted to change it and make zram select compression algorithm, instead of depending on some comp algorithm being already selected. But I can probably keep the old behaviour : config ZRAM : tristate "Compressed RAM block device support" : depends on BLOCK && SYSFS && MMU : select ZSMALLOC : depends on (LZO_COMPRESS && LZO_DECOMPRESS) || \ : (LZ4_COMPRESS && LZ4_DECOMPRESS) || \ : (LZ4HC_COMPRESS && LZ4_DECOMPRESS) || \ : (ZSTD_COMPRESS && ZSTD_DECOMPRESS) || \ : (ZLIB_DEFLATE && ZLIB_INFLATE)