From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1FAAC4345F for ; Sat, 4 May 2024 23:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C4EB6B0087; Sat, 4 May 2024 19:10:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74E0A6B0088; Sat, 4 May 2024 19:10:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EF606B0089; Sat, 4 May 2024 19:10:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 448DC6B0087 for ; Sat, 4 May 2024 19:10:28 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AE7BE402FA for ; Sat, 4 May 2024 23:10:25 +0000 (UTC) X-FDA: 82082259210.12.5D4F941 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf16.hostedemail.com (Postfix) with ESMTP id 7A3C118000A for ; Sat, 4 May 2024 23:10:23 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=cL68Y2fO; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714864224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q9H1XpCy8CyR9INgduSOiucnBNKn4ov8YVQr8IswE6c=; b=K4vmP9peiUoN/LNz6iKblG8d+lAToWu6doK1wcgbebDz+pyEeLz2RrXykczNWZCE3tLKxz dwIz+H+AZyVCam6T16cpJAMI6IYnVtMtlSA+xNpyVgTMndGdtKpD2bn24/29x/6r8cBqBZ PyFJSfVU8VovKkZSeWam6tJN/qwfZS4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=cL68Y2fO; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714864224; a=rsa-sha256; cv=none; b=8hYCTZyeQVihJZsy3THcaTxuCnxDip3AmTnM2fk4ATYOAPSfvdjznv2ndpYuCRlGRSd/R3 JI31cyn0TMIXteGTM4abQHztSp0Ad4QLFNDHVvP2dWNq88PkIIv5oQ+TMrgBl1vAylfFRQ tMx0bWbQDiusG1PYa3ExBw4oXq79O4c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9FBE3CE0201; Sat, 4 May 2024 23:10:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF829C072AA; Sat, 4 May 2024 23:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1714864217; bh=FW6qoHbDHK21pEFQTCdCfOoptYJ3bNepxrOzoRzW6Mc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cL68Y2fO9JhsUEO7D7shlWzLxPAMDqhELYNeQWDMw2quJz1ADARZOuMJQU8RTRhJN APHGm25HCCPF9pqXA6rCffBxy5MnZzupzSunL7LONu06Ns4L1VHm2Vcwg1h8S6cnpk 2R7n77vlxal9uoveCagkdkEf9tlk93HQVgqGG9YQ= Date: Sat, 4 May 2024 16:10:04 -0700 From: Andrew Morton To: Sergey Senozhatsky Cc: kernel test robot , Minchan Kim , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 08/14] zram: check that backends array has at least one backend Message-Id: <20240504161004.f5a0aab5e5aa1033d4696c20@linux-foundation.org> In-Reply-To: <20240504071416.GH14947@google.com> References: <20240503091823.3616962-9-senozhatsky@chromium.org> <202405041440.UTBQZAaf-lkp@intel.com> <20240504071416.GH14947@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7A3C118000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: q9kopstbhr8j71yai7hptab91stqra13 X-HE-Tag: 1714864223-762989 X-HE-Meta: U2FsdGVkX1/F+Dt9KgvDcjRYnLxcXcN4L4B3V0K2y4ZHF1UHlxzaNcrmqzMM8wEBTPf+0nZpAZ1UHN1sxus85+rO1WYtNEL5pUrDvGo20Ddv5bZBsSmJijKxcKnvZsVqDzxFu1d74MUo33qixtHZ6dhWxtBK2kvzb2WF6bvzwEkfwWjKU2HqWqQSjQZR+1woU4q0WGP1ObjYKUl5FoVq5XPENIStaUp5hr+C5gcgei+Yo/UE05ImgKxEJNQmfJ0XoauKW2POL1qTvYEW20uUHm3QuvT5hhVcbkENVlFy3G71QyflIQ+bZ5CEaqEnGJw/ic0wa2Phxd1yFcKV6LQuMNqSV5eJAZoTRHsXWcCMV/pQlASWPdeLhz1koTCET2G8698Zr8V1uZS3x0VpWEDKu/H1utN2ekSd/dScTGR+HrmVUIUcDgqVAQ7uA1Whc7yvIDrckWTk3fMJfAF44VFPhGGYdtk96KY36GxR2qYvGJduJH3X9oWETtVcTXRz51bdD5A3qDgtMi4x+MquArI6F6vb04fl6udCDJuna4bauC3LHw4d2fBQFpM1Da9TiTjqnSD+Gw0FsInOUoZFVGC906xSPFQWEt+PxZ49BObqMyjVaJ5q8llpZV+b9LkbZWHFp1Zlw3esQcGFDq4NeJr6OETFQV0zVw0cIitokc7kwbLMe5rEHCjJ6zfVU35hdb2a9Ux8YNaR3noq73j9S3u/bN1A70H7om5WYf4ipGL3isVlWEpAJKtBAcEn+ZWOXSTEMJVT9ywcZyUd1IipPTymnZchIhj/6pVT7mYZbaxUAMx9/xaEAxpJ5lQ36Tum4SeBPZ7qafZw4bzYmhoBMoyQTOZA4m+SxzRzw6cRBQTQp2G+YFPlxYZWE7KULkBrbl/HtC2AYff2qWm04iIkmVdnZouB+ZWKkBESdXuY+Z0GMMagBVgVaq/EJov1wJhjashX6x3q87zevoxptrAGtlH gCW0lEyv nXbARVNxV7qedGSJGvxqIt3eXp6fF0cO7+H0Tgxynln4ogX+QLZcHaY02MK0gzjI766PhTyA9hW4xBBy0eYOUQ/lECkW1vYEG+H7XqG20RwwCZYRyqLMo9eys1EAzRts1bZDVsuO3+xDMjWOMYqU5/uUYgAx7RpiIGCHnZ62fqdU5zAg5uKmcdCNf7XAOrpX0aD0CIPcQWgAFlSWRXWDVRLsEh+B1Kvjga0iFBQ6hVY/OAeIKnJMKhSCVu6svuSMgKUMX/QdGVtTmi9xBobQNIoFx+57NWlnZTiGy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 4 May 2024 16:14:16 +0900 Sergey Senozhatsky wrote: > On (24/05/04 14:54), kernel test robot wrote: > > | ~~~~~~~~~~~~~~~~~~~~~~ > > >> drivers/block/zram/zcomp.c:214:2: error: call to '__compiletime_assert_285' declared with 'error' attribute: BUILD_BUG_ON failed: ARRAY_SIZE(backends) <= 1 > > 214 | BUILD_BUG_ON(ARRAY_SIZE(backends) <= 1); > > | ^ > > So this is what that BUILD_BUG_ON() is supposed to catch. You don't > have any backends selected in your .config: > > # CONFIG_ZRAM_BACKEND_LZO is not set > # CONFIG_ZRAM_BACKEND_LZ4 is not set > # CONFIG_ZRAM_BACKEND_LZ4HC is not set > # CONFIG_ZRAM_BACKEND_ZSTD is not set > # CONFIG_ZRAM_BACKEND_DEFLATE is not set > CONFIG_ZRAM_DEF_COMP="unset-value" > > Which is invalid configuration because it means that zram has no > compression enabled. We don't want s390 defconfig to be doing this! I guess just pick one if none were selected.