From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6598AC4345F for ; Sat, 4 May 2024 23:03:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B699A6B0082; Sat, 4 May 2024 19:03:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B18ED6B0085; Sat, 4 May 2024 19:03:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A07BC6B0087; Sat, 4 May 2024 19:03:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 82D136B0082 for ; Sat, 4 May 2024 19:03:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AC423802E2 for ; Sat, 4 May 2024 23:03:29 +0000 (UTC) X-FDA: 82082241738.02.79DC66A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id E6D3A40006 for ; Sat, 4 May 2024 23:03:26 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nuY8doZR; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714863807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sDyndzSTSqQLyC30smtd+IDa1zZ0/wLggpql2tjZLEs=; b=jo5AZXg6mgm3EJszKOL69YWRlfYk4r7wUHyJK/47sEuZo+45JTK7+0gEp1qIMu+qej/mF6 A5hhnLK5se7p4tdR2t3GqYX8+/Fi55SeUJ0aOYBq18SrWIVU3ZQT8elopePTv+SYFkSijG bdLn6OoC8Gs0OfT+69RXo4osQTeeF9g= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nuY8doZR; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714863807; a=rsa-sha256; cv=none; b=jSJUZ0G4s6s0LNTAeC0wC1U0mysjvSb+7YytMBwTA5XTmonyh9I8M8qOQRZV/lM+aNvIzP Fowjq8QOMMlkZYe5Y/PCmjArAP10kR/ErKLk0wUCVAs6dt5xnB855H+ZpzUM6kiBDzAmyW aZKGfjogKzIp6W+uCPUIlZwlNgcgjXk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A3EC260B3F; Sat, 4 May 2024 23:03:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28A7DC072AA; Sat, 4 May 2024 23:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1714863805; bh=ZInlZsOkTWK0vvjZbnibAQPQae7tkslsf9UrJVVqEVs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nuY8doZRVNRzroY3YxRsdC1Ol3wcauUk6s/2q3pKvgrXdV0oAiSM/eVwICYRxfTe6 3FNErWgTeE4+YgfdBtCdh2dRGxaJNaUDnaD2GJb6b8wAT3vZTbDf3GoHTrJw898ye4 6zTPUZ7+fMkxeveKKwJirHntws+i9R/ZvN/3CkhY= Date: Sat, 4 May 2024 16:02:57 -0700 From: Andrew Morton To: Nathan Chancellor Cc: Matthew Wilcox , Kuan-Wei Chiu , Liam.Howlett@oracle.com, ndesaulniers@google.com, morbo@google.com, justinstitt@google.com, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, llvm@lists.linux.dev, jserv@ccns.ncku.edu.tw Subject: Re: [PATCH] maple_tree: Fix build failure with W=1 and LLVM=1 Message-Id: <20240504160257.02e20addebc407cb4a18da48@linux-foundation.org> In-Reply-To: <20240503160821.GB3960118@thelio-3990X> References: <20240503095027.747838-1-visitorckw@gmail.com> <20240503160821.GB3960118@thelio-3990X> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: E6D3A40006 X-Rspamd-Server: rspam06 X-Stat-Signature: qs4dhmioumouttop5xp6o1n6b53jyans X-HE-Tag: 1714863806-800531 X-HE-Meta: U2FsdGVkX1/CrbEYj6AtxXuMR3GBwev3m49tsLyuxP8FBi6/tgeNsWymbcmqxZud2K/WCa8kWtprMf7bZgzmjkcYq5OvfLPlFTIuLVikbC99RTv3uvU9hS6wr+i30mq9j3vlYIqTnXKUQhiMcRSicgPz3zJTbAXo0vJVXgBwWPs8ZMXJ3g+AyhTtKkfMx93H5chtAgsCnf++VnR1+7hIeakyNfjJ8XCPLD3WH5vrCKvSj0v9qVnuzIkfQHxtXFQMvAoPZ/b28hiNPT3A60J8UsaE1xDHvnnB3UOPnwd/yK+9IAhI81f5LIULnfNsJIlsi0AZUYb6ncK+C0+xS/jdGmLrrta+kV4YdSW+dJZBp8d+2eNKBvMakg0PHO1MrPWrs+z96tExmsH5FUefiXG9qorLsrEVzXikl4Pcq4xC7HKiKRlNNwDqgypQktXSMJIo7naw5CCsl41l/nCxp5rU3tFqJ70PDfmhVxB9xycaqEPCZpoclhTT9+PGMQS9HYYDLp6iuy3DlAIEGU2OHY6qKfAmrLGsimEFNEs8v0mmQsYKCoSwqBauzbIiPg86cs0o9qr6/yOpRZrOAnf40b7gGHUwXQSffeZXyi//0z8p9ojIEKG56ijWrBIIgqjFSEZJ81a4tunAdIZVgUBm9DKnQRXDhTkSLNsO0ggzc+mEzQnEyXRh2lNBHEHZArBVhv44WBQbhb5WlABPHUE/HQ/BbStQ7nm+ujEXcVdVOw/5z+u5ugSkL4Zv6Q9xs335/efa9MV3K3KSTNOGXEXobgcmTWGXksccQoimQonKcDLzDK23pJV4k0HxD5nMPftoGWQ+h72AP/ceTEOKFxg+QRdnqyGK6bCsEro5EgXD0AMVGhyHmr01lS1ZNQMaUPxyf36SP+1qZJV6BV98NjI/oapPs5Bhi5mLq06tKe+IgMw+r4g4pjPB7dooaBs5lyf7/2VTLPfm7T8+zcGRQZWu+2i ROfm1ud/ uwORzijHmmbr7wgZJGaxWff7FpGAUbJnyTc04hJ92MonteRKHmVi/LldwOt4/lI7e7AN5mjnCSXZnmZahPPqcaRIKbE/dW3Y2Ol3hfsBzkI3HI3IKTpMJRHLdIqislxkevWNp4xiblOrVTePgSefp1//pNhwX/cOCD+o19KvMdE3vaMbc7Z/N8/vXh55L82oIp1QP4eT3DYaX+N2B6AOMRmdSr5X9J23UFGOl0tZNxLwo+dw9KasK2VTS6441kjXR99ZJVdu/PNU8e+6UlGCerSA00Y6XOF7oL1PwjT6G9m1LQDFAnE6ho6PKgrZYkxxcP66cVe2x3+FH9sImYRoZBt9HnzELpJ0/SOMmJwP65X+ziIPc9bQLQJ5evrMA5CYAqAs+D9F140yWpDZPEfucp5eAlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 3 May 2024 09:08:21 -0700 Nathan Chancellor wrote: > This patch has effectively been sent four times now: > > https://lore.kernel.org/all/20220914101829.82000-1-jiapeng.chong@linux.alibaba.com/ > https://lore.kernel.org/all/20230217084647.50471-1-jiapeng.chong@linux.alibaba.com/ > https://lore.kernel.org/all/20230319132903.1702426-1-trix@redhat.com/ > https://lore.kernel.org/all/20240503095027.747838-1-visitorckw@gmail.com/ (this change obviously) > > Your first comment from the 2022 patch: > > They're not used now, but they will be in a release or two. > > I think a few releases have passed since then :) I don't personally care > if there is a solution here or not, as I don't test with W=1 (there's > enough to do at W=0 :P), but maybe it is time for either __maybe_unused > (as that strikes at the heart of the issue) or at the very least a > comment saying "hey, these functions are currently unused but there are > plans for them to be used, so don't remove them", rather than just > saying the status quo? We could just slap a #if 0 around them. But I don't think it'll kill us to have to type them in again one day ;)