From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DCCC4345F for ; Sat, 4 May 2024 22:45:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A95746B008A; Sat, 4 May 2024 18:45:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1F4A6B008C; Sat, 4 May 2024 18:45:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90D656B0092; Sat, 4 May 2024 18:45:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7142F6B008A for ; Sat, 4 May 2024 18:45:13 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C6F70A02C0 for ; Sat, 4 May 2024 22:45:12 +0000 (UTC) X-FDA: 82082195664.18.C81BAA4 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 94A7718000F for ; Sat, 4 May 2024 22:45:10 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Lut5JK1m; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714862711; a=rsa-sha256; cv=none; b=dcr0xaY5jFIwdnRfCYytOhf/dzMuf4KfK8dt2Qcafhaex05E8MIhs76OAWgNWlsjvt9kB4 HNKFx3pe4KgsbypYE0S4Q6rc9imy8zt2Tpzy1jHlBVt/aWyXwgLX6hcpjTBqpbq81I6gaX DbWbMuGKmLaQWqn6ArU7ndZxWQB9Fmc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Lut5JK1m; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714862711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=61UvVOEUXkxuISuz3+awZZ1Pt004ouQbolXgjYFrBbM=; b=5iEYHAu3rmOgeTSMmIe5vjRvFP7tUZwwpajtpYKPRdYJYiz69N/t+jijX5i6MDM1Rn8Wcj 2sCgRiAVFdP7TGQsgmsn8d3FYpm7Lxab2JCx5Kcy44IIIO8WUesKNgVkPvkxgrp4hERlAo DLeUFELRD2soa5qL52VsXpww4FAdV5A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0A873CE0219; Sat, 4 May 2024 22:45:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C08E1C072AA; Sat, 4 May 2024 22:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1714862706; bh=wIkMy/aIJUZBRpBNzcCyh4rgL2cxKhChqFeer1+RwGU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Lut5JK1mupwsPRhGO6YIdDjdnC/b8kg8ZJHfNpEYdeMWEDjOGYkaB44BbwsZe3H/H BEP0wrBqyFjQiavapKFEMa21bB9MGwkKEEXOGnnBwGPUGWwJFQNa7gYA3RSfqh06LD HinbaoRQkB9F3EnfFbRQ+hSnk9JXgcCDmkFSuL48= Date: Sat, 4 May 2024 15:44:55 -0700 From: Andrew Morton To: kernel test robot Cc: Song Liu , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [akpm-mm:mm-nonmm-unstable 80/82] kernel/watchdog_perf.c:282: warning: Function parameter or struct member 'str' not described in 'hardlockup_config_perf_event' Message-Id: <20240504154455.2ddd2cbc523698a270cca9c2@linux-foundation.org> In-Reply-To: <202405040851.2EgypmL1-lkp@intel.com> References: <202405040851.2EgypmL1-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: c53a7t7daayfoxirfz9zwarjc4ima353 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 94A7718000F X-HE-Tag: 1714862710-88744 X-HE-Meta: U2FsdGVkX1+gB7/z6/4sfPzZr9Zkn3KBSs2bPUnQtKXNpkQskYmOO3NhcJEZtnjifxa7/pkhgtQEHF0LUCxysz69I0ZK/LGJ6hydPplgjwJaiawOUVNbSXLEGr6+ONCGiI2m81Ho30yER+H+NYPdUfHa4/dgdjTtk/BUZI2aHID62J+BY8EmyrbfANU8keTTos6B2S2AiVG5dUh5pTHTiA2BrxOoFWuBzWIWhfgocJT8yw/woNa+I01lADuVjbf9BbbMH9TYY1zG9RFJCg9u7YjuKZyJUSXqRWWEGuwF3XA+hpRnqbl0+JdU0PxQrijEzFAymKsR6EJuH7dwFRXs551rNQGSKkSGzoe0YN8/4DaoiuTpNaycKY1+2i7KEBbDWuEqAPPyNjNbEUll6Sn+vsEgGKJdrU7+bZN8bydpiDXU4cKt5n1j7cUpO2nb93NGZQKPbmhP5wBYgJzug5tanLP4Owww5HdjM1t3gsLAqu5u7fcF7FcnDFdGZLVYGW9tq/ksnfguPqDFJOnNnJqaZYe5GnYLSAQzsXyKxMUwsMqdmB9T7cTJOf9Jt0IgYc0t9vjyLgMNiq0vtkW/Ao6yBXDsKsTuCyiVSiizrdrkPOXWFS75nnY6PSkyrWl5U/LVL2XV3Q7X9iRqmgZIlep/4aB1/XVNDjY1TR9N2jy9ib2C+YoZAoAOuY6Dn4crnD7sW8aujecQRIgIIk1BJJcl7XO0uLTD22mXXcugf9nfv2WdUd563ILEd4EQXiIZAFV25MOlakd5ElvU6rChz9oAj1/FB06AEVK/aQoBfmQ/x8Qk4Zb1/Cd6eeNHVqRImFMpDFxcU7ZiQH3NRW7AdqdwY+NqSMlO7WBoj1hpQdx0yvphNVe3QgcrZyWRLHNhN0xXIJzUZvPre5r6B0bcPFV6IWc+zN3b0mtrnl6OxjNRDICdlZ+rcE07/ihrWnMweLOU9v01wk2PKjqxlrqnCxU tG8LYph0 5ag18euqB1hwRly8aWoyGQPZh3iN3yszwWrdEu9hD5EXNlX5kVc8MHPQMrEz1Ls7mkQTcSG/WZrDFw7eGwWGRfvrG7AeIJq9iDpMrHXBlO9kXrdyfvp0LGCJoAPKCOlRhnBHiVa0n1u5nBrj2qE4Z/00FnEcokR8jO5zJUof71TND5Gah1f/5b45kBQHPAW0KxBAq6hS7oRKVDaeih0XPUR3KSdk5X0lJ6/tbqETuhQmIk/UZt7DtZFXjACiFWk4CL/6P8muoR3KLLAtFiFmRsKtn0/q/8h1gPxIsRIHofwva4n0O0u1YVSxb+egF6s2qOEsJ5l5gOIejReyXyKtSbKlw/4UzSVGTzuaogiz8HQaBpomrPbvVsLfg+u1fFWhFpnWENjVPLg51I22yUK7Gk3rkAkF2LwBUQXGq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 4 May 2024 08:38:45 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable > head: 2ce87845f9106e693ba6d72cc95af6c86dc52d98 > commit: 96dca662f6d64b4d31ad186ea1464e9b25d749c3 [80/82] watchdog: allow nmi watchdog to use raw perf event > config: x86_64-buildonly-randconfig-003-20240504 (https://download.01.org/0day-ci/archive/20240504/202405040851.2EgypmL1-lkp@intel.com/config) > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240504/202405040851.2EgypmL1-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202405040851.2EgypmL1-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> kernel/watchdog_perf.c:282: warning: Function parameter or struct member 'str' not described in 'hardlockup_config_perf_event' > > > vim +282 kernel/watchdog_perf.c > > 277 > 278 /** > 279 * hardlockup_config_perf_event - Overwrite config of wd_hw_attr. > 280 */ > 281 void __init hardlockup_config_perf_event(const char *str) > > 282 { Thanks, how does this look? --- a/kernel/watchdog_perf.c~watchdog-allow-nmi-watchdog-to-use-raw-perf-event-fix +++ a/kernel/watchdog_perf.c @@ -277,6 +277,8 @@ int __init watchdog_hardlockup_probe(voi /** * hardlockup_config_perf_event - Overwrite config of wd_hw_attr. + * + * @str: number which identifies the raw perf event to use */ void __init hardlockup_config_perf_event(const char *str) { _