* Re: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat
2024-05-02 18:50 ` [PATCH v2 1/1] " Usama Arif
@ 2024-05-02 23:28 ` Nhat Pham
2024-05-03 8:20 ` Bagas Sanjaya
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Nhat Pham @ 2024-05-02 23:28 UTC (permalink / raw)
To: Usama Arif
Cc: hannes, tj, lizefan.x, corbet, linux-mm, cgroups, linux-doc,
linux-kernel, kernel-team
On Thu, May 2, 2024 at 11:53 AM Usama Arif <usamaarif642@gmail.com> wrote:
>
> This includes zswpin, zswpout and zswpwb.
>
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>
> ---
> Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
> pglazyfreed (npn)
> Amount of reclaimed lazyfree pages
>
> + zswpin
> + Number of pages moved in to memory from zswap.
nit: into?
> +
> + zswpout
> + Number of pages moved out of memory to zswap.
> +
> + zswpwb
> + Number of pages written from zswap to swap.
> +
> thp_fault_alloc (npn)
> Number of transparent hugepages which were allocated to satisfy
> a page fault. This counter is not present when CONFIG_TRANSPARENT_HUGEPAGE
> --
> 2.43.0
>
That very small nit aside, LGTM. Thanks for completing the documentation.
Acked-by: Nhat Pham <nphamcs@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat
2024-05-02 18:50 ` [PATCH v2 1/1] " Usama Arif
2024-05-02 23:28 ` Nhat Pham
@ 2024-05-03 8:20 ` Bagas Sanjaya
2024-05-03 14:54 ` Johannes Weiner
2024-05-09 16:53 ` Jonathan Corbet
3 siblings, 0 replies; 6+ messages in thread
From: Bagas Sanjaya @ 2024-05-03 8:20 UTC (permalink / raw)
To: Usama Arif, hannes, tj, lizefan.x, nphamcs, corbet
Cc: linux-mm, cgroups, linux-doc, linux-kernel, kernel-team
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Thu, May 02, 2024 at 07:50:24PM +0100, Usama Arif wrote:
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
> pglazyfreed (npn)
> Amount of reclaimed lazyfree pages
>
> + zswpin
> + Number of pages moved in to memory from zswap.
> +
> + zswpout
> + Number of pages moved out of memory to zswap.
> +
> + zswpwb
> + Number of pages written from zswap to swap.
> +
> thp_fault_alloc (npn)
> Number of transparent hugepages which were allocated to satisfy
> a page fault. This counter is not present when CONFIG_TRANSPARENT_HUGEPAGE
LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat
2024-05-02 18:50 ` [PATCH v2 1/1] " Usama Arif
2024-05-02 23:28 ` Nhat Pham
2024-05-03 8:20 ` Bagas Sanjaya
@ 2024-05-03 14:54 ` Johannes Weiner
2024-05-09 16:53 ` Jonathan Corbet
3 siblings, 0 replies; 6+ messages in thread
From: Johannes Weiner @ 2024-05-03 14:54 UTC (permalink / raw)
To: Usama Arif
Cc: tj, lizefan.x, nphamcs, corbet, linux-mm, cgroups, linux-doc,
linux-kernel, kernel-team
On Thu, May 02, 2024 at 07:50:24PM +0100, Usama Arif wrote:
> This includes zswpin, zswpout and zswpwb.
>
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat
2024-05-02 18:50 ` [PATCH v2 1/1] " Usama Arif
` (2 preceding siblings ...)
2024-05-03 14:54 ` Johannes Weiner
@ 2024-05-09 16:53 ` Jonathan Corbet
3 siblings, 0 replies; 6+ messages in thread
From: Jonathan Corbet @ 2024-05-09 16:53 UTC (permalink / raw)
To: Usama Arif, hannes, tj, lizefan.x, nphamcs
Cc: linux-mm, cgroups, linux-doc, linux-kernel, kernel-team, Usama Arif
Usama Arif <usamaarif642@gmail.com> writes:
> This includes zswpin, zswpout and zswpwb.
>
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>
> ---
> Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
> pglazyfreed (npn)
> Amount of reclaimed lazyfree pages
>
> + zswpin
> + Number of pages moved in to memory from zswap.
> +
> + zswpout
> + Number of pages moved out of memory to zswap.
> +
> + zswpwb
> + Number of pages written from zswap to swap.
> +
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 6+ messages in thread