From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F7C8C4345F for ; Fri, 3 May 2024 09:31:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD1AA6B0096; Fri, 3 May 2024 05:31:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B824D6B0098; Fri, 3 May 2024 05:31:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A229E6B0099; Fri, 3 May 2024 05:31:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 83E036B0096 for ; Fri, 3 May 2024 05:31:34 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0F2D740D7E for ; Fri, 3 May 2024 09:31:34 +0000 (UTC) X-FDA: 82076566908.22.BA783ED Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id D41DD18001B for ; Fri, 3 May 2024 09:31:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KWs22mke; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zgTS9KJj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KWs22mke; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zgTS9KJj; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714728692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T1ZkI43ouhbZimT/6Sz/nQ9W4boKtYozaB6hBMysMKE=; b=D03sfLtA56AweuczFdomemOOd+G90qB3AWPGsDxFWqpbQDw2S5+bQH3+FVs86M4/tXFPWX elO/Wg/gzkCnoB/e+PrK2Df5zOVAm9UmM2FNXkizKNTdigesc/iO60m2hT9thV3CJxWWDX jcqGoHtLyzVRLXIDcsImV7SsDgtv9gc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714728692; a=rsa-sha256; cv=none; b=1sE/HDUEhwlFHP9PiAvcTcAU2Horji3XmWdfAg218fhd8VOzs+Pdx4ePoYUQJXqbmiYhMT 34AdlPxMn5pHPk6qwBwClk2H7YF8bxXIn9S6v2MqXHkioTFOKVEJMWieeX/O1gQvdDEzOJ CQg2pTLgsksmWHILpTeQt6L+I0B96mo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KWs22mke; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zgTS9KJj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KWs22mke; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zgTS9KJj; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 75E24336D0; Fri, 3 May 2024 09:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714728690; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T1ZkI43ouhbZimT/6Sz/nQ9W4boKtYozaB6hBMysMKE=; b=KWs22mke9uaE7QySPC4EkPDeE+dueH0WTYyUZMx4GAiNIzNsHy9KKRBDwslrT8TLMm1HxD zeapumC745oRo9QQyEMD+j8x/YV+Vq5r+eYH3O2DxD/7/jvtNyXQCUbCpPaPsCtANRGJTm FEQylR04QxJBiFPdfaZ/+OGtlsMap4k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714728690; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T1ZkI43ouhbZimT/6Sz/nQ9W4boKtYozaB6hBMysMKE=; b=zgTS9KJjYD1/sY6qc8iUMd4jwopzfuHTIKYMrcU5kR63QesMiyBb9gtJdB6F5c2KQYvaiG nxIviKrSk5y0eNAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714728690; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T1ZkI43ouhbZimT/6Sz/nQ9W4boKtYozaB6hBMysMKE=; b=KWs22mke9uaE7QySPC4EkPDeE+dueH0WTYyUZMx4GAiNIzNsHy9KKRBDwslrT8TLMm1HxD zeapumC745oRo9QQyEMD+j8x/YV+Vq5r+eYH3O2DxD/7/jvtNyXQCUbCpPaPsCtANRGJTm FEQylR04QxJBiFPdfaZ/+OGtlsMap4k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714728690; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T1ZkI43ouhbZimT/6Sz/nQ9W4boKtYozaB6hBMysMKE=; b=zgTS9KJjYD1/sY6qc8iUMd4jwopzfuHTIKYMrcU5kR63QesMiyBb9gtJdB6F5c2KQYvaiG nxIviKrSk5y0eNAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6C6E9139CB; Fri, 3 May 2024 09:31:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aB53GvKuNGaqMgAAD6G6ig (envelope-from ); Fri, 03 May 2024 09:31:30 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 365ECA0A12; Fri, 3 May 2024 11:31:30 +0200 (CEST) Date: Fri, 3 May 2024 11:31:30 +0200 From: Jan Kara To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, tj@kernel.org, jack@suse.cz, hcochran@kernelspring.com, axboe@kernel.dk, mszeredi@redhat.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] mm: remove stale comment __folio_mark_dirty Message-ID: <20240503093130.kxbolkashbezb2sx@quack3> References: <20240425131724.36778-1-shikemeng@huaweicloud.com> <20240425131724.36778-5-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425131724.36778-5-shikemeng@huaweicloud.com> X-Rspam-User: X-Stat-Signature: yaobrunwas1aapzen4kj56k1sm66adrr X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D41DD18001B X-HE-Tag: 1714728691-440802 X-HE-Meta: U2FsdGVkX1/MTHOaSerhd/mYcX1k6N7sdzsgYQ4g+KmWzjL90H/cUB+Fyyf/10DM939By0ynjxzpqEoHcKZg8TwLl5WBqhddCYy6PKFp2/cWqBj/wpdU7oUN0Z/tTJykSqF4MVnFeQ3IYvdhemHrnEa7euSYUo4LRoPUgjccAYSt9P0d34kEEtTZ8rhtDbRlrOw0okp+hDq3ArOCXTCZenEapFe4m3KwY8T3ErvQxbXoDJWbHhCuKdQQzcvZ3TIfRnrUHOGKk+12b9JIfSBCr+GFfnk7uWp3AwbwgaH3sKJOLDvfpCoB726Xgp47lC+RyAK8b+L8RCUQC3HmCKPrQSQbsq2NSydlyq/xwaT9Y1GZlPoU+aGNrMDDhojHLnO5Wamq+BHm4HxKHCB55sy2+OxX6EQFARvToQW4V4IRQjNgBZn3UvOXVBnfCfjwBJvLr5qqrqMjm86N1HSHaifnqDye82Aa/GavbJnArlzNc4YYs13mshPOuvAqvpHbTrzvVvoBCnbOeUpZtBL99ndZbHkjpBkA0FMVgcumSyn6Z8HkyRm4a1EsgmEqQiadNprbSBvGsj6PPxWgZ0FU39CuDF9FpvOgwetdzYeZNYo2lygFI49FJMEa61blnecW9x0efYYgrVQqbZPej0+NtA0mnDx4oJeiT9TWSybKUnI8lfVacS7Ug/F2wH183aiFXavRYCyhucsUBMWktOdkMXbpDTZ1KhDb6L6Jfu7nUKXd2Vdl897Rz08GangZ20jzlidsRYGs2KyEGle/hg6MSrPllmE+/+t1EC42VxDZITrEEBckOk+Gz9wQYJvLmcnXhHE71I67POoWjDzyi6n0WlbzXtGq3s7ZeyCBJ8ak3vauowKjWS5ptN3LtsJzzhQNcJw3IQFyFlgZiLdD/phAYjoL5FT8/ysvkfFZLqOH+j0nzurfGP5pUz1Coo4z3/589znqnotyRFehp8Gg2TSRhT0 Kcfgf/wr vWyqCiN/8wYHxru0L3vjq8FGLCMvDKRK40OKvD/e2v8soqwptNuLJL0bfxX4RWbuADeW8pkZ6TwfuHnUWKDTpg0KZaJK3kSXha5JNrj/3Zfz2EUicBwmsdEhNHfamkKphjPMu1nYt6GY8Ne3dHQ7k3gzEt3LKFleby1s2sE7+PV/6UP5D4hmM+30pcE2yhHGGyuOHcnBdtR3xsEQC8ty5ohPqpO40NgE7+mDN8m80H7eatGGz8IeL378Cg3tgAVq1zWO+e9syYS7mZz++fbg3WSblwqxcwPcLb5aYe7bsMl/Fffsym7nt23qDRx1PepfD6rqD0Z0QjceSIlZoy0WUc8axm8vxfSaRqRSieHCxEaAcuuqurdxyOg4zBcwWxkxhWsqQE1ONjTbAb8vg1VR7GqQFxwgyp6HhklyigLSNRCTe6M/GG7z5BpwZbh6kMFa00Mdu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 25-04-24 21:17:24, Kemeng Shi wrote: > The __folio_mark_dirty will not mark inode dirty any longer. Remove the > stale comment of it. > > Signed-off-by: Kemeng Shi > Reviewed-by: Matthew Wilcox (Oracle) Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 22e1acec899e..692c0da04cbd 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2721,8 +2721,7 @@ void folio_account_cleaned(struct folio *folio, struct bdi_writeback *wb) > } > > /* > - * Mark the folio dirty, and set it dirty in the page cache, and mark > - * the inode dirty. > + * Mark the folio dirty, and set it dirty in the page cache. > * > * If warn is true, then emit a warning if the folio is not uptodate and has > * not been truncated. > -- > 2.30.0 > -- Jan Kara SUSE Labs, CR