From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C73C4345F for ; Fri, 3 May 2024 09:31:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 282826B0088; Fri, 3 May 2024 05:31:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2328E6B0093; Fri, 3 May 2024 05:31:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D2606B0095; Fri, 3 May 2024 05:31:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E1BE76B0088 for ; Fri, 3 May 2024 05:31:26 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5B0D0C1046 for ; Fri, 3 May 2024 09:31:26 +0000 (UTC) X-FDA: 82076566572.20.9583760 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf24.hostedemail.com (Postfix) with ESMTP id 17FDC18000D for ; Fri, 3 May 2024 09:31:23 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Fo3Gasdm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=J9+Xtyq3; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ax0ntS1G; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Q0B1ph2D; dmarc=none; spf=pass (imf24.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714728684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FQLsjALtF8Dtf2dnf/M68oWEcW8pNv5BhZPogrR45fk=; b=uFtinbcSdDwhvhb5drwFUwlnirWW+Hj4PLT1lIjR9FTb/zJE3QaGsS97fA5RU3k6Emxmcw qqAFvzi8mPHRs4s1eBFgzttpmMNb9zI1XN46cqmzoCPEYR5826VA8fSoB6RxxlWZ0pXhjk OiRh8GgKmgUwPn0poWW+aeRt+570WxQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714728684; a=rsa-sha256; cv=none; b=q/mZfeI2TCLsrZvave0WgEd/rIieAQzKc+/sPAFPt382kBtS3ae6FKxW4WuCZzrvD0LIHV 5p6dxHSCwRjGMLUxMD7t0vklXr75x7gP0ANyjmCLF2opguCo8nnMv9LUWFsc3fR3fXpzQz DjYm747lqbgyOwkMpo3Pl3KRVqiJeDI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Fo3Gasdm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=J9+Xtyq3; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ax0ntS1G; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Q0B1ph2D; dmarc=none; spf=pass (imf24.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4958920002; Fri, 3 May 2024 09:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714728682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FQLsjALtF8Dtf2dnf/M68oWEcW8pNv5BhZPogrR45fk=; b=Fo3GasdmI/w2XYV+lWiI3ZTLoS7TPis247itBZfBT7p4cb0j4aRi6uKL7KV+tFoxi3FjLC YzI7vXyoREZlNuwyMfZ1B9APr5i3EQPdabNyzLhaoVyW7gVbVf5dMJR8VdBwItjEOYspmu IV1izz/KPN8rYT7ByKwcyJXfJAAUxkw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714728682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FQLsjALtF8Dtf2dnf/M68oWEcW8pNv5BhZPogrR45fk=; b=J9+Xtyq3R/qge9xbc65qxhonMt9b2smjsqeQ1fwJjoIz8lErIatZstpb0ZUPlZwY7lwsim wo28StX4/lJyv4BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714728681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FQLsjALtF8Dtf2dnf/M68oWEcW8pNv5BhZPogrR45fk=; b=ax0ntS1GXzWM2nK4IbPmigJIwDNtELCjSAb7YpvvKaZq+oVb5PSr6Xg4V0hC4kbZV4l2PC xzmibNkDOXgy2WrgugIrS1rliANiHfqfxirmKGA1yrOwvyHBXQkEdPZtOJyzov3O21Sy3u 7NZlkrEv2S35FIHsfMU5AotPunmOQPk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714728681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FQLsjALtF8Dtf2dnf/M68oWEcW8pNv5BhZPogrR45fk=; b=Q0B1ph2DL2HjHzFBldKprMx5fGpYptya5mIigYIbEHvzzk91PC/MIfT+219ijMRvfyYmWb TzBggLKtcDB502Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3959E139CB; Fri, 3 May 2024 09:31:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id L7/5DemuNGalMgAAD6G6ig (envelope-from ); Fri, 03 May 2024 09:31:21 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 00723A0A12; Fri, 3 May 2024 11:31:16 +0200 (CEST) Date: Fri, 3 May 2024 11:31:16 +0200 From: Jan Kara To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, tj@kernel.org, jack@suse.cz, hcochran@kernelspring.com, axboe@kernel.dk, mszeredi@redhat.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] mm: call __wb_calc_thresh instead of wb_calc_thresh in wb_over_bg_thresh Message-ID: <20240503093116.jwur3sb3rwnjsin3@quack3> References: <20240425131724.36778-1-shikemeng@huaweicloud.com> <20240425131724.36778-4-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425131724.36778-4-shikemeng@huaweicloud.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 17FDC18000D X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: wzz3xtaxzdfmecesj6d3soe5uerieurd X-HE-Tag: 1714728683-581577 X-HE-Meta: U2FsdGVkX1/e+xQbiKKVFnhkPXct/2cqsRNUZAo7OMvZ/NYC88ObsaeD1cH4gub4FnY4sZnTQcqn1Ep/VDI/9FhXx6Vra4MA1DazULMlADKtu0MN1jFPindgrhrf4Qgg2JY1bw80AdvVeG4HRU4V+zNFXAeTZFcPM2eX3pTmdYXQW35qQ6lpsg1QHpooL7x5ybKjSMftkVtWQr7EPPfpR5c+ta45kJTNhkcPWO0Bx5/JzXZtgYqccV454C0CaCZYNZxq64Bt65vRJ9N3mhsFVpDdUzfx7eqhQcN1brcgPRT68oyBsgwlgesDQ6vw3uF+j7g7oC7IPHQIifqfC4T1qRgP8VpZgkpZDwpmQq1gkHGx6sH8pwRHbY7xZ4ECJvaR2sndMPoVYz2wMOxkjg0vaoYe+WATV+PHB3bznCUQh1vcmspo9vKOu5HtY67yBzoQVEej5YoRK+ODHXLbz2Q5z0OjpDQ4+8HLTeDQrj9QbrPLGcDuB11AP+fnPQG04tNC3Bl5RP50B9BGPxiYWVLY8MzhoXwBxF5ePK6ihuYwnckMy53l1ac9dK5EA581L5wbPEF6m1eUf3dRkYKUD8UUB2jTG0NMWkG3/4Ca746EogsjivtwFvc0w7s1JbQKqBmgCKcIeaEzqeiyhQm/cRRlDVX+gDz858XfuX0H2/o9SHKl9PB0QeDWQRCjDYAgM9dZuZjCmnFjznBZ7Qk2oZRbFrHtLMgtGnpvesgY8VrXZxD0l1xPTw67pp1V5Y3IMNLrSsryc94O5pmXe9s5uyOXySAJkOurFIx8he/3xlrfdxV+R4b9e3yQ4Tw72gtiW3GMYdgacsyo5nfcB4ERF/LpvRdajLEYCS7gtx17QXTIeOQEWwsNpgsJJe9b6UkCtab22TQ+emKwVrZnGxDrzeouLdEKZgTU22obg3rxKuLhNGwy0pONdYEGb9zYgLfONaepvffazksBQjViVh911gW XQOHopGi 0gE5IFK8PRzSdc78iC9zxlpU0LMnKZU9vHWuKftCmBGMu3177sAaFyYM72WAGDbLQmzIWWZkcBYU+RFEl2IDW7cIenSm0B7ER+VUgj/kki+t/+wHARbD4LfYi9jaYzEBDDlKxvvzr8KgvKgIzN3uZr9sf6xIckiLfhQi+BFsoJdyE4G+MEEo0jF3+/cvqKUOb3jOukjrHDaWs8X0+2q57DXz+CESHDeGxq9HiWz48K9C4r4o4Q/Tk9ZZH3xp45lW7OpjmYy21/oSc4DGtsgz/xt1HJiaCLo1+QPRZ7HywOS7qAq8qm8xOQ62LxExAvU4y5K5IsWdffq/9QcPvLHEx+b7kRmzLICRLozrsLPgLrNuEzmtyTYKhWi6G4NEk1wQ/VvJM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 25-04-24 21:17:23, Kemeng Shi wrote: > Call __wb_calc_thresh to calculate wb bg_thresh of gdtc in > wb_over_bg_thresh to remove unnecessary wrap in wb_calc_thresh. > > Signed-off-by: Kemeng Shi Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 14893b20d38c..22e1acec899e 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2117,7 +2117,7 @@ bool wb_over_bg_thresh(struct bdi_writeback *wb) > if (gdtc->dirty > gdtc->bg_thresh) > return true; > > - thresh = wb_calc_thresh(gdtc->wb, gdtc->bg_thresh); > + thresh = __wb_calc_thresh(gdtc, gdtc->bg_thresh); > if (thresh < 2 * wb_stat_error()) > reclaimable = wb_stat_sum(wb, WB_RECLAIMABLE); > else > -- > 2.30.0 > -- Jan Kara SUSE Labs, CR