* [PATCH v1 0/1] selftest/mseal fix arm build
@ 2024-05-02 22:53 jeffxu
2024-05-02 22:53 ` [PATCH v1 1/1] selftest mm/mseal: " jeffxu
0 siblings, 1 reply; 3+ messages in thread
From: jeffxu @ 2024-05-02 22:53 UTC (permalink / raw)
To: ryan.roberts
Cc: Liam.Howlett, akpm, corbet, dave.hansen, deraadt, gregkh, groeck,
jannh, jeffxu, jeffxu, jorgelo, keescook, linux-hardening,
linux-kernel, linux-kselftest, linux-mm, merimus, pedro.falcato,
rdunlap, sroettger, surenb, torvalds, usama.anjum, willy
From: Jeff Xu <jeffxu@chromium.org>
This is followup on arm build failure reported by
Ryan Roberts [1]
I don't have right setup to repro the issue, so would need some
help to verify this in arm build.
[1] https://lore.kernel.org/lkml/f797fbde-ffb7-44b0-8af6-4ed2ec47eac1@arm.com/
Jeff Xu (1):
selftest mm/mseal: fix arm build
tools/testing/selftests/mm/mseal_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.45.0.rc1.225.g2a3ae87e7f-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1 1/1] selftest mm/mseal: fix arm build
2024-05-02 22:53 [PATCH v1 0/1] selftest/mseal fix arm build jeffxu
@ 2024-05-02 22:53 ` jeffxu
2024-05-03 11:00 ` Ryan Roberts
0 siblings, 1 reply; 3+ messages in thread
From: jeffxu @ 2024-05-02 22:53 UTC (permalink / raw)
To: ryan.roberts
Cc: Liam.Howlett, akpm, corbet, dave.hansen, deraadt, gregkh, groeck,
jannh, jeffxu, jeffxu, jorgelo, keescook, linux-hardening,
linux-kernel, linux-kselftest, linux-mm, merimus, pedro.falcato,
rdunlap, sroettger, surenb, torvalds, usama.anjum, willy
From: Jeff Xu <jeffxu@chromium.org>
add include linux/mman.h to fix arm build
fix a typo
Signed-off-by: Jeff Xu <jeffxu@chromium.org>
Suggested-by: Ryan Roberts <ryan.roberts@arm.com>
---
tools/testing/selftests/mm/mseal_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
index ca8dbee0c612..41998cf1dcf5 100644
--- a/tools/testing/selftests/mm/mseal_test.c
+++ b/tools/testing/selftests/mm/mseal_test.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
#define _GNU_SOURCE
+#include <linux/mman.h>
#include <sys/mman.h>
#include <stdint.h>
#include <unistd.h>
@@ -29,7 +30,7 @@
# define PKEY_DISABLE_WRITE 0x2
#endif
-#ifndef PKEY_BITS_PER_KEY
+#ifndef PKEY_BITS_PER_PKEY
#define PKEY_BITS_PER_PKEY 2
#endif
--
2.45.0.rc1.225.g2a3ae87e7f-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] selftest mm/mseal: fix arm build
2024-05-02 22:53 ` [PATCH v1 1/1] selftest mm/mseal: " jeffxu
@ 2024-05-03 11:00 ` Ryan Roberts
0 siblings, 0 replies; 3+ messages in thread
From: Ryan Roberts @ 2024-05-03 11:00 UTC (permalink / raw)
To: jeffxu, Aishwarya TCV
Cc: Liam.Howlett, akpm, corbet, dave.hansen, deraadt, gregkh, groeck,
jannh, jeffxu, jorgelo, keescook, linux-hardening, linux-kernel,
linux-kselftest, linux-mm, merimus, pedro.falcato, rdunlap,
sroettger, surenb, torvalds, usama.anjum, willy
On 02/05/2024 23:53, jeffxu@chromium.org wrote:
> From: Jeff Xu <jeffxu@chromium.org>
>
> add include linux/mman.h to fix arm build
> fix a typo
>
> Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> Suggested-by: Ryan Roberts <ryan.roberts@arm.com>
I confirm this has fixed our issue. Thanks!
Tested-by: Ryan Roberts <ryan.roberts@arm.com>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
> tools/testing/selftests/mm/mseal_test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> index ca8dbee0c612..41998cf1dcf5 100644
> --- a/tools/testing/selftests/mm/mseal_test.c
> +++ b/tools/testing/selftests/mm/mseal_test.c
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> #define _GNU_SOURCE
> +#include <linux/mman.h>
> #include <sys/mman.h>
> #include <stdint.h>
> #include <unistd.h>
> @@ -29,7 +30,7 @@
> # define PKEY_DISABLE_WRITE 0x2
> #endif
>
> -#ifndef PKEY_BITS_PER_KEY
> +#ifndef PKEY_BITS_PER_PKEY
> #define PKEY_BITS_PER_PKEY 2
> #endif
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-03 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-02 22:53 [PATCH v1 0/1] selftest/mseal fix arm build jeffxu
2024-05-02 22:53 ` [PATCH v1 1/1] selftest mm/mseal: " jeffxu
2024-05-03 11:00 ` Ryan Roberts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox