From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF931C4345F for ; Thu, 2 May 2024 22:40:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C43D6B0083; Thu, 2 May 2024 18:40:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 574EC6B0085; Thu, 2 May 2024 18:40:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 418646B0088; Thu, 2 May 2024 18:40:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 17CB46B0083 for ; Thu, 2 May 2024 18:40:04 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5CC93404C1 for ; Thu, 2 May 2024 22:40:03 +0000 (UTC) X-FDA: 82074925086.30.C9D16C3 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf14.hostedemail.com (Postfix) with ESMTP id 702CC100004 for ; Thu, 2 May 2024 22:40:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=C0iHij7K; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714689601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XFKejRkpdUqALs7RRbss3x8E7ytYFe91um4evBhxt90=; b=OFhxO89CsgZLoDZ1GBkAtAiTWpeEESO54CBcSUBfAZizdk/xR2+WBkchbY1WGI0Ri+USOn yp2hXgsAy8MemM5GnMOygCVNEM05adLFdLEO7Te769VjhWHavXFJBhhKEJC6U6JvSUVXap X6EfNewJdNKpBa4fhmiemFosi6NnI8E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714689601; a=rsa-sha256; cv=none; b=ModArEbtS0ptQXscCSj8pITuZ2rB79YEdxfN16NooQrEQMDOuqQjIkpUvXwAnrIzJMK0Jg cq9MR1Xl14iqwqiPUkxVs5nrw8mK/wYzsjtWRkxDGetEKV8omY4jUXFBlgbClxGOBBC3yZ Qm677DlInyLqJfvAhn+ZzPD7QAXY+Jk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=C0iHij7K; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6ed5109d924so7310913b3a.0 for ; Thu, 02 May 2024 15:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714689600; x=1715294400; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=XFKejRkpdUqALs7RRbss3x8E7ytYFe91um4evBhxt90=; b=C0iHij7KUpW2x11f+wTYtY0feh327kwAhbYvzikoF+wj0FtyF/72Ga+BHanGE4E87I 2Kiex0A7i1pck5Q0kR2QJVB8qZDFsIbp0j29ARbbKqzn7FnOkBjbQluxfenGHfRPR0As 3060KRe9aJqtTYlI2F51/GsKfPo0NKya7Jggc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714689600; x=1715294400; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XFKejRkpdUqALs7RRbss3x8E7ytYFe91um4evBhxt90=; b=eA5RvfPgwCvzVg/eKd8XfpX+AyJ18RRgApzlydIVxH1+eAi2olVxoVtoqecgrSWW6k 1NIMC/QL7Fce2blZgJo/qSEm92LRicX4jMnSuVRAFChhPrj3q6DmRf7YWXlYOpcWH1Ev dk1EWmqVKp2VlT0itTVPMvICEqTs5H7y0a99vR1iHyRbVDP5rin3HmurVKTvG4tm/Z6L 6v59dUOHbPs1zkpWW2zRhoIYtLVhDCbbC5CLld9rnk5zHS92IQFMSi6u31cM62tTRRGD jtmyVLdr6LEHrDAiAsWhq+0ftaFFJa+czmp5qdqSO5sytwKeR+tXoLkGXnWJIjDExw4n rR1w== X-Forwarded-Encrypted: i=1; AJvYcCWnygskBDitAy4sJmw3PTdi/h/2aR4dZGQoQjsh6mk2qlYUn7jtf3ia5DIRtSvsKfG0V7a2YIQbD27gUpiQr1IQIUI= X-Gm-Message-State: AOJu0YwhnGj+00f9xonnlWiq3oVLUVGuA1a40YpYFOQo11S5ckonQqQ5 Gy88eVwRY01pYAJydLtfDwOP+YSz0Y1ZNcTCedWCSIfwafzvANYmlVMUJBDLAg== X-Google-Smtp-Source: AGHT+IHZDYwJNE5fvscmVtdk5iGObl1CECGz4gO/Q2ayHOFmZuu6/FcbgJ5RUF+ig7m6xnqqjSb0qA== X-Received: by 2002:a05:6a21:b10:b0:1ad:6e6:b4c7 with SMTP id lr16-20020a056a210b1000b001ad06e6b4c7mr898849pzb.46.1714689600376; Thu, 02 May 2024 15:40:00 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id w11-20020aa7858b000000b006efd89cea71sm1784753pfn.84.2024.05.02.15.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 15:39:59 -0700 (PDT) Date: Thu, 2 May 2024 15:39:59 -0700 From: Kees Cook To: Muhammad Usama Anjum Cc: kernel test robot , Edward Liaw , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Andy Lutomirski , Axel Rasmussen , Bill Wendling , David Hildenbrand , Justin Stitt , "Mike Rapoport (IBM)" , Nathan Chancellor , Nick Desaulniers , Peter Xu , Shuah Khan , Will Drewry , linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: Re: [linus:master] [selftests/harness] 8092162335: kernel-selftests.sgx.make.fail Message-ID: <202405021539.F08251ED5C@keescook> References: <202404301040.3bea5782-oliver.sang@intel.com> <202405011330.85D66871E@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: s9jeqpe5b989cbe8niym7969wuephqbx X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 702CC100004 X-HE-Tag: 1714689601-383611 X-HE-Meta: U2FsdGVkX1++YXs6ML1jie6/wDPz7yX0d9P0K7qaNN8ikHFJRUl8AXBSbwklyUulgbpC3Ow9gVQ0OlI6a4286c8RYIFcvJb0upT0rx3eheJS086REy/zCqCgYiwuSKXOqR1jeVD3i+xwlU30WumCclsFgvMh99pbFQN0Eccnn+tSpfGmHTQ/83bTwk0p53QyhQY/mPdbJyYvUh1UkS967cFmif04pZEbFg3NoFSdfXnIdvnGqIQPfLyRf3xI8SEMb7hHQiFWYzM+Wwirs9UHfKGj1s/m7MXQzeSN4DmRUOglySxLyApOCmHb/GRm5GyZFqC3ba679UywYkSQ3AwvKCWfWZth9Oqwlc1QBydPN4OJQ3iBb2WQjHG1I9z/uEVHvW+08y0dNWfSKMrI69pBurCVqHGmEHn4te2ytMVzKynByTdrsVnHLRCqxOCPduJFDh+Nt1yoZMc6d54YAmwzz9BMvlW182i2n57z3PSAb/F1GrX7v6a5+t4c1Q00k2mLK1qnwJkJdF5BrUv0yDweuW5ts72lrJvOzh9rpTgBGoc9Q4ELIEf733YMmTq2ejaJQj2DdWhOBUbRtPpkHGAX1ubISRLy+HXL6/KOvoqKEtKR9/SKsEC37ti0BKJOuVIl6wMmd+QnbCSiH4k9gszDLegiL4GdLlcFFTKQPbt4or9Pq6dAcfYnWrVxIinXww6pqj4kJyVABQcrZ8XTKAEsD4ya0aTt/bgdUydc/JPArsRpxVuCgkkNKilBuNKg2qT0mgA4gNLXIM2LpvCe8KwQcaXL4Qz81WFXta3lsKALNONMrK1FB8en/IZg3c/1bGycBAzxST+BOs/La+kOfHUs8yF0ravplQ2VsUo3l/x2mqAfFukzOU9VMiXtmkC84l9UDJQ9y8SS5CkzWgT8R1QT68ssHpT7TWj1uAKqb2Vhsc0vMSuri9n72CzHojC0IcE3S0iMzjMvJb51rp0rDqu kTRHhNRV no/in9R0sN5kvtymI4zTU+9lsiTlcyfpJydhC2e1VwYDFGY8OILDP6KBA7MMv00mGyqKo1yAofC7ER6CTiEaRFqOKe4KQ/WcdIfSxJJinrO0uB2Htr5EGo2h66FdqGiAaPcHZ7++d0GY4LYVv5FXZgs3smV5qEVwgD6/hwqB5yClCQHuPmmP/R/9GnlwOd9llhd37/Itl++CgTBxPH0Hni/3ZiWbom2qGNENKVpV79KkcLVUAuuvQKKqjNNnIhOio8KlpSGtgGT/RR65bSp4SReVXElqaHx8KyFdIs4iKjjm+3vpHa+YtBrnamPCV5Wo/58BIinNZT/YkoaM7EvsSy83QhiKD9jtsvURi+5+L5uSOpqBN0e2RrRZrMiiO5M4rS9biDHMGmQ4CEDZCp6I/XiBfskCXgstsRKY+ORM6oHECXsxtb/yweaowWTVmgk+/aJcXWRNclmP9XMM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 02, 2024 at 11:33:17AM +0500, Muhammad Usama Anjum wrote: > On 5/2/24 1:32 AM, Kees Cook wrote: > > On Tue, Apr 30, 2024 at 11:02:36AM +0800, kernel test robot wrote: > >> version: kernel-selftests-x86_64-c7864053-1_20240419 > >> [...] > >> compiler: gcc-13 > >> 2024-04-29 15:02:59 make -j16 -C sgx > >> [...] > >> gcc -Wall -Werror -static-pie -nostdlib -ffreestanding -fPIE -fno-stack-protector -mrdrnd -I/usr/src/perf_selftests-x86_64-rhel-8.3-kselftests-8092162335554c8ef5e7f50eff68aa9cfbdbf865/tools/testing/selftests/../../../tools/include test_encl.c test_encl_bootstrap.S -o /usr/src/perf_selftests-x86_64-rhel-8.3-kselftests-8092162335554c8ef5e7f50eff68aa9cfbdbf865/tools/testing/selftests/sgx/test_encl.elf -Wl,-T,test_encl.lds,--build-id=none > >> /usr/bin/ld: warning: /tmp/lkp/cct4g3SV.o: missing .note.GNU-stack section implies executable stack > >> /usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker > >> In file included from main.c:21: > >> ../kselftest_harness.h: In function ‘__run_test’: > >> ../kselftest_harness.h:1166:13: error: implicit declaration of function ‘asprintf’; did you mean ‘vsprintf’? [-Werror=implicit-function-declaration] > >> 1166 | if (asprintf(&test_name, "%s%s%s.%s", f->name, > >> | ^~~~~~~~ > >> | vsprintf > >> cc1: all warnings being treated as errors > > > > What environment is this being built in? "asprintf" should be available > > via stdio.h, and "kselftest_harness.h" includes that (and _GNU_SOURCE). > Sometimes the order of include is as following: > > #inlucde > #define _GNU_SOURCE > #inlucde Oh, ew. Yeah, I see what you mean. > The _GNU_SOURCE wasn't defined the first time stdio.h was included hence > the definition of asprintf isn't present. The second inclusion of stdio.h > when _GNU_SOURCE is defined is ignored as it was already included. > > This is being fixed in following series: > https://lore.kernel.org/all/20240430235057.1351993-1-edliaw@google.com I'll comment there. Thanks! -- Kees Cook