From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592D4C4345F for ; Thu, 2 May 2024 00:02:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98BCA6B0085; Wed, 1 May 2024 20:02:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93BB16B0087; Wed, 1 May 2024 20:02:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82A566B0088; Wed, 1 May 2024 20:02:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 66D4C6B0085 for ; Wed, 1 May 2024 20:02:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1034416060F for ; Thu, 2 May 2024 00:02:58 +0000 (UTC) X-FDA: 82071505236.19.3D71F43 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf24.hostedemail.com (Postfix) with ESMTP id 2CECF18000D for ; Thu, 2 May 2024 00:02:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=cOAW+aeJ; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf24.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714608176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iBNgjATm1g/dvs/mF70E3zaHDPEr1jQSRo6dBQGN4Yc=; b=hb2F/ljwn4gmSvUbaMPejKslEfjhP4NCB746SEH+sTKq7IyBv4eiTExMsqrJQoHdpILNHw 3o8Igc+mBouHdKUSfX3jGSjZZWGigPwAL4aRPtAN9OXHDKx/UROX8g+kiSblvHEsr1VdXz ETkqPv5hNy39nAV+Sr5uxCFFJ6/97ME= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=cOAW+aeJ; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf24.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714608176; a=rsa-sha256; cv=none; b=uXlM5tbWF7sNXZHmMPN99Y1B5VIzrogjuDXpM6ZxRj86+z4NzeW/vmkjpsTc2ID847Lbbu 5b5cMcWutnC34M4Mim5QY8V48j40dMVVNzqtavkwxN04OmKP+r909ja9ZB5eqbWCSQ8koE Z8Vq1SaO6iAxksRm3tXq3GCiRepmjf4= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 441NKAPw010464; Thu, 2 May 2024 00:02:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2023-11-20; bh=iBNgjATm1g/dvs/mF70E3zaHDPEr1jQSRo6dBQGN4Yc=; b=cOAW+aeJW6MGxJkg049vVzz2Zzrb8XnTgk5GVZgHLiP74GRfVHXxw7mt9e2OxPnwPT8R t3+s32yTrY/ROVhL2IlZ1BJixpwJMqTOJhPM2JSztBbn2Sq16rfeuex6hKuxwpNHlsK8 1SC4qfcynTe3dxcCdxXZOmlwnvGwixyZdzlITCGCTuholKSh1CQP6x6cAUO6j8vYpNee P5BU2EzhcktlZAo6gYwGm9bGcwpcMl9JbDSh/kLwk1ePIgpiMWlXygpHMp/LcAjs8GL6 uq++DN7DScLxq5wM5tN4bqMK6X1YvKjOvm5L10vZbUZWZUPh8zN4QGvrk9zRU4+JcoWt dQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xrsdetpj7-261 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 May 2024 00:02:47 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 441MBS4E033172; Wed, 1 May 2024 23:25:12 GMT Received: from brm-x62-16.us.oracle.com (brm-x62-16.us.oracle.com [10.80.150.37]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3xrqt9vbuq-4; Wed, 01 May 2024 23:25:12 +0000 From: Jane Chu To: linmiaohe@huawei.com, nao.horiguchi@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] mm/memory-failure: send SIGBUS in the event of thp split fail Date: Wed, 1 May 2024 17:24:58 -0600 Message-Id: <20240501232458.3919593-4-jane.chu@oracle.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240501232458.3919593-1-jane.chu@oracle.com> References: <20240501232458.3919593-1-jane.chu@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-01_16,2024-04-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2405010165 X-Proofpoint-GUID: ovlQb9iG_YSm1K2_mAapQrq0LojExnvH X-Proofpoint-ORIG-GUID: ovlQb9iG_YSm1K2_mAapQrq0LojExnvH X-Rspamd-Server: rspam01 X-Stat-Signature: 44rtwzj9uounof7ak3wztc8gwyfwws95 X-Rspam-User: X-Rspamd-Queue-Id: 2CECF18000D X-HE-Tag: 1714608175-53951 X-HE-Meta: U2FsdGVkX1+b20HCveFRWKiHrwVZzCODftaUP3L+tu83vnOu09gJlDypUT4wSiBGsBb2/7LmczMDA7IIkx6np66ZP+LtIxSgH6Xtwnoj4JEsn7YJ3JmANLOL3jGTcZCnJZDUDyoEA6fEj6M/Np66uUmYya7i9eUnYw0mezf1jIj7GNG2gTYfaNR3AIQxGooBDzJX5hGde+48DuIxWLT+XxsmhmkT04GJzxct5oNSO81D02wVv3mmnGlgwEe4OGOJYydkJtOd0oYVZ56Yx9Y0+2WCS+QDLWX1p8wMPmz1NrffHO535sukEWV6o/eBCQIEXGWk1gkh+tekRUlDYT1m8XpsuxcBEcEm2HLLkBBUSLH0KA04jBn4JoODnsujJcbuFCn/qQ2v7Pap5+tY10SqmXbaiFmqkGBUHEl0Qirw/uKdQhTm4qOaUlrVIkvdAd1a97ZSzNvJVOhuBKd71w6ZlSEFnpV2ADZe8xvnwYXcyA9GUo2aObMJbXNi+uP0JG09Y6chkAP6YLjg2y2jAINfUOYq2vcDPOCj2509zRzw2KfHXzBXAhE9VroDg2TOjf/q5jfQXwaTcxsRI6/QHySuQYqkQ0/f4c6ucj9sL9sYDv7nL4Dk/CkqI6dQNIrdiK+/vmxcI+Zvag/9Zg37HJVl3AG2YKATTARgJtpjIZMgfrbMvzsP7ZcTI7vbHJZtqV2j/UuYZkeSb4oP5kLpBuWVPO5EEEM9cDfcI43gCD+T4o+iiQs8MDyv42KDdyOWZvp4gvTnKVr6P+cPQxUjtOs0M7+fK2IVkUoov+lTNrGw+hXXDnRMNy1ByZSvD9WjOp8CMoNfWklISQLpyvA23FOFWzWO+tcsy71n51mBc+TPBNjNHFamq6u9coJ7YN4qVBSwXT6gRjxStndirtLUnNShPG9cfKxy9icBzaaPSIPFwnxWnWOON4xed67o2xf47mjje9fxNT81iEB721TvOv9 NCOatGXR nZI7tH3j+iqDi+M2BKeQSRNLzym6KP2wb4xiAlUo0hH34KLY9Br5pPGvHKKsHu/Ev/A9HuECUNZJiPIfiGwRhekDMUP/AC/EWrj5Uz76VZBubf7RgPLiYbsMeoNlltUolROV55bYZ/9DOBooitY3431XgvRLRg/ohMxOs+ikQP3QA3Qy4IbYs7lq0oegZlGDKlYfqiWIYQj+wjTShBXN11xtBlqE4+T3nnL7RFIzAUEhkYsCieERGfsXKGO7O8NG5GoQk6kM0b0mEt5I6/udFBUrzeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When handle hwpoison in a GUP longterm pin'ed thp page, try_to_split_thp_page() will fail. And at this point, there is little else the kernel could do except sending a SIGBUS to the user process, thus give it a chance to recover. Signed-off-by: Jane Chu --- mm/memory-failure.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 7fcf182abb96..67f4d24a98e7 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2168,6 +2168,37 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, return rc; } +/* + * The calling condition is as such: thp split failed, page might have + * been GUP longterm pinned, not much can be done for recovery. + * But a SIGBUS should be delivered with vaddr provided so that the user + * application has a chance to recover. Also, application processes' + * election for MCE early killed will be honored. + */ +static int kill_procs_now(struct page *p, unsigned long pfn, int flags, + struct page *hpage) +{ + struct folio *folio = page_folio(hpage); + LIST_HEAD(tokill); + int res = -EHWPOISON; + + /* deal with user pages only */ + if (PageReserved(p) || PageSlab(p) || PageTable(p) || PageOffline(p)) + res = -EBUSY; + if (!(PageLRU(hpage) || PageHuge(p))) + res = -EBUSY; + + if (res == -EHWPOISON) { + collect_procs(folio, p, &tokill, flags & MF_ACTION_REQUIRED); + kill_procs(&tokill, true, pfn, flags); + } + + if (flags & MF_COUNT_INCREASED) + put_page(p); + + return res; +} + /** * memory_failure - Handle memory failure of a page. * @pfn: Page Number of the corrupted page @@ -2297,6 +2328,11 @@ int memory_failure(unsigned long pfn, int flags) */ SetPageHasHWPoisoned(hpage); if (try_to_split_thp_page(p) < 0) { + if (flags & MF_ACTION_REQUIRED) { + pr_err("%#lx: thp split failed\n", pfn); + res = kill_procs_now(p, pfn, flags, hpage); + goto unlock_mutex; + } res = action_result(pfn, MF_MSG_UNSPLIT_THP, MF_IGNORED); goto unlock_mutex; } -- 2.39.3