From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 965D5C4345F for ; Wed, 1 May 2024 15:21:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC8776B0082; Wed, 1 May 2024 11:21:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E508A6B0083; Wed, 1 May 2024 11:21:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCAA26B0085; Wed, 1 May 2024 11:21:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AF99A6B0082 for ; Wed, 1 May 2024 11:21:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 50747120A4C for ; Wed, 1 May 2024 15:21:34 +0000 (UTC) X-FDA: 82070191308.16.4CCF948 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf11.hostedemail.com (Postfix) with ESMTP id EC2BC40025 for ; Wed, 1 May 2024 15:21:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ls3lW+Sa; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714576892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=TZaQjmuc3UONzpLI3gUvo8t2dRWirBxT7Rx9rgyUHjg=; b=WIRGU002R7mCwS1O9KVhh8aYPUZZj6gOjvoslF3KRi+4El43ZaZa/uEmlQG/WaUugUPF4t sEY4zE2uLFN8FTG95Hw13VG2KoSZ9YJMM0y5+q3K23vzixUvqj1XROHaQokrIIn2kB0OzN QS+BKWfDSXwcAniLOVxAzGGMoe/uyXc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714576892; a=rsa-sha256; cv=none; b=C3pQQToY3lk+RHKm4fAsDpac6BBnnjG9qdZKXlBs4QN9+Iz8gYXp/efuD7p1U/lJpBq6ph KYuKCgB33BhoWvKt8SF+Dp+WdMb9uWeAEdHMyJJZ+0xcZ7iFeT+AUdtKt1Ml8tSEXpTC4C gy2ehMDUbfxX/TeLsv74xZBSxipXXVc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ls3lW+Sa; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714576891; x=1746112891; h=date:from:to:cc:subject:message-id:mime-version; bh=9Sz5/Z1YyM3d+xRuPOKVQ148iXowdxcZBT5enqfQkIQ=; b=Ls3lW+SaG1zuW7Ym0eCF3tECpwRlBNdZY7sIO5002bwg2ATmuqEj3cK1 CrMzY8WMKFj92EXaWepw+pvggDJgTKLXrHGNIUWQ39fWGZVTrGBT46zf7 hNO0eEkMW5VibdGMqpm9PgR2OhApsORKvdNKCqUGdc2SMvWmS4i04kKaC EsTIuGlETuhUSDgsKVh97lgFkdh4fEeEXYClqblJ7XIYIvtrGdPrVS+mJ kLnhv8VsL6PpTzAE0mM2kCa1/X3xsiCThaxbduWpVeof1GfDyxVST/j3U A09qGchZoSnDQ+OFBpHf+lLZ6KZ6JWWBRlUONhXkNTEEB3tCnBx5M+mkT Q==; X-CSE-ConnectionGUID: +Z5JgtGmSx2n5sMh9ZizBw== X-CSE-MsgGUID: Unk566AtQiebC5N2vf/CuQ== X-IronPort-AV: E=McAfee;i="6600,9927,11061"; a="14085787" X-IronPort-AV: E=Sophos;i="6.07,245,1708416000"; d="scan'208";a="14085787" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2024 08:21:29 -0700 X-CSE-ConnectionGUID: EF1BwJYTTEqaF9xhx/RYWQ== X-CSE-MsgGUID: pMeJdbH4SvCjQrpL7tHQJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,245,1708416000"; d="scan'208";a="57700492" Received: from lkp-server01.sh.intel.com (HELO e434dd42e5a1) ([10.239.97.150]) by orviesa002.jf.intel.com with ESMTP; 01 May 2024 08:21:27 -0700 Received: from kbuild by e434dd42e5a1 with local (Exim 4.96) (envelope-from ) id 1s2Blt-0009fK-0S; Wed, 01 May 2024 15:21:25 +0000 Date: Wed, 1 May 2024 23:20:35 +0800 From: kernel test robot To: Likun Gao Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alex Deucher , Hawking Zhang Subject: [linux-next:master 9762/10134] drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:235: warning: Function parameter or struct member 'job' not described in 'sdma_v7_0_ring_emit_ib' Message-ID: <202405012302.cOj1BNI5-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Stat-Signature: dotyo55dex9q1w8p9wnhg1njuxxygzx4 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EC2BC40025 X-HE-Tag: 1714576890-46555 X-HE-Meta: U2FsdGVkX18fDJZ/WXQB2ZIBM9aFCl4dCbMHksiwbFZj3UFIF0V+E2WLHFY/lXQSg3Gs/S+W7OFHTdE3bt/5E5Gi3uBPYZwURtcWRAz5/jHr23dUHunUkaS4X8YcU/A2ZqcGzQWUU5X88zrJVn1ugmxegQO9yreXjTqnUZliKfPjAC7EpN5X5Dx7C1sKZXZKfwDCPZ5qGwqNX6Fott3kZ+ZrIfEyj5LEwr2WC2eCzntzgE+R06+y3MM/NRay5hn46Tj5ykU+ITt0sK1U79kDuM7+MvPI6E2AsbszdBwK5JJyXe8TFPCT76vwxAZx/tNhGoIKbHhU4uJvYG+YW7VruIERgqwBQMdTfUKxOme6Q4vdE+lW86Fstz4AIImSVMHZtnFqYTNIzok2TNLySLxBcFP7Es/Ot0T47L55AvXxNwbOirtc4/ouR+nWd73GKMGcl5ESxdorKMvLvQjv99lE6z/22VAlFUefSgivVNN32hr56gbt/kxmhGKIqzdMk2WG1CZepXPdsrFLYj9qjvxhRyqZaFZhSkSTBcaziQ8yYWT0bEZmxz3KTrvDQzgaz8UvSHT8PGf2dwiIQ4cJmkRPvhJyLtECVQhAq1uSnnTv3B7RnZ+bFvwUs0XKZF/I5XjysIc3PgLkey2c3fEH+p3qDBWx/nGlivZG91mpbSrtW8JA9b6yLRD7+UCW1wz7iWlrXe4n3qMBP1RDvU2SnpQbRQ1RGspJX/VvwY7Zwbcb4wOP6UdpVoIUO8Y4tQXc+DXV2Hy4NpbRy+JVGA8+S1Fg2X9tVzisvv334blA1RmgKD7EfH746v1sy8CruaQ/wfULbPs/L9CX27O6WUZSWBy63faZrQjS9K3Y0oIfadjSvAEkEgdMSeMT4EXrXRPYTfKgj2OmhoiUl0YfDAm2ht/Gw1fQTx0jyA+F9TMolXmcfJYGRt4PWaC5bnVXWpPlsD9b2sRZXCS9//XbJlJZ/jT Ivx/o52q 74YocMtmlqdD7WaAn9XzmbH7xU6ZPpMnoED7aM5Y6DLCqX6GTjN8jfKf3KC4ZCqbZRhWSxFevmphKFj5pVfxo7XW9AMUZMeczwvklsNMIJoXZ6Pu9u6dT14b2W0K2PeIENwuxKPMbym3zujLhroSNVerJ7AbMYOJQTec2EeKhSg0zoRSjEKxG2mmFZzdld0XzLcno/UaBju7bJ0trL8v7f3vX4Oe0g/5KS8/kJavGSygUfUjcA58J81btTZNH59FKGoTK6XpdFbltIZDNP7WLQP7TCnw4jN81GyriSF0AXCxmNPDbtnWlqN44kN2tv7azUQpUTU6b3dpu9xQJsPamF4R2HFjo+/GB+CKH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: f68868ba718e30594165879cc3020607165b0761 commit: b412351e91bde3a6ec546b598087bdc3fcc458ee [9762/10134] drm/amdgpu: Add sdma v7_0 ip block support (v7) config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240501/202405012302.cOj1BNI5-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240501/202405012302.cOj1BNI5-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202405012302.cOj1BNI5-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:235: warning: Function parameter or struct member 'job' not described in 'sdma_v7_0_ring_emit_ib' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:235: warning: Function parameter or struct member 'flags' not described in 'sdma_v7_0_ring_emit_ib' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:269: warning: Excess function parameter 'job' description in 'sdma_v7_0_ring_emit_mem_sync' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:269: warning: Excess function parameter 'ib' description in 'sdma_v7_0_ring_emit_mem_sync' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:324: warning: Function parameter or struct member 'addr' not described in 'sdma_v7_0_ring_emit_fence' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:324: warning: Function parameter or struct member 'seq' not described in 'sdma_v7_0_ring_emit_fence' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:324: warning: Function parameter or struct member 'flags' not described in 'sdma_v7_0_ring_emit_fence' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:324: warning: Excess function parameter 'fence' description in 'sdma_v7_0_ring_emit_fence' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:915: warning: Function parameter or struct member 'timeout' not described in 'sdma_v7_0_ring_test_ib' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1043: warning: Function parameter or struct member 'value' not described in 'sdma_v7_0_vm_write_pte' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1043: warning: Excess function parameter 'addr' description in 'sdma_v7_0_vm_write_pte' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1043: warning: Excess function parameter 'flags' description in 'sdma_v7_0_vm_write_pte' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1095: warning: Function parameter or struct member 'ring' not described in 'sdma_v7_0_ring_pad_ib' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1147: warning: Function parameter or struct member 'vmid' not described in 'sdma_v7_0_ring_emit_vm_flush' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1147: warning: Function parameter or struct member 'pd_addr' not described in 'sdma_v7_0_ring_emit_vm_flush' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1147: warning: Excess function parameter 'vm' description in 'sdma_v7_0_ring_emit_vm_flush' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1555: warning: Function parameter or struct member 'ib' not described in 'sdma_v7_0_emit_copy_buffer' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1555: warning: Excess function parameter 'ring' description in 'sdma_v7_0_emit_copy_buffer' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1581: warning: Function parameter or struct member 'ib' not described in 'sdma_v7_0_emit_fill_buffer' >> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c:1581: warning: Excess function parameter 'ring' description in 'sdma_v7_0_emit_fill_buffer' vim +235 drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c 222 223 /** 224 * sdma_v7_0_ring_emit_ib - Schedule an IB on the DMA engine 225 * 226 * @ring: amdgpu ring pointer 227 * @ib: IB object to schedule 228 * 229 * Schedule an IB in the DMA ring. 230 */ 231 static void sdma_v7_0_ring_emit_ib(struct amdgpu_ring *ring, 232 struct amdgpu_job *job, 233 struct amdgpu_ib *ib, 234 uint32_t flags) > 235 { 236 unsigned vmid = AMDGPU_JOB_GET_VMID(job); 237 uint64_t csa_mc_addr = amdgpu_sdma_get_csa_mc_addr(ring, vmid); 238 239 /* An IB packet must end on a 8 DW boundary--the next dword 240 * must be on a 8-dword boundary. Our IB packet below is 6 241 * dwords long, thus add x number of NOPs, such that, in 242 * modular arithmetic, 243 * wptr + 6 + x = 8k, k >= 0, which in C is, 244 * (wptr + 6 + x) % 8 = 0. 245 * The expression below, is a solution of x. 246 */ 247 sdma_v7_0_ring_insert_nop(ring, (2 - lower_32_bits(ring->wptr)) & 7); 248 249 amdgpu_ring_write(ring, SDMA_PKT_COPY_LINEAR_HEADER_OP(SDMA_OP_INDIRECT) | 250 SDMA_PKT_INDIRECT_HEADER_VMID(vmid & 0xf)); 251 /* base must be 32 byte aligned */ 252 amdgpu_ring_write(ring, lower_32_bits(ib->gpu_addr) & 0xffffffe0); 253 amdgpu_ring_write(ring, upper_32_bits(ib->gpu_addr)); 254 amdgpu_ring_write(ring, ib->length_dw); 255 amdgpu_ring_write(ring, lower_32_bits(csa_mc_addr)); 256 amdgpu_ring_write(ring, upper_32_bits(csa_mc_addr)); 257 } 258 259 /** 260 * sdma_v7_0_ring_emit_mem_sync - flush the IB by graphics cache rinse 261 * 262 * @ring: amdgpu ring pointer 263 * @job: job to retrieve vmid from 264 * @ib: IB object to schedule 265 * 266 * flush the IB by graphics cache rinse. 267 */ 268 static void sdma_v7_0_ring_emit_mem_sync(struct amdgpu_ring *ring) > 269 { 270 uint32_t gcr_cntl = SDMA_GCR_GL2_INV | SDMA_GCR_GL2_WB | SDMA_GCR_GLM_INV | 271 SDMA_GCR_GL1_INV | SDMA_GCR_GLV_INV | SDMA_GCR_GLK_INV | 272 SDMA_GCR_GLI_INV(1); 273 274 /* flush entire cache L0/L1/L2, this can be optimized by performance requirement */ 275 amdgpu_ring_write(ring, SDMA_PKT_COPY_LINEAR_HEADER_OP(SDMA_OP_GCR_REQ)); 276 amdgpu_ring_write(ring, SDMA_PKT_GCR_REQ_PAYLOAD1_BASE_VA_31_7(0)); 277 amdgpu_ring_write(ring, SDMA_PKT_GCR_REQ_PAYLOAD2_GCR_CONTROL_15_0(gcr_cntl) | 278 SDMA_PKT_GCR_REQ_PAYLOAD2_BASE_VA_47_32(0)); 279 amdgpu_ring_write(ring, SDMA_PKT_GCR_REQ_PAYLOAD3_LIMIT_VA_31_7(0) | 280 SDMA_PKT_GCR_REQ_PAYLOAD3_GCR_CONTROL_18_16(gcr_cntl >> 16)); 281 amdgpu_ring_write(ring, SDMA_PKT_GCR_REQ_PAYLOAD4_LIMIT_VA_47_32(0) | 282 SDMA_PKT_GCR_REQ_PAYLOAD4_VMID(0)); 283 } 284 285 286 /** 287 * sdma_v7_0_ring_emit_hdp_flush - emit an hdp flush on the DMA ring 288 * 289 * @ring: amdgpu ring pointer 290 * 291 * Emit an hdp flush packet on the requested DMA ring. 292 */ 293 static void sdma_v7_0_ring_emit_hdp_flush(struct amdgpu_ring *ring) 294 { 295 struct amdgpu_device *adev = ring->adev; 296 u32 ref_and_mask = 0; 297 const struct nbio_hdp_flush_reg *nbio_hf_reg = adev->nbio.hdp_flush_reg; 298 299 ref_and_mask = nbio_hf_reg->ref_and_mask_sdma0 << ring->me; 300 301 amdgpu_ring_write(ring, SDMA_PKT_COPY_LINEAR_HEADER_OP(SDMA_OP_POLL_REGMEM) | 302 SDMA_PKT_POLL_REGMEM_HEADER_HDP_FLUSH(1) | 303 SDMA_PKT_POLL_REGMEM_HEADER_FUNC(3)); /* == */ 304 amdgpu_ring_write(ring, (adev->nbio.funcs->get_hdp_flush_done_offset(adev)) << 2); 305 amdgpu_ring_write(ring, (adev->nbio.funcs->get_hdp_flush_req_offset(adev)) << 2); 306 amdgpu_ring_write(ring, ref_and_mask); /* reference */ 307 amdgpu_ring_write(ring, ref_and_mask); /* mask */ 308 amdgpu_ring_write(ring, SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT(0xfff) | 309 SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(10)); /* retry count, poll interval */ 310 } 311 312 /** 313 * sdma_v7_0_ring_emit_fence - emit a fence on the DMA ring 314 * 315 * @ring: amdgpu ring pointer 316 * @fence: amdgpu fence object 317 * 318 * Add a DMA fence packet to the ring to write 319 * the fence seq number and DMA trap packet to generate 320 * an interrupt if needed. 321 */ 322 static void sdma_v7_0_ring_emit_fence(struct amdgpu_ring *ring, u64 addr, u64 seq, 323 unsigned flags) > 324 { 325 bool write64bit = flags & AMDGPU_FENCE_FLAG_64BIT; 326 /* write the fence */ 327 amdgpu_ring_write(ring, SDMA_PKT_COPY_LINEAR_HEADER_OP(SDMA_OP_FENCE) | 328 SDMA_PKT_FENCE_HEADER_MTYPE(0x3)); /* Ucached(UC) */ 329 /* zero in first two bits */ 330 BUG_ON(addr & 0x3); 331 amdgpu_ring_write(ring, lower_32_bits(addr)); 332 amdgpu_ring_write(ring, upper_32_bits(addr)); 333 amdgpu_ring_write(ring, lower_32_bits(seq)); 334 335 /* optionally write high bits as well */ 336 if (write64bit) { 337 addr += 4; 338 amdgpu_ring_write(ring, SDMA_PKT_COPY_LINEAR_HEADER_OP(SDMA_OP_FENCE) | 339 SDMA_PKT_FENCE_HEADER_MTYPE(0x3)); 340 /* zero in first two bits */ 341 BUG_ON(addr & 0x3); 342 amdgpu_ring_write(ring, lower_32_bits(addr)); 343 amdgpu_ring_write(ring, upper_32_bits(addr)); 344 amdgpu_ring_write(ring, upper_32_bits(seq)); 345 } 346 347 if (flags & AMDGPU_FENCE_FLAG_INT) { 348 uint32_t ctx = ring->is_mes_queue ? 349 (ring->hw_queue_id | AMDGPU_FENCE_MES_QUEUE_FLAG) : 0; 350 /* generate an interrupt */ 351 amdgpu_ring_write(ring, SDMA_PKT_COPY_LINEAR_HEADER_OP(SDMA_OP_TRAP)); 352 amdgpu_ring_write(ring, SDMA_PKT_TRAP_INT_CONTEXT_INT_CONTEXT(ctx)); 353 } 354 } 355 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki