From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 004FDC4345F for ; Wed, 1 May 2024 16:08:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D2726B0083; Wed, 1 May 2024 12:08:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 482E96B0085; Wed, 1 May 2024 12:08:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34AF26B0087; Wed, 1 May 2024 12:08:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 167026B0083 for ; Wed, 1 May 2024 12:08:11 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8606AC0905 for ; Wed, 1 May 2024 16:08:10 +0000 (UTC) X-FDA: 82070308740.25.13CFC70 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 080DD14002D for ; Wed, 1 May 2024 16:08:07 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="AoJ5YH/M"; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714579688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ed0/M615snFNcJ9BDnnzSLRF5L6rBaUe+KQVQxDjZvQ=; b=XmPv6gkl+LY2ovGgtlZrFiMwYZoZP3Pz5bLbl3Vlaks4KbAK2SLUgdxYxobkf+AWnlBE2l hgbYQHhFRdxKmykS1piezl8A2u6KpAXak3QteyyO3nyGsr0eo/Fz9YXDiTyrsVYLD+vZOp g0SZV4CKeeKsGRBJ3RNt6JTD5sgEjy8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714579688; a=rsa-sha256; cv=none; b=MCOrxRVkOGc02lfaAoCA9SK6ycffa7Qj5nGZpcQFpKgdPMIfIQu003uKCLwZ3R/IAdFPkH iXt91Yz+01CE/urSCrm0B6KDgeRSpuw895Y0zMPWQVL7J+QcIybbv/wRifvj8Ji1zzKQe7 VrmsiY5CyARxSHDBbyz5g39DMuso47U= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="AoJ5YH/M"; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D2FCF6179A; Wed, 1 May 2024 16:08:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00C9DC113CC; Wed, 1 May 2024 16:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714579686; bh=mStrog2oMrxkyglXae6P8Wt6hb3v6cHyjuBTYN/mI7A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AoJ5YH/MqGf6uSCzNJ0ET0mIDAHqieqnDjfEjSGdAwHSC6WGhTEQjXMjXwxs6HcKG uvEsDHXWz7WT/EZbQn7uILo940XO1L5EBH4Ty60X1kftIIEGbpXEejp4jZv5ztg+Zx /gC+n5v6KvctbSy00csdX7/Ng02LV2G7CUlyMKjBXDOUBkgFxQKlhxyraUtPV3oyRA qKQAFEfpwZo0mGeVZojF9LMXkMLn/6A7aDx4t1mM+dGV2A1XzrDhbB4e5hukAN7DKc 9Gdr1TrHFnpalexcq+zWVEOY2jcMDL3255Sc9+wxUKOOtLuDsnhrGqzqtoNl9gDl6M iTXpNF6wbpJqg== From: SeongJae Park To: Lance Yang Cc: SeongJae Park , akpm@linux-foundation.org, willy@infradead.org, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] Reclaim lazyfree THP without splitting Date: Wed, 1 May 2024 09:08:03 -0700 Message-Id: <20240501160803.60988-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240501042700.83974-1-ioworker0@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: hbugb9k73f8kap7yewumpugkbocfq45r X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 080DD14002D X-HE-Tag: 1714579687-124319 X-HE-Meta: U2FsdGVkX1/L6G34K7YQWeWnzUYv1O9l8EyMSnzfCMgAw/+5NqqyvYvhgqwL2pyfN2tHp9+rXZiM5Qg5+nmkRIDDTU2NByht6XJKbRDD2lVu4YWVJ5c4NKnBd5pqo+7xC6GgAk3KV/YzpTzUdPhHN+1Pxli9ozavxCWzDFeinkdbRyWv6C4uj8OUXLOlKLhYaHpIJqiX5pt0e4cLfgRUx1XbYhVBl/Xlxu0hu2J35DVshTx/FsOfDVDw+YTwUWd4NGpWwL+4usFbr2Td5w5R934BE99jRmjWF2k4tlo6+zSCtMkbyJkTiddlfe4BdP35XMLBz8K1oW6laF58R7cCtfQBRYd2o3l8j7J70lcJiXd7+KJO7j5k4amJjmbalFwk7/1a5ie/gI3AjV397G1Z7LIdFwSqR1Xq7sfTH5lwmvsU5OCx7BOeHD4pkN89pa6lIXjsJuPW7TQv6fwsy9zM0Ugxw8iv3e7JUwl+dNiU568e7DeTc/HaEZr43NBq0tj0W/XXKaSVHpDsPuShAaR0r+g7iEqG4qoN/fQ2R1yzQGbcRZVZUask3CONNM7FO7Ppl8wfjRj3X/E8mfIjliQWB4AgRgJi+J3lenUeMlD5sklM0LwoUZg8LWLEdDnNZ/iFX4Y2dbpwDNVKjvkApz87HIX0c9LrlVvW0mRWURNYS/7mUPr0WBbSiJ43BG30ydfK2zkF2JyqI5t0uuxD7PxfSRhE+Wx0jBRms3C+gfUtemdM3rlCBmZcfCSLdxlfINk7BZYmIehBI47EU5tmvmVVfcHjb39fxNpcM72OYcwGm3BONo14c7P3+VYXWVvex/zDdwvOJELEazkIDi8qF95R+IWMF1TOAlq12jKjZ65+nAMVwzEfh0+rm3cH3+38tLCZ5ZChbNcHCJdJB2r51Xn5Iu01QhkNVXcLgWJgiR+TLhFgrRmhwsqw7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Lance, On Wed, 1 May 2024 12:26:57 +0800 Lance Yang wrote: > Hi all, > > This series adds support for reclaiming PMD-mapped THP marked as lazyfree > without needing to first split the large folio via split_huge_pmd_address(). > > When the user no longer requires the pages, they would use madvise(MADV_FREE) > to mark the pages as lazy free. Subsequently, they typically would not re-write > to that memory again. > > During memory reclaim, if we detect that the large folio and its PMD are both > still marked as clean and there are no unexpected references(such as GUP), so we > can just discard the memory lazily, improving the efficiency of memory > reclamation in this case. > > Performance Testing > =================== > > On an Intel i5 CPU, reclaiming 1GiB of lazyfree THPs using > mem_cgroup_force_empty() results in the following runtimes in seconds > (shorter is better): > > -------------------------------------------- > | Old | New | Change | > -------------------------------------------- > | 0.683426 | 0.049197 | -92.80% | > -------------------------------------------- > > --- > > Changes since v3 [3] > ==================== > - mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop > - Resolve compilation errors by handling the case where > CONFIG_PGTABLE_HAS_HUGE_LEAVES is undefined (thanks to SeongJae Park) I confirmed that the issue I reported before is disappeared with this version of the patchset. For the fix, Tested-by: SeongJae Park Thanks, SJ [...]