linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Vasant Hegde <vasant.hegde@amd.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Joerg Roedel <jroedel@suse.de>, Jason Gunthorpe <jgg@nvidia.com>
Subject: [linux-next:master 8395/9390] drivers/iommu/amd/pasid.c:172:17: error: implicit declaration of function 'mmu_notifier_unregister'; did you mean 'mmu_notifier_release'?
Date: Tue, 30 Apr 2024 05:12:52 +0800	[thread overview]
Message-ID: <202404300543.z8m1DMGM-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   b0a2c79c6f3590b74742cbbc76687014d47972d8
commit: a5a91e54846d35c234939fb9170e035805353049 [8395/9390] iommu/amd: Add SVA domain support
config: x86_64-randconfig-x061-20230629 (https://download.01.org/0day-ci/archive/20240430/202404300543.z8m1DMGM-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240430/202404300543.z8m1DMGM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404300543.z8m1DMGM-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/iommu/amd/pasid.c: In function 'iommu_sva_domain_free':
>> drivers/iommu/amd/pasid.c:172:17: error: implicit declaration of function 'mmu_notifier_unregister'; did you mean 'mmu_notifier_release'? [-Werror=implicit-function-declaration]
     172 |                 mmu_notifier_unregister(&sva_pdom->mn, domain->mm);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~
         |                 mmu_notifier_release
   drivers/iommu/amd/pasid.c: In function 'amd_iommu_domain_alloc_sva':
>> drivers/iommu/amd/pasid.c:195:15: error: implicit declaration of function 'mmu_notifier_register'; did you mean 'mmu_notifier_release'? [-Werror=implicit-function-declaration]
     195 |         ret = mmu_notifier_register(&pdom->mn, mm);
         |               ^~~~~~~~~~~~~~~~~~~~~
         |               mmu_notifier_release
   cc1: some warnings being treated as errors


vim +172 drivers/iommu/amd/pasid.c

   166	
   167	static void iommu_sva_domain_free(struct iommu_domain *domain)
   168	{
   169		struct protection_domain *sva_pdom = to_pdomain(domain);
   170	
   171		if (sva_pdom->mn.ops)
 > 172			mmu_notifier_unregister(&sva_pdom->mn, domain->mm);
   173	
   174		amd_iommu_domain_free(domain);
   175	}
   176	
   177	static const struct iommu_domain_ops amd_sva_domain_ops = {
   178		.set_dev_pasid = iommu_sva_set_dev_pasid,
   179		.free	       = iommu_sva_domain_free
   180	};
   181	
   182	struct iommu_domain *amd_iommu_domain_alloc_sva(struct device *dev,
   183							struct mm_struct *mm)
   184	{
   185		struct protection_domain *pdom;
   186		int ret;
   187	
   188		pdom = protection_domain_alloc(IOMMU_DOMAIN_SVA);
   189		if (!pdom)
   190			return ERR_PTR(-ENOMEM);
   191	
   192		pdom->domain.ops = &amd_sva_domain_ops;
   193		pdom->mn.ops = &sva_mn;
   194	
 > 195		ret = mmu_notifier_register(&pdom->mn, mm);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


                 reply	other threads:[~2024-04-29 21:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202404300543.z8m1DMGM-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jgg@nvidia.com \
    --cc=jroedel@suse.de \
    --cc=linux-mm@kvack.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=vasant.hegde@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox