From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A5AC04FFE for ; Tue, 30 Apr 2024 00:12:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CB0C6B0085; Mon, 29 Apr 2024 20:12:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1546A6B0087; Mon, 29 Apr 2024 20:12:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F36976B0088; Mon, 29 Apr 2024 20:12:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D4CDA6B0085 for ; Mon, 29 Apr 2024 20:12:07 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F233D160230 for ; Tue, 30 Apr 2024 00:12:06 +0000 (UTC) X-FDA: 82064270652.11.E699A4F Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 2E5FA40011 for ; Tue, 30 Apr 2024 00:12:04 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UAaQ1rwD; spf=pass (imf11.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714435925; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CvLTPVX0E9HJQ+Gv13G3h9zskNE9lllppjOwhN0LSj0=; b=v5+mGmkOjVdd6Yu5sa8uaP6BKw6HpVkhw9MAzWiGfiphem/w1poyPqmWmv0iCm1AnskrGO YLM2CXayhNiVt7sWiTIRtc1hluvcrt+5NRKseb2UP54NpoyV9BGCEOZ3lpQL/hHmtmrYeA 9dytFebotTe+7rRjoWGl8IgR0FvuzEk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UAaQ1rwD; spf=pass (imf11.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714435925; a=rsa-sha256; cv=none; b=rr9FR79aD/sJ/yJeNv74PJzae3tCCyCgLLG1JujMOUzLVBurdM3z4xkTa5lbJCB9BE5UjH bRdewxBQX3ZSirqvQvW8r5Y2AufjGaDG6DDTWBY9qB8HSSyeTSh7IPx0GIWT3RfJ8TGbU9 AXChrYDG5S26Rg72DNjYqXtpENm2ReI= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a58f1f36427so291053666b.3 for ; Mon, 29 Apr 2024 17:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714435923; x=1715040723; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CvLTPVX0E9HJQ+Gv13G3h9zskNE9lllppjOwhN0LSj0=; b=UAaQ1rwDm6exuCQGBXAXJreGtXEIO+MJWr1LnDXWEGPqUiuWWv05ruoM3R06YXajO3 vMfs/l8JmfIjKQdwFMWraQx9+5r061nBzO7iWHoEZBx6s5wKJJGSi3bqEoWc0T4mYd6H 9UZ5fCFK5xKO5nTlydb1WZz8jfpdnzBxTyzrRWoU5fFB/AZLDbBGE5KAs0P3sAAjyZBa 6wqPcT14awR/feCdtDX41e/WiqBw02BZBVZPns5YdzRWB2vc7G1wHOMpyUypwzmZD1nR JojKHW9xZA6xTyG+UIg2P7Ny5AHwqh5G/d2bsfAXAaFdrHmCD8sqHhOoNLabLOyHEvLB wMKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714435923; x=1715040723; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CvLTPVX0E9HJQ+Gv13G3h9zskNE9lllppjOwhN0LSj0=; b=Z2emKO2nk2yFmOKpu7nZo16mPlSeFaDPEiz22e08EBKQWDGMu1yV/bInyDFOcQlY2i muGH2ieY6sec0NlM+ogRBHhoWY1W2WzqJGMImWOBrPJyvdaXBszRuI+iNqztYCgbe2+q 8eovEY6p/UtwVxfvWuknT0M4377M1HkHmZu59jvLxnYgqAbt2Ge4F8dmNlPUwfTAQplg pSNQ8uDfIXppgOXHSEN9hPBjN/5r0tz9Gv+jaD7pPH4TpIYFeaYw5ovS6tI6s00H/1os HR/1G4kO2f8FcnRv74lesFzwM0HrFOKl/HIypPiha+lFKko40FohRGDPZFXq3nTfj68Q L7JQ== X-Forwarded-Encrypted: i=1; AJvYcCWdtNqdODVWUKdJrXiS5nLS/JmoRqC6+VeawZLgGAdBOFllGEEUIBPLDNoavFtkiRYYtUzKgQeorPu+FOXW/3PUNzY= X-Gm-Message-State: AOJu0YyNJejCOzC/+VTZKjyMtkh7wSweW4VTjNe/3gWQOjtKf61csIad mpr+9LRWCiDA+gb8yzA5UvB/l144TtTH9F8fVq++jx/Jx3vKpedF X-Google-Smtp-Source: AGHT+IGXJa+/OpzHIuwYIzjFPlQTiqOVfeLmpvl6QHPwvJPth0Qkb/G319nSUsQO2BFaH0wrd8CQ0A== X-Received: by 2002:a17:906:2bd3:b0:a55:65e6:ce9f with SMTP id n19-20020a1709062bd300b00a5565e6ce9fmr804708ejg.20.1714435923394; Mon, 29 Apr 2024 17:12:03 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id f24-20020a170906c09800b00a522f867697sm14364413ejz.132.2024.04.29.17.12.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2024 17:12:02 -0700 (PDT) Date: Tue, 30 Apr 2024 00:12:02 +0000 From: Wei Yang To: Mike Rapoport Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [Patch v2 1/8] memblock tests: reserve the 129th memory block at all possible position Message-ID: <20240430001202.tjs77i3fxbykw5rp@master> Reply-To: Wei Yang References: <20240425071929.18004-1-richard.weiyang@gmail.com> <20240425071929.18004-2-richard.weiyang@gmail.com> <20240428122204.4ecwvc2qxrstl6yv@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: 9jgb8muctdwf6zb97j573e8m7t7igdau X-Rspamd-Queue-Id: 2E5FA40011 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714435924-880626 X-HE-Meta: U2FsdGVkX1/cANzXdNT0mLlm04DLjD0xwLCT6a7J5Fx+QBaQx1VtPj1Fl3TkMWIWnm/e8OMffN9EJIVi3Y4SejQ+5MCAcHrmchZcR59dBwIepiVBOwqXFV2Na4Rl29n8g8MdWJN0cE80ouSZ2JxyvdZhJZyjZGiX0E7qsM2RwD0sEHcmd1vzGZrrqL06ZJBRwC7gN5+NT9WQrcrFLsVrOKt2cmNAiV7xJ+SDf/kGq2lHR27BZc2IKBhsWn5dgQQ7yuPNwDjCN7Ra2z+idyvNwGqaoPhen1WeeoNcBGBR1f5uOf6gPxAGn54tmD+zoQdjVAwlec7hMVBN7jfxlY5mPTQ7HLP++GPmseBVZU0KEwjvlDwYC8PKdETIe0a6kpWlCekk6CZHtci7j3V1pEfoFra+AFmZngo1wLK+elKKSfR1xy2agVA1OAi4JTc+KDdnbXkaZebJTLxJ6U78iMH6xwc71IH+wLMrWDVomRwm02720ShkSyKXl5+JRtI7GeZNjk6WrP+FpPZh2Rdgdlql+7Hf2JK8azjS9cxgxg5/BIeSoWEC+ZJyXDGLlWle+OMEGgEB5D2e9SwPzOerN7PD8FGGPSZtBC0AlR3Y5QaOA+/RzzoyrIsyz1+wHEWWQWbObmHJSs9eEPpQL6QiJNBQO+zLAFdCKPvnoaH43DwzAaH7uButJ6lO85W7U48rUzMA1aK2z9zlqUntFNKrQaoMZ+lCnnh412OdNQatN9pI+L8I2dSe+t6afa9iAri8BGm7gxdv1OKzqo2SlwgGRn7kJuJGvjVqtRGvBlIH7E+Wu1qDd/z99lTwvMBqO/jpPBSz31ngRcZVW/NWWIR1FTTDSE8DqzqzTBjCdfaZj5YTSAisDe7bB1hg1hC7205n2ceM7MvrYO4x6JEEhLzO9aQhnDV8OSJ1aIp6tDORRzXl1oAPjqSREy+zEAaEN6QthTA73QCLzh7O/r6rYsJ0pw4 xpEKFLDP dzA5fESGtjf8ZN6E6Og9jPj4G+ARrL4alfyR6h2W5okYYzkArhNXIC4shCT6eK6KQxUyv9vvaENkhx4pl/C/R7knopVsspCBfqsczgOT5BxV3MDI34Z1h+k0cGTXGjQ0H9RrQFRDZnBK0Bnd3+aZD8FYPt1TCoJeIco2vqH9zgNIyKw7OQRWDyaelbc2w/gZklvATTA0enuffD7d6b8PipHRHL+yl5Qyg8DtktKjNc0ErPP1xeCCohnZYSwYeOujrI6+TOzDmdV1w4aAWw7b/thAuvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001364, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 05:17:19PM +0300, Mike Rapoport wrote: >On Sun, Apr 28, 2024 at 12:22:04PM +0000, Wei Yang wrote: >> On Sun, Apr 28, 2024 at 09:35:25AM +0300, Mike Rapoport wrote: >> >On Thu, Apr 25, 2024 at 07:19:22AM +0000, Wei Yang wrote: >> >> In stead of add 129th memory block at the last position, let's try all >> >> possible position. >> > >> >Why do you insist on changing the existing test rather than adding a new >> >one? >> > >> >> Sounds there is some misunderstanding between us. >> >> I am not sure about your idea at first, so I sent a draft to confirm with you. >> Then I came up with another version which could trigger the overlap bug. >> >> You mentioned to keep both and not objection to the first draft, which is the >> same as this one, I thought this is what you expect. > >Sorry if I wasn't clear. My intention was to keep the existing test and add >a new one rather than update the old test. > You are so kind. Nice to work with you. >> Well, I will add a new one next round. Do you have some suggestion on the >> function name? memblock_reserve_many_all_position_check ? > >How about memblock_reserve_all_locations_check? > Yep, sounds good :-) >> >> Signed-off-by: Wei Yang >> >> --- >> >> tools/testing/memblock/tests/basic_api.c | 121 ++++++++++++----------- >> >> 1 file changed, 65 insertions(+), 56 deletions(-) >> > >> > >> >-- >> >Sincerely yours, >> >Mike. >> >> -- >> Wei Yang >> Help you, Help me > >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me