From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4B7C4345F for ; Mon, 29 Apr 2024 21:02:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 533996B008C; Mon, 29 Apr 2024 17:02:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E32B6B0092; Mon, 29 Apr 2024 17:02:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D2286B0093; Mon, 29 Apr 2024 17:02:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1FA806B008C for ; Mon, 29 Apr 2024 17:02:47 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A6D90A0396 for ; Mon, 29 Apr 2024 21:02:46 +0000 (UTC) X-FDA: 82063793532.04.428432C Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf19.hostedemail.com (Postfix) with ESMTP id AB2741A0012 for ; Mon, 29 Apr 2024 21:02:44 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=U1ak6Uvm; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf19.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714424565; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cVauk+VnSvpEomOaaZ84W2esQ3BuTML2YO68AJLinVg=; b=T+EjEb+YHAqAs8Y77R4jdt6/RsYUe3eh99e6HF3m5lM6+O1SshvRNJZ7A5HuIYVG2boi2/ 75ZVGzsa37Ry1dEDj1JsvrndRlhw3EXdgRsyv7EYdIRZ5/6lgJOP/9YZBuJV4xdbFtL6t5 Qlyo/JOV3CyskPcK6fBdD8WNPMttjV8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=U1ak6Uvm; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf19.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714424565; a=rsa-sha256; cv=none; b=1SgjTkcrCY8bEwmz9jpxAVfhGtE+1WiVA2TYSrhGYXhJB2iOeGK0U4KgO7/o8OXxnwGa5+ lqZRxhlfkZhE5Evu27mkbQIO5Voo8swdDrCDi48eYqpCT/FAorhR1AWzxmwbRzhB1vvEhX Bmq9bzBPhz5bTRqatcb9Ms3LeVpaQb0= Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4VSwl41tMbz9sVm; Mon, 29 Apr 2024 23:02:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1714424560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cVauk+VnSvpEomOaaZ84W2esQ3BuTML2YO68AJLinVg=; b=U1ak6UvmPza8W1SDteiXJrHNjmnBm0B1b3nBLu1KGy+d6fQetJxAoa+/bJ7RUmEiNPAyfS HoS3MZ22Jj5ktWujk3WY+hZziIF/GDt5iX/zLiNw3d/46mrNxn4VVxgiK/C8v8Ne7FdMAS m0ZJ5gHUYPAeyt0Dn1h2KKbaAmH6rXPcTvOXIIlA69z0AeZJcUa2Wdhx1llkSz8jNEUHn9 /SS2kCHB5qGZJx13HA2FM1D6799dYqv+jHlULMJT74UPU7Hym41Jd92hlxEPAnneQ/AJrg wnhAgLhx+pwkyd7xaAJj1fZl6uCzjR+dhqFNcWPCJC+kwM2CHkrwurLrsmTLlQ== Date: Mon, 29 Apr 2024 21:02:36 +0000 From: "Pankaj Raghav (Samsung)" To: Christoph Hellwig Cc: willy@infradead.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240429210236.jfmhk4uboiqidr35@quentin> References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-8-kernel@pankajraghav.com> <20240426114301.rtrqsv653a6vkbh6@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Stat-Signature: aiqgmd4bjw1gejjpf3psryo8t9q3qqo3 X-Rspam-User: X-Rspamd-Queue-Id: AB2741A0012 X-HE-Tag: 1714424564-573979 X-HE-Meta: U2FsdGVkX1+hofOtqhn44IYQQL2dE2WMHfQ6uGCRiZNx/AVD24IKkIvQtSVPD1F4nbcS6ALJdcCuCn5xVKPcuGE/KCjXkU7Bv6/WnVE3hLmhcRRrdG4DB1gkfL6iwFtazV+E9Rfo9+h22sm3nQAfwv+2c1LxQEyeDfXpIDgaNWShS/WwbK9puVyjY2qEW+yvWFhzRAsh8GfROOa/oqOD7BS/HiUtnNi6rd4swL+aaUOh6E8+Z5uYphyorUDF7o59RTqbUaShTXSoc3zp3EJDWhQuYfZYsSh1I5oaiAS9XtvFQrdC/I0uJvQ70kQ+sm0MRNxj4cz8nruKFcIPhFjPJ62gXW1vpu6+gsrkhFLjScHYGCr97Kjdulssn4MBqS21OSTCLyG1qtykRE7LP3Q5bLaavHuNxnrflIilWNuwkiv3pxuH1eJYe3BsDK8wdKdhuGvDbG9jXVmvz1I2x4PIq9c0iSWeCahdYQBtsWwUePBnbXJY1/9Q+DPWYVRT4K7rwFAP6U/t7its3YJs5oKv9q4lds7hyJpkeT+l+D5xQLBn1XOOUSKE3wnTCBeqhToVyISq3UPjyPFMpAZ5FBIIydFH9kl+uJ69kbVjhC6d6E7ChLzjK03QnU/AQSQucMEDdzrDFGPPalcmmk9gdgTRO5AP7C1FQSCEG2dgWGa5L8u13y4OjjSzCTHs5Aq5Wu7NqLlodLdw0St6OhRZiPUreVZEi3/IQVCL2+wsFfEN2D0TqLnPhm1zu+FrVNvso9WsEH4rTAxiKa49LNSTjg93FkhkvJ/ihIWDek7TZjW1ZteOSX/vnPsEGg1yPX0CIZ1QM2609so3LZ0YyePadB+ByQ6xleVRqCfmW2W2FQKUe2jjekmhKGUNPQoX4gjb575lY8EYLe+orCo6ymEcDFFhpbum3yB0tYOnPrY7mxtdild5I2IMaG7S42bK6QC7IgDgRRfzd+vZCvSmJJe+337 ohhF5j2S f0d8oPhZfK0j16vK+LivUpx3stdRIAcIrY8tEaUmc/Mzy+klSYHZlXJPVCh/oJE/heR85UQxGHepshg6WpVkLOCFYtTt+Yitu38v0v9jHHnCve2NAAJhb6pqKSaZN6ryx+qd73CCk6ZXmYJAZsYMQoQdrpJ7IbMwoMTQst/ypDywP02BxqipcG4av520KucISypeGv0GvToN1XrDvw9Sdq5RctBFMQZSWh9LBZJd4KL4UwlpLSHUJJbvxjLMy5DvaH37WNlIjNR+lPsdSaTC43qt9CQZBCySOjp6dDWjcFwkUR2w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 10:12:01PM -0700, Christoph Hellwig wrote: > On Fri, Apr 26, 2024 at 11:43:01AM +0000, Pankaj Raghav (Samsung) wrote: > > Because allocating it during runtime will defeat the purpose. > > Well, what runtime? Either way it seems like we have the infrastructure > now based on the comment from willy. As willy pointed out in that reply, it is allocated on demand, so it might still fail and we might have to revert back to looping. And if we end up using the huge zero page, we should also make sure to decrement to reference in iomap_dio_bio_end_io(), which is not needed when we use ZERO_PAGE. FWIW, I did a prototype with mm_huge_zero_page() in one of the older series. [1] (I forgot to decrement reference in end_io()) but I did not get final response if that is the direction we want to go. Let me know your thoughts. [1]https://lore.kernel.org/linux-xfs/3pqmgrlewo6ctcwakdvbvjqixac5en6irlipe5aiz6vkylfyni@2luhrs36ke5r/#r > > > In anycase, I would like to pursue huge_zero_page folio separately > > from this series. Also iomap_dio_zero() only pads a fs block with > > zeroes, which should never be > 64k for XFS. > > Only if you are limited to 64k block size. >