From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93232C4345F for ; Mon, 29 Apr 2024 20:40:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 177116B0087; Mon, 29 Apr 2024 16:40:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1262E6B0092; Mon, 29 Apr 2024 16:40:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 014616B009D; Mon, 29 Apr 2024 16:40:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D86196B0087 for ; Mon, 29 Apr 2024 16:40:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8161780220 for ; Mon, 29 Apr 2024 20:40:11 +0000 (UTC) X-FDA: 82063736622.08.2CC7148 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf21.hostedemail.com (Postfix) with ESMTP id AE0B91C0018 for ; Mon, 29 Apr 2024 20:40:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=hD0xxNtV; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714423209; a=rsa-sha256; cv=none; b=Ys5sYuN76VXeybPdjvnsW84nXKmgu0ss9V4/JrNiAsGWUtTkn+KwLiHH5xJbbydypDRcWH 5lnDZ09pO9VgQOxEeb9Wwl1qMVDcXBsCe5T0lpEfn/hheov1FeCLsuj00VBQzI6ouDKE6L +YiXJHNEbbLx3meYFpLJKrKccDBsrL4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=hD0xxNtV; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714423209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bdRxYw1alqzNEbQvn6ARArUKP3stX6EgitWPX7yq5ok=; b=VcuWfVwv7qfZkENxb7q+8Q2V8lRZE/IUj2aaoEWUeXhPJzJuO4SDLXKmd26P6YMJ5gw1QL UAGusSTwEW65gYk63aRkaoWh9dNnjbRaq5FSGgxTuSChCJ6xfpZ+SD06tL5UnYS18al7+O Q0qxeNn3BcRLuhVkZqIcxVXhup4Q78M= Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4VSwDz4JFwz9skk; Mon, 29 Apr 2024 22:40:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1714423203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bdRxYw1alqzNEbQvn6ARArUKP3stX6EgitWPX7yq5ok=; b=hD0xxNtVSR4T/Vlszjoy5hAcIZofGysKkXAsrGwq+vDPpa8RNVQf8vdF2fv47nyhZdBL4V +4OXXRw4TQPLZSlNHnxJQEOrnNj7djzlCEhBSzUWHxWtm0jWRZwcmDCl3pUhQ8kahz5f/v IAgSEzuiZzvZ/Bv1OM58yCoZ8Hus9c3NblwPF+iTOTBPyGEuK2EjNkjst1McFU4uI1eDkG 9C3foAG2ODYHNvAGPzt3f/d1lZ6TbEWklnlI8wP+vgt8+rjLZTO7eocyL8WpQ2OnIzS0Gt HNQdGac5fDgTc3ZWfOiM1R84oyVNrH5fTyAN7E42qsJwjDrMA+j3liAapF76cw== Date: Mon, 29 Apr 2024 20:39:58 +0000 From: "Pankaj Raghav (Samsung)" To: Ritesh Harjani Cc: willy@infradead.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 00/11] enable bs > ps in XFS Message-ID: <20240429203958.gtwqfmdhcwb36kq7@quentin> References: <20240425113746.335530-1-kernel@pankajraghav.com> <87y18zxvpd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y18zxvpd.fsf@gmail.com> X-Stat-Signature: uerw5caa8ypejk9bwzbyamu6qiq644uq X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AE0B91C0018 X-HE-Tag: 1714423208-179530 X-HE-Meta: U2FsdGVkX19X2eSQWyS06dADNwJcxO3x/LiIFvGUX2LITCxFQFDljFJ3gInzy3WVfJyd6cPYLs3yykgojZL/j/39FMh8OPriYp+euMD98NAdt7+AMgIy4Bi5kSzCbDiP/vN2yOrfaDF6OrrfDcnBIfIuf6uXT/Chl0n/M+IEDN/30szA6p6NEjYn9xt/rA6GYNNE3IsY6shPGaps82/2ismsfngp8GOBLxQARusvt8FB8vxXKjiWTWm38BeYZcUbOzsQc2AFQnzaX6mT8BkjzIVTbdm+viGPLqEVdtAnoMU7RexWrY/nGxdOM5iGHgIWv+eqkD8o/apYTmEW4Tk+/cEO1ajMgMuoYKlCtuFIjd4P9PYELBNnKDRYXJ6TzVTXgtT/MTM98Z2o6Wm6qdSHGGmnQXJv74lHiuGawAJ5yXPlqNzcgziqukC6DGwU+xGYROzXJ/EHMguje/p2req5KFpwuPaoV9J5pj7pKnN5FEKCmBmaGuhMjtgxhwPvipSYcXhB2XlULrGySYRCtu7dHttkBmGF21Zv7Jiml20pV5k8n9cjM4CQV/uDN6+QYZ4qzIJOxTr7CIdP10M7KF5XsL6jxcBFm/La5eBnuOtfO0rdj6vkxq1ph6tAoYXtcdYYdBdw8ystv3F4KpLeONnUTy49FtFJFNeI+Dh06lmxOwZxJUHGf5PsdHmFrASrHwiCmKP4ZCML0DWgzzecAnSONxOflrqA5RFLEtOoOurav7eGkZ2BGPKRE2QbuB3WQtWIsSZk4FPWe+TujZLGgBASrGhGVXUQ9ZFhM4P4V/W3P/E0yVEnz+0DNR6iggzpB2Jrz6HDJM0WDMNKNeUBu3JeKQ02jWaXdzCPUi80S6b7ss975PtJT19sDsg9HpBCtoG63Fy2Vxput4uzULQ0eZ5OZmPLXsOLayA8TzExqI8JBlzkliFgxJraLU27nK3mpMeFpF/XMWiOOz8uyWyFDbt 9h3TmxKy FWNQleWkso7LkiFo6zRGOYcSU7BUiuyjb8qXSqe86tIMTWgLZgcr71tU9I7E2zfZ/BTcdLS+Yz7K+IYqpfqonZxRuEV1FHAuP7K0S716vxSjInGugEZAIfJ++/TYf6Cf7Mna6+kX5NxZRrjjViXrF16+M8m6epH8cIYYnBZCBrhywOpcV8DgbVfpcB49Q60EQCPJiMFjTc/m8awnRFkgC/huT6Uq5RJ5gkhVQyrs/4KjJ5qiCDBOkmJRK3GcvywSX5zjAOhql7Kka+NvxfKFCjE9Ww7klQm5AkgvppNkpu1s3eBRX+SCPm/ZRFdM+vVFAn07J2HrRN4Ck6UyJtaaUurMdkf+OGektTK6ty6viqGIdbsy2MEq0YthRMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 27, 2024 at 10:12:38AM +0530, Ritesh Harjani wrote: > "Pankaj Raghav (Samsung)" writes: > > > From: Pankaj Raghav > > > > This is the fourth version of the series that enables block size > page size > > (Large Block Size) in XFS. The context and motivation can be seen in cover > > letter of the RFC v1[1]. We also recorded a talk about this effort at LPC [3], > > if someone would like more context on this effort. > > > > This series does not split a folio during truncation even though we have > > an API to do so due to some issues with writeback. While it is not a > > blocker, this feature can be added as a future improvement once we > > get the base patches upstream (See patch 7). > > > > A lot of emphasis has been put on testing using kdevops. The testing has > > been split into regression and progression. > > > > Regression testing: > > In regression testing, we ran the whole test suite to check for > > *regression on existing profiles due to the page cache changes. > > > > No regression was found with the patches added on top. > > > > Progression testing: > > For progression testing, we tested for 8k, 16k, 32k and 64k block sizes. > > To compare it with existing support, an ARM VM with 64k base page system > > (without our patches) was used as a reference to check for actual failures > > due to LBS support in a 4k base page size system. > > > > There are some tests that assumes block size < page size that needs to > > be fixed. I have a tree with fixes for xfstests here [6], which I will be > > sending soon to the list. Already a part of this has been upstreamed to > > fstest. > > > > No new failures were found with the LBS support. > > I just did portability testing by creating XFS with 16k bs on x86 VM (4k > pagesize), created some files + checksums. I then moved the disk to > Power VM with 64k pagesize and mounted this. I was able to mount and > all the file checksums passed. > > Then I did the vice versa, created a filesystem on Power VM with 64k > blocksize and created 10 files with random data of 10MB each. I then > hotplugged this device out from Power and plugged it into x86 VM and > mounted it. > > > ~# mount /dev/vdk /mnt1/ > [ 35.145350] XFS (vdk): EXPERIMENTAL: Filesystem with Large Block Size (65536 bytes) enabled. > [ 35.149858] XFS (vdk): Mounting V5 Filesystem 91933a8b-1370-4931-97d1-c21213f31f8f > [ 35.227459] XFS (vdk): Ending clean mount > [ 35.235090] xfs filesystem being mounted at /mnt1 supports timestamps until 2038-01-19 (0x7fffffff) > ~# cd /mnt1/ > ~# sha256sum -c checksums > file-1.img: OK > file-2.img: OK > file-3.img: OK > file-4.img: OK > file-5.img: OK > file-6.img: OK > file-7.img: OK > file-8.img: OK > file-9.img: OK > file-10.img: OK > > So thanks for this nice portability which this series offers :) That is indeed nice. Thanks a lot for testing this Ritesh. :) > > -ritesh >