From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13273C4345F for ; Mon, 29 Apr 2024 17:21:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10A836B0083; Mon, 29 Apr 2024 13:21:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BAA66B0085; Mon, 29 Apr 2024 13:21:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC3B76B0087; Mon, 29 Apr 2024 13:21:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C95BC6B0083 for ; Mon, 29 Apr 2024 13:21:38 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 758FB1A0229 for ; Mon, 29 Apr 2024 17:21:38 +0000 (UTC) X-FDA: 82063236276.06.5BCC976 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf17.hostedemail.com (Postfix) with ESMTP id BEAAA4001E for ; Mon, 29 Apr 2024 17:21:36 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=IxToBezp; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf17.hostedemail.com: domain of apais@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=apais@linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714411297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=jBH8AhHdJPWgCtslcMAO+aZioWiiZfizHaoFD7DZLNQ=; b=otH1drvQoQ269gNzCJaQ6+En/yrRde3+0Z+BWEvm+Nc0z8KodzGtQlfCwBfNHcdceeaEwy 8jX+NcdGMJE1XibpHpGwGIUQiqausikWg8pKJhteERuT7DlVk40jErH4G23aRTe3SL0O61 q/jcjRhwwC4SmOPmGUaK197L81bzMxs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=IxToBezp; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf17.hostedemail.com: domain of apais@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=apais@linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714411297; a=rsa-sha256; cv=none; b=6BgGkbZKTM6yTx5Paj7BWIS/wx5rdEdwMzJJBOw8/5W7DvgpZckY0wgSYW+vMqCZmwWrrs 3QA3HesjwLm/21V8zN9HkWapOvFHTKhz23WFNGc/qgpAWjRkW5bjrmeUFK2KIFFvRyiOfE SgleBGA8y0cIR9sv8zYrMzEklmxnMEU= Received: from apais-vm1.0synte4vioeebbvidf5q0vz2ua.xx.internal.cloudapp.net (unknown [52.183.86.224]) by linux.microsoft.com (Postfix) with ESMTPSA id 7E699210EF5F; Mon, 29 Apr 2024 10:21:35 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7E699210EF5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1714411295; bh=jBH8AhHdJPWgCtslcMAO+aZioWiiZfizHaoFD7DZLNQ=; h=From:To:Cc:Subject:Date:From; b=IxToBezpHlKHGPPV9I2Ofu9C2YHjwlY1hCUnsXFGvNS4nhnIyo1ZBKuBdWdbOj8oc bTXBhIw2mwe7cig+Mj1Mwa6Fh9e8zKjYsQkIIGu4p8bv2oeHVoRcLDXqzMz6QPVlc7 +/6Xoo1kzEfGp3Vsf4QZ3NBhPWU2mch/uMc3hbJ4= From: Allen Pais To: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, ebiederm@xmission.com, keescook@chromium.org, mcgrof@kernel.org, j.granados@samsung.com Subject: [RFC PATCH] fs/coredump: Enable dynamic configuration of max file note size Date: Mon, 29 Apr 2024 17:21:28 +0000 Message-Id: <20240429172128.4246-1-apais@linux.microsoft.com> X-Mailer: git-send-email 2.17.1 X-Rspamd-Server: rspam01 X-Stat-Signature: 7y1qgz5zqicefgreozubhxdi7yxz1ucu X-Rspam-User: X-Rspamd-Queue-Id: BEAAA4001E X-HE-Tag: 1714411296-674914 X-HE-Meta: U2FsdGVkX19N1FXnWswfcv0cdDufIzV6SSsSdNZL5IAfUFd/cih4a6QYUIKLLs25J77b3C4ylTtBHu+tyWkHSkxUEPBn7P0FYjW9f1birzU8mC/WNWvjxUBcci9AeAm6cFEjfRxHLEuPSiynEZnQzO5exmA2pXcmW+AsPUEJb1HO8Q0/zijTW5G9DOqpwj+1Mru0TLYvMI/eguuTOziVLOcRuSrfx3DffO8En040niuMxFzEQeJ667YQxjiMgj7Wa66D2fgSd4bJ07XYpLyk5bUVDsF9q88W8QoNxYPTIs0989tWx56hukquKYE8LZt3qMGEha4Oq32+X6N1HZ6pPiB9y1Xhe/A40aqKvJWv8OYNCCDAug8Uu1hEOKW/uyKNFaLDRjRokjWX2eK75HFmxRGFW4dYhykdfpgXGay5tmeL/stHHUMbA5/ExJl6o7UVjE1ZIrNF17E0/eN662Yr0I/zPWVNUuQGW6SO5KiPudrvQBU9e4bnU7zjxYwdwVd435CzgNM46GrVFrMyF9oP0k5qeVZgEl/zWau8FV1djPOiWQ5h8JgS09LAGIyUZcCDU8ufljHQw8xTR17Bvs7hWrrwlas7hNmhMHHGPtl4pMf6UkxzyN6fCIzjVmVljc5RQOvMw/UvW3bqBPylKMLPMD8oGOq17BXRNdsgM4+E06OjBXAkcNufB4tJ94Dr7/br6N7183fp2NwzrQoPj9hZCDixSQ4GT0OTR/UTD+85aGIkxrj2Z8Jo+5+H5VFZLl1upIDoOEJHGuJ+gK+poxfZaA92xt1aqW2mubiVlWF2hvH1N4gZhUXEc/lsg0vpEd1qcNx8YPBxGknOWzEd+ATWcjshNZzNC+AjWXIjlX0t87Z0qW9VaEfXDlbIzC5CTwT0x8o3uSDweVultd421p9giFt4TQwgwL2cChljc2tAQxXU1tu43w+NX7Hs/x+zCCiZDTl+0ffwv9P+487nvcV 4/hXrHUB Sw2D19MfDWRA2WotvqFGb3mxrpAsfly3QimIIRyAhLi/pM0SUcTp/YKphkRUkQceHoZKcDKIIMlKbPpbVw6nzfxxTUXhDAbF4wwAI7G41uR0l/J80+uUVjlQ/kAtzS5FeGQ6EG9JWG8G7LAa8WwSggV50XqEEH+anAXtPEwqxN6VsfQQTmM86rT8UGGzGLp8WyEbs5tOv0VNsbTaiRyY7WhL96w2wiDCzLe8+7cq/vWUCEV4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Introduce the capability to dynamically configure the maximum file note size for ELF core dumps via sysctl. This enhancement removes the previous static limit of 4MB, allowing system administrators to adjust the size based on system-specific requirements or constraints. - Remove hardcoded `MAX_FILE_NOTE_SIZE` from `fs/binfmt_elf.c`. - Define `max_file_note_size` in `fs/coredump.c` with an initial value set to 4MB. - Declare `max_file_note_size` as an external variable in `include/linux/coredump.h`. - Add a new sysctl entry in `kernel/sysctl.c` to manage this setting at runtime. $ sysctl -a | grep max_file_note_size kernel.max_file_note_size = 4194304 $ sysctl -n kernel.max_file_note_size 4194304 $echo 519304 > /proc/sys/kernel/max_file_note_size $sysctl -n kernel.max_file_note_size 519304 Signed-off-by: Vijay Nag Signed-off-by: Allen Pais --- fs/binfmt_elf.c | 3 +-- fs/coredump.c | 3 +++ include/linux/coredump.h | 1 + kernel/sysctl.c | 8 ++++++++ 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 5397b552fbeb..5fc7baa9ebf2 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1564,7 +1564,6 @@ static void fill_siginfo_note(struct memelfnote *note, user_siginfo_t *csigdata, fill_note(note, "CORE", NT_SIGINFO, sizeof(*csigdata), csigdata); } -#define MAX_FILE_NOTE_SIZE (4*1024*1024) /* * Format of NT_FILE note: * @@ -1592,7 +1591,7 @@ static int fill_files_note(struct memelfnote *note, struct coredump_params *cprm names_ofs = (2 + 3 * count) * sizeof(data[0]); alloc: - if (size >= MAX_FILE_NOTE_SIZE) /* paranoia check */ + if (size >= max_file_note_size) /* paranoia check */ return -EINVAL; size = round_up(size, PAGE_SIZE); /* diff --git a/fs/coredump.c b/fs/coredump.c index be6403b4b14b..a83c6cc893fc 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -56,10 +56,13 @@ static bool dump_vma_snapshot(struct coredump_params *cprm); static void free_vma_snapshot(struct coredump_params *cprm); +#define MAX_FILE_NOTE_SIZE (4*1024*1024) + static int core_uses_pid; static unsigned int core_pipe_limit; static char core_pattern[CORENAME_MAX_SIZE] = "core"; static int core_name_size = CORENAME_MAX_SIZE; +unsigned int max_file_note_size = MAX_FILE_NOTE_SIZE; struct core_name { char *corename; diff --git a/include/linux/coredump.h b/include/linux/coredump.h index d3eba4360150..e1ae7ab33d76 100644 --- a/include/linux/coredump.h +++ b/include/linux/coredump.h @@ -46,6 +46,7 @@ static inline void do_coredump(const kernel_siginfo_t *siginfo) {} #endif #if defined(CONFIG_COREDUMP) && defined(CONFIG_SYSCTL) +extern unsigned int max_file_note_size; extern void validate_coredump_safety(void); #else static inline void validate_coredump_safety(void) {} diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 81cc974913bb..80cdc37f2fa2 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -63,6 +63,7 @@ #include #include #include +#include #include "../lib/kstrtox.h" @@ -1623,6 +1624,13 @@ static struct ctl_table kern_table[] = { .mode = 0644, .proc_handler = proc_dointvec, }, + { + .procname = "max_file_note_size", + .data = &max_file_note_size, + .maxlen = sizeof(unsigned int), + .mode = 0644, + .proc_handler = proc_dointvec, + }, #ifdef CONFIG_PROC_SYSCTL { .procname = "tainted", -- 2.17.1