From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C53C4345F for ; Mon, 29 Apr 2024 12:22:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F17C16B00A4; Mon, 29 Apr 2024 08:22:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC7656B00A5; Mon, 29 Apr 2024 08:22:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D402F6B00A6; Mon, 29 Apr 2024 08:22:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B236A6B00A4 for ; Mon, 29 Apr 2024 08:22:03 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 703F940E98 for ; Mon, 29 Apr 2024 12:22:03 +0000 (UTC) X-FDA: 82062481326.30.E766FFD Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf21.hostedemail.com (Postfix) with ESMTP id D4B561C0038 for ; Mon, 29 Apr 2024 12:21:55 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714393317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/3NklDgR1qRXhJjgOr9DoQgZWAZ2uH6aAOXUvCBLD5M=; b=zUIkpfEcl5dg6/KMNQXBpew3JyFbEp5TMtxcx5l2C1gw/1fq5IpiPu3RmWb5c+qCQ6Qcbd 6+stXdQcBBJmurPqQkIGYUn8rsChfHoyHDIrYho6DVDhh3fbtCkhWG980nAheKINe0iaBb KMiNSQ+FH32s4pXqzrBqeVX8Q/J6yHo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714393318; a=rsa-sha256; cv=none; b=ZOrAQ/igaIByxqFQ65FXx9a6Ck88CTDjKQ6hdE6AJBTxdBoEsRKyqpkNdIAh4oDgrsYEV2 IZFtbj5iKPBsS2LOre00hi+cwtlS0Wa0OoXogokw57WwWbisffEHooYQjH83+sZsLkllpq eHOBkcV64YnU1ZXQbhcdcoosGnEGgz8= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VSj6s3BKzz6GD6F; Mon, 29 Apr 2024 20:19:01 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 989301400DB; Mon, 29 Apr 2024 20:21:35 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 29 Apr 2024 13:21:34 +0100 Date: Mon, 29 Apr 2024 13:21:33 +0100 From: Jonathan Cameron To: Shiju Jose CC: fan , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "tony.luck@intel.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "mike.malvestuto@intel.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , tanxiaofei , "Zengtao (B)" , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: Re: [RFC PATCH v8 05/10] cxl/memscrub: Add CXL device patrol scrub control feature Message-ID: <20240429132133.0000606c@Huawei.com> In-Reply-To: <31df9f7d63e34e4bb1504dcc13a70604@huawei.com> References: <20240419164720.1765-1-shiju.jose@huawei.com> <20240419164720.1765-6-shiju.jose@huawei.com> <31df9f7d63e34e4bb1504dcc13a70604@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Stat-Signature: 7xqezu5ncjy78di7mgcpn5daujd5aa16 X-Rspam-User: X-Rspamd-Queue-Id: D4B561C0038 X-Rspamd-Server: rspam05 X-HE-Tag: 1714393315-257549 X-HE-Meta: U2FsdGVkX18KoGD7ok+GtVU8zMQD52eFf5L3bJMNUpMiv8RU7MKv/1RwTUL3RzhVyUnv1ud2yZpqgRjnOozownVcz3+SADb0s9lNQi2rnOFWvw8Ow/Ga1tgwoeyRZag6QHsYeMDv/sWiatn8WycovFffbxQf7Bf4PGUXYbBT3XIEQfbPj5yxqWfSZpAAag6cYZrE/N6Avm7ot5vWx4ADtxB8XUEHY0LWf60aaFbHIbgPF/FLJAtDqTAxWiVUycPFlea85hUg37j/o+ovtd+Tvd5yXiC1U4Vxo7onhA7tXAkBi5VGeEVuOD1VCGPNlTCxd9Kv/menqkTIfsYn+fYlP//U3Y8X/iKBUGUQjCj2XbufQzL0Zjd5+zG6gBO+DC8b3T5/XeuBJ5/PD5QuSXXtZov9FG9ZMnAv/i0R/4exmRxCKeQsj+eeVPZ5J9mwxgSrKvfJg556L78w3uZU/qclHrPDoxZnuKiP6xFUaBbpSkLQd9iw3R5J8jf3AVTOOV5U59FbIIHbx83qwMrJEPtPgPNH09TrTxr9cV91JESpaG9nEzVagvvtX6NdSK6fPudoeuDIaWkXRqqq5jYEMkx/p5VdrmdlHpcXKiuI5zFjtm/8GdTXg8pxigjk5VaZqpGHmKVdVs6omrkYesWDuOLExbuUe6gdIDAKjGLgEIccPnKkEtgTbxvHjjt9ZWZWFYOFN1EJ54evHlKhfpeTUdSMeuPTj/jaR1E0JalNYkWaHEDlxA1ZLEatZtanLC67scnR9qY9CUcac7LpwgW4zqxb7XHKB3WPuXBnKCijbNytBbqQRZXud1oK868Vy2H7+Rq7+SRtcZHCa3cIl8lybu5NuosfcPXR3Vb2oajJiiyKSDKUNC4DG9WI5eYUB5CzP/WlUHdcH7F7NefjDm0DwZ9ClEgUTAN59Q+zOtR87PGP+4jD+dBGXY9KFWQjf17gihbN/fQK+3lbuaRXChKcAW5 GX1Lw+oH x2nyV/Ktfljw5ib2T43u8vG7oBgKHkHbVG7ao0hgWIb/nUpwgLJeIwQL61dNmsl0F9R49NeHhKyRBS5xevTLMEGeNSOLrU1TdOONKWg+eebQUrT2EQAAwf+40O+WagxgEGNvoOOVzOh2NLGz3ZP4gp1IJ5BXJdQRCAUXs+fP2a0RoDqsjFR/YnxWoHywXQZQVWZyUVITB5KoVj+O1T7cMD/tQODl6jjKHgM72BMr5t6b2iHVt6BlkhE1i32JRlMRGJlJy5MVVCO8kjEMDoS17otfwNUbBG7EdRUXIYPX5QEIMTTw9TuWqZm5dRb/tGt5uss5m X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > >> diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c index > >> 0c79d9ce877c..399e43463626 100644 > >> --- a/drivers/cxl/mem.c > >> +++ b/drivers/cxl/mem.c > >> @@ -117,6 +117,12 @@ static int cxl_mem_probe(struct device *dev) > >> if (!cxlds->media_ready) > >> return -EBUSY; > >> > >> + rc = cxl_mem_patrol_scrub_init(cxlmd); > >> + if (rc) { > >> + dev_dbg(&cxlmd->dev, "CXL patrol scrub init failed\n"); > >> + return rc; > >> + } > > > >If the device does not support memory patrol scrub feature, the above function > >will return -EOPNOTSUPP. Since the feature is optional, should we just warn it > >and let it go through? > Feedback from Jonathan was that, if this feature is built in, then should not proceed > if the patrol scrub init failed, though it is an optional feature. Oops. That wasn't my intent. If the feature is implemented by the hardware and init fails, then I think we should fail probe. Or maybe just print a very shouty message about it being broken. If the feature is simply not implemented we should definitely not fail. Jonathan > > > > >Fan > >> + > >> /* > >> * Someone is trying to reattach this device after it lost its port > >> * connection (an endpoint port previously registered by this memdev > >> was > >> -- > >> 2.34.1 > >> > Thanks, > Shiju