From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E9ACC4345F for ; Sun, 28 Apr 2024 21:24:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B46B56B0088; Sun, 28 Apr 2024 17:24:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF6DB6B0089; Sun, 28 Apr 2024 17:24:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E5D76B008A; Sun, 28 Apr 2024 17:24:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 814706B0088 for ; Sun, 28 Apr 2024 17:24:12 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0525AA1C55 for ; Sun, 28 Apr 2024 21:24:12 +0000 (UTC) X-FDA: 82060218744.21.0687544 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 6133540004 for ; Sun, 28 Apr 2024 21:24:10 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=bPTI=MB=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=bPTI=MB=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714339450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JF87N7N8xSoYcCacDNK6ddfh2TUqqHAAzqf2pZDY5hw=; b=uw7yEz5/7eWVNz9EyNwsON2G5+kFo0jBlu/Q90X7v6fJ9PtNBhHTBMokwftYxEEQrVjqUB lJNSjQ97BKJZnzI3BdnMf65MYTiIp3ATCq411LkXa43jfxwhrZ2ApnyOiyn7fRlbYqbtkf t8aev6STuI2dV/ERBi1QZiLQXNKb7dw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=bPTI=MB=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=bPTI=MB=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714339450; a=rsa-sha256; cv=none; b=CAi79vzeJOyK9u4MK3aK4oPv4EkYq5ZgbL4NsJ7LP8cXCuFugRE5l2w/DHR0BdKeZH4za5 IamMgwTpEtNUG27hfIpsAUNdM5W3LomeVdUMTq4DARqCO0zrqdS2wYz+fHMitBIzLsnP70 UBM5JpiDHwi2VQ/ju/t2WTkXfBCapvY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5E4F56090B; Sun, 28 Apr 2024 21:24:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C57F2C113CC; Sun, 28 Apr 2024 21:24:07 +0000 (UTC) Date: Sun, 28 Apr 2024 17:24:06 -0400 From: Steven Rostedt To: "Liam R. Howlett" Cc: Vincent Donnefort , mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, kernel-team@android.com, rdunlap@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v20 2/5] ring-buffer: Introducing ring-buffer mapping functions Message-ID: <20240428172406.6eda8a17@rorschach.local.home> In-Reply-To: <6apbwt27afeercymrjsulrgyv4c2pj2tzqdllukf4czsbfifqo@6p23uqdjqtu7> References: <20240406173649.3210836-1-vdonnefort@google.com> <20240406173649.3210836-3-vdonnefort@google.com> <20240410134352.66d35fbc@gandalf.local.home> <6apbwt27afeercymrjsulrgyv4c2pj2tzqdllukf4czsbfifqo@6p23uqdjqtu7> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: 43gfrafouob17wj4mg575fei1dmpzuei X-Rspam-User: X-Rspamd-Queue-Id: 6133540004 X-HE-Tag: 1714339450-424660 X-HE-Meta: U2FsdGVkX19DfAXJqRtCG9qyT+QyeFoUfDIOGVzRFEZRmh6NbBHHw0cwWwaCEf1F4/Hg8TPLvRFz/rnySSJlJJ8V4b8V+FkE85XqyRYFfoxEtjN5sNfKTFVkgET8FZmxvQ31fTEr9u1nPs4IGKbqT3rxWjTOfgy8iZkQ7kJCYFMnvtbu3L6TM00EVY8fvy3YJLwacvuUVvdq92sfQMxWfJeCIHDZwPpcNc4fl1vQaYm9sdDW3MYAisxuWL4Bi9sYs8V7iVAZQobTcXMTJe15L5jvoYeN8kd5pWRT2iDIUCkmF/sN8OUzsJVzi5M1XJ8jQhRWzQXuk+41rzB+tzNnxG7zdYiDFzfSmDPggj74uPSNxwJpybYP7wO/6s7SenKHAD+n2bSAGcyttYEqvdGylwQrUjlzpY5kkyBLL3eqk3cD1iF3V+ovZ5Bahh3TBUVMO7DOpxa4Jg78pL7xZC2HyiglHOR+Q6xKFDFheFjypZLE7rMOoB79QDX71oMRWrHXi+7gO+9jBWSO3mS/Tj9LNeXMaahJ9cng4sI+MQml0wpvcXcxS4jyq+HpONtYaBBifvSirvLdXT4mbA+R8ROdnXW1T/pi2RastgAmLc073WHFy8ozyxMqlFjnFGqPZnYiZMreiFCP5SCF3s/gw0HkJjt2Zis0vVSzaxgQYo2YulsquRILseZX+AUO9HNPFnqJbVxiLu1N1VwsBrRkwWy1XLbdKo3nc7/WdaAcJNseKuv9r6Yc693XbYwiR5LtrNIigYI/ByXfd5F/QOdbCQQzPLxt0FIXpMcq02m+BRLxIPWj+R6lsaN2GSGfnmVeZQqryZ/15vXYnwNMsAWoY1zBi8pZLHsa3Qj0MKrU88tXjs39IndDHWEIYYKxqPPcEHNoNci9b4OszIBr0UtiqldoxKFVdbLvI5y9zXZ2eNB4Z1Ns6SJPBu1P7LxTjZjA9VmLaXTOaDLtOt+vw/QD8XF L/c5YqhG +7CtloylI8f1BqBnR5xLWKHTYapbrZ+QI0fsAF5aFr6JPhYXvmK6YGNo0b80MCz6O1RZZJ56TbOAFYN+zIZKJa9zm2D6BPxalyzJRMLddVm77uJefp4dUUaJI+1IUBFduyruZwdjrvZu3JeEPCGq/pl7rYtkTy71oWifXyg9oZR5RvC6gz2EvU06MDr4XuSU6ZtILe8A+F6uqXzKAyJkR2Ccg4A8fqBX84Uhkr4PSCDI+jJYV5WFAhllJqRh22CrMcAjX5fWzlAhXJ0RSnx764b+lxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 23 Apr 2024 12:04:15 -0400 "Liam R. Howlett" wrote: > > Nit: For all labels, please add a space before them. Otherwise, diffs will > > show "unlock" as the function and not "ring_buffer_map", making it harder > > to find where the change is. > > > > Isn't the inclusion of a space before labels outdate since 'git diff' > superseds 'diff' and fixed this issue? I still use patch and quilt ;-) and that still suffers from that on reject files (used for backporting and such). -- Steve