From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C10DC4345F for ; Sun, 28 Apr 2024 13:07:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA51C6B007B; Sun, 28 Apr 2024 09:07:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B557F6B0083; Sun, 28 Apr 2024 09:07:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1D1F6B0085; Sun, 28 Apr 2024 09:07:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8690C6B007B for ; Sun, 28 Apr 2024 09:07:41 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3468B120EB6 for ; Sun, 28 Apr 2024 13:07:41 +0000 (UTC) X-FDA: 82058967522.19.1DD8512 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf13.hostedemail.com (Postfix) with ESMTP id 36BD520002 for ; Sun, 28 Apr 2024 13:07:38 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bx8oRnvX; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714309659; a=rsa-sha256; cv=none; b=WIKwP0WfSwOyEHKtzlb+L6N1TQNZLPBGE468PaP7A4fNFTNx4zTe0du4yw+HcqFGg/mHXg LzpHaNfvuZNkeBQxbTbLyC5ueyk1sADauR+B61xeXjbqFSpqjUW5OjVyQrUybJYeNss2PW 9ESkXyFYSO4yYXZRTdcKpfWD7Bg3OQ4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bx8oRnvX; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714309659; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nUVwiK0J+5bFOWjtqquPOnEoFZ7l4R6NFXuDGhnNpcE=; b=mgX6XQStELgexToeh9fIRg71NfGviBYCRjAUsHjvWVWWPHUYLNBh4aqzUbxggZsmHmnvLb 0rZGudad85/YFPNutqD/tW/VLrsKOtXMbbmv/s1PabVhHwDKv18v4lAmIjgrm0DHi0MwWQ SFgj52w85Ufl4ZhA5sV1fVJCnNCkPQQ= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-57222fc625aso4122944a12.3 for ; Sun, 28 Apr 2024 06:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714309658; x=1714914458; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=nUVwiK0J+5bFOWjtqquPOnEoFZ7l4R6NFXuDGhnNpcE=; b=bx8oRnvXXs/1KicZS6jpomtk4jYp9SSEX0rlKacJ/DrocKGvRrNdONaZ/Ty5SAPrWZ xJGyv8UCl4+cS+7HGn7JcOu5jc92EwawZ4YuwQUw4pBiIb6EQ46PciNqnjFKxC8IjX1J Xd+X58H2pV161sGfmCGOV5oIMeH+ZTtioom62/ygUiawVr88LPiMRldr1slAhhVg769A 5+F/jRWITE3BrHkJHIH5tNZzVATugC8C4/6liDQfoLYFSm9yiovuyDJfj70FefCvRYT9 z7hBa/J5EsGhrA44h0XQ4pZt5tUHpcUNhmYH15gIBnBjVxKlDHGszO8S4JkttLzIIKMe TV2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714309658; x=1714914458; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nUVwiK0J+5bFOWjtqquPOnEoFZ7l4R6NFXuDGhnNpcE=; b=tMrkoDNV1Phm//fW1xTt64EN3WwyZxki8iO8+amFZZ91t7Y7BFbEb/Wv8UK3rteBf9 4LSKBMfJCXlR3b/6QaXBiSdMDNGKnTZbBmD8WThlNBib+XEVst7Sm/md9vNjiD3nNmIE tMk1w0a4TokN48dhOe6ROzORv3Z5EnCUWBaaZK1f2+Hjh8Wu5O0i1X1fJ5IOXDcUHXbw b3DXOsj62C+oj3njUMUgWNUt6/QEsnav+AfxaYbrJuzT3wajLHTnFnmVYYcPS8lM4Klf I2mP2Zay5RB2BE9X/7jWZfoIvQFtdJK6DuD+22/f9BugP2xYNl1fwV+ZVQKCS7Z5q2Iy m1FA== X-Forwarded-Encrypted: i=1; AJvYcCVpjmZtZT1iG7Ol+eFW7iIimjTqQE4YxTn+iYs3azZg62RtzZZKnmmft7AoqszAXmGHE2vfa/jX1n9b9sHTLCJinyg= X-Gm-Message-State: AOJu0YzijSSzR6+iDQMA2zo0s+SwKf3NR/dot4pNKDzPF2JNVSmkhrJA tRMFj4SWOC3pIhKfbeiphP8+ULkx5rti0iQCkwgZ1jIc8UdgoUdb X-Google-Smtp-Source: AGHT+IFS5d/rC9NUylNI1zcDV/4POrk8GXOhrxd8KCJNacuJE5SdMeOhaCFDmLD33M8YWdr/jbSppQ== X-Received: by 2002:a17:906:c202:b0:a52:5493:a0b9 with SMTP id d2-20020a170906c20200b00a525493a0b9mr7018936ejz.39.1714309657584; Sun, 28 Apr 2024 06:07:37 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 17-20020a170906311100b00a5599f3a057sm10091875ejx.107.2024.04.28.06.07.36 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Apr 2024 06:07:36 -0700 (PDT) Date: Sun, 28 Apr 2024 13:07:36 +0000 From: Wei Yang To: Mike Rapoport Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [Patch v2 3/8] mm/memblock: fix comment for memblock_isolate_range() Message-ID: <20240428130736.ionlmpvexeylnreq@master> Reply-To: Wei Yang References: <20240425071929.18004-1-richard.weiyang@gmail.com> <20240425071929.18004-4-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: h8fu9d39ikdjmh1jyw7qsdm5g4qq1i36 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 36BD520002 X-HE-Tag: 1714309658-273835 X-HE-Meta: U2FsdGVkX19LmLs/R9o4Ol9gQCbH3R/hHhhpEPu5M9ThjG3WRacCLpo61QmkkPDeFTS0z0vq56fgwB/1xtfJRegMhwp4DsVAr55Yyinayzmmkn7VHLJh5U7Eu9OG680/kHEonCcrV9m8TxVXtJUCmsDeuiqJYY7Crco5KMHSC1WZDbljGKNmTYDcP4KMOUAxT26+0kZCjTNhxxRQXkVGATQNQk4V16RoCZL0HShevl22Hi1/eeQKIVjDashpzRc3QhNAhBfSS7tJHkhJoYISnDWV0vOD+EWj9UjuAqZGb0YStTJ2Fjleg6UJvMFjLXecPM6n4izMBszmkh1kIpzUfjtV1HDRQO8I/MaP/yVji73oys8ron4t+o1xqm9WzhOGN52sCNtUw7Pndly83KbyU5H3QTLg0vxQC3nhvT5YIHIp7pZlTsj/JRFYiZ5qRHMOablQETPsotBLgIwQfqihmPh32B+8ZvHihrsimn1THac6+cKIttH6UhWdLg2QBj080niQ8Lo962eBt75tGytKwfkSVoDho/PgnbDEHqY/FrD8xYTOemYwCg+niTOZr33HSitCigWoOroBHMGQJ9U2Fn1p7GeZWbkHM3VoToXnZfev75FFiqCUCCxxwMu+tX/7xwOtQd9GbLDPlf9U34y8LWdKwIHcmkoXbazBhl8SC2bZ5d4J1v+aTsCfIxloZtMchekeh91Gzv6lR4rnz69KeA73V8BRt6EA3Ct2iMHgWV+AuwvGy9z3oFJbtgVJmSQfShUnoSGPCfDRCkW2vLIk1WBxmJycT2vaeRQG798ya9+/tko/AYwaE+/p9ZjQruZc4eApSXjP9t/dcLDzNo2vyD1vwhPiNNCatA8A+2Xzi41LWY2jHUWYV0ShxM1BQJmRH7nqhJa+Z5f3MUr61xaddfPC8U0GRYyvj1SXpB84ogVYkEA/2AabIrxWds+vewqpQ5up6wPcMts3sWHGXdj gsOx8Bkm yGU+0Sm3qAGH69vc5WqfEu9+rApbL9HSe5Xx+Hggth/ydOFDz8WF+61bjRw/Jio/sof3uM39Bq0gkClECtoBI+De7WNxxm0wMpX1iryG3PT+sdL1ywS5hESkG5wNmFSxw5N0M0A0bAdII43AvKxEVJ8wkgKuG9858to2KwHRJHYNnww3YW69uHTv6Hqpd5hyJWiklkswlsWnfiOgqIQS/oA3rx0yDzGVVfKeoYbIyXNpxvXe5W9K/RPFEI1BqEr0nuznevSbvXbjTznjf5EGY3HTLRxs+GUq80n7/DkEkQ1r/us+cT9HaydvAKCIdCuv+OeGbsVTUN4f4bEydsF3OIR/BqPNoRQCoDVHRP0PAiMsRrxYZBMmZ4bbUYRaDY1OHYbzITHsBapsVml9MZlI/iL1oHoG4gdJ9Gt2Nk4TzvD1lbtlNzbG8iXZVcTriEso2uQ00L9PofzAal8JBwV1x7Ol5dlGlxDYINsjAIFZehGJWzfRQN70GMATHV+AS5Aj2MpbU+rCM/+tgQy4u3QCnV95U9YkfONvuU17xdVtsz+jQ3Pdaew/reXnAENYcCyW5HxYtQ7FHlKG1yywRNe6WawY6Jcl3owuSPpXdzuVINMn8UWCRRj+bnfhq+YUAgusdExPmB3S2rOfSpX3C/VATey5yhjvEjND0A7kDMaGqpoWf0zWX+HCt4SWHv/2vTUlKKi6F49Nel+/L8UkSUBfzy3BBJ0kOLTg8peQONYIkPE5NTdVEtSI6ZkfkFVmMX+vPpyZL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 28, 2024 at 09:43:54AM +0300, Mike Rapoport wrote: >On Thu, Apr 25, 2024 at 07:19:24AM +0000, Wei Yang wrote: >> The isolated range is [*@start_rgn, *@end_rgn - 1], while the comment says >> "the end region inside the range" is *@end_rgn. >> >> Let's correct it. >> >> Signed-off-by: Wei Yang >> --- >> mm/memblock.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/memblock.c b/mm/memblock.c >> index 98d25689cf10..5a363ef283d0 100644 >> --- a/mm/memblock.c >> +++ b/mm/memblock.c >> @@ -772,12 +772,12 @@ bool __init_memblock memblock_validate_numa_coverage(unsigned long threshold_byt >> * @base: base of range to isolate >> * @size: size of range to isolate >> * @start_rgn: out parameter for the start of isolated region >> - * @end_rgn: out parameter for the end of isolated region >> + * @end_rgn: out parameter for the (end + 1) of isolated region > >end can be inclusive or exclusive, please let's keep this line ... > >> * >> * Walk @type and ensure that regions don't cross the boundaries defined by >> * [@base, @base + @size). Crossing regions are split at the boundaries, >> * which may create at most two more regions. The index of the first >> - * region inside the range is returned in *@start_rgn and end in *@end_rgn. >> + * region inside the range is returned in *@start_rgn and (end + 1) in *@end_rgn. > >... and emphasise here that end is exclusive, e.g > >The index of the first region inside the range is returned in *@start_rgn >and the index of the first region after the range is returned in *@end_rgn. > Looks better, thanks. >> * >> * Return: >> * 0 on success, -errno on failure. >> -- >> 2.34.1 >> > >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me