From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EEA5C4345F for ; Sun, 28 Apr 2024 12:22:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A98A6B0085; Sun, 28 Apr 2024 08:22:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 759B86B0087; Sun, 28 Apr 2024 08:22:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 622A46B0088; Sun, 28 Apr 2024 08:22:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 430F36B0085 for ; Sun, 28 Apr 2024 08:22:12 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9FA4C40F0E for ; Sun, 28 Apr 2024 12:22:11 +0000 (UTC) X-FDA: 82058852862.23.298ECCB Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf04.hostedemail.com (Postfix) with ESMTP id ADA464000C for ; Sun, 28 Apr 2024 12:22:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z2ElQTn7; spf=pass (imf04.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714306929; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YaxsZiHyRqn0br0MfYCWmnFw5qyWxxc1sKHklV62x2g=; b=TcA2MtHE4S3ONFrDuWTmnGc8+vyUJrqRsVY30jST3iKRiKRidrKLm5xwu9dKi3RHLvTYIi G4uvCpOekOfEUR+b435/iDpQiYLxd6QrHVAUm3D7shtBcsJoZrV1Ckz4MHsQy1K0cFdGTF Ts7TeWXL4K1DV2723h08vLSfPWIEoP8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z2ElQTn7; spf=pass (imf04.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714306929; a=rsa-sha256; cv=none; b=LdegPTXVSB4jPQF5rXXZN+S2R7VOYQMQTBNk3K3gOrMDW946dDEwHbq6IIencnuAFziP3b 2F7SBFwzp+2mLfyCe8DuxjhZ5NNE14ZJNPp3zvsskFl4QlIq9bgkcbp0pjFMul8IU3yz5L Ay+o0TO0R0LwWSaZppzwy9GpAhnUGkI= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5727c009fe4so552848a12.3 for ; Sun, 28 Apr 2024 05:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714306928; x=1714911728; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YaxsZiHyRqn0br0MfYCWmnFw5qyWxxc1sKHklV62x2g=; b=Z2ElQTn7W0HPvlQ+ejCiFEf69EYq58VobLqvOdZn4QjpSjrtTWKQ4rhzhPOzpuANYV TFhiQ+tx30cpqgn7jUySwn3i06oNvscQqAdlG5XaGsLGqCKODuyV+pfgeQ8KCgM1TbcY eHFPbKEU3aNQrOTKZjHqlh6K7wZGpOP5Lm9Z6Q0IY4Pzn+nM+PNM/T1GRK2wJ/RI6lPW Msd5cyvG5QfO6w+7ZFNbjvS/RRRu4ogGuLj2+eQ96ryrQ1cY6aHhTSxeoQoMZg+rs3kw NUsXhXFdy0jz10DaA0LZGpCmATCz+CJJC+uca788iG/CJ/jVTOxFdn3+aoIXLFMHyF+s CYHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714306928; x=1714911728; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YaxsZiHyRqn0br0MfYCWmnFw5qyWxxc1sKHklV62x2g=; b=kGodfQAQF4GTWdz5K2QjQaS+Zb5O6rMTGWB9ws1LuVQKOvPkNGHQ63W7A2QorQpUfn RkYJLTZirMFOlH2jSUieA8TCbe81XamGy5otjDVcrYiX/P37EhyLuzHZaf9Q8kGnF4Wb ZJr2GWse+HHA0egcDnSYpQKMMW5Ry/lMsMpfKUirmB4HkvmCVC41R4okGxBCA3lt6wYI 1Ty4NDNgCvGOuA4umxXNEtx9ilRar+SaC+csfbBP/la6JezQdfgvaSNnTYgoMP6wdVEg N0c191Rv9G22/tAvzmlha5woidgvH8uCu92fmofH7jfvCl8ld9TdKTGVri/4Zt3XMc35 y4QA== X-Forwarded-Encrypted: i=1; AJvYcCXAFN2Y0k3zlLbGADIqyIMyUXVVUJ0+CH0ACrMwnTxF8TvIF6+XZbHbDLftub+Fz7N5kLp9pzd8v/QadOgp0eKKMBY= X-Gm-Message-State: AOJu0YwrWmtF2yEOmBfXVP2LnTUJiUn/KlBU6QnN2eXttZqxS3bgam8J buhIOUZKr/TaPzntkrImTNTvDQ/HRW/p1UQAbCHTUc1+rxbT9iel X-Google-Smtp-Source: AGHT+IHlANJc1+A1BS+xA72fLmgu3lGkAth5ehXBbkE/lh9zE26yubMctJvnQJvgnQZ/XHDBI6lbpA== X-Received: by 2002:a17:907:9284:b0:a58:c551:4ea3 with SMTP id bw4-20020a170907928400b00a58c5514ea3mr6367579ejc.48.1714306927842; Sun, 28 Apr 2024 05:22:07 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id z15-20020a170906668f00b00a51d073da7esm12636904ejo.82.2024.04.28.05.22.04 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Apr 2024 05:22:05 -0700 (PDT) Date: Sun, 28 Apr 2024 12:22:04 +0000 From: Wei Yang To: Mike Rapoport Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [Patch v2 1/8] memblock tests: reserve the 129th memory block at all possible position Message-ID: <20240428122204.4ecwvc2qxrstl6yv@master> Reply-To: Wei Yang References: <20240425071929.18004-1-richard.weiyang@gmail.com> <20240425071929.18004-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: r79jebb9iwaho111barb59e1q9oqf13b X-Rspamd-Queue-Id: ADA464000C X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714306929-43379 X-HE-Meta: U2FsdGVkX1/7EhWvV1C3Py7hKTUKw5CQYJUS9+euteESznEwF45OevZdZeOfZa0CFM7lYpssWmTPlS1zFa2NMvtUn7hjKalC6qk4xiTnyO6/Dc1ymCZPYxMKpT0QDk3K9SfWjDc6cgc2YtDbtucWyM7iybNdDEDmyWTLzfq6CoFgHQMoex+QG8pRL3K6owdLEnEd0Ebm6nnvAlJf6l5LFAhLDPf1iIpOEee7ezsRwJw+PjcuFoZF67e9nzjNzj2hjlUgFQzjI/r4gVRos4PU3X9s7xMg1aLqzKONX6zE8DcUQUWbOS0NT6x9fiz4kN5AD8TdRjLkSjCOqj/5tVToj1yke7OQ84fmgVQbVPuQQLHJrMDRHGJRdHDynOt0h3r1xNOMMC3sqk21qsb7EEKjjS57YPRUuegiWYW1gWp9N2tQiIdYVRW54cwTYr8ETOMOToooxvJU+d31Lp2OkIjO4LzzVx/kR572Un5lXqlpRY4tc+5QV3G2RbN32F3qVaN1jZ10ReC2DMqehflWIdfMm0xlwmxeaJeTQTDKTl4jvw1jmbwiCUD1VKu5yEyH8l2UfdxfSOBzc+auUCijMsa+8W+ZbxHTRMukB+O6svhjq1djSsWNnPe1e6vk6UxRZxIcBNpU8GWQ8AzHx+RDX5COdmVwqLZEds1pyGOUBTNcnYJkGsUoe3YFJX5D4X16qANF69Yb4ufKVh3odOoBrI/pgjygQCMEiK7nhpatAwP9BwnP0Za2lonxkBm/2kpJmZ1NQKuSu4xdAnhdbg5CZNbfXP+E1ZyL5/OEP35UeHiaCQjUE2kGtaqV+3Y73A6w89+J7QWi6WfmIHBZ1Cxg85FaEPvIC2j3BvOspc2b8ks0IBhkCPU69Eb5nBM1CkMNoryQmeLzvkZUCmrZJByChHvUM62cGi6pP0TvKnxAy9Dwtf1D5QuLcXA6ONUWx+Y80cLKSgvHvVCkkDu63Xf/DyZ XFmxrFgc vaZ+gqg0R3ANK37iTcl4z5Cw3ygf9qFukOiGU9jLIdikxpFGEXWke5gFkbFWqNO1z4LJcpLEwP4lJpgjbvKOfkveb0J8BcASm+gxAlgRMpIUEXbYa1G1LS+mAtkwsjXcBfBTA8EyB6xmN/pbAByjm0zBCFG1ZAo5X/xO8OVJHzBI7iNxa160BFa48KhJ4pZL9Jl95UNKYL6/Au7R3Y4OWIGWdkcgsmuFBb/94kHE+1UPiydaQjLn2jrhkXFVORL6qxr6jfp1Ua08qWWKjvSGdPWv3+yf8iqjwupkO6Z0Alcp74otkDVIWmEKRC3giVsNPRQoLD0K2TR9n1QUrjOhsZ1auS0eNuPR2vKwAqHf1r13Rh57gnz+kUEs/myhJlPn883zyvWrdeXbiJE5o0Q/B5rHTe8rkVDT0kbF8sLAx4/agQD4qzlCQL6y6D5gtqtbjOMz7+OyrxUa3YrOVMdaCmWIbfWS2ZS9ygL4vDfm1S/SB0K+XZYmvT6PDTglb3vdOTkvdR9ak2il09YcFAy3hr3UEyfzIqLl28kkYzLeraHXmWkwxw5JUEw2xBzs+pala9W3cH5vaPW6nzVAU7MzFY8xGfgKsHIpjz7ZPAjLMM8BSYpxWhb4QUIcsMco5PBGycaFBO6/LY7bM40GYGdW7xHF4p8CsVL3P+1x22LFCursnHv5zgRIRxKfsVv+Ry80FN0elFFB5u/qE0xNhXEEGq75bJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.039911, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 28, 2024 at 09:35:25AM +0300, Mike Rapoport wrote: >On Thu, Apr 25, 2024 at 07:19:22AM +0000, Wei Yang wrote: >> In stead of add 129th memory block at the last position, let's try all >> possible position. > >Why do you insist on changing the existing test rather than adding a new >one? > Sounds there is some misunderstanding between us. I am not sure about your idea at first, so I sent a draft to confirm with you. Then I came up with another version which could trigger the overlap bug. You mentioned to keep both and not objection to the first draft, which is the same as this one, I thought this is what you expect. Well, I will add a new one next round. Do you have some suggestion on the function name? memblock_reserve_many_all_position_check ? >> Signed-off-by: Wei Yang >> --- >> tools/testing/memblock/tests/basic_api.c | 121 ++++++++++++----------- >> 1 file changed, 65 insertions(+), 56 deletions(-) > > >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me