From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09D2C4345F for ; Sat, 27 Apr 2024 05:05:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22E776B0087; Sat, 27 Apr 2024 01:05:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DE546B0088; Sat, 27 Apr 2024 01:05:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A6A36B0089; Sat, 27 Apr 2024 01:05:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DD0B56B0087 for ; Sat, 27 Apr 2024 01:05:21 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8DE8A120930 for ; Sat, 27 Apr 2024 05:05:21 +0000 (UTC) X-FDA: 82054123242.28.0ED7EE8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id E16B5180003 for ; Sat, 27 Apr 2024 05:05:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="E/3L/32v"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714194320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=No6xZIfndD4E6Jp9Z/sv5p4jz1wJTa77iD15FxUtBM8=; b=GtHLRElltffEjB14dRCs/8EjV7+EysVB/SlFl7iIVJ3DaFgUhaAjdLI6fmR4hBhNCol9ac SkKVrFLSSw09F//TS3+gaTZ/WwRgFQGo73uFsyWrrLTnEaFMTk8b3HqCQqBUmBxU9cOk0Z uW8IJY873sanCCiSWWTm/cWyIFr+1AI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714194320; a=rsa-sha256; cv=none; b=NoilWoeHrhl4bCJrY0laaE7qSnQ0dAd1Yfp7vKptZX2N3Zk65GwpLXmpdrEIldDA5MLUFv m83vhogiRq/Sy6tvWRMUj1SQ0BFS1EXFDBRT0XtGRv7JFsYXu+oEm/3AyG4rievAf5Kxdt gZbBj9sWOctIPBiNEZGUBUB4NbUKRXk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="E/3L/32v"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E201A60920; Sat, 27 Apr 2024 05:05:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81B20C113CE; Sat, 27 Apr 2024 05:05:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714194318; bh=Pn09BqCdvGBpv9oyzNDTerZgLB2/sM1Oc/sK0a/sceA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E/3L/32vgCHnYYhzIyzQIsZUl9VXAwaHmX1BhU5Z4GpgyHvNrONVpPJ5aNxAyKq3A R1JcQ++zUGoYG4SQDRxm6YvNjksF8eQsqSaNebe4BzrGHsoFVawC/qDPyr7I49tX44 yK9OvxPjsAMH6xP1sNe8+c9rBNm3GwO8UzJ/aLFCXL9xTrJ7sZPT8tkeN4+h1T7FHf 2+NZnL+0qxtAT36Lk8YakS+Y8kphqBxNjpOXX4OyyiNjUSij9oQ0W3pVVCi2J578QC G0MdmASHwjKW0NHMfABrcuSFByPhmFlrMUmTBUfJHQl/UmgzcSoYJ2tSJoRkdYOYQQ iULwLzWScBHcw== Date: Fri, 26 Apr 2024 22:05:17 -0700 From: "Darrick J. Wong" To: Ritesh Harjani Cc: "Pankaj Raghav (Samsung)" , willy@infradead.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 00/11] enable bs > ps in XFS Message-ID: <20240427050517.GC360898@frogsfrogsfrogs> References: <20240425113746.335530-1-kernel@pankajraghav.com> <87y18zxvpd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y18zxvpd.fsf@gmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E16B5180003 X-Stat-Signature: 58qrc96cdpwjhb51qjzre3ofc7965ht9 X-Rspam-User: X-HE-Tag: 1714194319-568611 X-HE-Meta: U2FsdGVkX19l/qQlxZQ30JWVGkvqhoOVW9sZsks/xYYlnE/sYHUMnwD30+3LG/ypvWLvdu1zCORnjnWwaO17mqfeTd2l86zE50mCppaGzVKPEGE+e+HogSzdgVGBi4VDz9euVqLkYJ6b/frAmIZd3r2jx7gf5W4koqJ5FqMlfmOxuA4YHTDO3Q5zO0E1M24454bnC50eXBpkqIIhTTbh79AaOtAv7gNO2xaVnKzXWAyuVucafM93/HrHOT4Vmceyxt262KhBbZfJwNfkRiUFxp5tntmkvwOeushyr5hGGtSuq7E7FOpH/v36HtIt3cwjbNokMECkM7hjOlbXXw3heMmis8K9tZlN5wXl07xaFfP0Xu0bUrblJKXe0iv4xUdMSB40Cx2KK6Dt0ULIxJOjkDcbJdgigW6SGakEOTVjA27gEjVuEeZm6g4OEmQ9t5QhyXEfVaO668RRt3p1HLbZpm548Yk/3/FuqWd5I5PSsq8nYIURRGyh2eVeTMRT1bp4E4gjB7fwx2jumnCQ1+1Qn0cahhczwYk0edIdwKD45df1oY7o1oc3FwlLKaRjsdwWPtvJEB8CpWX9B3vCRPsfQ7sRHsi8a41xiCOzIe0sdKNjIWvpTQ8dMrKa5llhy9C6BM5oWTxg5QAPhgjHPP04YJQrruxkFvbmLeNHcAEfrv9R4tfNxpKAA95EvQHKfY3jCoAr+AJa/HdO5UhRL5Ig+d0WJaiw0utuQJ+lvEpaWZ0VXDZaaUVRbbTT/03AwkdV8bNllJOwNR6szHJ+Cv1IUzB8UgqoriKdxzBw8ZdsUsLAPVizPnlc0uPYGYmzTNM1dk8tjG00SVJ7oKTn2DgECUB4VJQefWZKUw5UHWYW3rPKtebCPbNnKJLLc9IbaoTTPUXImrPEQhLikKdikt+zE+VTpgFMhbTiChWR0/coX2f+H9ZXl/5j3Uu5U7trd6ZIwlU2i3vEM7r3533UmHg Upi6DDrH ZiHLyVk7Si8ddz//vTvV8FZuN8u6Reu6UeMqre/qkfWd13ILFFVDuZS5lYHrotNOu0V3syQSzu+g2mvFKkdUfD/4p1Gy8dTXVvTB7M1T3xVgWY839gcINMFxyuNryda+KagCCtzEiQKupNa6Y1MPs+CzHrL+PkfStgZlqxlmRO+CSz970ikb51ax/wPr9wz3YTmK8dlV3Le8E2XIhn4/McaXLWM4B5nJbj5qN6RF5GE7dNwbUpf6siL5sR0ktZB9FD9dbmcnJII+MLEfwbINdawnGZfDFw+KmfLtk0B58rKM+KeziOX/xJIva/mQHEQd+qpDU+TIuIHuorskKjPw9FKCGxaqRUUf+cMB12vgXmw2eaP0G3GUKW0m7aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 27, 2024 at 10:12:38AM +0530, Ritesh Harjani wrote: > "Pankaj Raghav (Samsung)" writes: > > > From: Pankaj Raghav > > > > This is the fourth version of the series that enables block size > page size > > (Large Block Size) in XFS. The context and motivation can be seen in cover > > letter of the RFC v1[1]. We also recorded a talk about this effort at LPC [3], > > if someone would like more context on this effort. > > > > This series does not split a folio during truncation even though we have > > an API to do so due to some issues with writeback. While it is not a > > blocker, this feature can be added as a future improvement once we > > get the base patches upstream (See patch 7). > > > > A lot of emphasis has been put on testing using kdevops. The testing has > > been split into regression and progression. > > > > Regression testing: > > In regression testing, we ran the whole test suite to check for > > *regression on existing profiles due to the page cache changes. > > > > No regression was found with the patches added on top. > > > > Progression testing: > > For progression testing, we tested for 8k, 16k, 32k and 64k block sizes. > > To compare it with existing support, an ARM VM with 64k base page system > > (without our patches) was used as a reference to check for actual failures > > due to LBS support in a 4k base page size system. > > > > There are some tests that assumes block size < page size that needs to > > be fixed. I have a tree with fixes for xfstests here [6], which I will be > > sending soon to the list. Already a part of this has been upstreamed to > > fstest. > > > > No new failures were found with the LBS support. > > I just did portability testing by creating XFS with 16k bs on x86 VM (4k > pagesize), created some files + checksums. I then moved the disk to > Power VM with 64k pagesize and mounted this. I was able to mount and > all the file checksums passed. > > Then I did the vice versa, created a filesystem on Power VM with 64k > blocksize and created 10 files with random data of 10MB each. I then > hotplugged this device out from Power and plugged it into x86 VM and > mounted it. > > > ~# mount /dev/vdk /mnt1/ > [ 35.145350] XFS (vdk): EXPERIMENTAL: Filesystem with Large Block Size (65536 bytes) enabled. > [ 35.149858] XFS (vdk): Mounting V5 Filesystem 91933a8b-1370-4931-97d1-c21213f31f8f > [ 35.227459] XFS (vdk): Ending clean mount > [ 35.235090] xfs filesystem being mounted at /mnt1 supports timestamps until 2038-01-19 (0x7fffffff) > ~# cd /mnt1/ > ~# sha256sum -c checksums > file-1.img: OK > file-2.img: OK > file-3.img: OK > file-4.img: OK > file-5.img: OK > file-6.img: OK > file-7.img: OK > file-8.img: OK > file-9.img: OK > file-10.img: OK > > So thanks for this nice portability which this series offers :) Yessss this is awesome to see this coming together after many years! --D > -ritesh > >