From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA67C4345F for ; Fri, 26 Apr 2024 15:15:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 936076B009C; Fri, 26 Apr 2024 11:15:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BE256B009D; Fri, 26 Apr 2024 11:15:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75F3F6B009E; Fri, 26 Apr 2024 11:15:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 588256B009C for ; Fri, 26 Apr 2024 11:15:49 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF02841409 for ; Fri, 26 Apr 2024 15:15:48 +0000 (UTC) X-FDA: 82052032776.21.A4E47C2 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id C880B1C0014 for ; Fri, 26 Apr 2024 15:15:46 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ti3q8L3p; spf=pass (imf18.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714144547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xftLkgUAQOCEMot6BnWzc9rgQrFVB+6TnwjGV5rqgHw=; b=ZMFRgDkwSuEb/qrFHeYmZkF+WyA42lDR4LG4rtY3WtmOukltRgKdEmPwip+cffw3jNbzVY CQ9ChlMKqE9ocOJx0LhUKfig7yUzLT2ZvhaG1AYn+aHhfolxqfYdoXbizZ5gvk2kQO+4vh hFnTq4XI8x79N9+WJxNijrkJ0ayRnKg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ti3q8L3p; spf=pass (imf18.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714144547; a=rsa-sha256; cv=none; b=yZWwggJj/4Ml6VqYe+emZRHYPx4S6Lrg4RmuykLd+KcobUx626hypwL0Ru+4ErmETWReZF kw0ZzTIDDnAxeL1DWYfhkbFtrgCQESSTbOJqYhCRlFZATXTBNVu31nkyq5QOwQYtj7bohb ETdcOzVzlPmK4LP14IuuctMGIkjRx5E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9E08FCE1A81; Fri, 26 Apr 2024 15:15:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BADF5C113CD; Fri, 26 Apr 2024 15:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714144542; bh=JtWLiBEE0MYykclQ9qosZ0yssrcJ73QSVvIgrP7pgsY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ti3q8L3puZFymuhMqmUVIbsLhYTYUlL7mBfESqoSRiKAsoFFsbdfoXSD2aj5pGpJx jgAYUQA7bbte0IKNAhmMBy2U3ZI6SVlUZIssgPZ7J6DIaEROICXhhUTTAHjN5/QC4d RDsfWbUJtAChfuc/XdOGHkmbaf5H1Wrc2hAI0egBna3je2n9M9Drwb4N702Tt9HvpI yzFOolF2WcRhoNeGOeGvIV6HsW/iUz2ixfGGwX4t/bFzzacF3EP3jXlw424h4IWPB8 nV5o7r38FcX68JD8BmcCBjjmzfR0QyZK+iJJYXw3usS2X6qGz1t7DOivKBHqkDi6/P em30UbQ32m4ag== Date: Fri, 26 Apr 2024 08:15:42 -0700 From: "Darrick J. Wong" To: "Pankaj Raghav (Samsung)" Cc: willy@infradead.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 09/11] xfs: expose block size in stat Message-ID: <20240426151542.GE360919@frogsfrogsfrogs> References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-10-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425113746.335530-10-kernel@pankajraghav.com> X-Rspamd-Queue-Id: C880B1C0014 X-Stat-Signature: ak4i6fc77zs6o9xt36qs9bpmg16y8us4 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1714144546-276355 X-HE-Meta: U2FsdGVkX1+DMM7vj44YjIM3yyINP/vcfbNjMCXHZrTl47z9uxh6OicAHhqIFtL0nWKz1dvrjgQBCQwGlAH2PtG9PHdTZwrkL/Wdj/2YkwOxDt4eZgRHZyfIeWJwvK00o4u3WbUauk6GBBU4jLV7wpwu9qLSOlbmPbQwdmwKyrw8D72+qjrqo6IYh5NdnjodhfH7IabjgCkW5U4HBxQCRdpmR3dUH4vCn6ztBkp6y34NglIOvjK7IpIsm4KypmLbTKvIHA5ccQvAVHb91h+7lbHTLR/0ZFoUBPULG8+Mrnv9pLpXAUnjoYmtB1Ldpnao7jtuR4H1bYxQSmvUuGckLzMfSw1Bk9On7Rozb92sbgspTbJBZ7Rw4r/468MWh0AE8ifcSz+fLwPBdYJtq9KJMgQ2/M1LSKYvvXkwLoWpCjSOab2jheXJL9L1eCSBSngYpsdjG1WaWDPnOHHzBjlVlNXrt9lBWT4d5xMAHZOHiJPA33ktS3ebEUMYoVOrHY4CQjhWQQJdJWBlXT7dzEYFSvVy9cXWjUVnGIk9nkygz8xBTe2p9bVPflcum0tm92Psyc14nURBuP5yY+yVFyjDo0iZ3egcqlNL2yGq2TlW1rDvgQ1uTbFSxTKxcXSb33A25EbeNdlYmxC3WSd7gZt/D3ETB1kHhCpWwkO21/uXZFzy0kiIt5KG48ndr8AOIX8EH7QM4ktyRxvV5HSvPOUjJr6FibZDbTOYLsO/+l+8d7rUNO/eKiQVAj96c7wX5n23Z9sj0dWhRp7j98r/TvDB3AgArkqt25AIe1Flzan3+JMUqrm/TX+stlU8XIbghq0DPrRb/gXomHUK8b9u7EmTDltpugGRScwc9PhvUAXdOLRV8/fC+MdEgt5pfi86gn3Bf/169tda19Ka008fGuzM+BGNu5XNkeHQVarj6ugw7M2iGr4a58vlH+TLJ5aEy0l2BKrzcI98LD+96cKumCJ 3iVM88Zk Op+u2E3K7yMzrOxSxK4/hIuVhx8YDqfKJNoHyLIehp757JAFrWClA0XnzD633C/hkQodpmvEEY/iJi5vvwlxHiSiQRsB7Bu8FYmn0Aa2M8AVX/f0Iv0lAQdT1hT+fKguDjHMkkrGdSznaiqY+RuQS2CzNmoZfmjHJyVHmA0eXZd9hLa7dJOZWEl0n/XIrsjaAd4liuARWi/f/4FfXXXqy8j6mebS2Ed/1230TAksvx2rBiyi7F2zd+zALweSZT4jjyaAQv3BXPM2Ab1RE6mc3MZ1jfVlb16hE6+gRRkdZJwb20SiySMHA6M71VZqzT/Yn/VBr+C3R1Dhf038AFypfwjqCGsiUwcGh4HRlQpI9t1gxMwqIR/LJSd/nchqDSYcklmcfrxDHK5T6aww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 01:37:44PM +0200, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > For block size larger than page size, the unit of efficient IO is > the block size, not the page size. Leaving stat() to report > PAGE_SIZE as the block size causes test programs like fsx to issue > illegal ranges for operations that require block size alignment > (e.g. fallocate() insert range). Hence update the preferred IO size > to reflect the block size in this case. > > This change is based on a patch originally from Dave Chinner.[1] > > [1] https://lwn.net/ml/linux-fsdevel/20181107063127.3902-16-david@fromorbit.com/ > > Signed-off-by: Pankaj Raghav > Signed-off-by: Luis Chamberlain Seems reasonable to me... Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_iops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index 66f8c47642e8..77b198a33aa1 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -543,7 +543,7 @@ xfs_stat_blksize( > return 1U << mp->m_allocsize_log; > } > > - return PAGE_SIZE; > + return max_t(uint32_t, PAGE_SIZE, mp->m_sb.sb_blocksize); > } > > STATIC int > -- > 2.34.1 > >