From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7569FC4345F for ; Fri, 26 Apr 2024 12:54:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0CA06B007B; Fri, 26 Apr 2024 08:54:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BBFA6B0082; Fri, 26 Apr 2024 08:54:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 884446B0083; Fri, 26 Apr 2024 08:54:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 69DE36B007B for ; Fri, 26 Apr 2024 08:54:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D62791408E0 for ; Fri, 26 Apr 2024 12:54:22 +0000 (UTC) X-FDA: 82051676364.05.3BAED24 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 045F41C000D for ; Fri, 26 Apr 2024 12:54:20 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=BTuW3g2S; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714136061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gvK113BQiEHRRB+jUoKp4pYoXm1qV6dv7bI+yo26L2s=; b=AcAazlY4s/aM8M/9bL8UnypgRbRBFZ0sY8vYpz8DukIuD0huueR9eVLHTKFOBFZpsdLuO3 zMAywvB5tgZ/c0jdya79SpApdkNI9Th6iLrlLB0cHlqCWghF1GMxXWnbIdlsy44ccPkGyt FMsqomPyp7SRwZNqzORvlehaFOovjpI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=BTuW3g2S; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714136061; a=rsa-sha256; cv=none; b=YLds1q20tiiWnaTYLS+xR2sUxRe8GtDbB291LviONTLVNeckMG89zwl32HQtcbsduqacXT XnNz8rOO/8etKtb9Xgp/rSfqvwmEoHpIPyJWIvsNyg5F2QX6v9rBYUBKZ2ismNjAlYQsXo qLUf9U/b+QmyPK/PQd1yT3LWlgUvq3o= Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4VQt2t2hJHz9sWd; Fri, 26 Apr 2024 14:54:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1714136054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gvK113BQiEHRRB+jUoKp4pYoXm1qV6dv7bI+yo26L2s=; b=BTuW3g2SAvenk5ulUQkTFm/sWdNlXv7N24BPmPPBaebmxLqAgsb6/bjYKvZFi1tXEyURDs FFtbT8+qEIgbOeyGBt6/Ck0n5PbnTRU/Kd7YkQauiA/i1GguM1ng3uvFUQQkPwATqo2ltU 6Z4HHR9ONyV6D+sa7/PCLEKNuQqk6pNlhb5WAvyO4P/T9su5NU/w8YKk8Zv1ZpkK4xNbX+ FbiE6k/QnNgoeVNPla27GvFtpgRdYs8WJRCkI0Wr8sdUqH4vs7BzuLD8ERFRkmPHmdS3mC 69dnlhPWlRY9OFVf+HF+kIqZ0A8drq895qT8D/8OIEonLq3EAkTWcA2vYKuiBA== Date: Fri, 26 Apr 2024 12:54:10 +0000 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 06/11] filemap: cap PTE range to be created to i_size in folio_map_range() Message-ID: <20240426125410.myhl33aewkd6wpzf@quentin> References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-7-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 045F41C000D X-Rspam-User: X-Stat-Signature: yuod7z95kp5xp6995so7tey3c3pt6uhz X-HE-Tag: 1714136060-326343 X-HE-Meta: U2FsdGVkX19iUQsaPMCqhHJ4UGGa76WIh5avuHN0SM4XTxg2BcEHBzY/90E5Ig3xDGZ8uptV9at9IURVJNzU67ehd2MmulhuTljFapGA6/Lt3YfSZd6mHOOrKj2m32tqD/gKHD5DXp6scK1A2tQWApQJiQAewq8X3p7xVOp0AopEh028ur7r1wY/ZOQhNDFl3KES8azFncoStxKqDj5NIhM7yW4tMK7oeYIw048NZzRJdwL3X9wBnVYBx5PyqueXTg5fLtKXmTA3vwsO46ULCnOCuBjXQIJD+96L/VBfnFApzm7ExqCC7A4BXbXa/tzFT8rgvvEn65HQ3mKwNawoiwtwb9Olo4Kmdbvgqao1C+6ijI3L9AepZdWktmPWaUk1v3Vd+s0tebjrZxIllAk66PqesgPmYLb+s0Dk2Alzj0JWeFyWrR4S2fqLfZYpKR8gUwIDNPc6OQWFiHL6iPo6WbnpemZt+k1wZYHQpjPGF31iyxXmHFvHTuKU0GWsT0sLjH9QjRdYG3yZVSJ/AJQzGcjiDSS2TmraaADZuKbXDpxx2UdqccB4IaMTa8k38VeIz1Q6WJPJTWBQvEG2xOV1HWkcU0I4YQ00iS6pJdLbaLBgmQnCKP4YXMgESQmQsiZsljTRiPq8ATQL6ZOkDORfrFLbLPkDYK5YlHaYwNPeEf6S7P4zlXNPOMHhMreKTDDpKiJm5U1tm4Hx+5dxa3HdkmUIllPs+zv3QdV1VJSE8WmYzMyBFBPw320tVLyX7MjZEog2iBxWzd1v6v3Ko/ME2SBIcGf6//oOEccEEIjPmbzM46ac1lCR/4EjSoE+YIA+ap1dgNITxDvJw/A3zguGtlS6TvAVsZc3jyUmYti+H93CJwbVjkUwe8nxWBHHfkj1bDmEWWU1IZcJN6H2caTfz/Zq/Shrw0VhkR8YCCoeH62qCbsfD8ZG6+QFj3R1jlxHkiwkipTSJzr38wZyYmZ SJwplMAU 9cs+cKKI5WqJ/g6S/tJMkt180oRiVUvxWgLNiKH00+cD27ZlPSSIOL3PAXY4p1cAHkyHJj8Ck2Hzlv+6LIeyobxWi3iPo8NFajFNpbg2uo029WsDfv2UTuy+IoZYa2zB3+KSFFSZKZBkAv7tKbEYKdoKxZD5A395wjAaQIt1FDvqbhF92cCJ+sOm3WxpE/rF6aKPGlWwRdOg2+L0C42Ng/id6OUWgtYEA2L3H+bb99OzqvdE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 09:24:33PM +0100, Matthew Wilcox wrote: > On Thu, Apr 25, 2024 at 01:37:41PM +0200, Pankaj Raghav (Samsung) wrote: > > do { > > unsigned long end; > > + unsigned long i_size; > > Usually i_size is the name of a variable that contains an loff_t, not a > page count. Not sure what to call this though. Also, can't we move > this outside the loop? You are right, this can move out as i_size is not going to change. I will make this change. Thanks! > > pgoff_t file_end = DIV_ROUND_UP(i_size_read(mapping->host), > PAGE_SIZE) - 1; > > if (end_pgoff > file_end) > end_pgoff = file_end; -- Pankaj