From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45027C4345F for ; Fri, 26 Apr 2024 11:43:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73E276B0087; Fri, 26 Apr 2024 07:43:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EE4D6B0088; Fri, 26 Apr 2024 07:43:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DC7E6B0089; Fri, 26 Apr 2024 07:43:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 414406B0087 for ; Fri, 26 Apr 2024 07:43:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A5541A1CC1 for ; Fri, 26 Apr 2024 11:43:12 +0000 (UTC) X-FDA: 82051497024.17.4B03232 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by imf20.hostedemail.com (Postfix) with ESMTP id D331F1C000C for ; Fri, 26 Apr 2024 11:43:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=aQ34CJ9E; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf20.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714131791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cltDh65KDZw+OJ1Jx8uFob9VDGIFeVIuEhOR2xoeV7w=; b=BB/MspWA6jvCtCgXVFsTcnjUOu0wHcYVbnedaiOMams1eRsMWyh47PlT2Fo61NtbWoqgMq r4Vm1zo/VYv2mgkkmmcRjChEwzZKTw3V1QzsW+L38FjRGvO7uUHSVBLeael4fdmwby3WBO WPB37rqNSNpfUiRMdz8cgUlE3XgIs1Q= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=aQ34CJ9E; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf20.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714131791; a=rsa-sha256; cv=none; b=jh9ai0WkB+XFgHSJDCy9y59LOYVJTAVH2yrb/YXgLe7/nBBvoiBegPCtdoKKSzGIZuk0b6 mrPWlvUtEPI3Ql1yTEh0ovF87fzNLWG/aaS9srun/mXFokYwYbAK7fDJ0P8m/2z1y4ARRC 1jUqHi52C8EsepVVaHuBwf4Afmg1IF4= Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4VQrSn4Vb2z9smT; Fri, 26 Apr 2024 13:43:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1714131785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cltDh65KDZw+OJ1Jx8uFob9VDGIFeVIuEhOR2xoeV7w=; b=aQ34CJ9EipShkD28LV1bat6g3mnpc2GYmdBbBDCxEOoKx1zuh67XteNQm//lttTjtJ0edL 6LHYT43I/gKfoQuSGCtBrXqszUCosiV79JLe/IpGS2LxZSkhUI7OvKsJYEDjwHNBKu8mdo UlDUKmUFUqBoNudAiYdIi/bpWmjmwDddMKFafy8oYEyhkldv+0DZxVEi8SZ1hUtGFCQf/B rdfj2D7v9znaP2RGoKhZD/BYFOGRi82ix5kxdxKbu4K5kZkVUmO3U2/QhsErvykWztTiKe 7h0LLoaQJb+HZoz5OX0ZqX+BGUNHfMp8oEV433VEKJDCmdeFCDClI1k7vcvcPQ== Date: Fri, 26 Apr 2024 11:43:01 +0000 From: "Pankaj Raghav (Samsung)" To: Christoph Hellwig Cc: willy@infradead.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, p.raghav@samsung.com Subject: Re: [PATCH v4 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240426114301.rtrqsv653a6vkbh6@quentin> References: <20240425113746.335530-1-kernel@pankajraghav.com> <20240425113746.335530-8-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D331F1C000C X-Rspam-User: X-Stat-Signature: hjkj8ubwqhcr8nfifzwzmar9z5jbody1 X-HE-Tag: 1714131790-224537 X-HE-Meta: U2FsdGVkX1/IlSI9n8S0pYBeB7TEyb+g+HvTzoxd7SXxPDg98OwZctg+j2Bm0S6lYoVzFIabz7f0zKJl78f1lTO852NpKfl/PzICzSd1R7UqTbHZqQ4uIAbmcZbAaeWGoOfz2lHNc2a54r8MlG6BqECAUNA2+riGSik1Cu7+EvgKMDze7//hrrYh6gKCj1v/6PluM6jQ0WXgUqzx4EgOFDI2rxseR2TO8eQJ69bJKijdwlA7R9sANQh+UDfXTqPlfh2PxhWE0rNGlgdri7USGHK0RuRYahysHOexeCtxJb0I2u2tyl4XnltLDcmgW/aHP2+o3n+I9UTgXtU0/2wV7aOQg+dHCmPSU37KCrSZrivXmDfNEowMtu3uFnjXplzKnWOJeoUkdgWvJjdPzy4Jib+PUlaVNhwwQQZ9nN7TzGOmHC/Tokn4HxmbpryTm0ErKCz7DqsnscPByzMZldLAD8znX0j1D9Of++D3V0ycPeeO3yN/RKL9l2b+9kYJIJM8EB1ylQKRpxwi7i662s3mPpw4CH2PY9lraJkWTcjWnv/MrFctoJMQr3NDJajF2M3e3DsRniCjTh3NOXhKdpncohfthbBe2C+cXMUFxDzL+KUtxb9WQ9NfhvDKG8UlhRnBCTCfpfYxml8LOjqCCGP7UasZfjqTcGojyF3EITA98OLPXZGIHj8OXT0QwXsMetttNwSHHPLereQbBCBumKheqQRBWlUrEb8VWurjJti4LetsBPxREYqrgZjZjP/Ordjeb9WVlw6KesprTUw3CyefOcYkOWpVl/SQCx33wv+IvIZJLbe7mHcdPsde/TUSnwSYFn89AOEosiU1vHaXzHw4oHD+kKATX3uZeevtjOM1Bt5P2+x+0K+Sazj4pxaF3EFE5ylUQrqLTxb9aH5woEfc+Y0Scz/8n+Vaggll/rHvNySGG8GBJaR0o/qjERN/ORR4CbFNDhrWlt6W5fOkE1g rg/Lny8p 1qxtB52nBtoRe1eXjaVqb5yqdA9KjhWLSwkn5amL470M1kLdL5qXEt0M3nApYIMzV/kYW2CP3s1xw6949jqc9f22YUZerO94PX7kR31H4QOUd0T1hOlj50IR2B/75Nt9ZwdLpANpTeNb59wLeV60626Y2PsvYGk20IqGlIcTMKP8eFIy7bp1nNsuqP5lHINUK0YISF0WXjXbeE5Mtz+cmNwmvvYe6TkiLzjlvi0FZDiw2Ul9gumnTR8CHfmVpZihABD+k/aOCfvbLCdzo278VQ4mbdaFVLJhf8XIlYSZi2qFcrWXlMiAjrlY0CRM5utfs4QmbF2jKmyJUcaUJkHTGO592LQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 11:22:35PM -0700, Christoph Hellwig wrote: > On Thu, Apr 25, 2024 at 01:37:42PM +0200, Pankaj Raghav (Samsung) wrote: > > From: Pankaj Raghav > > > > iomap_dio_zero() will pad a fs block with zeroes if the direct IO size > > < fs block size. iomap_dio_zero() has an implicit assumption that fs block > > size < page_size. This is true for most filesystems at the moment. > > > > If the block size > page size, this will send the contents of the page > > next to zero page(as len > PAGE_SIZE) to the underlying block device, > > causing FS corruption. > > > > iomap is a generic infrastructure and it should not make any assumptions > > about the fs block size and the page size of the system. > > So what happened to the plan to making huge_zero_page a folio and have > it available for non-hugetlb setups? Not only would this be cleaner > and more efficient, but it would actually work for the case where you'd > have to zero more than 1MB on a 4k PAGE_SIZE system, which doesn't > seem impossible with 2MB folios. I mentioned this Darrick in one of the older series[1] that it was proving to be a bit complicated (at least for me) to add that support. Currently, we reserve the ZERO_PAGE during kernel startup (arch/x86/kernel/head_64.S). Do we go about doing the same by reserving 1 PMD (512 PTEs with base page size) at kernel startup if we want to have zeroed 2MB (for x86) always at our disposal to use for zeroing out? Because allocating it during runtime will defeat the purpose. Let me know what you think. In anycase, I would like to pursue huge_zero_page folio separately from this series. Also iomap_dio_zero() only pads a fs block with zeroes, which should never be > 64k for XFS. [1] https://lore.kernel.org/linux-fsdevel/5kodxnrvjq5dsjgjfeps6wte774c2sl75bn3fg3hh46q3wkwk5@2tru4htvqmrq/