From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF8FC4345F for ; Fri, 26 Apr 2024 17:06:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DFFC6B0082; Fri, 26 Apr 2024 13:06:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 590106B0083; Fri, 26 Apr 2024 13:06:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 457726B0085; Fri, 26 Apr 2024 13:06:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 262B86B0082 for ; Fri, 26 Apr 2024 13:06:24 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C83E0C07E2 for ; Fri, 26 Apr 2024 17:06:23 +0000 (UTC) X-FDA: 82052311446.16.CBBA916 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf12.hostedemail.com (Postfix) with ESMTP id EA95A4001B for ; Fri, 26 Apr 2024 17:06:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="E8cGd/Ep"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714151181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SgX9HQcRhIm4KtQdq9GYft3Q0ZiwCuQWZ5JhWxXdoTI=; b=nn3ZLl8Hlcp0lmZOskQXMkL/0kJEhNflEAm3kTemRCaPluH1k6VbXubaJ17awqny7FnqeC b4e9LJ14L8OXCDT2JtB94fZa88Ud9PpSqbHhdSwJ3YZwiXCNUe1+xQtmA4oboSOrSo0Rxw XhK6o6wlh6BHJQxi+MKrpVuWLvQ3H4E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714151181; a=rsa-sha256; cv=none; b=txn+XPrRMgsIqTs8F4XyOX8hiPRy8O6GTawmihlZf9PVFLF5utuoZk9q2r+6dpwbvmXKAF enKkJCRusPiWjn/694bfYZsqAGOuotqZajd5jbP0PWviIq9vY77A+9/1TCNAPjDa+hAXea EagrzvuoDz1PZOoKiPCpIaOCI6LIXNU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="E8cGd/Ep"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=keescook@chromium.org Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6f0b9f943cbso2155147b3a.0 for ; Fri, 26 Apr 2024 10:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714151180; x=1714755980; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SgX9HQcRhIm4KtQdq9GYft3Q0ZiwCuQWZ5JhWxXdoTI=; b=E8cGd/Ep4FtI4eX/cPkvC0UMh5Ud4QOPXEYawkKlW1pUDRdK+7+1G4qVfCM66nuUfF yTX55RKx+VR7ErNoEfUerFrItzgCumTlllxs6PJ5L7nmAqK+OnzpCFcC7OAGgvLxGZXZ 6DFV+sVWBQUO+EcnwWJer6/Xrp0GM9D4PwCTM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714151180; x=1714755980; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SgX9HQcRhIm4KtQdq9GYft3Q0ZiwCuQWZ5JhWxXdoTI=; b=QCNiPEFJ1yWIJfTJR2nsGZ7xeaw3FZk06mK3w/xi3JYva1YvpJvM/L3Oh62xXergkD Vrk4XPwy7AJnbMVK7DkwW9Rw68PJKW/+QE0mglGbjNNwvBFH7bh3QUi67rPXSBbRuKbE uB9w7KsBvC8CRZDzEi1XYj4awxFycruLHOUTKpSzNwLUD/3UrD+wR8nbhwjVdny2q03r 7qk2fOO0x2kyyqJqNKMFI8EeRkwsIYHaPhxdJb3I/ovTNceqNfmiIRIERGvLa8QAZfth 1HN8OnbTdh/sK2F2vcCKMKpSV1WrTD4h/rE9xVX7zH4I6nprGpWihc9+2boUddc7xutd LT4A== X-Forwarded-Encrypted: i=1; AJvYcCVzR4uVqh5rFhMvtnV/FtJSLi9wTrg94O8jdvcetXVsIosrHAsOoSwuPjo3camSVMB9AJAgWMSgjwq+uLcP2PSXY8M= X-Gm-Message-State: AOJu0YxK3Tk3gSi209wp4HiLLK+Ki2Rg05fpEea2qreUxMsomZh6Lz9L J78Xc2zduKyMSDsngSS0fSjkipiVcyUqncmlXjBAM1vZCG1sFNOhfaMkoqamYQ== X-Google-Smtp-Source: AGHT+IFRuONJTBeF5jWTd1Z1iUSFqM7Mlp2kx8AS+7oOD8Od6nCZUNw8lqItcPq8AJeYMewLdxXOFA== X-Received: by 2002:a05:6a20:9703:b0:1ad:92e0:f5d7 with SMTP id hr3-20020a056a20970300b001ad92e0f5d7mr3368882pzc.46.1714151179677; Fri, 26 Apr 2024 10:06:19 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id jw37-20020a056a0092a500b006ecf0ad97bbsm15541913pfb.17.2024.04.26.10.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 10:06:18 -0700 (PDT) Date: Fri, 26 Apr 2024 10:06:17 -0700 From: Kees Cook To: Catalin Marinas Cc: Suren Baghdasaryan , Kent Overstreet , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] mm/slub: Avoid recursive loop with kmemleak Message-ID: <202404261005.F7393F558@keescook> References: <20240425205516.work.220-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EA95A4001B X-Stat-Signature: k7kowigwco1j8inaqk6ecwgjw4y9zh9j X-Rspam-User: X-HE-Tag: 1714151180-664251 X-HE-Meta: U2FsdGVkX1+BnF2A5HMnAOl7epTtlVomoiCWH2EWgZOhqfPcEdd0qKQ+InZFOvLeka5EW7Wk9/K2AwONH/wgGbn5pkfLxqOv6OtKS/w+6Dg4MZzyUoz2iOErGxUz5SY7BCnMtMGJqzO2hfoXC4d9d2bZx+hFcCP5cZRs2kfOPwZryqfzYf1WJIQa/sCSYpV1LZFfK1j7SZzai2y/ay+hAd6KWxD9cPAT0Nh87XP2XOmR2d8xAbEWXK61+qVruQjpzwFm/U6t8YIX7Jq+OXV5TzgNXCl+03p+JL48bgpOmCjLa3dSFc44pZ2j5snmLnmoQo95gg4JwU7/oYwY6WQ5fGanq/3Jvsj3QA01vLNlu95OI5TqnBfCRbkDVOQXOwImxW1ajj5qhKPeCTPEwvPW3+6WLWWKNybxRsdhutkPeXrAY13HSZIr67bMkxNhlSo2AxPvyDlteVtazbFCiuxMUgbJPfSwamF00LGfyb708meSJQH3nIRgsLjQMwuf4vlUWzZveYjDtdHwaDln3PFNCEaIeMicZBNVrd5zbtYYyBErcwtMxhN0AHRqtq/iNkI1/YEFV+fmsNThwPVxCas3K+m6KQTGZ8X2X4iskwlM2lN0a3aJ+ScV8+kVW4Tju1OgKgDAzQryVpXKTlOepMj6uHN6RpIcNLRgXH1jLo7TsY6z0AH0xK17+Q4l96GZy+P5/J1VV+1btNUrU2Zilm/lLKcP5fbmoefUCbyWWfW7BmA+aUO1KndY6xKvmEFiGtHXX7UrgqxxUCsdmziqOR781h71rHNSX4TLBTgtsiP/GpmYoam+JmfIkjIHuVPR68O5zya41rKJ578lWhuWh21zi+SF8ufP9lMZk3/s48QfRcBG2dT0To5ne2KRefxur4amvFnKA0YHoXlDV2OcyjWNM09cCY9kuHBnET7nO22p1NkZ0KVkwYd11NQnHF5LKShTR43LKbvRI2SdYdbtK8h BE47T8Qo YLkpijrkN7n04D+DL5a/LK6Fyr1txCziekSWEqTPZYmym2EEl/rTesQdSZk+dmnHFXtQ5vVWKG/fmuJSFy+AWSpM3rYKTTyeYNB9fHru8TFBsBiSNxNBqZMG6zDWi2GR0fQWZcGYaiVrKpTpHdP+tPDzhzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 03:52:24PM +0100, Catalin Marinas wrote: > On Thu, Apr 25, 2024 at 01:55:23PM -0700, Kees Cook wrote: > > The system will immediate fill up stack and crash when both Oops, typo from me: "immediately". You'd never guess I'm a native English speaker! :) > > CONFIG_DEBUG_KMEMLEAK and CONFIG_MEM_ALLOC_PROFILING are enabled. > > Avoid allocation tagging of kmemleak caches, otherwise recursive > > allocation tracking occurs. > > > > Fixes: 279bb991b4d9 ("mm/slab: add allocation accounting into slab allocation and free paths") > > Signed-off-by: Kees Cook > > For the kmemleak bits: > > Acked-by: Catalin Marinas Thanks! -Kees -- Kees Cook