From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC89C10F15 for ; Fri, 26 Apr 2024 02:42:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CE3F6B0093; Thu, 25 Apr 2024 22:42:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17F966B0096; Thu, 25 Apr 2024 22:42:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F39746B0098; Thu, 25 Apr 2024 22:42:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CF55F6B0093 for ; Thu, 25 Apr 2024 22:42:25 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 73435A0738 for ; Fri, 26 Apr 2024 02:42:25 +0000 (UTC) X-FDA: 82050134250.05.408E92A Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2061.outbound.protection.outlook.com [40.107.255.61]) by imf30.hostedemail.com (Postfix) with ESMTP id 0801480009 for ; Fri, 26 Apr 2024 02:42:21 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=FfwRrfYY; spf=pass (imf30.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.255.61 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1714099342; a=rsa-sha256; cv=pass; b=SpzXkWHOrKKRgtDKRW4IjaIuQXdvWw0cUd5wgES4qArGuijPrSwykKdxVipynfnuDzIvPa gB2Wz32E9xtCRQ/B9GrtjdS2YRiA0zsZ7UW2nr8hDD2/E5biLz0KVwfSaCeByDU1CkqRE/ +FH9plrs69PPhc7zGwk11B8O3oR5bGU= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=FfwRrfYY; spf=pass (imf30.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.255.61 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714099342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=wBC48aIJAsA8XkHfaD3wU/Rub0q4GdFutM6FCJKvUAM=; b=Re+lTjFP3j9lVqZTzwzLMgY5T9QMA99R6OHClvTMnH9oA5+BG6NU/VmFHUaHLlHMSPkOra 5iaMYPreV7+/2U6UhGnSlDegZ/yZ89AqDP1uYVMDenHY+AE+kzzMLnYMjAdaYmMxl39iFP td0A7mF6wJqa9mXmRyQWm90KLW3YHUc= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QFbQ9wgEpbaM4LX8aYVHn0rTqNbxrvG1O8Ute2c4H6Aa100sBa2T/KuFg406+W7OE48oh/nioU6UpB6+AD6tMsAMfuBsmpvKQaM10JuYwyFDnab0DIMiVUUCDYrzQZFUdUxbwcbotNXfA2h6kDFb9UNxxiuvyIhF6zIn710tCiF1FoipBJQgEaszxSXNap5+CLW/lPUuv58fEJ4fpqBZSyyfDNUZ2/XK6EPhTJh1Tdaof7bsomNtfTcHw84EyN52gYSBxqQ9xjw7A3b9NRQ/pCwNAxFZ2MKceSbNNCrA3LyvP3qKh4eMVuYQHJYy5JmVIe0XYe8GVmPddzZtsQVp7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wBC48aIJAsA8XkHfaD3wU/Rub0q4GdFutM6FCJKvUAM=; b=B5b1BfJ6RePYyBf1rsQqrqF3yFT3SJB5HsIBkLgR6HmEWLCqlU7OriAMCxVBLNATGBYzvPFhW82j9jJFJh7HpmCTt9EGeoeHSyDpO5K0QvifWT9euDtgeao9uF+uaQKy3hCSLLA1XFb17r7JzPtscqERG0SsM1lyc0lCpyKq0CtVKTUHL9Ot7d3HW3Oi2tuIFJT5CrtDk2Z1hUsM2kKqlhDH6ZugntI17FN10coPSeprbtzdqnhC6J3vEWPTeyhgRVMoPXMcygjj6T2l5lIpwubmIMFFxJALQfVXzAV7F9pevqAVlDL2H+kBQ4hB5S/spDZfmqF6KyTOeqklT1aqbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBC48aIJAsA8XkHfaD3wU/Rub0q4GdFutM6FCJKvUAM=; b=FfwRrfYYRT8kqMbQ1Pyht8SBn7mG4l+Mm43V3AC88Zs1bBjIWAHdmxqZhx50j6bAUKsOjgynfzVRfNOAzKLb+1i7kMLGvI/GDW9uQkeHI+OQnQk3oVWXfbUITLfNJHcxKR49LDzCWr0akOFZ/B6bBJdrknQCtRPksH04KLiglAk= Received: from SI2PR01CA0037.apcprd01.prod.exchangelabs.com (2603:1096:4:193::9) by SEZPR02MB5495.apcprd02.prod.outlook.com (2603:1096:101:4a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Fri, 26 Apr 2024 02:42:16 +0000 Received: from SG2PEPF000B66CB.apcprd03.prod.outlook.com (2603:1096:4:193:cafe::18) by SI2PR01CA0037.outlook.office365.com (2603:1096:4:193::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22 via Frontend Transport; Fri, 26 Apr 2024 02:42:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by SG2PEPF000B66CB.mail.protection.outlook.com (10.167.240.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.19 via Frontend Transport; Fri, 26 Apr 2024 02:42:15 +0000 Received: from PH80250894.adc.com (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 26 Apr 2024 10:42:07 +0800 From: To: CC: , , , <21cnbao@gmail.com>, , , Hailong.Liu , Barry Song Subject: [PATCH v3] mm/vmalloc: fix return value of vb_alloc if size is 0 Date: Fri, 26 Apr 2024 10:41:49 +0800 Message-ID: <20240426024149.21176-1-hailong.liu@oppo.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw31.adc.com (172.16.56.198) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PEPF000B66CB:EE_|SEZPR02MB5495:EE_ X-MS-Office365-Filtering-Correlation-Id: 093f007e-9553-4427-5a1b-08dc659a7c0d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|36860700004|82310400014|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VnpHaVpRczBuNGtOenE1cnF0Z0Nwckgza2lpNkZpTVZTTHJhdm1xa3JRQUFH?= =?utf-8?B?aFJJVDZxUEo0TXdMSXlQYXJQQUlvcWV3MUttMGY1YkVuVVhLNW9UdllnaUhP?= =?utf-8?B?MUJ4UW9pN0prdGFUOWJ5dWJaZnAzeHE0MTV1bEtkZEV4QnBrV3NFbFNCa3Fp?= =?utf-8?B?eWRJRXlaRDJvQkgrQy9qUlVDeTdoMHprazBKQnJYTFdNVmVqQlRxZExwM3FR?= =?utf-8?B?Y3daQzhmaFQ2ZlE1M2VhUFNLVVpXcm4wczV2bkJJZngvVWxZczU2U3ZtWVpC?= =?utf-8?B?TDl2Q2liaGhiRWxoVFRkbk5NV2hBY1JsRlI2SkFuL29ZS1htUW9SR0Vzdkxy?= =?utf-8?B?UWpMK0V2LzFaZVkwOTc1bTZhbWlKeklIVFVEQjN3OTRCZ24za0pMQjFaaUxn?= =?utf-8?B?ZFhPSnVZNVl1SlNmSjhXRkNkR2xueXBoU3NwOUwycENTNTBrOTE5bUw1bGd4?= =?utf-8?B?Ri9TNjhIZ0hRaTJIZnNNTHloRHRxbXBHUXcxRjNnZFhWZ3QyakUyMTdKVXJs?= =?utf-8?B?a3R4TDViOU9mNTlpQ0lQWHduYUN0RmUrR2NzV3RodGN5WnhKNS85V1JhYjRy?= =?utf-8?B?cC91bTJjMVdVWmNBQko2dnhhVEl1VTZTSnU0SU54RG1iYnBFZ2prMWNYK3A4?= =?utf-8?B?KzNVNm5kbnVJTGFxOXFnTDhSTVJrN1p1YWtnU29ieWFnQmdRWnRhckFNY3dL?= =?utf-8?B?aFUyV05lRUFQYll4aUdGcDNqSFp4VUYwWEUyblF6Y2FMcEttUVIvRnA1T0tV?= =?utf-8?B?YWlXcnJWNnBCZVlhbGpmQlp0QStZaStOM1BMd1BnWmVpS25mb2QyRDFwdFlL?= =?utf-8?B?OEQvb0g2bUZIS3Jkd0Mwekswc1IybUJPaEZJREZ1VjIyVElMSEtURXZ5c0px?= =?utf-8?B?aVJMMWY2NXNITjRFRjloSEIwR1hrTDNrSG1CVEh5QUpiZDdpc1ZodU9sUmsz?= =?utf-8?B?eHEzSUZ1VnFkTVhIdDhLWWlrWGk1cDBFdVFUUEhGZm9jaVc5NHpTYTA1QkVr?= =?utf-8?B?bXBadHhNWjJpZXBYTW0vNnlkQjFvWXdsTk5oRHIwUGt6SURsdmRTVXMwNGFy?= =?utf-8?B?M2MzSU43bi9tZkJkSEpDQmpEYlQwc1c4YUtIODBGMi8reno1RXJ2NnltVTdy?= =?utf-8?B?bkh1RFQ4dHpZNkhraEt1ckZjMHNaN3VWQU9vdkpKVzFwR2lZbGhvdXYrVENm?= =?utf-8?B?a01NendYU0FzWlJjQ05WOWdzNjRtd0l0azVJaWl6YmRGanl6WXgrdUo4NVA2?= =?utf-8?B?YWQ0dTlzMG11ZWlFWGxhazUrNVpCY1gxRWZ2aVo0dmJ5WWk3YitWVERKbzEr?= =?utf-8?B?ajh2VUxHU1R0OFBQUnJaVWd2N2R1QkJiTmVWT1Y5Mi9ub3RUV2FyRUd1aTho?= =?utf-8?B?WFU3emNTbmRlVnV0endZdThnL2VFeVF3RTkrOWpkdUJxYkVQK0hPN0tycGRX?= =?utf-8?B?WHpRR24zSGU4TFI4d0krSlcxd0UrakFTczdYdDBtc3J0K3hRSmJtWThNNFJT?= =?utf-8?B?Y0pqMFZkT1VBYzVhdjFld2IyTVMwTUhnT0RwVitFZWlvcDdRdTlUaERPNEU5?= =?utf-8?B?QTl6OExhU1VZeSt1OU9IMlY4OVkzYm41VHNVcDdmMHhQdEExV1Y2WWNCMTdw?= =?utf-8?B?VVk0S0FLNXp5Y1R5cWNZR2JadXNLb0owbWJsV0JSV0VGVjRNTnExTTlCN1k0?= =?utf-8?B?MWJ2NXpiaTN3RmhaZlZoUEw4VlM5cEtOdy8rcnF0dm5GU1laYnArOXNBelI0?= =?utf-8?Q?zdda0nCX6wd24qYbkzV4rKCQHWQbp3i7VHJeTOC?= X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(36860700004)(82310400014)(1800799015)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 02:42:15.9292 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 093f007e-9553-4427-5a1b-08dc659a7c0d X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: SG2PEPF000B66CB.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR02MB5495 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0801480009 X-Stat-Signature: sydgp997euqocpb93x8sc4ps9npjkqpq X-Rspam-User: X-HE-Tag: 1714099341-139119 X-HE-Meta: U2FsdGVkX1+FwF5FkmFF6YepuqMSAy1k4HKD7HyumMhIO8uGEAKAPNBi/Eq3QrPyndRAXRSRiQWxgv6KPEhx+AkaF02vQeiJXeqaJP+B+rhANm7WOLZKISzxq7ACjGsTEdMwhTjdgvHd1nOq2kNaysDYZ7NIHw9g6ORjfCXJ+WZoJsejsTzAGAMGJ8H0eF/Wbt5Fx3XtIWGWnnCT9WCvD5NaEa7mDEGSJPZkaPcVNaB2LJa0hKSvfpyGkDxnQEzL2zWZtCE4SrluObSOejio42xza7zQeWU0JdfFJEqIXdzliarIdxDSgZ4HiOX4b2QYjcUe9mHcxs0ArFqqt3PfhcP+jA8pUa7kyiiqP7sRsTM/Zc+EiK0k4QTUZIivyLom3xf9rLG4u7YbGDYJvgqvjAxKggpsU/xvnSbVx9UvKxAOW1kkGqT3HYUS8rvTaxUtwistNM2TrbgpvnZZmVHTz0EvY/nrRo0kZxWNAzFx7KMeRgZuVgPuUkdswHS253Ykg8PDRAT6zyGZTIWmzgnOErpDkvRr0P8XccZJfORGhPE5ENtut7zZK2XiKQ9JBMxYbN8kbuc8zB2k4uzUWZiomTFbJVgx2EgmkPXEkY9HVBU5+JrHgRPEZJx6yo29x2+drA+JTBq+ayqCS4Jl6AbdsQHjxjnSqK5xpcG31iF0cevXy0HtDz8aiZsbCWf6vOrzapw6UX7C2Ikxbkco9P276dBYa05zi9UKM8ZnhRqessifranTRl7HDgl/QCuLHEv94ED6JEOkKdmIyRS/EaPt3OqLlfEptqwLkNIaYYqC29wQ/2Es5UCyIYTvN4goEOgQKPPkDpqIYhXnke5VzLkulJPWR63TgFHC58LDbkcnRQAx7DrADC9aOZhchl+dTsAeA1CAPonMblNqdMXa0OIgaAmO8LWpR47n4gNMUVycd2SE8mIWRUA99GgHJjwFrrFWKXUcXjJDzAD8KDxHI5N GzOa3trt 9oNUUGtJqsXo60NTQBL0qzMbBpM9ZiC73uV+mEN6WIBTOMO1wLqDVgg0Pfaw85L7Nmgt4PrDdWOxPNFly9CdgGHbdneYWJjTuoo9UeN34Zr/PquEWKISF6weafZcFA0THQ9dFnalnXy7E8DUuYkMouFA0bxwLgnSjJQI5i2SYSkZSMsIf1ju+CKvcC1mbU6UeFhiNlBlxHpzrCzwVBI6WIb47o0iKKeBM4cy/l5760TKYfpB5VTw/Mc6EOEZLX/QG3tJdcJ3wVqQbGODW0EOC6PAqL4PJrIPySG8lIkXA603P5TxBK4Qozpl3cGNMjB59Ie3p51LLFVGTvmUT6KnVzHP65kp0nMprvYRh1cENBHNbjtfsC1UFWqTAj3freHTR8PssVFQOnaCZiCSdhjtozP+9YKNFIHKx4R6pp0GrIGDmjTI5sK1B+GDYk3CqQGIP4BK/hgjjI5VBrRsmwgJqdQaPPZ9NXjyJu/SZF01D4H067RSehdZ/+bQxyOyWyvm1NnMj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Hailong.Liu" The function vm_map_ram() uses IS_ERR() to validate the return value of vb_alloc(). If vm_map_ram(page, 0, 0) is executed, vb_alloc(0, GFP_KERNEL) would return NULL. In such a case, IS_ERR() cannot handle the return value and lead to kernel panic by vmap_pages_range_noflush() at last. To resolve this issue, return ERR_PTR(-EINVAL) if the size is 0. Reviewed-by: Barry Song Reviewed-by: Uladzislau Rezki (Sony) Signed-off-by: Hailong.Liu --- Changes since v2 [2]: - Remove RFC tag - Modify commit msg, per Barry Changes since v1 [1]: - Return ERR_PTR(-EINVAL) or not check IS_ERR_OR_NULL [1] https://lore.kernel.org/all/84d7cd03-1cf8-401a-8edf-2524db0bd6d5@oppo.com/ [2] https://lore.kernel.org/all/20240419101643.11534-1-hailong.liu@oppo.com/ mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index d12a17fc0c17..44be3edb3f42 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2173,7 +2173,7 @@ static void *vb_alloc(unsigned long size, gfp_t gfp_mask) * get_order(0) returns funny result. Just warn and terminate * early. */ - return NULL; + return ERR_PTR(-EINVAL); } order = get_order(size); -- 2.34.1