* [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS
@ 2024-04-25 21:59 Yosry Ahmed
2024-08-10 1:10 ` Yosry Ahmed
2024-08-12 6:39 ` Kirill A. Shutemov
0 siblings, 2 replies; 3+ messages in thread
From: Yosry Ahmed @ 2024-04-25 21:59 UTC (permalink / raw)
To: x86, Thomas Gleixner, Ingo Molnar
Cc: Borislav Petkov, Dave Hansen, H. Peter Anvin, Andy Lutomirski,
Peter Zijlstra, Kirill A. Shutemov, Rick Edgecombe,
Andrew Morton, linux-mm, linux-kernel, Yosry Ahmed
Commit 6fd166aae78c ("x86/mm: Use/Fix PCID to optimize user/kernel
switches") removed the last usage of CR3_HW_ASID_BITS and opted to use
X86_CR3_PCID_BITS instead. Remove CR3_HW_ASID_BITS.
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
---
arch/x86/mm/tlb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 44ac64f3a047c..a2ba5bb201705 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -85,9 +85,6 @@
*
*/
-/* There are 12 bits of space for ASIDS in CR3 */
-#define CR3_HW_ASID_BITS 12
-
/*
* When enabled, MITIGATION_PAGE_TABLE_ISOLATION consumes a single bit for
* user/kernel switches
--
2.44.0.769.g3c40516874-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS
2024-04-25 21:59 [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS Yosry Ahmed
@ 2024-08-10 1:10 ` Yosry Ahmed
2024-08-12 6:39 ` Kirill A. Shutemov
1 sibling, 0 replies; 3+ messages in thread
From: Yosry Ahmed @ 2024-08-10 1:10 UTC (permalink / raw)
To: x86, Thomas Gleixner, Ingo Molnar
Cc: Borislav Petkov, Dave Hansen, H. Peter Anvin, Andy Lutomirski,
Peter Zijlstra, Kirill A. Shutemov, Rick Edgecombe,
Andrew Morton, linux-mm, linux-kernel
On Thu, Apr 25, 2024 at 2:59 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> Commit 6fd166aae78c ("x86/mm: Use/Fix PCID to optimize user/kernel
> switches") removed the last usage of CR3_HW_ASID_BITS and opted to use
> X86_CR3_PCID_BITS instead. Remove CR3_HW_ASID_BITS.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
I think this may have gotten lost in the noise, friendly ping :)
> ---
> arch/x86/mm/tlb.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 44ac64f3a047c..a2ba5bb201705 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -85,9 +85,6 @@
> *
> */
>
> -/* There are 12 bits of space for ASIDS in CR3 */
> -#define CR3_HW_ASID_BITS 12
> -
> /*
> * When enabled, MITIGATION_PAGE_TABLE_ISOLATION consumes a single bit for
> * user/kernel switches
> --
> 2.44.0.769.g3c40516874-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS
2024-04-25 21:59 [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS Yosry Ahmed
2024-08-10 1:10 ` Yosry Ahmed
@ 2024-08-12 6:39 ` Kirill A. Shutemov
1 sibling, 0 replies; 3+ messages in thread
From: Kirill A. Shutemov @ 2024-08-12 6:39 UTC (permalink / raw)
To: Yosry Ahmed
Cc: x86, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
H. Peter Anvin, Andy Lutomirski, Peter Zijlstra, Rick Edgecombe,
Andrew Morton, linux-mm, linux-kernel
On Thu, Apr 25, 2024 at 09:59:51PM +0000, Yosry Ahmed wrote:
> Commit 6fd166aae78c ("x86/mm: Use/Fix PCID to optimize user/kernel
> switches") removed the last usage of CR3_HW_ASID_BITS and opted to use
> X86_CR3_PCID_BITS instead. Remove CR3_HW_ASID_BITS.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kiryl Shutsemau / Kirill A. Shutemov
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-12 6:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 21:59 [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS Yosry Ahmed
2024-08-10 1:10 ` Yosry Ahmed
2024-08-12 6:39 ` Kirill A. Shutemov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox